149693 2015-09-30 19:47:25 -0700 [EFL][Gtk] Try to fix the build after r190379. 2015-09-30 20:56:07 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong achristensen alecflett beidson commit-queue gyuyoung.kim jsbell lucas.de.marchi ossy oldest_to_newest 1129799 0 hs85.jeong 2015-09-30 19:47:25 -0700 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/24658/steps/compile-webkit/logs/stdio ../../Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h:38:97: error: ‘IDBDatabaseIdentifier’ does not name a type friend std::unique_ptr<MemoryIDBBackingStore> std::make_unique<MemoryIDBBackingStore>(const IDBDatabaseIdentifier&); ^ ../../Source/WTF/wtf/StdLibExtras.h: In instantiation of ‘typename std::_Unique_if<T>::_Single_object std::make_unique(Args&& ...) [with T = WebCore::IDBServer::MemoryIDBBackingStore; Args = {const WebCore::IDBDatabaseIdentifier&}; typename std::_Unique_if<T>::_Single_object = std::unique_ptr<WebCore::IDBServer::MemoryIDBBackingStore>]’: ../../Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:36:62: required from here ../../Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:39:1: error: ‘WebCore::IDBServer::MemoryIDBBackingStore::MemoryIDBBackingStore(const WebCore::IDBDatabaseIdentifier&)’ is private MemoryIDBBackingStore::MemoryIDBBackingStore(const IDBDatabaseIdentifier& identifier) ^ In file included from ../../Source/WTF/wtf/FastMalloc.h:26:0, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:26: ../../Source/WTF/wtf/StdLibExtras.h:319:60: error: within this context return unique_ptr<T>(new T(std::forward<Args>(args)...)); ^ ^ EFL, Gtk port build failed after r190379. 1129800 1 262225 hs85.jeong 2015-09-30 19:51:12 -0700 Created attachment 262225 Patch 1129801 2 hs85.jeong 2015-09-30 19:54:53 -0700 Compiler didn't find the 'IDBDatabaseIdentifier'. So I add the 'Webcore::' to find the 'IDBDatabaseIdentifier'. 1129808 3 262225 commit-queue 2015-09-30 20:56:03 -0700 Comment on attachment 262225 Patch Clearing flags on attachment: 262225 Committed r190384: <http://trac.webkit.org/changeset/190384> 1129809 4 commit-queue 2015-09-30 20:56:07 -0700 All reviewed patches have been landed. Closing bug. 262225 2015-09-30 19:51:12 -0700 2015-09-30 20:56:03 -0700 Patch bug-149693-20151001115046.patch text/plain 1387 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDM4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA5LTMwICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtHdGtdIFRy eSB0byBmaXggdGhlIGJ1aWxkIGFmdGVyIHIxOTAzNzkuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDk2OTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9NZW1v cnlJREJCYWNraW5nU3RvcmUuaDoKKwogMjAxNS0wOS0zMCAgRGVhbiBKYWNrc29uICA8ZGlub0Bh cHBsZS5jb20+CiAKICAgICAgICAgR3JhcGhpY3NDb250ZXh0M0Q6Om1hcHBlZFN5bWJvbE5hbWUg c2hvdWxkIGluaXRpYWxpemUgY291bnQgdmFyaWFibGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvaW5kZXhlZGRiL3NlcnZlci9NZW1vcnlJREJCYWNraW5nU3RvcmUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvTWVtb3J5SURCQmFj a2luZ1N0b3JlLmgJKHJldmlzaW9uIDE5MDM4MSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL3NlcnZlci9NZW1vcnlJREJCYWNraW5nU3RvcmUuaAkod29ya2luZyBjb3B5KQpA QCAtMzUsNyArMzUsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBuYW1lc3BhY2UgSURCU2VydmVy IHsKIAogY2xhc3MgTWVtb3J5SURCQmFja2luZ1N0b3JlIDogcHVibGljIElEQkJhY2tpbmdTdG9y ZSB7Ci0gICAgZnJpZW5kIHN0ZDo6dW5pcXVlX3B0cjxNZW1vcnlJREJCYWNraW5nU3RvcmU+IHN0 ZDo6bWFrZV91bmlxdWU8TWVtb3J5SURCQmFja2luZ1N0b3JlPihjb25zdCBJREJEYXRhYmFzZUlk ZW50aWZpZXImKTsKKyAgICBmcmllbmQgc3RkOjp1bmlxdWVfcHRyPE1lbW9yeUlEQkJhY2tpbmdT dG9yZT4gc3RkOjptYWtlX3VuaXF1ZTxNZW1vcnlJREJCYWNraW5nU3RvcmU+KGNvbnN0IFdlYkNv cmU6OklEQkRhdGFiYXNlSWRlbnRpZmllciYpOwogcHVibGljOgogICAgIHN0YXRpYyBzdGQ6OnVu aXF1ZV9wdHI8TWVtb3J5SURCQmFja2luZ1N0b3JlPiBjcmVhdGUoY29uc3QgSURCRGF0YWJhc2VJ ZGVudGlmaWVyJik7CiAgICAgCg==