149682 2015-09-30 15:48:10 -0700 Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline 2015-09-30 17:26:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue dbates graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1129695 0 joepeck 2015-09-30 15:48:10 -0700 * SUMMARY Thousands of timers fire after switching to JavaScript and Events timeline. The UI is slow and frequently unresponsive while interacting with the timeline while these timers fire. For instance scroll synchronization (which uses timers) doesn't get synchronized until all of the previously queued timers are exhausted. That can take 30+ seconds for a large profile. * STEPS TO REPRODUCE 1. Inspect apple.com 2. Timeline tab 3. Reload 4. Click "JavaScript & Events" => try to scroll the data grid after it shows up * NOTES - Many many TreeElement onchange events spawned by the "status" of the GeneralTreeElement changing. Seems we don't even need to trigger a treeOutline.onchange for that. 1129696 1 webkit-bug-importer 2015-09-30 15:48:29 -0700 <rdar://problem/22924064> 1129702 2 262200 joepeck 2015-09-30 16:05:47 -0700 Created attachment 262200 [PATCH] Proposed Fix 1129704 3 262200 timothy 2015-09-30 16:14:22 -0700 Comment on attachment 262200 [PATCH] Proposed Fix Do the close status elements still work? I think I added these to make those close elements work. 1129728 4 joepeck 2015-09-30 16:42:16 -0700 (In reply to comment #3) > Comment on attachment 262200 [details] > [PATCH] Proposed Fix > > Do the close status elements still work? I think I added these to make those > close elements work. Yes, I tested this a bunch but never encountered an issue. Wherever there is a goto arrow, loading a content view produces a close button to go back. I tested in the overview timeline, network timeline and tab, and JS & Events timeline. 1129757 5 262200 commit-queue 2015-09-30 17:26:38 -0700 Comment on attachment 262200 [PATCH] Proposed Fix Clearing flags on attachment: 262200 Committed r190377: <http://trac.webkit.org/changeset/190377> 1129758 6 commit-queue 2015-09-30 17:26:42 -0700 All reviewed patches have been landed. Closing bug. 262200 2015-09-30 16:05:47 -0700 2015-09-30 17:26:38 -0700 [PATCH] Proposed Fix timers-1.patch text/plain 2483 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRmZDk5MTEuLjI0MmE5ODEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTA5LTMwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGhvdXNh bmRzIG9mIHRpbWVycyBmaXJlIGFmdGVyIHN3aXRjaGluZyB0byBKYXZhU2NyaXB0IGFuZCBFdmVu dHMgdGltZWxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0OTY4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNldHRpbmcgdGhlIHN0YXR1cyBlbGVtZW50IG9mIGEgR2VuZXJhbFRyZWVFbGVtZW50IHdh cyB0cmlnZ2VyaW5nIGEKKyAgICAgICAgVHJlZU91dGxpbmUub25jaGFuZ2UgZXZlbnQuIEZvciBU cmVlT3V0bGluZXMgd2l0aCBsb3RzIG9mIHRyZWUgZWxlbWVudHMKKyAgICAgICAgKEphdmFTY3Jp cHQgJiBFdmVudHMgd2l0aCBwcm9maWxlIG5vZGVzKSB0aGlzIGNvdWxkIHJlc3VsdCBpbiB0aG91 c2FuZHMKKyAgICAgICAgb2Ygb25jaGFuZ2UgZXZlbnRzIHRoYXQgY2F1c2VzIGxvdHMgb2YgdW5u ZWNlc3Nhcnkgd29yayBhbmQgYmxvY2tzCisgICAgICAgIGZ1dHVyZSB0aW1lcnMgKGxpa2Ugc2Ny b2xsIHN5bmNocm9uaXphdGlvbikgZnJvbSBmaXJpbmcuCisKKyAgICAgICAgVGhpcyBjaGFuZ2Ug ZWxpbWluYXRlcyBUcmVlT3V0bGluZSBjaGFuZ2UgZXZlbnRzIGZvciB0cmVlIGVsZW1lbnQKKyAg ICAgICAgY2hhbmdlcyB0aGF0IGFyZSBub3QgaW50ZXJlc3RpbmcuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQucHJvdG90eXBlLnNldCBzdGF0dXMpOiBEZWxldGVkLgor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVHJlZU91dGxpbmUuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVHJlZUVsZW1lbnQucHJvdG90eXBlLnNldCB0b29sdGlwKTogRGVsZXRlZC4K KworMjAxNS0wOS0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlZHVjZSBgZGVsZXRlYCBpbiBUcmVlRWxlbWVudHMgYW5k IERhdGFHcmlkTm9kZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0OTY4MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVHJlZUVsZW1lbnQuanMKaW5kZXggYzZiMGFm MC4uMDAwYzg0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvR2VuZXJhbFRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUcmVlRWxlbWVudC5qcwpAQCAtMTg4LDcgKzE4 OCw2IEBAIFdlYkluc3BlY3Rvci5HZW5lcmFsVHJlZUVsZW1lbnQgPSBjbGFzcyBHZW5lcmFsVHJl ZUVsZW1lbnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuCiAKICAgICAgICAgdGhpcy5fc3RhdHVzID0g eCB8fCAiIjsKICAgICAgICAgdGhpcy5fdXBkYXRlU3RhdHVzRWxlbWVudCgpOwotICAgICAgICB0 aGlzLmRpZENoYW5nZSgpOwogICAgIH0KIAogICAgIGdldCBmaWx0ZXJhYmxlRGF0YSgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UcmVlT3V0 bGluZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVP dXRsaW5lLmpzCmluZGV4IGY4MTk2OTEuLjc5YzdiMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RyZWVPdXRsaW5lLmpzCkBAIC02 MjAsNyArNjIwLDYgQEAgV2ViSW5zcGVjdG9yLlRyZWVFbGVtZW50ID0gY2xhc3MgVHJlZUVsZW1l bnQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIHRoaXMuX3Rvb2x0aXAgPSB4 OwogICAgICAgICBpZiAodGhpcy5fbGlzdEl0ZW1Ob2RlKQogICAgICAgICAgICAgdGhpcy5fbGlz dEl0ZW1Ob2RlLnRpdGxlID0geCA/IHggOiAiIjsKLSAgICAgICAgdGhpcy5kaWRDaGFuZ2UoKTsK ICAgICB9CiAKICAgICBnZXQgaGFzQ2hpbGRyZW4oKQo=