149663 2015-09-30 06:14:38 -0700 [GTK] Deprecation warnings in DOMNodeTest 2015-09-30 07:08:10 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela webkit-unassigned commit-queue oldest_to_newest 1129561 0 tpopela 2015-09-30 06:14:38 -0700 After the webkit_dom_document_get_elements_by_tag_name deprecation we should update the tests to use webkit_dom_document_query_selector_all and also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection (the replacement for the deprecated function). 1129564 1 262155 tpopela 2015-09-30 06:22:11 -0700 Created attachment 262155 Patch 1129570 2 262155 commit-queue 2015-09-30 07:08:07 -0700 Comment on attachment 262155 Patch Clearing flags on attachment: 262155 Committed r190346: <http://trac.webkit.org/changeset/190346> 1129571 3 commit-queue 2015-09-30 07:08:10 -0700 All reviewed patches have been landed. Closing bug. 262155 2015-09-30 06:22:11 -0700 2015-09-30 07:08:07 -0700 Patch bug-149663-20150930152145.patch text/plain 7514 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMzQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzVmMmY5YTY2N2ZkZGU4YjU3YTRjYjZlZTlhMDBhN2Jk ZGY3YmNhYy4uNWYyMmJkZDBkYmFjYzQyMDkyNTZhM2U2Y2Y4ZmJhOWVjZjUxMTg4ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDE1LTA5LTMwICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgW0dUS10gRGVwcmVjYXRpb24gd2FybmluZ3MgaW4gRE9NTm9kZVRlc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTY2MworCisgICAgICAg IEFmdGVyIHRoZSB3ZWJraXRfZG9tX2RvY3VtZW50X2dldF9lbGVtZW50c19ieV90YWdfbmFtZSBk ZXByZWNhdGlvbiB3ZQorICAgICAgICBuZWVkIHRvIHVwZGF0ZSB0aGUgdGVzdHMgdG8gdXNlIHdl YmtpdF9kb21fZG9jdW1lbnRfcXVlcnlfc2VsZWN0b3JfYWxsCisgICAgICAgIHRvIGF2b2lkIGNv bXBpbGF0aW9uIHdhcm5pbmdzLgorCisgICAgICAgIEFsc28gYWRkIGEgbmV3IHRlc3QgZm9yIHdl YmtpdF9kb21fZG9jdW1lbnRfZ2V0X2VsZW1lbnRzX2J5X3RhZ19uYW1lX2FzX2h0bWxfY29sbGVj dGlvbgorICAgICAgICAodGhlIHN1Z2dlc3RlZCByZXBsYWNlbWVudCBmb3IgdGhlIGRlcHJlY2F0 ZWQgZnVuY3Rpb24pLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL0RPTU5vZGVUZXN0LmNwcDoK KyAgICAgICAgKFdlYktpdERPTU5vZGVUZXN0Ojp0ZXN0VGFnTmFtZXNOb2RlTGlzdCk6CisgICAg ICAgIChXZWJLaXRET01Ob2RlVGVzdDo6dGVzdFRhZ05hbWVzSFRNTENvbGxlY3Rpb24pOgorICAg ICAgICAocmVnaXN0ZXJUZXN0cyk6CisgICAgICAgIChXZWJLaXRET01Ob2RlVGVzdDo6dGVzdFRh Z05hbWVzKTogRGVsZXRlZC4KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJH dGsvVGVzdERPTU5vZGUuY3BwOgorICAgICAgICAocHJlcGFyZURPTUZvclRhZ05hbWVzVGVzdHMp OgorICAgICAgICAodGVzdFdlYktpdERPTU5vZGVUYWdOYW1lc05vZGVMaXN0KToKKyAgICAgICAg KHRlc3RXZWJLaXRET01Ob2RlVGFnTmFtZXNIVE1MQ29sbGVjdGlvbik6CisgICAgICAgIChiZWZv cmVBbGwpOgorICAgICAgICAodGVzdFdlYktpdERPTU5vZGVUYWdOYW1lcyk6IERlbGV0ZWQuCisK IDIwMTUtMDktMjkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViS2l0VGVzdFJ1bm5lciBmYWlscyB0byBhcHBseSAidXNlRmxleGlibGVWaWV3cG9y dCIgd2hlbiBpdCdzIHNwZWNpZmllZCBpbiBhIGZpbGUgY29tbWVudApkaWZmIC0tZ2l0IGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL0RPTU5vZGVUZXN0LmNwcCBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9ET01Ob2RlVGVzdC5jcHAKaW5kZXggMzM0 Mzg0ZjY3YTQ3OWJkODNmZGNhMmUzY2M5MGMwMzlmZGNkZmNlMi4uOWQ1N2I0MmQyYzEyODY0NDJl ZGNjYjRkYzg2YTQ0MmNmY2JiMzU5MCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXQyR3RrL0RPTU5vZGVUZXN0LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdDJHdGsvRE9NTm9kZVRlc3QuY3BwCkBAIC0xNzgsNyArMTc4LDcgQEAgcHJp dmF0ZToKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgYm9vbCB0ZXN0VGFnTmFt ZXMoV2ViS2l0V2ViUGFnZSogcGFnZSkKKyAgICBib29sIHRlc3RUYWdOYW1lc05vZGVMaXN0KFdl YktpdFdlYlBhZ2UqIHBhZ2UpCiAgICAgewogICAgICAgICBzdGF0aWMgY29uc3QgY2hhciogZXhw ZWN0ZWRUYWdOYW1lc1tdID0geyAiSFRNTCIsICJIRUFEIiwgIkJPRFkiLCAiVklERU8iLCAiU09V UkNFIiwgIlZJREVPIiwgIlNPVVJDRSIsICJJTlBVVCIgfTsKIApAQCAtMTg2LDcgKzE4Niw3IEBA IHByaXZhdGU6CiAgICAgICAgIGdfYXNzZXJ0KFdFQktJVF9ET01fSVNfRE9DVU1FTlQoZG9jdW1l bnQpKTsKICAgICAgICAgYXNzZXJ0T2JqZWN0SXNEZWxldGVkV2hlblRlc3RGaW5pc2hlcyhHX09C SkVDVChkb2N1bWVudCkpOwogCi0gICAgICAgIEdSZWZQdHI8V2ViS2l0RE9NTm9kZUxpc3Q+IGxp c3QgPSBhZG9wdEdSZWYod2Via2l0X2RvbV9kb2N1bWVudF9nZXRfZWxlbWVudHNfYnlfdGFnX25h bWUoZG9jdW1lbnQsICIqIikpOworICAgICAgICBHUmVmUHRyPFdlYktpdERPTU5vZGVMaXN0PiBs aXN0ID0gYWRvcHRHUmVmKHdlYmtpdF9kb21fZG9jdW1lbnRfcXVlcnlfc2VsZWN0b3JfYWxsKGRv Y3VtZW50LCAiKiIsIG51bGxwdHIpKTsKICAgICAgICAgZ19hc3NlcnQoV0VCS0lUX0RPTV9JU19O T0RFX0xJU1QobGlzdC5nZXQoKSkpOwogICAgICAgICBhc3NlcnRPYmplY3RJc0RlbGV0ZWRXaGVu VGVzdEZpbmlzaGVzKEdfT0JKRUNUKGxpc3QuZ2V0KCkpKTsKICAgICAgICAgZ3Vsb25nIG5vZGVD b3VudCA9IHdlYmtpdF9kb21fbm9kZV9saXN0X2dldF9sZW5ndGgobGlzdC5nZXQoKSk7CkBAIC0y MDIsNiArMjAyLDMwIEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAor ICAgIGJvb2wgdGVzdFRhZ05hbWVzSFRNTENvbGxlY3Rpb24oV2ViS2l0V2ViUGFnZSogcGFnZSkK KyAgICB7CisgICAgICAgIHN0YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZFRhZ05hbWVzW10gPSB7 ICJIVE1MIiwgIkhFQUQiLCAiQk9EWSIsICJWSURFTyIsICJTT1VSQ0UiLCAiVklERU8iLCAiU09V UkNFIiwgIklOUFVUIiB9OworCisgICAgICAgIFdlYktpdERPTURvY3VtZW50KiBkb2N1bWVudCA9 IHdlYmtpdF93ZWJfcGFnZV9nZXRfZG9tX2RvY3VtZW50KHBhZ2UpOworICAgICAgICBnX2Fzc2Vy dChXRUJLSVRfRE9NX0lTX0RPQ1VNRU5UKGRvY3VtZW50KSk7CisgICAgICAgIGFzc2VydE9iamVj dElzRGVsZXRlZFdoZW5UZXN0RmluaXNoZXMoR19PQkpFQ1QoZG9jdW1lbnQpKTsKKworICAgICAg ICBHUmVmUHRyPFdlYktpdERPTUhUTUxDb2xsZWN0aW9uPiBjb2xsZWN0aW9uID0gYWRvcHRHUmVm KHdlYmtpdF9kb21fZG9jdW1lbnRfZ2V0X2VsZW1lbnRzX2J5X3RhZ19uYW1lX2FzX2h0bWxfY29s bGVjdGlvbihkb2N1bWVudCwgIioiKSk7CisgICAgICAgIGdfYXNzZXJ0KFdFQktJVF9ET01fSVNf SFRNTF9DT0xMRUNUSU9OKGNvbGxlY3Rpb24uZ2V0KCkpKTsKKyAgICAgICAgYXNzZXJ0T2JqZWN0 SXNEZWxldGVkV2hlblRlc3RGaW5pc2hlcyhHX09CSkVDVChjb2xsZWN0aW9uLmdldCgpKSk7Cisg ICAgICAgIGd1bG9uZyBub2RlQ291bnQgPSB3ZWJraXRfZG9tX2h0bWxfY29sbGVjdGlvbl9nZXRf bGVuZ3RoKGNvbGxlY3Rpb24uZ2V0KCkpOworICAgICAgICBnX2Fzc2VydF9jbXB1aW50KG5vZGVD b3VudCwgPT0sIEdfTl9FTEVNRU5UUyhleHBlY3RlZFRhZ05hbWVzKSk7CisgICAgICAgIGZvciAo dW5zaWduZWQgaSA9IDA7IGkgPCBub2RlQ291bnQ7IGkrKykgeworICAgICAgICAgICAgV2ViS2l0 RE9NTm9kZSogbm9kZSA9IHdlYmtpdF9kb21faHRtbF9jb2xsZWN0aW9uX2l0ZW0oY29sbGVjdGlv bi5nZXQoKSwgaSk7CisgICAgICAgICAgICBnX2Fzc2VydChXRUJLSVRfRE9NX0lTX05PREUobm9k ZSkpOworICAgICAgICAgICAgYXNzZXJ0T2JqZWN0SXNEZWxldGVkV2hlblRlc3RGaW5pc2hlcyhH X09CSkVDVChub2RlKSk7CisgICAgICAgICAgICBHVW5pcXVlUHRyPGNoYXI+IHRhZ05hbWUod2Vi a2l0X2RvbV9ub2RlX2dldF9ub2RlX25hbWUobm9kZSkpOworICAgICAgICAgICAgZ19hc3NlcnRf Y21wc3RyKHRhZ05hbWUuZ2V0KCksID09LCBleHBlY3RlZFRhZ05hbWVzW2ldKTsKKyAgICAgICAg fQorCisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKwogICAgIGJvb2wgdGVzdERPTUNhY2hl KFdlYktpdFdlYlBhZ2UqIHBhZ2UpCiAgICAgewogICAgICAgICBXZWJLaXRET01Eb2N1bWVudCog ZG9jdW1lbnQgPSB3ZWJraXRfd2ViX3BhZ2VfZ2V0X2RvbV9kb2N1bWVudChwYWdlKTsKQEAgLTI1 Miw4ICsyNzYsMTAgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIHJldHVybiB0ZXN0SGllcmFyY2h5 TmF2aWdhdGlvbihwYWdlKTsKICAgICAgICAgaWYgKCFzdHJjbXAodGVzdE5hbWUsICJpbnNlcnRp b24iKSkKICAgICAgICAgICAgIHJldHVybiB0ZXN0SW5zZXJ0aW9uKHBhZ2UpOwotICAgICAgICBp ZiAoIXN0cmNtcCh0ZXN0TmFtZSwgInRhZy1uYW1lcyIpKQotICAgICAgICAgICAgcmV0dXJuIHRl c3RUYWdOYW1lcyhwYWdlKTsKKyAgICAgICAgaWYgKCFzdHJjbXAodGVzdE5hbWUsICJ0YWctbmFt ZXMtbm9kZS1saXN0IikpCisgICAgICAgICAgICByZXR1cm4gdGVzdFRhZ05hbWVzTm9kZUxpc3Qo cGFnZSk7CisgICAgICAgIGlmICghc3RyY21wKHRlc3ROYW1lLCAidGFnLW5hbWVzLWh0bWwtY29s bGVjdGlvbiIpKQorICAgICAgICAgICAgcmV0dXJuIHRlc3RUYWdOYW1lc0hUTUxDb2xsZWN0aW9u KHBhZ2UpOwogICAgICAgICBpZiAoIXN0cmNtcCh0ZXN0TmFtZSwgImRvbS1jYWNoZSIpKQogICAg ICAgICAgICAgcmV0dXJuIHRlc3RET01DYWNoZShwYWdlKTsKIApAQCAtMjY2LDcgKzI5Miw4IEBA IHN0YXRpYyB2b2lkIF9fYXR0cmlidXRlX18oKGNvbnN0cnVjdG9yKSkgcmVnaXN0ZXJUZXN0cygp CiB7CiAgICAgUkVHSVNURVJfVEVTVChXZWJLaXRET01Ob2RlVGVzdCwgIldlYktpdERPTU5vZGUv aGllcmFyY2h5LW5hdmlnYXRpb24iKTsKICAgICBSRUdJU1RFUl9URVNUKFdlYktpdERPTU5vZGVU ZXN0LCAiV2ViS2l0RE9NTm9kZS9pbnNlcnRpb24iKTsKLSAgICBSRUdJU1RFUl9URVNUKFdlYktp dERPTU5vZGVUZXN0LCAiV2ViS2l0RE9NTm9kZS90YWctbmFtZXMiKTsKKyAgICBSRUdJU1RFUl9U RVNUKFdlYktpdERPTU5vZGVUZXN0LCAiV2ViS2l0RE9NTm9kZS90YWctbmFtZXMtbm9kZS1saXN0 Iik7CisgICAgUkVHSVNURVJfVEVTVChXZWJLaXRET01Ob2RlVGVzdCwgIldlYktpdERPTU5vZGUv dGFnLW5hbWVzLWh0bWwtY29sbGVjdGlvbiIpOwogICAgIFJFR0lTVEVSX1RFU1QoV2ViS2l0RE9N Tm9kZVRlc3QsICJXZWJLaXRET01Ob2RlL2RvbS1jYWNoZSIpOwogfQogCmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdERPTU5vZGUuY3BwIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RET01Ob2RlLmNwcAppbmRleCA0 YjI4MDQyNGM0MzM4ODI0ZWUwMDA3YzU4ZmVkNjQwNDI5MjNlZDgxLi44ODYzNTZiN2UzOTY4MzRh YTczMzFjNGE4ZDRmZTY4NTI5M2MwNjllIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdDJHdGsvVGVzdERPTU5vZGUuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0RE9NTm9kZS5jcHAKQEAgLTQxLDcgKzQxLDcgQEAgc3Rh dGljIHZvaWQgdGVzdFdlYktpdERPTU5vZGVJbnNlcnRpb24oV2ViVmlld1Rlc3QqIHRlc3QsIGdj b25zdHBvaW50ZXIpCiAgICAgZ19hc3NlcnQodGVzdC0+cnVuV2ViUHJvY2Vzc1Rlc3QoIldlYktp dERPTU5vZGUiLCAiaW5zZXJ0aW9uIikpOwogfQogCi1zdGF0aWMgdm9pZCB0ZXN0V2ViS2l0RE9N Tm9kZVRhZ05hbWVzKFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQorc3RhdGljIHZv aWQgcHJlcGFyZURPTUZvclRhZ05hbWVzVGVzdHMoV2ViVmlld1Rlc3QqIHRlc3QpCiB7CiAgICAg c3RhdGljIGNvbnN0IGNoYXIqIHRlc3RIVE1MID0gIjxodG1sPjxoZWFkPjwvaGVhZD48Ym9keT4i CiAgICAgICAgICI8dmlkZW8gaWQ9J3ZpZGVvJyBwcmVsb2FkPSdub25lJz4iCkBAIC01MywxMCAr NTMsMjAgQEAgc3RhdGljIHZvaWQgdGVzdFdlYktpdERPTU5vZGVUYWdOYW1lcyhXZWJWaWV3VGVz dCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICAgICAgIiAgICAgICAgWW91ciBicm93c2VyIGRv ZXMgbm90IHN1cHBvcnQgdGhlIHZpZGVvIHRhZy4iCiAgICAgICAgICI8L3ZpZGVvPiIKICAgICAg ICAgIjxpbnB1dCB0eXBlPSdoaWRkZW4nIGlkPSd0ZXN0JyBuYW1lPSdmaW5pc2gnIHZhbHVlPSdm YWxzZSc+PC9ib2R5PjwvaHRtbD4iOwotICAgIHRlc3QtPmxvYWRIdG1sKHRlc3RIVE1MLCAwKTsK KyAgICB0ZXN0LT5sb2FkSHRtbCh0ZXN0SFRNTCwgbnVsbHB0cik7CiAgICAgdGVzdC0+d2FpdFVu dGlsTG9hZEZpbmlzaGVkKCk7Cit9CisKK3N0YXRpYyB2b2lkIHRlc3RXZWJLaXRET01Ob2RlVGFn TmFtZXNOb2RlTGlzdChXZWJWaWV3VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKK3sKKyAgICBw cmVwYXJlRE9NRm9yVGFnTmFtZXNUZXN0cyh0ZXN0KTsKKyAgICBnX2Fzc2VydCh0ZXN0LT5ydW5X ZWJQcm9jZXNzVGVzdCgiV2ViS2l0RE9NTm9kZSIsICJ0YWctbmFtZXMtbm9kZS1saXN0IikpOwor fQogCi0gICAgZ19hc3NlcnQodGVzdC0+cnVuV2ViUHJvY2Vzc1Rlc3QoIldlYktpdERPTU5vZGUi LCAidGFnLW5hbWVzIikpOworc3RhdGljIHZvaWQgdGVzdFdlYktpdERPTU5vZGVUYWdOYW1lc0hU TUxDb2xsZWN0aW9uKFdlYlZpZXdUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQoreworICAgIHBy ZXBhcmVET01Gb3JUYWdOYW1lc1Rlc3RzKHRlc3QpOworICAgIGdfYXNzZXJ0KHRlc3QtPnJ1bldl YlByb2Nlc3NUZXN0KCJXZWJLaXRET01Ob2RlIiwgInRhZy1uYW1lcy1odG1sLWNvbGxlY3Rpb24i KSk7CiB9CiAKIHN0YXRpYyB2b2lkIHRlc3RXZWJLaXRET01PYmplY3RDYWNoZShXZWJWaWV3VGVz dCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKQEAgLTc4LDcgKzg4LDggQEAgdm9pZCBiZWZvcmVBbGwo KQogewogICAgIFdlYlZpZXdUZXN0OjphZGQoIldlYktpdERPTU5vZGUiLCAiaGllcmFyY2h5LW5h dmlnYXRpb24iLCB0ZXN0V2ViS2l0RE9NTm9kZUhpZXJhcmNoeU5hdmlnYXRpb24pOwogICAgIFdl YlZpZXdUZXN0OjphZGQoIldlYktpdERPTU5vZGUiLCAiaW5zZXJ0aW9uIiwgdGVzdFdlYktpdERP TU5vZGVJbnNlcnRpb24pOwotICAgIFdlYlZpZXdUZXN0OjphZGQoIldlYktpdERPTU5vZGUiLCAi dGFnLW5hbWVzIiwgdGVzdFdlYktpdERPTU5vZGVUYWdOYW1lcyk7CisgICAgV2ViVmlld1Rlc3Q6 OmFkZCgiV2ViS2l0RE9NTm9kZSIsICJ0YWctbmFtZXMtbm9kZS1saXN0IiwgdGVzdFdlYktpdERP TU5vZGVUYWdOYW1lc05vZGVMaXN0KTsKKyAgICBXZWJWaWV3VGVzdDo6YWRkKCJXZWJLaXRET01O b2RlIiwgInRhZy1uYW1lcy1odG1sLWNvbGxlY3Rpb24iLCB0ZXN0V2ViS2l0RE9NTm9kZVRhZ05h bWVzSFRNTENvbGxlY3Rpb24pOwogICAgIFdlYlZpZXdUZXN0OjphZGQoIldlYktpdERPTU5vZGUi LCAiZG9tLWNhY2hlIiwgdGVzdFdlYktpdERPTU9iamVjdENhY2hlKTsKIH0KIAo=