149649 2015-09-29 15:36:24 -0700 Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc) 2015-09-29 22:59:06 -0700 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1129428 0 joepeck 2015-09-29 15:36:24 -0700 * SUMMARY Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc). * STEPS TO REPRODUCE 1. js> o = {}; 2. js> o.to| => expected "toString", got nothing * NOTES - Missing completion suggestions include any projects on a bare object ({}). 1129429 1 webkit-bug-importer 2015-09-29 15:36:47 -0700 <rdar://problem/22905818> 1129430 2 262115 joepeck 2015-09-29 15:38:41 -0700 Created attachment 262115 [PATCH] Proposed Fix 1129511 3 262115 commit-queue 2015-09-29 22:59:03 -0700 Comment on attachment 262115 [PATCH] Proposed Fix Clearing flags on attachment: 262115 Committed r190342: <http://trac.webkit.org/changeset/190342> 1129512 4 commit-queue 2015-09-29 22:59:06 -0700 All reviewed patches have been landed. Closing bug. 262115 2015-09-29 15:38:41 -0700 2015-09-29 22:59:03 -0700 [PATCH] Proposed Fix completion-1.patch text/plain 3156 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJkYWNlNjkuLmFkYzYyNWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE1LTA5LTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29uc29s ZSBjb21wbGV0aW9uIHN1Z2dlc3Rpb25zIHNob3VsZCBpbmNsdWRlIHByb3BlcnRpZXMgb24gT2Jq ZWN0IChoYXNPd25Qcm9wZXJ0eSwgdG9TdHJpbmcsIGV0YykKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTY0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGll cy5qczoKKyAgICAgICAgKHZhbHVlKToKKyAgICAgICAgU2luY2Uga2V5U2V0cyBpbiB0aGlzIGlu c3RhbmNlIGFyZSBvZnRlbiB1c2VkIGFzIGhhc2ggbWFwcyB3aXRoIHRoZQorICAgICAgICBgaW5g IG9wZXJhdG9yLCBjcmVhdGUgYSBibGFuayBvYmplY3QgdGhhdCB3b24ndCBoYXZlIE9iamVjdC5w cm90b3R5cGUKKyAgICAgICAgZnVuY3Rpb25zIHRoYXQgd291bGQgYmUgc2VlbiBieSBgaW5gLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9KYXZhU2NyaXB0UnVudGltZUNv bXBsZXRpb25Qcm92aWRlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0UnVu dGltZUNvbXBsZXRpb25Qcm92aWRlci5wcm90b3R5cGUuY29tcGxldGlvbkNvbnRyb2xsZXJDb21w bGV0aW9uc05lZWRlZC5yZWNlaXZlZFByb3BlcnR5TmFtZXMuY29tcGFyZSk6CisgICAgICAgIFNv cnQgX19kZWZpbmVHZXR0ZXJfXyBhbmQgX19sb29rdXBHZXR0ZXJfXyBhbmQgZnJpZW5kcyBsYXN0 LCBzaW5jZSB0aGV5CisgICAgICAgIGFyZSByYXJlbHkgdXNlZCBwcm9wZXJ0aWVzLgorCisyMDE1 LTA5LTI5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAg V2ViIEluc3BlY3RvcjogTWlzc2luZyBjb21wbGV0aW9ucyBmb3IgU3ltYm9sIG9iamVjdHMsIGNv bnNvbGUuZXJyb3Igd2FybmluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ5NjQxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvVXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRpZXMuanMKaW5kZXggZDBiMmIyMS4uYjRkNjMxMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGlsaXRp ZXMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VdGls aXRpZXMuanMKQEAgLTQ0NSw3ICs0NDUsNyBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoQXJyYXku cHJvdG90eXBlLCAia2V5U2V0IiwKIHsKICAgICB2YWx1ZTogZnVuY3Rpb24oKQogICAgIHsKLSAg ICAgICAgdmFyIGtleXMgPSB7fTsKKyAgICAgICAgbGV0IGtleXMgPSBPYmplY3QuY3JlYXRlKG51 bGwpOwogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMubGVuZ3RoOyArK2kpCiAgICAg ICAgICAgICBrZXlzW3RoaXNbaV1dID0gdHJ1ZTsKICAgICAgICAgcmV0dXJuIGtleXM7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9K YXZhU2NyaXB0UnVudGltZUNvbXBsZXRpb25Qcm92aWRlci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlv blByb3ZpZGVyLmpzCmluZGV4IDIzYWY4NTQuLjI0ZjMyN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1l Q29tcGxldGlvblByb3ZpZGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0phdmFTY3JpcHRSdW50aW1lQ29tcGxldGlvblByb3ZpZGVyLmpz CkBAIC0yNjMsMTAgKzI2MywxOCBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdFJ1bnRpbWVDb21w bGV0aW9uUHJvdmlkZXIgPSBjbGFzcyBKYXZhU2NyaXB0UnVudGltZUNvbXBsZQogICAgICAgICAg ICAgZnVuY3Rpb24gY29tcGFyZShhLCBiKQogICAgICAgICAgICAgewogICAgICAgICAgICAgICAg IC8vIFRyeSB0byBzb3J0IGluIG51bWVyaWNhbCBvcmRlciBmaXJzdC4KLSAgICAgICAgICAgICAg ICB2YXIgbnVtZXJpY0NvbXBhcmVSZXN1bHQgPSBhIC0gYjsKKyAgICAgICAgICAgICAgICBsZXQg bnVtZXJpY0NvbXBhcmVSZXN1bHQgPSBhIC0gYjsKICAgICAgICAgICAgICAgICBpZiAoIWlzTmFO KG51bWVyaWNDb21wYXJlUmVzdWx0KSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIG51bWVy aWNDb21wYXJlUmVzdWx0OwogCisgICAgICAgICAgICAgICAgLy8gU29ydCBfX2RlZmluZUdldHRl cl9fLCBfX2xvb2t1cEdldHRlcl9fLCBhbmQgZnJpZW5kcyBsYXN0LgorICAgICAgICAgICAgICAg IGxldCBhUmFyZVByb3BlcnR5ID0gYS5zdGFydHNXaXRoKCJfXyIpICYmIGEuZW5kc1dpdGgoIl9f Iik7CisgICAgICAgICAgICAgICAgbGV0IGJSYXJlUHJvcGVydHkgPSBiLnN0YXJ0c1dpdGgoIl9f IikgJiYgYi5lbmRzV2l0aCgiX18iKTsKKyAgICAgICAgICAgICAgICBpZiAoYVJhcmVQcm9wZXJ0 eSAmJiAhYlJhcmVQcm9wZXJ0eSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDE7CisgICAg ICAgICAgICAgICAgaWYgKCFhUmFyZVByb3BlcnR5ICYmIGJSYXJlUHJvcGVydHkpCisgICAgICAg ICAgICAgICAgICAgIHJldHVybiAtMTsKKwogICAgICAgICAgICAgICAgIC8vIE5vdCBudW1iZXJz LCBzb3J0IGFzIHN0cmluZ3MuCiAgICAgICAgICAgICAgICAgcmV0dXJuIGEubG9jYWxlQ29tcGFy ZShiKTsKICAgICAgICAgICAgIH0K