149627 2015-09-29 09:15:49 -0700 [GTK][CMake] Warning about CMP0058 2015-09-29 12:18:54 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro commit-queue mcatanzaro mrobinson oldest_to_newest 1129249 0 mcatanzaro 2015-09-29 09:15:49 -0700 Since CMake 3.3: CMake Warning (dev): Policy CMP0058 is not set: Ninja requires custom command byproducts to be explicit. Run "cmake --help-policy CMP0058" for policy details. Use the cmake_policy command to set the policy and suppress this warning. This project specifies custom command DEPENDS on files in the build tree that are not specified as the OUTPUT or BYPRODUCTS of any add_custom_command or add_custom_target: DerivedSources/webkit2gtk/WebKit2ResourcesGResourceBundle.xml For compatibility with versions of CMake that did not have the BYPRODUCTS option, CMake is generating phony rules for such files to convince 'ninja' to build. Project authors should add the missing BYPRODUCTS or OUTPUT options to the custom commands that produce these files. This warning is for project developers. Use -Wno-dev to suppress it. There is no way to get rid of the warning using the old policy, except to stop using the file command to generate WebKit2ResourcesGResourceBundle.xml and to use a custom script to do it instead, which would be a crazy unnecessary workaround. At http://public.kitware.com/pipermail/cmake/2015-September/061672.html one of the CMake developers notes that it's safe in our case to just switch to the new policy, so let's just do that. The risk is that someone using an old CMake might in the future break the build for people using modern CMake, but that would be noticed pretty quickly.... 1129250 1 262070 mcatanzaro 2015-09-29 09:17:43 -0700 Created attachment 262070 Patch 1129330 2 262070 commit-queue 2015-09-29 12:18:51 -0700 Comment on attachment 262070 Patch Clearing flags on attachment: 262070 Committed r190321: <http://trac.webkit.org/changeset/190321> 1129331 3 commit-queue 2015-09-29 12:18:54 -0700 All reviewed patches have been landed. Closing bug. 262070 2015-09-29 09:17:43 -0700 2015-09-29 12:18:51 -0700 Patch bug-149627-20150929111719.patch text/plain 1056 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMjcyCmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IDkxYjk4ZDFkM2NkZWMxOTk4YmEzNDk3ODA0Y2MwOGFjMWI4 NDc4ZTQuLmNmYTRjYzJjZTRkY2Q4YjNmMTIyYTlkODg5NTYzOTY5ZjE5ODUzYjAgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0xLDYgKzEsMTEgQEAK IGNtYWtlX21pbmltdW1fcmVxdWlyZWQoVkVSU0lPTiAyLjguMTIpCiBwcm9qZWN0KFdlYktpdCkK IAorIyBUaGlzIHNob3VsZCBiZSByZW1vdmVkIG9uY2Ugd2UgcmVxdWlyZSBDTWFrZSAzLjMuCitp ZiAoUE9MSUNZIENNUDAwNTgpCisgICAgY21ha2VfcG9saWN5KFNFVCBDTVAwMDU4IE5FVykKK2Vu ZGlmICgpCisKIHNldChDTUFLRV9NT0RVTEVfUEFUSCAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3Vy Y2UvY21ha2UiKQogCiBpZiAoTk9UIERFRklORUQgRU5BQkxFX1dFQktJVCkKZGlmZiAtLWdpdCBh L0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1YjRlMDM4ZTI4NWJhYmEyNDAwMmNhMDQ3YjBk NzEwYjMwZWM4ZDdkLi41NjU1YzY4YTFiOWEyZjQ4NDY5YWNhODJjZWY3MDEzNjI3ODNiNzdmIDEw MDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTUtMDktMjkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdW0NNYWtlXSBXYXJuaW5nIGFib3V0IENNUDAwNTgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTYyNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9wdC1pbiB0byB0aGUgbmV3IGJlaGF2 aW9yIGZvciBDTVAwMDU4LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTUtMDkt MjUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBDbGVhbiB1cCBDTWFrZSBidWlsZCBvbiBNYWMK