149619 2015-09-29 02:29:48 -0700 [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux 2015-09-30 15:30:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P1 Critical --- 108645 148664 1 ossy msaboff msaboff oldest_to_newest 1129188 0 ossy 2015-09-29 02:29:48 -0700 https://trac.webkit.org/changeset/190289 made 374 tests crash on 32 bit ARM Linux platforms. (81 different tests) EFL ARMv7 Thumb2 instructuon set: https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release/builds/15412 EFL ARMv7 "traditional" ARM instruction set: https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/15278 GTK ARM "whatever": https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/8640 1129415 1 ap 2015-09-29 14:41:54 -0700 Should this be duped to bug 149647 now (the rollout bug)? 1129666 2 msaboff 2015-09-30 14:16:47 -0700 I think I found the issue. In LowLevelAssembler.asm, the macro prepareForTailCall had the following construct: if ARM or SH4 or ARM64 or C_LOOP or MIPS addp 2 * PtrSize, sp subi 2 * PtrSize, temp2 loadp PtrSize[cfr], lr else addp PtrSize, sp subi PtrSize, temp2 loadp PtrSize[cfr], temp3 storep temp3, [sp] end The "if ARM or SH4 ..." case accounts for having a link register. The problem is that this if should also take into account the other ARM variants. It should read: if ARM or ARMv7_TRADITIONAL or ARMv7 or SH4 or ARM64 or C_LOOP or MIPS Running all JSC regression tests now. 1129671 3 262191 msaboff 2015-09-30 14:34:15 -0700 Created attachment 262191 Patch 1129688 4 msaboff 2015-09-30 15:30:05 -0700 Landed as part of change set r190370: <http://trac.webkit.org/changeset/190370>. 262191 2015-09-30 14:34:15 -0700 2015-09-30 14:37:27 -0700 Patch 149619.patch text/plain 1441 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkwMzY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTA5LTMwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtBUk1dIFJFR1JFU1NJT04ocjE5MDI4OSk6IEl0IG1hZGUgMzc0IHRlc3RzIGNyYXNoIG9u IDMyIGJpdCBBUk0gTGludXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0OTYxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE5lZWQgdG8gY2hlY2sgZm9yIEFSTXY3X1RSQURJVElPTkFMIGFuZCBBUk12NyBp biBhZGRpdGlvbiB0byBBUk0gaW4gImlmIgorICAgICAgICBzdGF0ZW1lbnQgdG8gaGFuZGxlIHBs YXRmb3JtcyB3aXRoIGEgbGluayByZWdpc3Rlci4KKyAgICAgICAgCisgICAgICAgICogbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlci5hc206CisgICAgICAgIChwcmVwYXJlRm9yVGFpbENhbGwpOgor CiAyMDE1LTA5LTMwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFtFUzZdIEFkZCBUeXBlZEFycmF5LnByb3RvdHlwZSBmdW5jdGlvbmFsaXR5LgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl dGVyLmFzbQkocmV2aXNpb24gMTkwMzY3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC03NTMsNyArNzUzLDcg QEAgbWFjcm8gcHJlcGFyZUZvclRhaWxDYWxsKGNhbGxlZSwgdGVtcDEsIAogICAgIGFkZGkgU3Rh Y2tBbGlnbm1lbnQgLSAxICsgQ2FsbEZyYW1lSGVhZGVyU2l6ZSwgdGVtcDIKICAgICBhbmRpIH5T dGFja0FsaWdubWVudE1hc2ssIHRlbXAyCiAKLSAgICBpZiBBUk0gb3IgU0g0IG9yIEFSTTY0IG9y IENfTE9PUCBvciBNSVBTCisgICAgaWYgQVJNIG9yIEFSTXY3X1RSQURJVElPTkFMIG9yIEFSTXY3 IG9yIFNINCBvciBBUk02NCBvciBDX0xPT1Agb3IgTUlQUwogICAgICAgICBhZGRwIDIgKiBQdHJT aXplLCBzcAogICAgICAgICBzdWJpIDIgKiBQdHJTaXplLCB0ZW1wMgogICAgICAgICBsb2FkcCBQ dHJTaXplW2Nmcl0sIGxyCg==