149599 2015-09-28 11:01:36 -0700 js/regress/getter-richards-try-catch is timing out on debug layout tests 2015-09-28 16:47:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam ap commit-queue ryanhaddad oldest_to_newest 1129033 0 saam 2015-09-28 11:01:36 -0700 ... 1129034 1 262013 saam 2015-09-28 11:03:58 -0700 Created attachment 262013 patch 1129035 2 saam 2015-09-28 11:04:37 -0700 (In reply to comment #1) > Created attachment 262013 [details] > patch This is a speculative fix. I couldn't reproduce this timeout locally. I'll continue to lower the number of iterations until it doesn't time out. 1129051 3 262013 commit-queue 2015-09-28 11:57:50 -0700 Comment on attachment 262013 patch Clearing flags on attachment: 262013 Committed r190282: <http://trac.webkit.org/changeset/190282> 1129052 4 commit-queue 2015-09-28 11:57:53 -0700 All reviewed patches have been landed. Closing bug. 1129079 5 ryanhaddad 2015-09-28 14:53:06 -0700 This test is still flaking on all debug bots: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fregress%2Fgetter-richards-try-catch.html 1129094 6 ap 2015-09-28 15:39:17 -0700 Is this test worth the time it takes? Generally, tests shouldn't take more than a second (and ideally, a few milliseconds). If a test takes 10 seconds, it's the cost we pay forever going forward. 1129102 7 saam 2015-09-28 15:53:25 -0700 (In reply to comment #6) > Is this test worth the time it takes? Generally, tests shouldn't take more > than a second (and ideally, a few milliseconds). If a test takes 10 seconds, > it's the cost we pay forever going forward. Probably not worth it. I'll further lower the iteration count. 1129105 8 saam 2015-09-28 16:06:24 -0700 follow up: http://trac.webkit.org/changeset/190294 1129112 9 saam 2015-09-28 16:47:08 -0700 follow up #2: disabled on debug builds. http://trac.webkit.org/changeset/190296 262013 2015-09-28 11:03:58 -0700 2015-09-28 11:57:50 -0700 patch b-backup.diff text/plain 1751 saam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MDI4MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA5LTI4ICBTYWFtIGJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIGpzL3JlZ3Jlc3MvZ2V0dGVyLXJpY2hhcmRzLXRy eS1jYXRjaCBpcyB0aW1pbmcgb3V0IG9uIGRlYnVnIGxheW91dCB0ZXN0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTk5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqcy9yZWdyZXNzL3NjcmlwdC10 ZXN0cy9nZXR0ZXItcmljaGFyZHMtdHJ5LWNhdGNoLmpzOgorICAgICAgICAoUGFja2V0LnByb3Rv dHlwZS50b1N0cmluZyk6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6 CisKIDIwMTUtMDktMjggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAg ICBPYmplY3QuZ2V0T3duUHJvcGVydHlOYW1lcygpIGRvZXMgbm90IHJldHVybiBuYW1lZCBwcm9w ZXJ0aWVzCkluZGV4OiBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3NjcmlwdC10ZXN0cy9nZXR0ZXIt cmljaGFyZHMtdHJ5LWNhdGNoLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3JlZ3Jl c3Mvc2NyaXB0LXRlc3RzL2dldHRlci1yaWNoYXJkcy10cnktY2F0Y2guanMJKHJldmlzaW9uIDE5 MDI4MCkKKysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL2dldHRlci1yaWNo YXJkcy10cnktY2F0Y2guanMJKHdvcmtpbmcgY29weSkKQEAgLTExNDcsNSArMTE0Nyw1IEBAIFBh Y2tldC5wcm90b3R5cGUudG9TdHJpbmcgPSBmdW5jdGlvbiAoKSAKICAgICByZXR1cm4gIlBhY2tl dCI7CiB9OwogCi1mb3IgKHZhciBpID0gMDsgaSA8IDM1MDsgKytpKQorZm9yICh2YXIgaSA9IDA7 IGkgPCAyODA7ICsraSkKICAgICBydW5SaWNoYXJkcygpOwpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDE5MDI4MCkKKysrIExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xMzE1 LDUgKzEzMTUsMyBAQCB3ZWJraXQub3JnL2IvMTQ5NDQxIGZhc3Qvc2hhZG93LWRvbS9jc3MtCiB3 ZWJraXQub3JnL2IvMTQ5NTkzIGZhc3Qvc2hhZG93LWRvbS9zaGFkb3ctbGF5b3V0LWFmdGVyLXNs b3QtY2hhbmdlcy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xNDk1 MTAgYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1leHBhbmRlZC1ub3RpZmljYXRpb25zLmh0bWwgWyBQ YXNzIEZhaWx1cmUgXQotCi13ZWJraXQub3JnL2IvMTQ5NTc1IFsgRGVidWcgXSBqcy9yZWdyZXNz L2dldHRlci1yaWNoYXJkcy10cnktY2F0Y2guaHRtbCBbIFNraXAgXQo=