149559 2015-09-25 12:31:32 -0700 Clicking on a data detected item inside a form control always pops up a map on force touch trackpad 2015-09-25 14:36:39 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1128747 0 bdakin 2015-09-25 12:31:32 -0700 Clicking on a data detected item inside a form control always pops up a map on force touch trackpad 1) Load https://smartasset.com/mortgage/top-ten-american-cities-to-work-in-tech 2) Search for "How does the cost of living in your area compare" 3) type a city name 4) Click and drag to select the text rdar://problem/22826796 1128748 1 261933 bdakin 2015-09-25 12:45:16 -0700 Created attachment 261933 Patch 1128768 2 261933 thorton 2015-09-25 14:13:30 -0700 Comment on attachment 261933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261933&action=review > Source/WebCore/editing/mac/DataDetection.mm:130 > + extra newline. 1128777 3 bdakin 2015-09-25 14:36:39 -0700 Thanks Tim! http://trac.webkit.org/changeset/190252 261933 2015-09-25 12:45:16 -0700 2015-09-25 14:13:30 -0700 Patch for-review.txt text/plain 6527 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDI0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA5LTI1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBDbGlja2luZyBvbiBhIGRhdGEgZGV0 ZWN0ZWQgaXRlbSBpbnNpZGUgYSBmb3JtIGNvbnRyb2wgYWx3YXlzIHBvcHMgdXAgYSBtYXAgCisg ICAgICAgIG9uIGZvcmNlIHRvdWNoIHRyYWNrcGFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDk1NTkKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5n LQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMjgyNjc5NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSByZWFsIGJ1ZyBoZXJlIGFwcGVhcnMgdG8g YmUgYSBidWcgaW4gTG9va3VwLCBidXQgd2UgY2FuIHdvcmsgYXJvdW5kIGl0LiAKKyAgICAgICAg Rm9yIG5vcm1hbCB0ZXh0LCB3ZSBjYWxsIGRpcmVjdGx5IGludG8gRGF0YSBEZXRlY3RvcnMgZm9y IG1hcCByZXN1bHRzLCBhbmQgCisgICAgICAgIHRoYXQgd29ya3MgZmluZS4gRm9yIHRleHQgd2l0 aGluIGZvcm0gY29udHJvbHMsIHdlIGRpZCBub3QgcHJvcGVybHkgZXh0cmFjdCAKKyAgICAgICAg dGhlIHRleHQgZm9yIERELCBzbyB3ZSBzZW50IGl0IHRvIExvb2t1cCBpbnN0ZWFkLCBhbmQgTG9v a3VwIGhhcyB0aGlzIGJ1ZyAKKyAgICAgICAgd2hlcmUgdGhleSB3aWxsIHBvcCBvcGVuIHRoZSBt YXAgcmlnaHQgYXdheS4gSWYgd2UgcHJvcGVybHkgZXh0cmFjdCB0aGUgdGV4dCAKKyAgICAgICAg Zm9yIGZvcm0gY29udHJvbHMsIHRoZW4gd2UgY2FuIHdvcmsgYXJvdW5kIHRoaXMgYnVnLgorCisg ICAgICAgICogZWRpdGluZy9tYWMvRGF0YURldGVjdGlvbi5tbToKKyAgICAgICAgKFdlYkNvcmU6 OmRldGVjdEl0ZW1BdFBvc2l0aW9uV2l0aFJhbmdlKToKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFE ZXRlY3Rpb246OmRldGVjdEl0ZW1Bcm91bmRIaXRUZXN0UmVzdWx0KToKKwogMjAxNS0wOS0yNSAg UGVyIEFybmUgVm9sbGFuICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW1dpbkNhaXJv XSBJbmNvcnJlY3QgcG9zaXRpb24gZm9yIHdpbmRvd2xlc3MgcGx1Z2lucy4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0RhdGFEZXRlY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMvRGF0YURldGVjdGlvbi5tbQkocmV2aXNpb24gMTkwMjEz KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMvRGF0YURldGVjdGlvbi5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMzAsNiArMzAsNyBAQAogCiAjaW1wb3J0ICJEYXRhRGV0ZWN0b3JzU1BJLmgi CiAjaW1wb3J0ICJGcmFtZVZpZXcuaCIKKyNpbXBvcnQgIkhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50LmgiCiAjaW1wb3J0ICJIaXRUZXN0UmVzdWx0LmgiCiAjaW1wb3J0ICJOb2RlLmgiCiAjaW1w b3J0ICJSYW5nZS5oIgpAQCAtNDEsMjUgKzQyLDggQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewog Ci1SZXRhaW5QdHI8RERBY3Rpb25Db250ZXh0PiBEYXRhRGV0ZWN0aW9uOjpkZXRlY3RJdGVtQXJv dW5kSGl0VGVzdFJlc3VsdChjb25zdCBIaXRUZXN0UmVzdWx0JiBoaXRUZXN0UmVzdWx0LCBGbG9h dFJlY3QmIGRldGVjdGVkRGF0YUJvdW5kaW5nQm94LCBSZWZQdHI8UmFuZ2U+JiBkZXRlY3RlZERh dGFSYW5nZSkKK3N0YXRpYyBSZXRhaW5QdHI8RERBY3Rpb25Db250ZXh0PiBkZXRlY3RJdGVtQXRQ b3NpdGlvbldpdGhSYW5nZShWaXNpYmxlUG9zaXRpb24gcG9zaXRpb24sIFJlZlB0cjxSYW5nZT4g Y29udGV4dFJhbmdlLCBGbG9hdFJlY3QmIGRldGVjdGVkRGF0YUJvdW5kaW5nQm94LCBSZWZQdHI8 UmFuZ2U+JiBkZXRlY3RlZERhdGFSYW5nZSkKIHsKLSAgICBpZiAoIURhdGFEZXRlY3RvcnNMaWJy YXJ5KCkpCi0gICAgICAgIHJldHVybiBudWxscHRyOwotCi0gICAgTm9kZSogbm9kZSA9IGhpdFRl c3RSZXN1bHQuaW5uZXJOb25TaGFyZWROb2RlKCk7Ci0gICAgaWYgKCFub2RlKQotICAgICAgICBy ZXR1cm4gbnVsbHB0cjsKLSAgICBhdXRvIHJlbmRlcmVyID0gbm9kZS0+cmVuZGVyZXIoKTsKLSAg ICBpZiAoIXJlbmRlcmVyKQotICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICBWaXNpYmxlUG9z aXRpb24gcG9zaXRpb24gPSByZW5kZXJlci0+cG9zaXRpb25Gb3JQb2ludChoaXRUZXN0UmVzdWx0 LmxvY2FsUG9pbnQoKSwgbnVsbHB0cik7Ci0gICAgaWYgKHBvc2l0aW9uLmlzTnVsbCgpKQotICAg ICAgICBwb3NpdGlvbiA9IGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShub2RlKTsKLQotICAg IFJlZlB0cjxSYW5nZT4gY29udGV4dFJhbmdlID0gcmFuZ2VFeHBhbmRlZEFyb3VuZFBvc2l0aW9u QnlDaGFyYWN0ZXJzKHBvc2l0aW9uLCAyNTApOwotICAgIGlmICghY29udGV4dFJhbmdlKQotICAg ICAgICByZXR1cm4gbnVsbHB0cjsKLQogICAgIFN0cmluZyBmdWxsUGxhaW5UZXh0U3RyaW5nID0g cGxhaW5UZXh0KGNvbnRleHRSYW5nZS5nZXQoKSk7CiAgICAgaW50IGhpdExvY2F0aW9uID0gVGV4 dEl0ZXJhdG9yOjpyYW5nZUxlbmd0aChtYWtlUmFuZ2UoY29udGV4dFJhbmdlLT5zdGFydFBvc2l0 aW9uKCksIHBvc2l0aW9uKS5nZXQoKSk7CiAKQEAgLTEwNCw2ICs4OCw1MSBAQCBSZXRhaW5QdHI8 RERBY3Rpb25Db250ZXh0PiBEYXRhRGV0ZWN0aW9uCiAgICAgcmV0dXJuIGFjdGlvbkNvbnRleHQ7 CiB9CiAKK1JldGFpblB0cjxEREFjdGlvbkNvbnRleHQ+IERhdGFEZXRlY3Rpb246OmRldGVjdEl0 ZW1Bcm91bmRIaXRUZXN0UmVzdWx0KGNvbnN0IEhpdFRlc3RSZXN1bHQmIGhpdFRlc3RSZXN1bHQs IEZsb2F0UmVjdCYgZGV0ZWN0ZWREYXRhQm91bmRpbmdCb3gsIFJlZlB0cjxSYW5nZT4mIGRldGVj dGVkRGF0YVJhbmdlKQoreworICAgIGlmICghRGF0YURldGVjdG9yc0xpYnJhcnkoKSkKKyAgICAg ICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICBOb2RlKiBub2RlID0gaGl0VGVzdFJlc3VsdC5pbm5l ck5vblNoYXJlZE5vZGUoKTsKKyAgICBpZiAoIW5vZGUpCisgICAgICAgIHJldHVybiBudWxscHRy OworICAgIGF1dG8gcmVuZGVyZXIgPSBub2RlLT5yZW5kZXJlcigpOworICAgIGlmICghcmVuZGVy ZXIpCisgICAgICAgIHJldHVybiBudWxscHRyOworCisgICAgVmlzaWJsZVBvc2l0aW9uIHBvc2l0 aW9uOworICAgIFJlZlB0cjxSYW5nZT4gY29udGV4dFJhbmdlOworCisgICAgaWYgKCFpczxIVE1M VGV4dEZvcm1Db250cm9sRWxlbWVudD4oKm5vZGUpKSB7CisgICAgICAgIHBvc2l0aW9uID0gcmVu ZGVyZXItPnBvc2l0aW9uRm9yUG9pbnQoaGl0VGVzdFJlc3VsdC5sb2NhbFBvaW50KCksIG51bGxw dHIpOworICAgICAgICBpZiAocG9zaXRpb24uaXNOdWxsKCkpCisgICAgICAgICAgICBwb3NpdGlv biA9IGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShub2RlKTsKKworICAgICAgICBjb250ZXh0 UmFuZ2UgPSByYW5nZUV4cGFuZGVkQXJvdW5kUG9zaXRpb25CeUNoYXJhY3RlcnMocG9zaXRpb24s IDI1MCk7CisgICAgICAgIGlmICghY29udGV4dFJhbmdlKQorICAgICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CisgICAgfSBlbHNlIHsKKyAgICAgICAgRnJhbWUqIGZyYW1lID0gbm9kZS0+ZG9jdW1l bnQoKS5mcmFtZSgpOworICAgICAgICBpZiAoIWZyYW1lKQorICAgICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CisKKyAgICAgICAgSW50UG9pbnQgZnJhbWVQb2ludCA9IGhpdFRlc3RSZXN1bHQucm91 bmRlZFBvaW50SW5Jbm5lck5vZGVGcmFtZSgpOworICAgICAgICBpZiAoIWZyYW1lLT5yYW5nZUZv clBvaW50KGZyYW1lUG9pbnQpKQorICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICAg ICAgVmlzaWJsZVBvc2l0aW9uIHBvc2l0aW9uID0gZnJhbWUtPnZpc2libGVQb3NpdGlvbkZvclBv aW50KGZyYW1lUG9pbnQpOworICAgICAgICBpZiAocG9zaXRpb24uaXNOdWxsKCkpCisgICAgICAg ICAgICByZXR1cm4gbnVsbHB0cjsKKworICAgICAgICBjb250ZXh0UmFuZ2UgPSBlbmNsb3NpbmdU ZXh0VW5pdE9mR3JhbnVsYXJpdHkocG9zaXRpb24sIExpbmVHcmFudWxhcml0eSwgRGlyZWN0aW9u Rm9yd2FyZCk7CisgICAgICAgIGlmICghY29udGV4dFJhbmdlKQorICAgICAgICAgICAgcmV0dXJu IG51bGxwdHI7CisKKyAgICB9CisKKyAgICByZXR1cm4gZGV0ZWN0SXRlbUF0UG9zaXRpb25XaXRo UmFuZ2UocG9zaXRpb24sIGNvbnRleHRSYW5nZSwgZGV0ZWN0ZWREYXRhQm91bmRpbmdCb3gsIGRl dGVjdGVkRGF0YVJhbmdlKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYg Ly8gUExBVEZPUk0oTUFDKQpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTkwMjQ5KQorKysgU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTUtMDktMjUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIENsaWNr aW5nIG9uIGEgZGF0YSBkZXRlY3RlZCBpdGVtIGluc2lkZSBhIGZvcm0gY29udHJvbCBhbHdheXMg cG9wcyB1cCBhIG1hcCAKKyAgICAgICAgb24gZm9yY2UgdG91Y2ggdHJhY2twYWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTU1OQorICAgICAgICAt YW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIyODI2Nzk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG9vayBmb3IgRGF0 YSBEZXRlY3RlZCB0ZXh0IGZvciB0ZXh0IG5vZGVzIGFuZCBIaXRUZXN0UmVzdWx0cyB0aGF0IGFy ZSBvdmVyIAorICAgICAgICB0ZXh0IGluc2lkZSBmb3JtIGNvbnRyb2xzLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlOjpwZXJmb3JtSW1tZWRpYXRlQWN0aW9uSGl0VGVzdEF0TG9jYXRpb24pOgorCiAyMDE1 LTA5LTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBBU1NFUlRJT04gRkFJTEVEOiAhbV9pblVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRl IGluIERyYXdpbmdBcmVhSW1wbDo6ZGlzcGxheSgpIGFmdGVyIERyYXdpbmdBcmVhSW1wbDo6Zm9y Y2VSZXBhaW50KCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMv V2ViUGFnZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0JKHJldmlzaW9uIDE5MDIxMykKKysrIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkod29ya2luZyBjb3B5KQpA QCAtMTE0MCw3ICsxMTQwLDcgQEAgdm9pZCBXZWJQYWdlOjpwZXJmb3JtSW1tZWRpYXRlQWN0aW9u SGl0VAogICAgIH0KIAogICAgIC8vIEZJWE1FOiBBdm9pZCBzY2FubmluZyBpZiB3ZSB3aWxsIGp1 c3QgdGhyb3cgYXdheSB0aGUgcmVzdWx0IChlLmcuIHdlJ3JlIG92ZXIgYSBsaW5rKS4KLSAgICBp ZiAoIXBhZ2VPdmVybGF5RGlkT3ZlcnJpZGVEYXRhRGV0ZWN0b3JzICYmIGhpdFRlc3RSZXN1bHQu aW5uZXJOb2RlKCkgJiYgaGl0VGVzdFJlc3VsdC5pbm5lck5vZGUoKS0+aXNUZXh0Tm9kZSgpKSB7 CisgICAgaWYgKCFwYWdlT3ZlcmxheURpZE92ZXJyaWRlRGF0YURldGVjdG9ycyAmJiBoaXRUZXN0 UmVzdWx0LmlubmVyTm9kZSgpICYmIChoaXRUZXN0UmVzdWx0LmlubmVyTm9kZSgpLT5pc1RleHRO b2RlKCkgfHwgaGl0VGVzdFJlc3VsdC5pc092ZXJUZXh0SW5zaWRlRm9ybUNvbnRyb2xFbGVtZW50 KCkpKSB7CiAgICAgICAgIEZsb2F0UmVjdCBkZXRlY3RlZERhdGFCb3VuZGluZ0JveDsKICAgICAg ICAgUmVmUHRyPFJhbmdlPiBkZXRlY3RlZERhdGFSYW5nZTsKICAgICAgICAgaW1tZWRpYXRlQWN0 aW9uUmVzdWx0LmRldGVjdGVkRGF0YUFjdGlvbkNvbnRleHQgPSBEYXRhRGV0ZWN0aW9uOjpkZXRl Y3RJdGVtQXJvdW5kSGl0VGVzdFJlc3VsdChoaXRUZXN0UmVzdWx0LCBkZXRlY3RlZERhdGFCb3Vu ZGluZ0JveCwgZGV0ZWN0ZWREYXRhUmFuZ2UpOwo=