149543 2015-09-24 15:06:11 -0700 Find hole drawn at subframe's 0x0 when a subframe find match is not rendered 2015-09-25 09:15:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin mitz simon.fraser oldest_to_newest 1128595 0 thorton 2015-09-24 15:06:11 -0700 Find hole drawn at subframe's 0x0 when a subframe find match is not rendered 1128596 1 261898 thorton 2015-09-24 15:06:41 -0700 Created attachment 261898 Patch 1128604 2 thorton 2015-09-24 16:04:51 -0700 http://trac.webkit.org/changeset/190228 1128708 3 261898 darin 2015-09-25 09:15:24 -0700 Comment on attachment 261898 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261898&action=review > Source/WebKit2/WebProcess/WebPage/FindController.cpp:419 > for (Vector<IntRect>::iterator it = frameRects.begin(), end = frameRects.end(); it != end; ++it) { > it->intersect(visibleRect); > - it->move(frameOffset.x(), frameOffset.y()); > + > + if (it->isEmpty()) > + continue; > + > + it->moveBy(frameOffset); > rects.append(*it); > } Should use a modern for loop. 261898 2015-09-24 15:06:41 -0700 2015-09-24 16:01:38 -0700 Patch bug-149543-20150924150621.patch text/plain 1619 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmZmNDQzNTBjYWZkODcy MmJmZDE4M2RkYjQyZWE3YzVhYzNiMGQ4MC4uODRjOThkNzFkNjUxYzFkZTg2OTM2NWQ2YmI4OGMy N2EyNzhkZDc0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTI0ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEZpbmQgaG9sZSBk cmF3biBhdCBzdWJmcmFtZSdzIDB4MCB3aGVuIGEgc3ViZnJhbWUgZmluZCBtYXRjaCBpcyBub3Qg cmVuZGVyZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE0OTU0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6RmluZENvbnRyb2xsZXI6OnJlY3RzRm9yVGV4dE1hdGNoZXMpOgorICAgICAgICBEb24ndCBh ZGQgZW1wdHkgcmVjdHMgdG8gdGhlIGxpc3QuIExhdGVyIGNvZGUgd2lsbCBqdXN0IGluZmxhdGUg dGhlbQorICAgICAgICBhbmQgZW5kIHVwIGRyYXdpbmcgYSBub25zZW5zaWNhbCBmaW5kIGhvbGUu CisKIDIwMTUtMDktMjIgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgog CiAgICAgICAgIEFkZCBhIGZpbGUgb2YgcG9pbnRlci1sb2NrIHRvIGNtYWtlIHBvcnRzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIu Y3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0ZpbmRDb250cm9sbGVyLmNw cAppbmRleCBhNzE4ZmRmODdlOTg5NTllYjY0NmY1NzQyZTBmZGYxOGY4OGVlMDAzLi4yNWM3NTU2 ZTA4YzVjZDhlODMwN2FhZmI4MWMyOWIyMTJmMzBhN2I4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRmluZENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9GaW5kQ29udHJvbGxlci5jcHAKQEAgLTQxMCw3ICs0 MTAsMTEgQEAgVmVjdG9yPEludFJlY3Q+IEZpbmRDb250cm9sbGVyOjpyZWN0c0ZvclRleHRNYXRj aGVzKCkKIAogICAgICAgICBmb3IgKFZlY3RvcjxJbnRSZWN0Pjo6aXRlcmF0b3IgaXQgPSBmcmFt ZVJlY3RzLmJlZ2luKCksIGVuZCA9IGZyYW1lUmVjdHMuZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkg ewogICAgICAgICAgICAgaXQtPmludGVyc2VjdCh2aXNpYmxlUmVjdCk7Ci0gICAgICAgICAgICBp dC0+bW92ZShmcmFtZU9mZnNldC54KCksIGZyYW1lT2Zmc2V0LnkoKSk7CisKKyAgICAgICAgICAg IGlmIChpdC0+aXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAg ICAgICBpdC0+bW92ZUJ5KGZyYW1lT2Zmc2V0KTsKICAgICAgICAgICAgIHJlY3RzLmFwcGVuZCgq aXQpOwogICAgICAgICB9CiAgICAgfQo=