149540 2015-09-24 13:50:28 -0700 FTLOSRExitCompiler incorrectly excludes FPR registers in callee saves loop 2015-09-25 16:53:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam msaboff benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1128578 0 saam 2015-09-24 13:50:28 -0700 The first line in the loop "continue"s if "reg.isGPR()" is false. Later in the loop, we check "reg.isGPR()" and an else clause if it's false. This else clause is dead code. We need to decide if we don't need the else clause or if the check at the top of the loop is faulty. 1128821 1 261955 msaboff 2015-09-25 16:49:44 -0700 Created attachment 261955 Patch 1128822 2 261955 saam 2015-09-25 16:50:43 -0700 Comment on attachment 261955 Patch r=me 1128823 3 msaboff 2015-09-25 16:53:00 -0700 Committed r190258: <http://trac.webkit.org/changeset/190258> 261955 2015-09-25 16:49:44 -0700 2015-09-25 16:50:43 -0700 Patch 149540.patch text/plain 1473 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkwMjU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE1LTA5LTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEZUTE9TUkV4aXRDb21waWxlciBpbmNvcnJlY3RseSBleGNsdWRlcyBGUFIgcmVnaXN0ZXJz IGluIGNhbGxlZSBzYXZlcyBsb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDk1NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBFbGltaW5hdGVkIHRoZSBpbmNvcnJlY3QgY2hlY2sgdGhhdCBjYWxsZWUg c2F2ZXMgcmVnaXN0ZXJzIGFyZSBvbmx5IEdQUnMuCisKKyAgICAgICAgKiBmdGwvRlRMT1NSRXhp dENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpjb21waWxlU3R1Yik6CisKIDIwMTUt MDktMjUgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBbV2luXSBTd2l0Y2ggdG8gQ01ha2UKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9m dGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTE9TUkV4aXRDb21waWxlci5jcHAJKHJldmlzaW9uIDE5MDI1NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDM1LDcgKzQzNSw3IEBAIHN0YXRpYyB2b2lkIGNvbXBpbGVTdHViKAogICAgIFJl Z2lzdGVyQXRPZmZzZXRMaXN0KiBiYXNlbGluZUNhbGxlZVNhdmVzID0gYmFzZWxpbmVDb2RlQmxv Y2stPmNhbGxlZVNhdmVSZWdpc3RlcnMoKTsKIAogICAgIGZvciAoUmVnIHJlZyA9IFJlZzo6Zmly c3QoKTsgcmVnIDw9IFJlZzo6bGFzdCgpOyByZWcgPSByZWcubmV4dCgpKSB7Ci0gICAgICAgIGlm ICghYWxsRlRMQ2FsbGVlU2F2ZXMuZ2V0KHJlZykgfHwgIXJlZy5pc0dQUigpKQorICAgICAgICBp ZiAoIWFsbEZUTENhbGxlZVNhdmVzLmdldChyZWcpKQogICAgICAgICAgICAgY29udGludWU7CiAg ICAgICAgIHVuc2lnbmVkIHVud2luZEluZGV4ID0gY29kZUJsb2NrLT5jYWxsZWVTYXZlUmVnaXN0 ZXJzKCktPmluZGV4T2YocmVnKTsKICAgICAgICAgUmVnaXN0ZXJBdE9mZnNldCogYmFzZWxpbmVS ZWdpc3Rlck9mZnNldCA9IGJhc2VsaW5lQ2FsbGVlU2F2ZXMtPmZpbmQocmVnKTsK