149539 2015-09-24 13:27:03 -0700 Support building for arbitrary architectures 2015-09-24 14:39:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 dbates dbates ap ddkilzer dean_johnson lforschler oldest_to_newest 1128573 0 dbates 2015-09-24 13:27:03 -0700 Towards setting up OpenSource iOS device or 32-bit simulator builders we need to teach buildbot to pass the architectures associated with a builder to build-webkit. 1128574 1 261890 dbates 2015-09-24 13:29:31 -0700 Created attachment 261890 Patch 1128575 2 261891 dbates 2015-09-24 13:37:49 -0700 Created attachment 261891 Patch Updated patch to only pass ARCHS and ONLY_ACTIVE_ARCH to build-webkit when the property architecture is a non-empty string 1128584 3 261891 ap 2015-09-24 14:20:40 -0700 Comment on attachment 261891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261891&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213 > + self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO']) Will this work for multiple architectures? 1128587 4 dbates 2015-09-24 14:28:25 -0700 (In reply to comment #3) > Comment on attachment 261891 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261891&action=review > > > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:213 > > + self.setCommand(self.command + ['ARCHS=' + architecture, 'ONLY_ACTIVE_ARCH=NO']) > > Will this work for multiple architectures? It should. According to <http://docs.buildbot.net/current/manual/cfg-buildsteps.html#buildbot.steps.source.buildbot.steps.shell.ShellCommand> when argument command of a ShellCommand is a list of strings then it is "used directly as an argv array". 1128588 5 dbates 2015-09-24 14:39:58 -0700 Committed r190219: <http://trac.webkit.org/changeset/190219> 261890 2015-09-24 13:29:31 -0700 2015-09-24 13:37:46 -0700 Patch bug-149539-20150924132912.patch text/plain 1927 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMjE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODBiMjcyOGRmZGRiNTJjMWE1YzBmNzE2ZjY5NzM4MThh NTYyNGJhOC4uNWJiMTFjMWJkNjZmYTRmZDk4M2QxMTZmMTc3ZDY5M2I5YzA5ZTQ2YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE1LTA5LTI0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAg ICAgICBTdXBwb3J0IGJ1aWxkaW5nIGZvciBhcmJpdHJhcnkgYXJjaGl0ZWN0dXJlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTM5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVhY2ggYnVpbGRib3Qg dG8gcGFzcyB0aGUgYXJjaGl0ZWN0dXJlcyBhc3NvY2lhdGVkIHdpdGggdGhlIGJ1aWxkZXIgdG8g YnVpbGQtd2Via2l0CisgICAgICAgIHdoZW4gYnVpbGRpbmcgb24gT1MgWCBhbmQgaU9TLiBBcyBh IHNpZGUgZWZmZWN0IG9mIHRoaXMgY2hhbmdlIHdlIG5vdyBzdXBwb3J0IGJ1aWxkaW5nCisgICAg ICAgIHVuaXZlcnNhbCBiaW5hcmllcyB3aGVuIG11bHRpcGxlcyBhcmNoaXRlY3R1cmVzIGFyZSBz cGVjaWZpZWQuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoQ29tcGlsZVdlYktpdC5zdGFydCk6CisKKzIw MTUtMDktMjQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCiAgICAgICAgIEZp eCB0aGUgYnVpbGQgYWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE5MDIx Mj4KICAgICAgICAgKGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE5MDIxMikKIApk aWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcKaW5kZXggMzljNDU2MzIwMTMxNTBkNDA2YWZlYjBhN2Q4MTc0ZmUx NjMyNjFkMS4uNTZjZTJiYjRkYmY5MTZkZDk4MWM5YTE5ODc2NGVhNWRmMzY4MGI4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9tYXN0ZXIuY2ZnCkBAIC0yMDksOCArMjA5LDggQEAgY2xhc3MgQ29tcGlsZVdlYktpdChz aGVsbC5Db21waWxlKToKICAgICAgICAgcGxhdGZvcm0gPSBzZWxmLmdldFByb3BlcnR5KCdwbGF0 Zm9ybScpCiAgICAgICAgIGJ1aWxkT25seSA9IHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkT25seScp CiAgICAgICAgIGFyY2hpdGVjdHVyZSA9IHNlbGYuZ2V0UHJvcGVydHkoJ2FyY2hpdGVjdHVyZScp Ci0gICAgICAgIGlmIHBsYXRmb3JtID09ICdtYWMnIGFuZCBhcmNoaXRlY3R1cmUgPT0gJ2kzODYn OgotICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsnLS0zMi1iaXQn XSkKKyAgICAgICAgaWYgcGxhdGZvcm0gaW4gKCdtYWMnLCAnaW9zJyk6CisgICAgICAgICAgICBz ZWxmLnNldENvbW1hbmQoc2VsZi5jb21tYW5kICsgWydBUkNIUz0nICsgYXJjaGl0ZWN0dXJlLCAn T05MWV9BQ1RJVkVfQVJDSD1OTyddKQogICAgICAgICBpZiBwbGF0Zm9ybSA9PSAnbWFjJyBhbmQg YnVpbGRPbmx5OgogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsn REVCVUdfSU5GT1JNQVRJT05fRk9STUFUPWR3YXJmLXdpdGgtZHN5bSddKQogCg== 261891 2015-09-24 13:37:49 -0700 2015-09-24 14:20:40 -0700 Patch bug-149539-20150924133729.patch text/plain 1944 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMjE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODBiMjcyOGRmZGRiNTJjMWE1YzBmNzE2ZjY5NzM4MThh NTYyNGJhOC4uNWJiMTFjMWJkNjZmYTRmZDk4M2QxMTZmMTc3ZDY5M2I5YzA5ZTQ2YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE1LTA5LTI0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAg ICAgICBTdXBwb3J0IGJ1aWxkaW5nIGZvciBhcmJpdHJhcnkgYXJjaGl0ZWN0dXJlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTM5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVhY2ggYnVpbGRib3Qg dG8gcGFzcyB0aGUgYXJjaGl0ZWN0dXJlcyBhc3NvY2lhdGVkIHdpdGggdGhlIGJ1aWxkZXIgdG8g YnVpbGQtd2Via2l0CisgICAgICAgIHdoZW4gYnVpbGRpbmcgb24gT1MgWCBhbmQgaU9TLiBBcyBh IHNpZGUgZWZmZWN0IG9mIHRoaXMgY2hhbmdlIHdlIG5vdyBzdXBwb3J0IGJ1aWxkaW5nCisgICAg ICAgIHVuaXZlcnNhbCBiaW5hcmllcyB3aGVuIG11bHRpcGxlcyBhcmNoaXRlY3R1cmVzIGFyZSBz cGVjaWZpZWQuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoQ29tcGlsZVdlYktpdC5zdGFydCk6CisKKzIw MTUtMDktMjQgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCiAgICAgICAgIEZp eCB0aGUgYnVpbGQgYWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE5MDIx Mj4KICAgICAgICAgKGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE5MDIxMikKIApk aWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvbWFzdGVyLmNmZyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL21hc3Rlci5jZmcKaW5kZXggMzljNDU2MzIwMTMxNTBkNDA2YWZlYjBhN2Q4MTc0ZmUx NjMyNjFkMS4uZmI3NzI4NzY4YmMwMzE4ZGY5NzcxZDgyOTQyZWFkZTM1ODBkODMwNyAxMDA2NDQK LS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9tYXN0ZXIuY2ZnCkBAIC0yMDksOCArMjA5LDggQEAgY2xhc3MgQ29tcGlsZVdlYktpdChz aGVsbC5Db21waWxlKToKICAgICAgICAgcGxhdGZvcm0gPSBzZWxmLmdldFByb3BlcnR5KCdwbGF0 Zm9ybScpCiAgICAgICAgIGJ1aWxkT25seSA9IHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkT25seScp CiAgICAgICAgIGFyY2hpdGVjdHVyZSA9IHNlbGYuZ2V0UHJvcGVydHkoJ2FyY2hpdGVjdHVyZScp Ci0gICAgICAgIGlmIHBsYXRmb3JtID09ICdtYWMnIGFuZCBhcmNoaXRlY3R1cmUgPT0gJ2kzODYn OgotICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsnLS0zMi1iaXQn XSkKKyAgICAgICAgaWYgcGxhdGZvcm0gaW4gKCdtYWMnLCAnaW9zJykgYW5kIGFyY2hpdGVjdHVy ZToKKyAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJ0FSQ0hTPScg KyBhcmNoaXRlY3R1cmUsICdPTkxZX0FDVElWRV9BUkNIPU5PJ10pCiAgICAgICAgIGlmIHBsYXRm b3JtID09ICdtYWMnIGFuZCBidWlsZE9ubHk6CiAgICAgICAgICAgICBzZWxmLnNldENvbW1hbmQo c2VsZi5jb21tYW5kICsgWydERUJVR19JTkZPUk1BVElPTl9GT1JNQVQ9ZHdhcmYtd2l0aC1kc3lt J10pCiAK