149538 2015-09-24 13:13:44 -0700 Simplify Stopwatch::elapsedTime 2015-09-25 10:52:12 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg benjamin cmarcelo commit-queue oldest_to_newest 1128567 0 joepeck 2015-09-24 13:13:44 -0700 * SUMMARY Simplify Stopwatch::elapsedTime. In the case where the stopwatch is active, it calls monotonicallyIncreasingTime twice and updates both its member variables (some multiple times). It could be made simpler. 1128570 1 261888 joepeck 2015-09-24 13:14:44 -0700 Created attachment 261888 [PATCH] Proposed Fix 1128727 2 261888 commit-queue 2015-09-25 10:52:07 -0700 Comment on attachment 261888 [PATCH] Proposed Fix Clearing flags on attachment: 261888 Committed r190247: <http://trac.webkit.org/changeset/190247> 1128728 3 commit-queue 2015-09-25 10:52:12 -0700 All reviewed patches have been landed. Closing bug. 261888 2015-09-24 13:14:44 -0700 2015-09-25 10:52:07 -0700 [PATCH] Proposed Fix simplify-stopwatch.patch text/plain 1214 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZmVmOWY5Yy4uMWIyNDFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNS0wOS0yNCAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFNpbXBsaWZ5 IFN0b3B3YXRjaDo6ZWxhcHNlZFRpbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0OTUzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL1N0b3B3YXRjaC5oOgorICAgICAgICAoV1RGOjpTdG9wd2F0 Y2g6OmVsYXBzZWRUaW1lKToKKyAgICAgICAgU2ltcGxpZnkgYnkgbm90IHN0YXJ0aW5nL3N0b3Bw aW5nIGJ1dCBqdXN0IGNvbXB1dGluZyB3aXRob3V0IHVwZGF0aW5nIG1lbWJlcnMuCisKIDIwMTUt MDktMjIgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUg UXVpY2tMb29rIG9uIHR2T1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0b3B3YXRjaC5o IGIvU291cmNlL1dURi93dGYvU3RvcHdhdGNoLmgKaW5kZXggZGY1MWM3NS4uNWZiMjE1ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvU3RvcHdhdGNoLmgKKysrIGIvU291cmNlL1dURi93dGYv U3RvcHdhdGNoLmgKQEAgLTc1LDE1ICs3NSwxMCBAQCBpbmxpbmUgdm9pZCBTdG9wd2F0Y2g6OnN0 b3AoKQogCiBpbmxpbmUgZG91YmxlIFN0b3B3YXRjaDo6ZWxhcHNlZFRpbWUoKQogewotICAgIGJv b2wgc2hvdWxkU3VzcGVuZCA9ICFzdGQ6OmlzbmFuKG1fbGFzdFN0YXJ0VGltZSk7Ci0gICAgaWYg KHNob3VsZFN1c3BlbmQpCi0gICAgICAgIHN0b3AoKTsKKyAgICBpZiAoIWlzQWN0aXZlKCkpCisg ICAgICAgIHJldHVybiBtX2VsYXBzZWRUaW1lOwogCi0gICAgZG91YmxlIGVsYXBzZWRUaW1lID0g bV9lbGFwc2VkVGltZTsKLQotICAgIGlmIChzaG91bGRTdXNwZW5kKQotICAgICAgICBzdGFydCgp OwotICAgIHJldHVybiBlbGFwc2VkVGltZTsKKyAgICByZXR1cm4gbV9lbGFwc2VkVGltZSArICht b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIG1fbGFzdFN0YXJ0VGltZSk7CiB9CiAKIH0g Ly8gbmFtZXNwYWNlIFdURgo=