149537 2015-09-24 13:10:24 -0700 Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling 2015-09-28 19:20:13 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1128565 0 joepeck 2015-09-24 13:10:24 -0700 * SUMMARY JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling. JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend - does nothing, should at least call "super" InspectorRuntimeAgent::willDestroyFrontendAndBackend 1128566 1 261887 joepeck 2015-09-24 13:11:35 -0700 Created attachment 261887 [PATCH] Proposed Fix 1128720 2 261887 commit-queue 2015-09-25 10:06:25 -0700 Comment on attachment 261887 [PATCH] Proposed Fix Rejecting attachment 261887 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 261887, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: FAILED -- saving rejects to file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj.rej patching file Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.h patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.cpp patching file Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/211203 1129132 3 262036 joepeck 2015-09-28 18:01:50 -0700 Created attachment 262036 [PATCH] For Landing 1129137 4 262036 commit-queue 2015-09-28 18:55:55 -0700 Comment on attachment 262036 [PATCH] For Landing Clearing flags on attachment: 262036 Committed r190301: <http://trac.webkit.org/changeset/190301> 261887 2015-09-24 13:11:35 -0700 2015-09-25 10:06:25 -0700 [PATCH] Proposed Fix cleanup.patch text/plain 3993 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDVjNjExMzAuLjgzMjFjODYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSlNHbG9i YWxSdW50aW1lQWdlbnQgdW5pbnRlbnRpb25hbGx5IG92ZXJyaWRlcyBJbnNwZWN0b3JSdW50aW1l QWdlbnQgZGVzdHJ1Y3Rpb24gaGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0OTUzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRp bWVBZ2VudC5oOgorICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmplY3RSdW50 aW1lQWdlbnQuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdFJ1bnRpbWVB Z2VudDo6d2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tlbmQpOiBEZWxldGVkLgorICAgICAgICBE byBub3Qgb3ZlcnJpZGUgbWV0aG9kLCBzdXBlciBjbGFzcyBpbXBsZW1lbnRhdGlvbiBpcyBzdWZm aWNpZW50LgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4 cHJvajoKKyAgICAgICAgRml4IGZpbGUgb3JkZXJpbmcuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv YWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaDoKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBt ZW1iZXIgdmFyaWFibGUuCisKIDIwMTUtMDktMjMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5pbXBsZW1lbnRlZCBtZXRob2QgSGVhcDo6 c2hvd1N0YXRpc3RpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggMTZhNzE1Ni4u ZGIyM2Q5ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTU3NzAsNyArNTc3MCw2 IEBACiAJCUE1QkExNURGMTgyMzQwOTIwMEE4MkU2OSAvKiBpbnNwZWN0b3IgKi8gPSB7CiAJCQlp c2EgPSBQQlhHcm91cDsKIAkJCWNoaWxkcmVuID0gKAotCQkJCTk5RjFBNzAwMUI5OEZCRUMwMDQ2 M0IyNiAvKiBJbnNwZWN0b3JGcm9udGVuZFJvdXRlci5oICovLAogCQkJCUE1MTNFNUNDMTg1RkI5 OTIwMDdFOTVBRCAvKiBhZ2VudHMgKi8sCiAJCQkJQTVFQTcwRTMxOUY1QjBFMjAwOThGNUVDIC8q IGF1Z21lbnRhYmxlICovLAogCQkJCUE1MzI0MzhEMTg1Njk2Q0EwMDJFRDY5MiAvKiBwcm90b2Nv bCAqLywKQEAgLTU4MDMsNiArNTgwMiw3IEBACiAJCQkJQTVEMEExQkExODYyMzAxQjAwQzdCNDk2 IC8qIEluc3BlY3RvckVudmlyb25tZW50LmggKi8sCiAJCQkJQTU5NDU1OTQxODI0NzlFQjAwQ0Mz ODQzIC8qIEluc3BlY3RvckZyb250ZW5kQ2hhbm5lbC5oICovLAogCQkJCTk5RjFBNkZDMUI4RTZE OTQwMDQ2M0IyNiAvKiBJbnNwZWN0b3JGcm9udGVuZFJvdXRlci5jcHAgKi8sCisJCQkJOTlGMUE3 MDAxQjk4RkJFQzAwNDYzQjI2IC8qIEluc3BlY3RvckZyb250ZW5kUm91dGVyLmggKi8sCiAJCQkJ QTU1RDkzQUIxODUxNEY3OTAwNDAwREVEIC8qIEluc3BlY3RvclByb3RvY29sVHlwZXMuaCAqLywK IAkJCQlBNTkzQ0Y4MDE4NDAzNzcxMDBCRkNFMjcgLyogSW5zcGVjdG9yVmFsdWVzLmNwcCAqLywK IAkJCQlBNTkzQ0Y4MTE4NDAzNzcxMDBCRkNFMjcgLyogSW5zcGVjdG9yVmFsdWVzLmggKi8sCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0 b3JEZWJ1Z2dlckFnZW50LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50 cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmgKaW5kZXggN2FkZmViYi4uNWRmMDg0MyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVi dWdnZXJBZ2VudC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRz L0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaApAQCAtMTczLDcgKzE3Myw2IEBAIHByaXZhdGU6CiAg ICAgYm9vbCBtX2phdmFTY3JpcHRQYXVzZVNjaGVkdWxlZCB7IGZhbHNlIH07CiAgICAgYm9vbCBt X2hhc0V4Y2VwdGlvblZhbHVlIHsgZmFsc2UgfTsKICAgICBib29sIG1fZGlkUGF1c2VTdG9wd2F0 Y2ggeyBmYWxzZSB9OwotICAgIFJlZlB0cjxXVEY6OlN0b3B3YXRjaD4gbV9zdG9wd2F0Y2g7CiB9 OwogCiB9IC8vIG5hbWVzcGFjZSBJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0UnVudGltZUFnZW50LmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0UnVu dGltZUFnZW50LmNwcAppbmRleCBlYWMzZDViLi4yM2QzMWUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2Vu dC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNHbG9i YWxPYmplY3RSdW50aW1lQWdlbnQuY3BwCkBAIC00NiwxMCArNDYsNiBAQCB2b2lkIEpTR2xvYmFs T2JqZWN0UnVudGltZUFnZW50OjpkaWRDcmVhdGVGcm9udGVuZEFuZEJhY2tlbmQoRnJvbnRlbmRS b3V0ZXIqLCBCYQogewogfQogCi12b2lkIEpTR2xvYmFsT2JqZWN0UnVudGltZUFnZW50Ojp3aWxs RGVzdHJveUZyb250ZW5kQW5kQmFja2VuZChEaXNjb25uZWN0UmVhc29uKQotewotfQotCiBWTSYg SlNHbG9iYWxPYmplY3RSdW50aW1lQWdlbnQ6Omdsb2JhbFZNKCkKIHsKICAgICByZXR1cm4gbV9n bG9iYWxPYmplY3Qudm0oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw ZWN0b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0UnVudGltZUFnZW50LmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2VudC5oCmlu ZGV4IDVkYzg3YjIuLmRlYjhlOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0UnVudGltZUFnZW50LmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmplY3RSdW50aW1lQWdl bnQuaApAQCAtMzksNyArMzksNiBAQCBwdWJsaWM6CiAgICAgSlNHbG9iYWxPYmplY3RSdW50aW1l QWdlbnQoSlNBZ2VudENvbnRleHQmKTsKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRDcmVhdGVGcm9u dGVuZEFuZEJhY2tlbmQoRnJvbnRlbmRSb3V0ZXIqLCBCYWNrZW5kRGlzcGF0Y2hlciopIG92ZXJy aWRlOwotICAgIHZpcnR1YWwgdm9pZCB3aWxsRGVzdHJveUZyb250ZW5kQW5kQmFja2VuZChEaXNj b25uZWN0UmVhc29uKSBvdmVycmlkZTsKIAogICAgIHZpcnR1YWwgSlNDOjpWTSYgZ2xvYmFsVk0o KSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIEluamVjdGVkU2NyaXB0IGluamVjdGVkU2NyaXB0Rm9y RXZhbChFcnJvclN0cmluZyYsIGNvbnN0IGludCogZXhlY3V0aW9uQ29udGV4dElkKSBvdmVycmlk ZTsK 262036 2015-09-28 18:01:50 -0700 2015-09-28 18:55:55 -0700 [PATCH] For Landing for-landing-1.patch text/plain 2965 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDMwYTY2ZDcuLmMzZjczZjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSlNHbG9i YWxSdW50aW1lQWdlbnQgdW5pbnRlbnRpb25hbGx5IG92ZXJyaWRlcyBJbnNwZWN0b3JSdW50aW1l QWdlbnQgZGVzdHJ1Y3Rpb24gaGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0OTUzNworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgorCisgICAgICAgICogaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVB Z2VudC5oOgorICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmplY3RSdW50aW1l QWdlbnQuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2Vu dDo6d2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tlbmQpOiBEZWxldGVkLgorICAgICAgICBEbyBu b3Qgb3ZlcnJpZGUgbWV0aG9kLCBzdXBlciBjbGFzcyBpbXBsZW1lbnRhdGlvbiBpcyBzdWZmaWNp ZW50LgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv ajoKKyAgICAgICAgRml4IGZpbGUgb3JkZXJpbmcuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvYWdl bnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuaDoKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBtZW1i ZXIgdmFyaWFibGUuCisKIDIwMTUtMDktMjggIGJhc2lsZV9jbGVtZW50QGFwcGxlLmNvbSAgPGJh c2lsZV9jbGVtZW50QGFwcGxlLmNvbUAyNjhmNDVjYy1jZDA5LTA0MTAtYWIzYy1kNTI2OTFiNGRi ZmM+CiAKICAgICAgICAgW0VTNl0gSW1wbGVtZW50IHRhaWwgY2FsbHMgaW4gdGhlIEZUTApkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9y RGVidWdnZXJBZ2VudC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMv SW5zcGVjdG9yRGVidWdnZXJBZ2VudC5oCmluZGV4IDdhZGZlYmIuLjVkZjA4NDMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVn Z2VyQWdlbnQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9J bnNwZWN0b3JEZWJ1Z2dlckFnZW50LmgKQEAgLTE3Myw3ICsxNzMsNiBAQCBwcml2YXRlOgogICAg IGJvb2wgbV9qYXZhU2NyaXB0UGF1c2VTY2hlZHVsZWQgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9o YXNFeGNlcHRpb25WYWx1ZSB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2RpZFBhdXNlU3RvcHdhdGNo IHsgZmFsc2UgfTsKLSAgICBSZWZQdHI8V1RGOjpTdG9wd2F0Y2g+IG1fc3RvcHdhdGNoOwogfTsK IAogfSAvLyBuYW1lc3BhY2UgSW5zcGVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2VudC5jcHAgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRp bWVBZ2VudC5jcHAKaW5kZXggZWFjM2Q1Yi4uMjNkMzFlMiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmplY3RSdW50aW1lQWdlbnQu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFs T2JqZWN0UnVudGltZUFnZW50LmNwcApAQCAtNDYsMTAgKzQ2LDYgQEAgdm9pZCBKU0dsb2JhbE9i amVjdFJ1bnRpbWVBZ2VudDo6ZGlkQ3JlYXRlRnJvbnRlbmRBbmRCYWNrZW5kKEZyb250ZW5kUm91 dGVyKiwgQmEKIHsKIH0KIAotdm9pZCBKU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2VudDo6d2lsbERl c3Ryb3lGcm9udGVuZEFuZEJhY2tlbmQoRGlzY29ubmVjdFJlYXNvbikKLXsKLX0KLQogVk0mIEpT R2xvYmFsT2JqZWN0UnVudGltZUFnZW50OjpnbG9iYWxWTSgpCiB7CiAgICAgcmV0dXJuIG1fZ2xv YmFsT2JqZWN0LnZtKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2VudC5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSlNHbG9iYWxPYmplY3RSdW50aW1lQWdlbnQuaAppbmRl eCA1ZGM4N2IyLi5kZWI4ZThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL2FnZW50cy9KU0dsb2JhbE9iamVjdFJ1bnRpbWVBZ2VudC5oCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0pTR2xvYmFsT2JqZWN0UnVudGltZUFnZW50 LmgKQEAgLTM5LDcgKzM5LDYgQEAgcHVibGljOgogICAgIEpTR2xvYmFsT2JqZWN0UnVudGltZUFn ZW50KEpTQWdlbnRDb250ZXh0Jik7CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlkQ3JlYXRlRnJvbnRl bmRBbmRCYWNrZW5kKEZyb250ZW5kUm91dGVyKiwgQmFja2VuZERpc3BhdGNoZXIqKSBvdmVycmlk ZTsKLSAgICB2aXJ0dWFsIHZvaWQgd2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tlbmQoRGlzY29u bmVjdFJlYXNvbikgb3ZlcnJpZGU7CiAKICAgICB2aXJ0dWFsIEpTQzo6Vk0mIGdsb2JhbFZNKCkg b3ZlcnJpZGU7CiAgICAgdmlydHVhbCBJbmplY3RlZFNjcmlwdCBpbmplY3RlZFNjcmlwdEZvckV2 YWwoRXJyb3JTdHJpbmcmLCBjb25zdCBpbnQqIGV4ZWN1dGlvbkNvbnRleHRJZCkgb3ZlcnJpZGU7 Cg==