149525 2015-09-24 09:14:15 -0700 Fix the broken !ENABLE(STREAM_API) build 2015-09-29 04:48:16 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy youennf achristensen bfulgham commit-queue ossy youennf oldest_to_newest 1128501 0 ossy 2015-09-24 09:14:15 -0700 build log: ----------- DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp: In function 'JSC::FunctionExecutable* WebCore::countQueuingStrategySizeCodeGenerator(JSC::VM&)': DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp:81:182: error: 'class WebCore::WebCoreJSClientData' has no member named 'countQueuingStrategyBuiltins' DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp:81:276: error: 'class WebCore::WebCoreJSClientData' has no member named 'countQueuingStrategyBuiltins' DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp: In function 'JSC::FunctionExecutable* WebCore::countQueuingStrategyInitializeCountQueuingStrategyCodeGenerator(JSC::VM&)': DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp:81:555: error: 'class WebCore::WebCoreJSClientData' has no member named 'countQueuingStrategyBuiltins' DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp:81:675: error: 'class WebCore::WebCoreJSClientData' has no member named 'countQueuingStrategyBuiltins' DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp: In function 'JSC::FunctionExecutable* WebCore::countQueuingStrategySizeCodeGenerator(JSC::VM&)': DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp:81:346: error: control reaches end of non-void function [-Werror=return-type] DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp: In function 'JSC::FunctionExecutable* WebCore::countQueuingStrategyInitializeCountQueuingStrategyCodeGenerator(JSC::VM&)': DerivedSources/WebCore/CountQueuingStrategyBuiltins.cpp:81:771: error: control reaches end of non-void function [-Werror=return-type] ... DerivedSources/WebCore/ReadableStreamBuiltins.cpp: In function 'JSC::FunctionExecutable* WebCore::readableStreamPipeThroughCodeGenerator(JSC::VM&)': DerivedSources/WebCore/ReadableStreamBuiltins.cpp:64:183: error: 'class WebCore::WebCoreJSClientData' has no member named 'readableStreamBuiltins' DerivedSources/WebCore/ReadableStreamBuiltins.cpp:64:272: error: 'class WebCore::WebCoreJSClientData' has no member named 'readableStreamBuiltins' DerivedSources/WebCore/ReadableStreamBuiltins.cpp:64:337: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors ... In file included from ../../Source/WebCore/bindings/js/JSDOMWindowBase.cpp:38:0: ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:40:43: error: unused parameter 'vm' [-Werror=unused-parameter] ... 1128552 1 261882 youennf 2015-09-24 11:58:56 -0700 Created attachment 261882 Patch 1128555 2 youennf 2015-09-24 12:02:34 -0700 (In reply to comment #1) > Created attachment 261882 [details] > Patch This is a temp fix. The initial plan was to not compile these built-in files when streams api is off. I changed the plan to make it build on windows. I will try to fix that properly later, maybe using a WebCoreJSBuiltinsAllInOne.cpp file. 1128729 3 261882 commit-queue 2015-09-25 10:52:43 -0700 Comment on attachment 261882 Patch Clearing flags on attachment: 261882 Committed r190248: <http://trac.webkit.org/changeset/190248> 1128730 4 commit-queue 2015-09-25 10:52:47 -0700 All reviewed patches have been landed. Closing bug. 1128988 5 ossy 2015-09-28 03:11:03 -0700 Reopen, because the build is still broken: In file included from ../../Source/WebCore/bindings/js/JSDOMWindowBase.cpp:39:0: ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:81:5: error: 'ReadableStreamBuiltinsWrapper' does not name a type ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:82:5: error: 'CountQueuingStrategyBuiltinsWrapper' does not name a type ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:88:5: error: 'ReadableStreamBuiltinsWrapper' does not name a type ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:89:5: error: 'CountQueuingStrategyBuiltinsWrapper' does not name a type ../../Source/WebCore/bindings/js/WebCoreJSClientData.h: In constructor 'WebCore::WebCoreJSClientData::WebCoreJSClientData(JSC::VM&)': ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:44:11: error: class 'WebCore::WebCoreJSClientData' does not have any field named 'm_readableStreamBuiltins' ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:45:11: error: class 'WebCore::WebCoreJSClientData' does not have any field named 'm_countQueuingStrategyBuiltins' 1128992 6 ossy 2015-09-28 03:38:48 -0700 It seems https://trac.webkit.org/changeset/190225 and http://trac.webkit.org/changeset/190248 are in conflict. Reverting r190225 solved the build failure on Linux. What about Windows? 1128993 7 262006 ossy 2015-09-28 04:12:38 -0700 Created attachment 262006 Patch Revert r190225. Brent, could you confirm if it breaks the Windows build or not? 1128998 8 youennf 2015-09-28 04:48:23 -0700 (In reply to comment #5) > Reopen, because the build is still broken: > > In file included from > ../../Source/WebCore/bindings/js/JSDOMWindowBase.cpp:39:0: > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:81:5: error: > 'ReadableStreamBuiltinsWrapper' does not name a type > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:82:5: error: > 'CountQueuingStrategyBuiltinsWrapper' does not name a type > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:88:5: error: > 'ReadableStreamBuiltinsWrapper' does not name a type > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:89:5: error: > 'CountQueuingStrategyBuiltinsWrapper' does not name a type > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h: In constructor > 'WebCore::WebCoreJSClientData::WebCoreJSClientData(JSC::VM&)': > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:44:11: error: class > 'WebCore::WebCoreJSClientData' does not have any field named > 'm_readableStreamBuiltins' > ../../Source/WebCore/bindings/js/WebCoreJSClientData.h:45:11: error: class > 'WebCore::WebCoreJSClientData' does not have any field named > 'm_countQueuingStrategyBuiltins' 1129000 9 youennf 2015-09-28 04:54:43 -0700 (In reply to comment #7) > Created attachment 262006 [details] > Patch > > Revert r190225. Brent, could you confirm if it breaks the Windows build or > not? I am a bit surprised that r190225 is fixing the win build. What were the build errors? FWIW, the build system is expected to always generate the XXBuiltins.h/.cpp and XXBuiltinsWrapper.h. I plan to update the build system so that the XXBuiltins.cpp files are only compiled and linked when feature (STREAMS_API e.g.) is on. I am thinking to use a file called WebCoreJSBuiltins.cpp which would include the XXBuiltins.cpp with the required #if ENABLE(YY). This would also simplify the addition of new js files. 1129001 10 youennf 2015-09-28 05:01:36 -0700 > I plan to update the build system so that the XXBuiltins.cpp files are only > compiled and linked when feature (STREAMS_API e.g.) is on. At that time, we will be able to insert back the #ifdef ENABLE... in WebCoreJSClientData.h 1129199 11 262006 ossy 2015-09-29 03:23:39 -0700 Comment on attachment 262006 Patch Clearing flags on attachment: 262006 Committed r190307: <http://trac.webkit.org/changeset/190307> 1129200 12 ossy 2015-09-29 03:23:48 -0700 All reviewed patches have been landed. Closing bug. 1129204 13 ossy 2015-09-29 03:33:41 -0700 (In reply to comment #10) > > I plan to update the build system so that the XXBuiltins.cpp files are only > > compiled and linked when feature (STREAMS_API e.g.) is on. > > At that time, we will be able to insert back the #ifdef ENABLE... in > WebCoreJSClientData.h If you are going to do this refactor, please cc me to the bug report. 1129223 14 youennf 2015-09-29 04:48:16 -0700 Fil(In reply to comment #13) > (In reply to comment #10) > > > I plan to update the build system so that the XXBuiltins.cpp files are only > > > compiled and linked when feature (STREAMS_API e.g.) is on. > > > > At that time, we will be able to insert back the #ifdef ENABLE... in > > WebCoreJSClientData.h > > If you are going to do this refactor, please cc me to the bug report. Filed bug 149624 for that purpose. 261882 2015-09-24 11:58:56 -0700 2015-09-25 10:52:43 -0700 Patch bug-149525-20150924205837.patch text/plain 2103 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMxMDVlMmU0Y2ZmMzNm ZjFmMDkxMTFjODQ1OWY2YWM4ZmIwNGNlMC4uYmQ3ZmJkZTNiYmE5ODg0YWY4NjE2ODQ5MDA3M2Vk ZjEyMTI4ZjQyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA5LTI0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgRml4IHRo ZSBicm9rZW4gIUVOQUJMRShTVFJFQU1fQVBJKSBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBzb21lICNpZmRlZiBFTkFCTEUoU1RS RUFNU19BUEkpIHRvIG1ha2UgYnVpbGQgd29yayB3aGVuIFNUUkVBTVNfQVBJIGlzIG9mZi4KKyAg ICAgICAgVGhpcyBpcyBhIHRlbXBvcmFyeSBmaXguCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9X ZWJDb3JlSlNDbGllbnREYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpXZWJDb3JlSlNDbGllbnRE YXRhOjpXZWJDb3JlSlNDbGllbnREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OmluaXROb3JtYWxX b3JsZENsaWVudERhdGEpOgorCiAyMDE1LTA5LTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgRHJvcCBYUEFUSF9OQU1FU1BBQ0VfTk9ERSBmcm9tIE5vZGU6Ok5v ZGVUeXBlIGVudW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNv cmVKU0NsaWVudERhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0Ns aWVudERhdGEuaAppbmRleCA0MDk0MjNmYThhNGNiZDBlOWY0ZDEyZTljYTFlYzhkYjRjYjJmNDg4 Li5kMmYyMjUxMmE2YjNkZTNmNjQzMjUyYjQwYmQxOTU2ZTYzZjdmYjljIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNDbGllbnREYXRhLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV2ViQ29yZUpTQ2xpZW50RGF0YS5oCkBAIC0zOCwxMCAr MzgsOCBAQCBjbGFzcyBXZWJDb3JlSlNDbGllbnREYXRhIDogcHVibGljIEpTQzo6Vk06OkNsaWVu dERhdGEgewogCiBwdWJsaWM6CiAgICAgZXhwbGljaXQgV2ViQ29yZUpTQ2xpZW50RGF0YShKU0M6 OlZNJiB2bSkKLSNpZiBFTkFCTEUoU1RSRUFNU19BUEkpCiAgICAgICAgIDogbV9yZWFkYWJsZVN0 cmVhbUJ1aWx0aW5zKCZ2bSkKICAgICAgICAgLCBtX2NvdW50UXVldWluZ1N0cmF0ZWd5QnVpbHRp bnMoJnZtKQotI2VuZGlmCiAgICAgewogICAgIH0KIApAQCAtNzcsMTkgKzc1LDE1IEBAIHB1Ymxp YzoKICAgICAgICAgbV93b3JsZFNldC5yZW1vdmUoJndvcmxkKTsKICAgICB9CiAKLSNpZiBFTkFC TEUoU1RSRUFNU19BUEkpCiAgICAgUmVhZGFibGVTdHJlYW1CdWlsdGluc1dyYXBwZXImIHJlYWRh YmxlU3RyZWFtQnVpbHRpbnMoKSB7IHJldHVybiBtX3JlYWRhYmxlU3RyZWFtQnVpbHRpbnM7IH0K ICAgICBDb3VudFF1ZXVpbmdTdHJhdGVneUJ1aWx0aW5zV3JhcHBlciYgY291bnRRdWV1aW5nU3Ry YXRlZ3lCdWlsdGlucygpIHsgcmV0dXJuIG1fY291bnRRdWV1aW5nU3RyYXRlZ3lCdWlsdGluczsg fQotI2VuZGlmCiAKIHByaXZhdGU6CiAgICAgSGFzaFNldDxET01XcmFwcGVyV29ybGQqPiBtX3dv cmxkU2V0OwogICAgIFJlZlB0cjxET01XcmFwcGVyV29ybGQ+IG1fbm9ybWFsV29ybGQ7CiAKLSNp ZiBFTkFCTEUoU1RSRUFNU19BUEkpCiAgICAgUmVhZGFibGVTdHJlYW1CdWlsdGluc1dyYXBwZXIg bV9yZWFkYWJsZVN0cmVhbUJ1aWx0aW5zOwogICAgIENvdW50UXVldWluZ1N0cmF0ZWd5QnVpbHRp bnNXcmFwcGVyIG1fY291bnRRdWV1aW5nU3RyYXRlZ3lCdWlsdGluczsKLSNlbmRpZgogfTsKIAog aW5saW5lIHZvaWQgaW5pdE5vcm1hbFdvcmxkQ2xpZW50RGF0YShKU0M6OlZNKiB2bSkK 262006 2015-09-28 04:12:38 -0700 2015-09-29 03:23:39 -0700 Patch bug-149525-20150928041215.patch text/plain 1538 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM2OTBmZjRmYjhmYzlj ZTFiMTc3OGE4MGM0ZmJjMTdhZmY3MWQ2NC4uMTY0ODQ2OTZjM2VkYjdkODQ1ZjFiMjA3ODdhOWI4 OTBkNDNkODBiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTI4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBicm9r ZW4gIUVOQUJMRShTVFJFQU1fQVBJKSBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9XZWJDb3JlSlNDbGllbnREYXRhLmg6 IFJldmVydCByMTkwMjI1LgorCisKIDIwMTUtMDktMjggIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fi b3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBBbiBTVkcgaW5oZXJpdHMgdGhlIGNvbnRh aW5lciBzaXplIG9mIHRoZSBwcmV2aW91c2x5IGRyYXduIEhUTUxJbWFnZUVsZW1lbnQgd2hlbiBk cmF3aW5nIGl0IG9uIGEgY2FudmFzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9XZWJDb3JlSlNDbGllbnREYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9X ZWJDb3JlSlNDbGllbnREYXRhLmgKaW5kZXggZTEzZjE0Yzk0NjU1MjkzNTE4OTU0NmNkZDJjNGQx NWM5YWZmYzRkNi4uZDJmMjI1MTJhNmIzZGUzZjY0MzI1MmI0MGJkMTk1NmU2M2Y3ZmI5YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV2ViQ29yZUpTQ2xpZW50RGF0YS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0NsaWVudERhdGEuaApA QCAtMjIsMTYgKzIyLDEzIEBACiAjaWZuZGVmIFdlYkNvcmVKU0NsaWVudERhdGFfaAogI2RlZmlu ZSBXZWJDb3JlSlNDbGllbnREYXRhX2gKIAorI2luY2x1ZGUgIkNvdW50UXVldWluZ1N0cmF0ZWd5 QnVpbHRpbnNXcmFwcGVyLmgiCiAjaW5jbHVkZSAiRE9NV3JhcHBlcldvcmxkLmgiCisjaW5jbHVk ZSAiUmVhZGFibGVTdHJlYW1CdWlsdGluc1dyYXBwZXIuaCIKICNpbmNsdWRlICJXZWJDb3JlVHlw ZWRBcnJheUNvbnRyb2xsZXIuaCIKICNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgogI2luY2x1ZGUg PHd0Zi9SZWZQdHIuaD4KIAotI2lmIEVOQUJMRShTVFJFQU1TX0FQSSkKLSNpbmNsdWRlICJDb3Vu dFF1ZXVpbmdTdHJhdGVneUJ1aWx0aW5zV3JhcHBlci5oIgotI2luY2x1ZGUgIlJlYWRhYmxlU3Ry ZWFtQnVpbHRpbnNXcmFwcGVyLmgiCi0jZW5kaWYKLQogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBj bGFzcyBXZWJDb3JlSlNDbGllbnREYXRhIDogcHVibGljIEpTQzo6Vk06OkNsaWVudERhdGEgewo=