149519 2015-09-24 04:06:24 -0700 validate-committer-lists -b shouldn't need edituser privileges 2015-09-28 02:16:22 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=149520 P2 Normal --- 1 ossy ossy commit-queue glenn ossy oldest_to_newest 1128465 0 ossy 2015-09-24 04:06:24 -0700 Tools/Scripts/validate-committer-lists -b checks if each committer in contributors.json has set valid bugzilla email address. (the first address must be a valid bugzilla address) Now this feature needs edituser privileges, but it is an unnecessary restriction, we can extract the necessary data from bugzilla without edituser privileges. 1128467 1 261865 ossy 2015-09-24 04:37:56 -0700 Created attachment 261865 Patch 1128981 2 261865 ossy 2015-09-28 02:16:15 -0700 Comment on attachment 261865 Patch Clearing flags on attachment: 261865 Committed r190276: <http://trac.webkit.org/changeset/190276> 1128982 3 ossy 2015-09-28 02:16:22 -0700 All reviewed patches have been landed. Closing bug. 261865 2015-09-24 04:37:56 -0700 2015-09-28 02:16:15 -0700 Patch bug-149519-20150924133737.patch text/plain 2945 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMjAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTE4MTMyY2IzMzBiMjJhZTc4NTRhMjNjZWUzZWIxOGZk NTNjYjUzZS4uNDljMjAzODYwZDc0Y2JkMzA5OTlmMjJiY2FlMGQxMmIxOWZhNjQxMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA5LTI0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgdmFsaWRhdGUtY29tbWl0dGVyLWxpc3RzIC1iIHNob3VsZG4ndCBuZWVkIGVkaXR1 c2VyIHByaXZpbGVnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0OTUxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy92YWxpZGF0ZS1jb21taXR0ZXItbGlzdHM6CisgICAgICAgIChDb21t aXR0ZXJMaXN0QnVnemlsbGFDaGVja2VyLl9oYXNfaW52YWxpZF9idWd6aWxsYV9lbWFpbCk6Cisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5 OgorICAgICAgICAoQnVnemlsbGFRdWVyaWVzLmlzX2ludmFsaWRfYnVnemlsbGFfZW1haWwpOgor ICAgICAgICAoQnVnemlsbGFRdWVyaWVzKTogRGVsZXRlZC4KKyAgICAgICAgKEJ1Z3ppbGxhUXVl cmllcy5mZXRjaF9sb2dpbnNfbWF0Y2hpbmdfc3Vic3RyaW5nKTogRGVsZXRlZC4KKwogMjAxNS0w OS0yNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZC4gRml4IEdPYmplY3QgRE9NIEFQSSBicmVha3MgYWZ0ZXIgcjE5MDEyMC4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvdmFsaWRhdGUtY29tbWl0dGVyLWxpc3RzIGIvVG9v bHMvU2NyaXB0cy92YWxpZGF0ZS1jb21taXR0ZXItbGlzdHMKaW5kZXggNjJmZjliYzUyM2JhZDM5 M2ZkZmViNmY5MjM4MWVjNDYyMWVlNTllZi4uZDEzZDA4N2VhNTU1ZDRiNTcxN2JkYTcyMWFkMWE1 NjlkYjU2OWEwNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy92YWxpZGF0ZS1jb21taXR0ZXIt bGlzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy92YWxpZGF0ZS1jb21taXR0ZXItbGlzdHMKQEAgLTI1 Myw3ICsyNTMsNyBAQCBjbGFzcyBDb21taXR0ZXJMaXN0QnVnemlsbGFDaGVja2VyKG9iamVjdCk6 CiAgICAgICAgIHNlbGYuX2J1Z3ppbGxhID0gQnVnemlsbGEoKQogCiAgICAgZGVmIF9oYXNfaW52 YWxpZF9idWd6aWxsYV9lbWFpbChzZWxmLCBjb21taXR0ZXIpOgotICAgICAgICByZXR1cm4gbm90 IHNlbGYuX2J1Z3ppbGxhLnF1ZXJpZXMuZmV0Y2hfbG9naW5zX21hdGNoaW5nX3N1YnN0cmluZyhj b21taXR0ZXIuYnVnemlsbGFfZW1haWwoKSkKKyAgICAgICAgcmV0dXJuIHNlbGYuX2J1Z3ppbGxh LnF1ZXJpZXMuaXNfaW52YWxpZF9idWd6aWxsYV9lbWFpbChjb21taXR0ZXIuYnVnemlsbGFfZW1h aWwoKSkKIAogICAgIGRlZiBwcmludF9jb21taXR0ZXJzX3dpdGhfaW52YWxpZF9idWd6aWxsYV9l bWFpbHMoc2VsZiwgY29tbWl0dGVyX2xpc3QpOgogICAgICAgICBwcmludCAjIFByaW50IGEgbmV3 bGluZSBiZWZvcmUgd2Ugc3RhcnQgaGl0dGluZyBidWd6aWxsYSAoaXQgbG9ncyBhYm91dCBsb2dn aW5nIGluKS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWd6aWxsYS9idWd6aWxsYS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWd6aWxsYS9idWd6aWxsYS5weQppbmRleCA0MDg1MzFlMWQ5MDg2ODk0ZDk4MDVhNjdhYzYzM2Nj ZGYwY2NjYzJmLi4zMTU4NTMzMmQ0YWNkODE1NTg4ZGZhYjIyN2QwZWQxMTI4NDEyMjU4IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemls bGEucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1 Z3ppbGxhLnB5CkBAIC0yODYsMTEgKzI4NiwxMCBAQCBjbGFzcyBCdWd6aWxsYVF1ZXJpZXMob2Jq ZWN0KToKICAgICAgICAgIyBXZSBjb3VsZCBwdWxsIHRoZSBFZGl0VXNlcnNQYXJzZXIgb2ZmIEJ1 Z3ppbGxhIGlmIG5lZWRlZC4KICAgICAgICAgcmV0dXJuIEVkaXRVc2Vyc1BhcnNlcigpLmxvZ2lu X3VzZXJpZF9wYWlyc19mcm9tX2VkaXRfdXNlcl9yZXN1bHRzKHJlc3VsdHNfcGFnZSkKIAotICAg ICMgRklYTUU6IFdlIHNob3VsZCBjb25zaWRlciBhZGRpbmcgYSBCdWd6aWxsYVVzZXIgY2xhc3Mu Ci0gICAgZGVmIGZldGNoX2xvZ2luc19tYXRjaGluZ19zdWJzdHJpbmcoc2VsZiwgc2VhcmNoX3N0 cmluZyk6Ci0gICAgICAgIHBhaXJzID0gc2VsZi5mZXRjaF9sb2dpbl91c2VyaWRfcGFpcnNfbWF0 Y2hpbmdfc3Vic3RyaW5nKHNlYXJjaF9zdHJpbmcpCi0gICAgICAgIHJldHVybiBtYXAobGFtYmRh IHBhaXI6IHBhaXJbMF0sIHBhaXJzKQotCisgICAgZGVmIGlzX2ludmFsaWRfYnVnemlsbGFfZW1h aWwoc2VsZiwgc2VhcmNoX3N0cmluZyk6CisgICAgICAgIHJldmlld19xdWV1ZV91cmwgPSAicmVx dWVzdC5jZ2k/YWN0aW9uPXF1ZXVlJnJlcXVlc3Rlcj0lcyZwcm9kdWN0PSZ0eXBlPXJldmlldyZy ZXF1ZXN0ZWU9JmNvbXBvbmVudD0mZ3JvdXA9cmVxdWVzdGVlIiAlIHVybGxpYi5xdW90ZShzZWFy Y2hfc3RyaW5nKQorICAgICAgICByZXN1bHRzX3BhZ2UgPSBzZWxmLl9sb2FkX3F1ZXJ5KHJldmll d19xdWV1ZV91cmwpCisgICAgICAgIHJldHVybiBib29sKHJlLnNlYXJjaCgiZGlkIG5vdCBtYXRj aCBhbnl0aGluZyIsIHJlc3VsdHNfcGFnZS5yZWFkKCkpKQogCiBjbGFzcyBDb21taXRRdWV1ZUZs YWcob2JqZWN0KToKICAgICBtYXJrX2Zvcl9ub3RoaW5nID0gMAo=