149515 2015-09-23 19:50:23 -0700 Simplify / Optimize Range::selectNode() 2015-09-23 21:23:28 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://dom.spec.whatwg.org/#dom-range-selectnode P2 Normal --- 1 cdumez cdumez commit-queue darin esprehn+autocc kangil.han rniwa oldest_to_newest 1128431 0 cdumez 2015-09-23 19:50:23 -0700 Simplify / Optimize Range::selectNode() 1128432 1 261859 cdumez 2015-09-23 20:11:41 -0700 Created attachment 261859 Patch 1128433 2 261859 commit-queue 2015-09-23 21:23:24 -0700 Comment on attachment 261859 Patch Clearing flags on attachment: 261859 Committed r190195: <http://trac.webkit.org/changeset/190195> 1128434 3 commit-queue 2015-09-23 21:23:28 -0700 All reviewed patches have been landed. Closing bug. 261859 2015-09-23 20:11:41 -0700 2015-09-23 21:23:24 -0700 Patch bug-149515-20150923201123.patch text/plain 3288 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQwMDdmZGNkNzIyMTM0 NTc4NjI2OTJlMmQ4OTE2YTA3Y2E4MjI5Mi4uOWZkOTFhNjUxYTliYWVmYTEzYzM5MWE1NDMxYjAx Nzk4NjMwNGY5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE1LTA5LTIzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgLyBPcHRpbWl6 ZSBSYW5nZTo6c2VsZWN0Tm9kZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDk1MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW1wbGlmeSAvIE9wdGltaXplIFJhbmdlOjpzZWxlY3ROb2RlKCk6Cisg ICAgICAgIDEuIERvIGEgbnVsbC1jaGVjayBvbiByZWZOb2RlLT5wYXJlbnROb2RlKCkgaW5zdGVh ZCBvZiBjaGVja2luZyB0aGUKKyAgICAgICAgICAgbm9kZVR5cGUoKSwgd2hpY2ggaXMgdmlydHVh bC4gQXR0ciwgRG9jdW1lbnRGcmFnbWVudCBhbmQgRG9jdW1lbnQKKyAgICAgICAgICAgTm9kZXMg ZG8gbm90IGhhdmUgYSBwYXJlbnQgYW5kIHRodXMgYXJlIGNvdmVyZWQgYnkgdGhpcyBjaGVjay4K KyAgICAgICAgICAgQWxzbywgc2V0U3RhcnRCZWZvcmUoKSAvIHNldEVuZEFmdGVyKCkgd2VyZSBh bHJlYWR5IGRvaW5nIGEgbnVsbAorICAgICAgICAgICBjaGVjayBvbiB0aGUgcGFyZW50LgorICAg ICAgICAyLiBDYWxsIGxvd2VyLWxldmVsIHNldFN0YXJ0KCkgLyBzZXRFbmQoKSBkaXJlY3RseSwg aW5zdGVhZCBvZiB1c2luZworICAgICAgICAgICBzZXRTdGFydEJlZm9yZSgpIC8gc2V0RW5kQWZ0 ZXIoKSBhcyBpbnRlcm1lZGlhcnkuIEFzIGEgcmVzdWx0OgorICAgICAgICAgICAyLmEuIFdlIGF2 b2lkIGRvaW5nIGEgcmVkdW5kYW50IG51bGwgY2hlY2tzIG9uIHJlZk5vZGUgYW5kIGl0cyBwYXJl bnQKKyAgICAgICAgICAgICAgICAoaW5zaWRlIHRob3NlIGludGVybWVkaWF0ZSBmdW5jdGlvbnMp CisgICAgICAgICAgIDIuYi4gV2Ugb25seSBjYWxsIHJlZk5vZGUtPmNvbXB1dGVOb2RlSW5kZXgo KSBvbmNlIGluc3RlYWQgb2YgdHdpY2UKKyAgICAgICAgICAgICAgICAoaW4gZWFjaCBvZiB0aG9z ZSBpbnRlcm1lZGlhdGUgZnVuY3Rpb25zKS4gY29tcHV0ZU5vZGVJbmRleCgpCisgICAgICAgICAg ICAgICAgaXMgbm90IGEgdHJpdmlhbCBnZXR0ZXIgYXMgaXRzIG5lZWRzIHRvIHRyYXZlcnNlIGFs bCB0aGUKKyAgICAgICAgICAgICAgICBwcmV2aW91cyBzaWJsaW5ncy4KKworICAgICAgICBUaGUg aW1wbGVtZW50YXRpb24gbm93IG1hdGNoZXMgZXhhY3RseSB0aGUgdGV4dCBvZiB0aGUgRE9NIHNw ZWNpZmljYXRpb24KKyAgICAgICAgYXMgd2VsbDoKKyAgICAgICAgaHR0cHM6Ly9kb20uc3BlYy53 aGF0d2cub3JnLyNjb25jZXB0LXJhbmdlLXNlbGVjdAorCisgICAgICAgIE5vIG5ldyBsYXlvdXQg dGVzdHMsIG5vIHdlYi1leHBvc2VkIGJlaGF2aW9yIGludGVuZGVkLgorCisgICAgICAgICogZG9t L1JhbmdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJhbmdlOjpzZWxlY3ROb2RlKToKKwogMjAx NS0wOS0yMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAg ICAgIFtDb2NvYV0gW0ZvbnQgRmVhdHVyZXNdIEltcGxlbWVudCBmb250LXZhcmlhbnQtKgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9SYW5nZS5jcHAKaW5kZXggNzlhYmVmMTgzZTg2MGZjYWZlNDg0NGJmY2QzZjA1Yzc4OWEwMjNl YS4uMDhiNmE2M2M0NjNkY2QyMTUxNWE2Mzk2ZDFhNzFjNWMzZjlmY2I3NyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1JhbmdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUmFu Z2UuY3BwCkBAIC0xMDc1LDMxICsxMDc1LDIwIEBAIHZvaWQgUmFuZ2U6OnNlbGVjdE5vZGUoTm9k ZSogcmVmTm9kZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAK LSAgICAvLyBJTlZBTElEX05PREVfVFlQRV9FUlI6IFJhaXNlZCBpZiByZWZOb2RlIGlzIGEgRG9j dW1lbnQsIERvY3VtZW50RnJhZ21lbnQgb3IgQXR0ciBub2RlLgotICAgIHN3aXRjaCAocmVmTm9k ZS0+bm9kZVR5cGUoKSkgewotICAgICAgICBjYXNlIE5vZGU6OkNEQVRBX1NFQ1RJT05fTk9ERToK LSAgICAgICAgY2FzZSBOb2RlOjpDT01NRU5UX05PREU6Ci0gICAgICAgIGNhc2UgTm9kZTo6RE9D VU1FTlRfVFlQRV9OT0RFOgotICAgICAgICBjYXNlIE5vZGU6OkVMRU1FTlRfTk9ERToKLSAgICAg ICAgY2FzZSBOb2RlOjpQUk9DRVNTSU5HX0lOU1RSVUNUSU9OX05PREU6Ci0gICAgICAgIGNhc2Ug Tm9kZTo6VEVYVF9OT0RFOgotICAgICAgICBjYXNlIE5vZGU6OlhQQVRIX05BTUVTUEFDRV9OT0RF OgotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgTm9kZTo6QVRUUklCVVRFX05PREU6 Ci0gICAgICAgIGNhc2UgTm9kZTo6RE9DVU1FTlRfRlJBR01FTlRfTk9ERToKLSAgICAgICAgY2Fz ZSBOb2RlOjpET0NVTUVOVF9OT0RFOgotICAgICAgICAgICAgZWMgPSBJTlZBTElEX05PREVfVFlQ RV9FUlI7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgaWYgKCFyZWZOb2RlLT5wYXJlbnROb2Rl KCkpIHsKKyAgICAgICAgZWMgPSBJTlZBTElEX05PREVfVFlQRV9FUlI7CisgICAgICAgIHJldHVy bjsKICAgICB9CiAKICAgICBpZiAoJm93bmVyRG9jdW1lbnQoKSAhPSAmcmVmTm9kZS0+ZG9jdW1l bnQoKSkKICAgICAgICAgc2V0RG9jdW1lbnQocmVmTm9kZS0+ZG9jdW1lbnQoKSk7CiAKKyAgICB1 bnNpZ25lZCBpbmRleCA9IHJlZk5vZGUtPmNvbXB1dGVOb2RlSW5kZXgoKTsKICAgICBlYyA9IDA7 Ci0gICAgc2V0U3RhcnRCZWZvcmUocmVmTm9kZSwgZWMpOworICAgIHNldFN0YXJ0KHJlZk5vZGUt PnBhcmVudE5vZGUoKSwgaW5kZXgsIGVjKTsKICAgICBpZiAoZWMpCiAgICAgICAgIHJldHVybjsK LSAgICBzZXRFbmRBZnRlcihyZWZOb2RlLCBlYyk7CisgICAgc2V0RW5kKHJlZk5vZGUtPnBhcmVu dE5vZGUoKSwgaW5kZXggKyAxLCBlYyk7CiB9CiAKIHZvaWQgUmFuZ2U6OnNlbGVjdE5vZGVDb250 ZW50cyhOb2RlKiByZWZOb2RlLCBFeGNlcHRpb25Db2RlJiBlYykK