149513 2015-09-23 17:31:56 -0700 git-add-reviewer should trim trailing spaces/newlines 2015-09-30 13:06:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Enhancement --- 1 anshu dburkart dburkart webkit-bug-importer oldest_to_newest 1128413 0 anshu 2015-09-23 17:31:56 -0700 I typed git add-reviewer HEAD "Reviewer Name then accidentally hit return without closing my end quote. I typed the end quote on the next line, assuming that the script would trim the newline at the end. It didn't. I ended up with my ChangeLog looking like: Reviewed by Reviewer Name . It would be nice if the script could avoid doing this. 1128415 1 dburkart 2015-09-23 17:33:38 -0700 rdar://problem/22809451 1129319 2 262085 dburkart 2015-09-29 11:52:13 -0700 Created attachment 262085 Chomp trailing whitespace from the reviewer argument 1129654 3 dburkart 2015-09-30 13:06:23 -0700 Committed r190366 262085 2015-09-29 11:52:13 -0700 2015-09-29 22:13:43 -0700 Chomp trailing whitespace from the reviewer argument 0001-git-add-reviewer-should-trim-trailing-spaces-newline.patch text/plain 1445 dburkart RnJvbSA1MThkNTQxNjA1NWI4OTMxZmQyMzFmNmI2ZjMwMjAzYjIyM2YxM2JlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5hIEJ1cmthcnQgPGRidXJrYXJ0QGFwcGxlLmNvbT4KRGF0 ZTogVHVlLCAyOSBTZXAgMjAxNSAxMTo1MDowNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGdpdC1h ZGQtcmV2aWV3ZXIgc2hvdWxkIHRyaW0gdHJhaWxpbmcgc3BhY2VzL25ld2xpbmVzCiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTEzCgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogU2NyaXB0cy9naXQtYWRkLXJldmlld2VyOgoobm9uSW50ZXJhY3RpdmUp OgotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIFRv b2xzL1NjcmlwdHMvZ2l0LWFkZC1yZXZpZXdlciB8ICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTEg aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5n ZUxvZwppbmRleCA0M2ZiNDBkLi41MzJhOGU0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMDktMjkgIERhbmEg QnVya2FydCAgPGRidXJrYXJ0QGFwcGxlLmNvbT4KKworICAgICAgICBnaXQtYWRkLXJldmlld2Vy IHNob3VsZCB0cmltIHRyYWlsaW5nIHNwYWNlcy9uZXdsaW5lcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTEzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2dpdC1hZGQtcmV2aWV3ZXI6 CisgICAgICAgIChub25JbnRlcmFjdGl2ZSk6CisKIDIwMTUtMDktMjkgIEJyZW50IEZ1bGdoYW0g IDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCA2NC1iaXQg YnVpbGQgZml4IGFmdGVyIHN3aXRjaCB0byBDTWFrZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvZ2l0LWFkZC1yZXZpZXdlciBiL1Rvb2xzL1NjcmlwdHMvZ2l0LWFkZC1yZXZpZXdlcgppbmRl eCA4ZDhjYTY1Li43YTYyMGRlIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2dpdC1hZGQtcmV2 aWV3ZXIKKysrIGIvVG9vbHMvU2NyaXB0cy9naXQtYWRkLXJldmlld2VyCkBAIC0xNzAsNiArMTcw LDcgQEAgc3ViIG5vbkludGVyYWN0aXZlKCkKICAgICBteSAkaGVhZENvbW1pdCA9IHRvQ29tbWl0 KCRoZWFkKTsKIAogICAgIGlzQW5jZXN0b3IoJGNvbW1pdCwgJGhlYWQpIG9yIGRpZSAiJEFSR1Zb MF0gaXMgbm90IGFuIGFuY2VzdG9yIG9mIEhFQUQuIjsKKyAgICBjaG9tcCgkcmV2aWV3ZXIpOwog CiAgICAgbXkgJWl0ZW0gPSAoCiAgICAgICAgIHJldmlld2VyID0+ICRyZXZpZXdlciwKLS0gCjIu My44IChBcHBsZSBHaXQtNTgpCgo=