149512 2015-09-23 17:15:51 -0700 Remove special case code for the no-parallel-GC case 2015-09-24 13:13:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other All All RESOLVED FIXED P2 Normal --- 149433 1 fpizlo fpizlo barraclough benjamin ggaren mark.lam mhahnenb msaboff nrotem oliver saam sam oldest_to_newest 1128410 0 fpizlo 2015-09-23 17:15:51 -0700 Serial GC is just a special case of parallel GC, where the helper threads never do anything. 1128411 1 261851 fpizlo 2015-09-23 17:20:22 -0700 Created attachment 261851 the patch 1128414 2 261851 mark.lam 2015-09-23 17:32:51 -0700 Comment on attachment 261851 the patch r=me 1128568 3 fpizlo 2015-09-24 13:13:48 -0700 Landed in http://trac.webkit.org/changeset/190217 261851 2015-09-23 17:20:22 -0700 2015-09-23 17:32:51 -0700 the patch blah.patch text/plain 6434 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkwMTkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE1LTA5LTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIHNwZWNpYWwgY2FzZSBjb2RlIGZvciB0aGUgbm8tcGFyYWxsZWwtR0MgY2FzZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTEyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzZXJpYWwg R0MganVzdCBhIHBhcmFsbGVsIEdDIHdoZXJlIHRoZSBoZWxwZXIgdGhyZWFkcyBkb24ndCBkbyBh bnl0aGluZy4gQWxzbyBtYWtlIHRoZQorICAgICAgICBpZGxlIHRocmVhZCBjYWxjdWxhdGlvbiBh IGJpdCBtb3JlIGV4cGxpY2l0LgorCisgICAgICAgIFRoZSBtYWluIG91dGNvbWUgaXMgdGhhdCB3 ZSBubyBsb25nZXIgdXNlIE9wdGlvbnM6Om51bWJlck9mR0NNYXJrZXJzKCkgYXMgbXVjaCwgc28g dGhlIGNvZGUgaXMKKyAgICAgICAgcmVzaWxpZW50IGFnYWluc3QgdGhlIG51bWJlciBvZiBHQyBt YXJrZXJzIGNoYW5naW5nLgorCisgICAgICAgICogaGVhcC9IZWFwLmg6CisgICAgICAgICogaGVh cC9TbG90VmlzaXRvci5jcHA6CisgICAgICAgIChKU0M6OlNsb3RWaXNpdG9yOjpkb25hdGVLbm93 blBhcmFsbGVsKToKKyAgICAgICAgKEpTQzo6U2xvdFZpc2l0b3I6OmRyYWluKToKKyAgICAgICAg KEpTQzo6U2xvdFZpc2l0b3I6OmRyYWluRnJvbVNoYXJlZCk6CisKIDIwMTUtMDktMjMgIFNhYW0g YmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgSlNDIGFsbG93cyBpbnZhbGlk IHZhciBkZWNsYXJhdGlvbnMgd2hlbiB0aGUgZGVjbGFyZWQgbmFtZSBpcyB0aGUgc2FtZSBhcyBh IGxldC9jb25zdCB2YXJpYWJsZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVh cC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAkocmV2 aXNpb24gMTkwMTg5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC00MjgsNiArNDI4LDcgQEAgcHJpdmF0ZToKICAgICBDb25kaXRpb24gbV9t YXJraW5nQ29uZGl0aW9uVmFyaWFibGU7CiAgICAgTWFya1N0YWNrQXJyYXkgbV9zaGFyZWRNYXJr U3RhY2s7CiAgICAgdW5zaWduZWQgbV9udW1iZXJPZkFjdGl2ZVBhcmFsbGVsTWFya2VycyB7IDAg fTsKKyAgICB1bnNpZ25lZCBtX251bWJlck9mV2FpdGluZ1BhcmFsbGVsTWFya2VycyB7IDAgfTsK ICAgICBib29sIG1fcGFyYWxsZWxNYXJrZXJzU2hvdWxkRXhpdCB7IGZhbHNlIH07CiAKICAgICBM b2NrIG1fb3BhcXVlUm9vdHNNdXRleDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L1Nsb3RWaXNpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9TbG90VmlzaXRvci5jcHAJKHJldmlzaW9uIDE5MDE4OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL1Nsb3RWaXNpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ3LDggKzE0Nyw3 IEBAIHZvaWQgU2xvdFZpc2l0b3I6OmRvbmF0ZUtub3duUGFyYWxsZWwoKQogICAgIC8vIE90aGVy d2lzZSwgYXNzdW1lIHRoYXQgYSB0aHJlYWQgd2lsbCBnbyBpZGxlIHNvb24sIGFuZCBkb25hdGUu CiAgICAgbV9zdGFjay5kb25hdGVTb21lQ2VsbHNUbyhtX2hlYXAubV9zaGFyZWRNYXJrU3RhY2sp OwogCi0gICAgaWYgKG1faGVhcC5tX251bWJlck9mQWN0aXZlUGFyYWxsZWxNYXJrZXJzIDwgT3B0 aW9uczo6bnVtYmVyT2ZHQ01hcmtlcnMoKSkKLSAgICAgICAgbV9oZWFwLm1fbWFya2luZ0NvbmRp dGlvblZhcmlhYmxlLm5vdGlmeUFsbCgpOworICAgIG1faGVhcC5tX21hcmtpbmdDb25kaXRpb25W YXJpYWJsZS5ub3RpZnlBbGwoKTsKIH0KIAogdm9pZCBTbG90VmlzaXRvcjo6ZHJhaW4oKQpAQCAt MTU2LDIzICsxNTUsMTQgQEAgdm9pZCBTbG90VmlzaXRvcjo6ZHJhaW4oKQogICAgIFN0YWNrU3Rh dHM6OnByb2JlKCk7CiAgICAgQVNTRVJUKG1faXNJblBhcmFsbGVsTW9kZSk7CiAgICAKLSAgICBp ZiAoT3B0aW9uczo6bnVtYmVyT2ZHQ01hcmtlcnMoKSA+IDEpIHsKLSAgICAgICAgd2hpbGUgKCFt X3N0YWNrLmlzRW1wdHkoKSkgewotICAgICAgICAgICAgbV9zdGFjay5yZWZpbGwoKTsKLSAgICAg ICAgICAgIGZvciAodW5zaWduZWQgY291bnRkb3duID0gT3B0aW9uczo6bWluaW11bU51bWJlck9m U2NhbnNCZXR3ZWVuUmViYWxhbmNlKCk7IG1fc3RhY2suY2FuUmVtb3ZlTGFzdCgpICYmIGNvdW50 ZG93bi0tOykKLSAgICAgICAgICAgICAgICB2aXNpdENoaWxkcmVuKCp0aGlzLCBtX3N0YWNrLnJl bW92ZUxhc3QoKSk7Ci0gICAgICAgICAgICBkb25hdGVLbm93blBhcmFsbGVsKCk7Ci0gICAgICAg IH0KLSAgICAgICAgCi0gICAgICAgIG1lcmdlT3BhcXVlUm9vdHNJZk5lY2Vzc2FyeSgpOwotICAg ICAgICByZXR1cm47Ci0gICAgfQotICAgIAogICAgIHdoaWxlICghbV9zdGFjay5pc0VtcHR5KCkp IHsKICAgICAgICAgbV9zdGFjay5yZWZpbGwoKTsKLSAgICAgICAgd2hpbGUgKG1fc3RhY2suY2Fu UmVtb3ZlTGFzdCgpKQorICAgICAgICBmb3IgKHVuc2lnbmVkIGNvdW50ZG93biA9IE9wdGlvbnM6 Om1pbmltdW1OdW1iZXJPZlNjYW5zQmV0d2VlblJlYmFsYW5jZSgpOyBtX3N0YWNrLmNhblJlbW92 ZUxhc3QoKSAmJiBjb3VudGRvd24tLTspCiAgICAgICAgICAgICB2aXNpdENoaWxkcmVuKCp0aGlz LCBtX3N0YWNrLnJlbW92ZUxhc3QoKSk7CisgICAgICAgIGRvbmF0ZUtub3duUGFyYWxsZWwoKTsK ICAgICB9CisgICAgCisgICAgbWVyZ2VPcGFxdWVSb290c0lmTmVjZXNzYXJ5KCk7CiB9CiAKIHZv aWQgU2xvdFZpc2l0b3I6OmRyYWluRnJvbVNoYXJlZChTaGFyZWREcmFpbk1vZGUgc2hhcmVkRHJh aW5Nb2RlKQpAQCAtMTgyLDE4ICsxNzIsNiBAQCB2b2lkIFNsb3RWaXNpdG9yOjpkcmFpbkZyb21T aGFyZWQoU2hhcmVkCiAgICAgCiAgICAgQVNTRVJUKE9wdGlvbnM6Om51bWJlck9mR0NNYXJrZXJz KCkpOwogICAgIAotICAgIGJvb2wgc2hvdWxkQmVQYXJhbGxlbDsKLQotICAgIHNob3VsZEJlUGFy YWxsZWwgPSBPcHRpb25zOjpudW1iZXJPZkdDTWFya2VycygpID4gMTsKLSAgICAKLSAgICBpZiAo IXNob3VsZEJlUGFyYWxsZWwpIHsKLSAgICAgICAgLy8gVGhpcyBjYWxsIHNob3VsZCBiZSBhIG5v LW9wLgotICAgICAgICBBU1NFUlRfVU5VU0VEKHNoYXJlZERyYWluTW9kZSwgc2hhcmVkRHJhaW5N b2RlID09IE1hc3RlckRyYWluKTsKLSAgICAgICAgQVNTRVJUKG1fc3RhY2suaXNFbXB0eSgpKTsK LSAgICAgICAgQVNTRVJUKG1faGVhcC5tX3NoYXJlZE1hcmtTdGFjay5pc0VtcHR5KCkpOwotICAg ICAgICByZXR1cm47Ci0gICAgfQotICAgIAogICAgIHsKICAgICAgICAgc3RkOjpsb2NrX2d1YXJk PExvY2s+IGxvY2sobV9oZWFwLm1fbWFya2luZ011dGV4KTsKICAgICAgICAgbV9oZWFwLm1fbnVt YmVyT2ZBY3RpdmVQYXJhbGxlbE1hcmtlcnMrKzsKQEAgLTIwMiw2ICsxODAsNyBAQCB2b2lkIFNs b3RWaXNpdG9yOjpkcmFpbkZyb21TaGFyZWQoU2hhcmVkCiAgICAgICAgIHsKICAgICAgICAgICAg IHN0ZDo6dW5pcXVlX2xvY2s8TG9jaz4gbG9jayhtX2hlYXAubV9tYXJraW5nTXV0ZXgpOwogICAg ICAgICAgICAgbV9oZWFwLm1fbnVtYmVyT2ZBY3RpdmVQYXJhbGxlbE1hcmtlcnMtLTsKKyAgICAg ICAgICAgIG1faGVhcC5tX251bWJlck9mV2FpdGluZ1BhcmFsbGVsTWFya2VycysrOwogCiAgICAg ICAgICAgICAvLyBIb3cgd2Ugd2FpdCBkaWZmZXJzIGRlcGVuZGluZyBvbiBkcmFpbiBtb2RlLgog ICAgICAgICAgICAgaWYgKHNoYXJlZERyYWluTW9kZSA9PSBNYXN0ZXJEcmFpbikgewpAQCAtMjA5 LDcgKzE4OCw4IEBAIHZvaWQgU2xvdFZpc2l0b3I6OmRyYWluRnJvbVNoYXJlZChTaGFyZWQKICAg ICAgICAgICAgICAgICAvLyBmb3IgdXMgdG8gZG8uCiAgICAgICAgICAgICAgICAgd2hpbGUgKHRy dWUpIHsKICAgICAgICAgICAgICAgICAgICAgLy8gRGlkIHdlIHJlYWNoIHRlcm1pbmF0aW9uPwot ICAgICAgICAgICAgICAgICAgICBpZiAoIW1faGVhcC5tX251bWJlck9mQWN0aXZlUGFyYWxsZWxN YXJrZXJzICYmIG1faGVhcC5tX3NoYXJlZE1hcmtTdGFjay5pc0VtcHR5KCkpIHsKKyAgICAgICAg ICAgICAgICAgICAgaWYgKCFtX2hlYXAubV9udW1iZXJPZkFjdGl2ZVBhcmFsbGVsTWFya2Vycwor ICAgICAgICAgICAgICAgICAgICAgICAgJiYgbV9oZWFwLm1fc2hhcmVkTWFya1N0YWNrLmlzRW1w dHkoKSkgewogICAgICAgICAgICAgICAgICAgICAgICAgLy8gTGV0IGFueSBzbGVlcGluZyBzbGF2 ZXMga25vdyBpdCdzIHRpbWUgZm9yIHRoZW0gdG8gcmV0dXJuOwogICAgICAgICAgICAgICAgICAg ICAgICAgbV9oZWFwLm1fbWFya2luZ0NvbmRpdGlvblZhcmlhYmxlLm5vdGlmeUFsbCgpOwogICAg ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwpAQCAtMjI2LDE5ICsyMDYsMjYgQEAgdm9pZCBT bG90VmlzaXRvcjo6ZHJhaW5Gcm9tU2hhcmVkKFNoYXJlZAogICAgICAgICAgICAgICAgIEFTU0VS VChzaGFyZWREcmFpbk1vZGUgPT0gU2xhdmVEcmFpbik7CiAgICAgICAgICAgICAgICAgCiAgICAg ICAgICAgICAgICAgLy8gRGlkIHdlIGRldGVjdCB0ZXJtaW5hdGlvbj8gSWYgc28sIGxldCB0aGUg bWFzdGVyIGtub3cuCi0gICAgICAgICAgICAgICAgaWYgKCFtX2hlYXAubV9udW1iZXJPZkFjdGl2 ZVBhcmFsbGVsTWFya2VycyAmJiBtX2hlYXAubV9zaGFyZWRNYXJrU3RhY2suaXNFbXB0eSgpKQor ICAgICAgICAgICAgICAgIGlmICghbV9oZWFwLm1fbnVtYmVyT2ZBY3RpdmVQYXJhbGxlbE1hcmtl cnMKKyAgICAgICAgICAgICAgICAgICAgJiYgbV9oZWFwLm1fc2hhcmVkTWFya1N0YWNrLmlzRW1w dHkoKSkKICAgICAgICAgICAgICAgICAgICAgbV9oZWFwLm1fbWFya2luZ0NvbmRpdGlvblZhcmlh YmxlLm5vdGlmeUFsbCgpOwogCi0gICAgICAgICAgICAgICAgbV9oZWFwLm1fbWFya2luZ0NvbmRp dGlvblZhcmlhYmxlLndhaXQobG9jaywgW3RoaXNdIHsgcmV0dXJuICFtX2hlYXAubV9zaGFyZWRN YXJrU3RhY2suaXNFbXB0eSgpIHx8IG1faGVhcC5tX3BhcmFsbGVsTWFya2Vyc1Nob3VsZEV4aXQ7 IH0pOworICAgICAgICAgICAgICAgIG1faGVhcC5tX21hcmtpbmdDb25kaXRpb25WYXJpYWJsZS53 YWl0KAorICAgICAgICAgICAgICAgICAgICBsb2NrLAorICAgICAgICAgICAgICAgICAgICBbdGhp c10geworICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuICFtX2hlYXAubV9zaGFyZWRNYXJr U3RhY2suaXNFbXB0eSgpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgfHwgbV9oZWFwLm1f cGFyYWxsZWxNYXJrZXJzU2hvdWxkRXhpdDsKKyAgICAgICAgICAgICAgICAgICAgfSk7CiAgICAg ICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgLy8gSXMgdGhlIGN1cnJlbnQgcGhhc2UgZG9u ZT8gSWYgc28sIHJldHVybiBmcm9tIHRoaXMgZnVuY3Rpb24uCiAgICAgICAgICAgICAgICAgaWYg KG1faGVhcC5tX3BhcmFsbGVsTWFya2Vyc1Nob3VsZEV4aXQpCiAgICAgICAgICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgCi0gICAgICAgICAgICBzaXplX3Qg aWRsZVRocmVhZENvdW50ID0gT3B0aW9uczo6bnVtYmVyT2ZHQ01hcmtlcnMoKSAtIG1faGVhcC5t X251bWJlck9mQWN0aXZlUGFyYWxsZWxNYXJrZXJzOwotICAgICAgICAgICAgbV9zdGFjay5zdGVh bFNvbWVDZWxsc0Zyb20obV9oZWFwLm1fc2hhcmVkTWFya1N0YWNrLCBpZGxlVGhyZWFkQ291bnQp OworICAgICAgICAgICAgbV9zdGFjay5zdGVhbFNvbWVDZWxsc0Zyb20oCisgICAgICAgICAgICAg ICAgbV9oZWFwLm1fc2hhcmVkTWFya1N0YWNrLCBtX2hlYXAubV9udW1iZXJPZldhaXRpbmdQYXJh bGxlbE1hcmtlcnMpOwogICAgICAgICAgICAgbV9oZWFwLm1fbnVtYmVyT2ZBY3RpdmVQYXJhbGxl bE1hcmtlcnMrKzsKKyAgICAgICAgICAgIG1faGVhcC5tX251bWJlck9mV2FpdGluZ1BhcmFsbGVs TWFya2Vycy0tOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBkcmFpbigpOwo=