149510 2015-09-23 13:29:27 -0700 accessibility/mac/aria-expanded-notifications.html is flaky 2015-10-01 10:46:26 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=149218 InRadar P2 Normal --- 1 bdakin mmaxfield aboxhall apinheiro ap cfleizach commit-queue dmazzoni jcraig jdiggs mario mmaxfield samuel_white webkit-bug-importer oldest_to_newest 1128375 0 bdakin 2015-09-23 13:29:27 -0700 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Faria-expanded-notifications.html shows that this test has been flaky on the Mavericks and Yosemite bots. 1128376 1 webkit-bug-importer 2015-09-23 13:29:40 -0700 <rdar://problem/22826005> 1128378 2 bdakin 2015-09-23 13:35:29 -0700 Marked it flaky: http://trac.webkit.org/changeset/190183 1128379 3 webkit-bug-importer 2015-09-23 13:36:05 -0700 <rdar://problem/22826112> 1129394 4 mmaxfield 2015-09-29 14:12:31 -0700 Almost certainly caused by http://trac.webkit.org/changeset/189668 1129395 5 mmaxfield 2015-09-29 14:12:57 -0700 Can reproducing after running a few dozen times in a row with the attached test list. 1129396 6 262106 mmaxfield 2015-09-29 14:13:23 -0700 Created attachment 262106 Test List 1129410 7 mmaxfield 2015-09-29 14:33:16 -0700 Attaching the failure diff 1129411 8 262109 mmaxfield 2015-09-29 14:33:43 -0700 Created attachment 262109 Failure diff 1129655 9 mmaxfield 2015-09-30 13:15:47 -0700 (In reply to comment #4) > Almost certainly caused by http://trac.webkit.org/changeset/189668 Verified this. 1129656 10 mmaxfield 2015-09-30 13:21:21 -0700 (In reply to comment #9) > (In reply to comment #4) > > Almost certainly caused by http://trac.webkit.org/changeset/189668 > > Verified this. By "verified," I mean that, when the patch is reverted, I can no longer repro the issue. 1129828 11 mmaxfield 2015-09-30 22:08:57 -0700 Breaking in AccessibilityController::addNotificationListener() seems to make this reproduce 100%. Seems like a race. 1129841 12 mmaxfield 2015-09-30 23:13:41 -0700 The problem is triggered by our resumable parser. if (elapsedTime > m_parserTimeLimit) session.needsYield = true; AXLoadComplete gets called synchronously from DocumentLoader::finishedLoading(). This means that the order of the AXLoadComplete message isn't FIFO: If the parser yielded previously, the AXLoadComplete will be handled after some AX messages had been handled. If the parser hadn't yielded, the AXLoadComplete will be the first message processed (no matter what had been queued up before it). I assume that making AXLoadComplete asynchronous is not possible. Therefore, it seems the test should be relaxed to handle the case of various orderings. 1129844 13 262236 mmaxfield 2015-09-30 23:27:10 -0700 Created attachment 262236 Patch 1129845 14 ap 2015-09-30 23:27:17 -0700 > I assume that making AXLoadComplete asynchronous is not possible. This actually sounds like it should be good. Loading is asynchronous in nature, so queueing the notification should not make an observable difference other than in this edge case. Chris, does that make sense? 1129847 15 262236 ap 2015-09-30 23:29:19 -0700 Comment on attachment 262236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262236&action=review > LayoutTests/accessibility/mac/aria-expanded-notifications-expected.txt:12 > TEST COMPLETE > -Notification: AXLoadComplete > Notification: AXRowCountChanged This should be fixed by properly using js-test functionality - TEST COMPLETE is supposed to be last. > LayoutTests/platform/mac/TestExpectations:-1334 > -webkit.org/b/149510 accessibility/mac/aria-expanded-notifications.html [ Pass Failure ] It seems like we would need a code change anyway for the other test that asserts. 1129849 16 cfleizach 2015-09-30 23:30:57 -0700 Yea this sounds good. The test is not dependent on the order of these notifications If we didn't get to the bottom of this I was going to suggest filtering out the load notification Thanks! 1129851 17 262236 mmaxfield 2015-09-30 23:31:12 -0700 Comment on attachment 262236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262236&action=review >> LayoutTests/platform/mac/TestExpectations:-1334 >> -webkit.org/b/149510 accessibility/mac/aria-expanded-notifications.html [ Pass Failure ] > > It seems like we would need a code change anyway for the other test that asserts. Unfortunately, it seems that other test is a separate issue :( 1129972 18 mmaxfield 2015-10-01 10:46:26 -0700 Committed r190417: <http://trac.webkit.org/changeset/190417> 262106 2015-09-29 14:13:23 -0700 2015-09-29 14:13:23 -0700 Test List file2.txt text/plain 518 mmaxfield YWNjZXNzaWJpbGl0eS9tYWMvYWJici1hY3JvbnltLXRhZ3MuaHRtbAphY2Nlc3NpYmlsaXR5L21h Yy9hYmJyLWFjcm9ueW0tdGFncy5odG1sCmFjY2Vzc2liaWxpdHkvbWFjL2FjY2Vzc2tleS5odG1s CmFjY2Vzc2liaWxpdHkvbWFjL2FsdC1mb3ItY3NzLWNvbnRlbnQuaHRtbAphY2Nlc3NpYmlsaXR5 L21hYy9hcmVhLXdpdGgtYXJpYS1sYWJlbC5odG1sCmFjY2Vzc2liaWxpdHkvbWFjL2FyaWEtYWxl cnRzLmh0bWwKYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1jb2x1bW5yb3doZWFkZXJzLmh0bWwKYWNj ZXNzaWJpbGl0eS9tYWMvYXJpYS1kaXJlY3RvcnkuaHRtbAphY2Nlc3NpYmlsaXR5L21hYy9hcmlh LWRpdnMtbm90LWlnbm9yZWQuaHRtbAphY2Nlc3NpYmlsaXR5L21hYy9hcmlhLWRyYWctZHJvcC5o dG1sCmFjY2Vzc2liaWxpdHkvbWFjL2FyaWEtZXhwYW5kZWQtbm90LWV4cG9zZWQtd2hlbi11bmRl ZmluZWQuaHRtbAphY2Nlc3NpYmlsaXR5L21hYy9hcmlhLWV4cGFuZGVkLW5vdGlmaWNhdGlvbnMu aHRtbAo= 262109 2015-09-29 14:33:43 -0700 2015-09-29 14:33:43 -0700 Failure diff aria-expanded-notifications-diff.txt text/plain 499 mmaxfield LS0tIC9Wb2x1bWVzL0RhdGEvaG9tZS9tbWF4ZmllbGQvQnVpbGQvRGVidWcvbGF5b3V0LXRlc3Qt cmVzdWx0cy9hY2Nlc3NpYmlsaXR5L21hYy9hcmlhLWV4cGFuZGVkLW5vdGlmaWNhdGlvbnMtZXhw ZWN0ZWQudHh0CisrKyAvVm9sdW1lcy9EYXRhL2hvbWUvbW1heGZpZWxkL0J1aWxkL0RlYnVnL2xh eW91dC10ZXN0LXJlc3VsdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1leHBhbmRlZC1ub3RpZmlj YXRpb25zLWFjdHVhbC50eHQKQEAgLTksOSArOSw5IEBACiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKLU5vdGlmaWNhdGlvbjogQVhMb2FkQ29tcGxldGUK IE5vdGlmaWNhdGlvbjogQVhSb3dDb3VudENoYW5nZWQKIE5vdGlmaWNhdGlvbjogQVhSb3dDb2xs YXBzZWQKIE5vdGlmaWNhdGlvbjogQVhSb3dDb3VudENoYW5nZWQKIE5vdGlmaWNhdGlvbjogQVhS b3dFeHBhbmRlZAorTm90aWZpY2F0aW9uOiBBWExvYWRDb21wbGV0ZQogCg== 262236 2015-09-30 23:27:10 -0700 2015-09-30 23:31:52 -0700 Patch bug-149510-20150930232645.patch text/plain 3872 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMzgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDNhY2VkMGNiNDc0OWVlNGZhZTE5 NDgzMGFkYWJjYTI3YzE4YjBkMC4uN2E0NzVhMWQwZmVkYzI1ZjU0ODNhZjBiYjk0NDk1MzNkMzVj ZTlmMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA5LTMwICBNeWxlcyBDLiBNYXhmaWVs ZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgYWNjZXNzaWJpbGl0eS9tYWMvYXJp YS1leHBhbmRlZC1ub3RpZmljYXRpb25zLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTUxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRyaWdnZXJlZCBi eSBvdXIgcmVzdW1hYmxlIHBhcnNlci4gQVhMb2FkQ29tcGxldGUgZ2V0cyBjYWxsZWQKKyAgICAg ICAgc3luY2hyb25vdXNseSBmcm9tIERvY3VtZW50TG9hZGVyOjpmaW5pc2hlZExvYWRpbmcoKS4g VGhpcyBtZWFucyB0aGF0IHRoZSBvcmRlciBvZgorICAgICAgICB0aGUgQVhMb2FkQ29tcGxldGUg bWVzc2FnZSBpc24ndCBGSUZPLgorCisgICAgICAgIElmIHRoZSBwYXJzZXIgeWllbGRlZCBwcmV2 aW91c2x5LCB0aGUgQVhMb2FkQ29tcGxldGUgd2lsbCBiZSBoYW5kbGVkIGFmdGVyIHNvbWUgQVgK KyAgICAgICAgbWVzc2FnZXMgaGFkIGJlZW4gaGFuZGxlZC4KKworICAgICAgICBJZiB0aGUgcGFy c2VyIGhhZG4ndCB5aWVsZGVkLCB0aGUgQVhMb2FkQ29tcGxldGUgd2lsbCBiZSB0aGUgZmlyc3Qg bWVzc2FnZQorICAgICAgICBwcm9jZXNzZWQgKG5vIG1hdHRlciB3aGF0IGhhZCBiZWVuIHF1ZXVl ZCB1cCBiZWZvcmUgaXQpLgorCisgICAgICAgIEJlY2F1c2UgbWFraW5nIHRoZSBBWExvYWRDb21w bGV0ZSBtZXNzYWdlIGFzeW5jaG9ub3VzIGlzIG5vdCBkZXNpcmFibGUsIHRoZQorICAgICAgICBz b2x1dGlvbiBpcyB0byByZWxheCB0aGUgdGVzdCB0byBoYW5kbGUgdmFyaW91cyBvcmRlcmluZ3Mu CisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9hcmlhLWV4cGFuZGVkLW5vdGlmaWNhdGlv bnMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL2FyaWEtZXhwYW5k ZWQtbm90aWZpY2F0aW9ucy5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0 YXRpb25zOgorCiAyMDE1LTA5LTMwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgVW5pcXVlSURCRGF0YWJhc2Ugb2JqZWN0LCBJREJCYWNraW5nU3RvcmUg b2JqZWN0cywgYW5kIGEgZGF0YWJhc2Ugb3BlcmF0aW9uIHRocmVhZC4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtZXhwYW5kZWQtbm90aWZpY2F0aW9ucy1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9hcmlhLWV4cGFuZGVk LW5vdGlmaWNhdGlvbnMtZXhwZWN0ZWQudHh0CmluZGV4IDg3MDVjMTcxNTQ3MDc3ODA3MTBjODcx NGM0ZGY3OTQyNTZiNjEwMDAuLmEyNThhYWFmM2FkMThhMGUwNWNhMzEzOTE5MTQwMzYyN2YzMjg5 MmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtZXhwYW5k ZWQtbm90aWZpY2F0aW9ucy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9tYWMvYXJpYS1leHBhbmRlZC1ub3RpZmljYXRpb25zLWV4cGVjdGVkLnR4dApAQCAtOSw3 ICs5LDYgQEAgUEFTUyBhZGRlZE5vdGlmaWNhdGlvbiBpcyB0cnVlCiBQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKLU5vdGlmaWNhdGlvbjogQVhMb2FkQ29t cGxldGUKIE5vdGlmaWNhdGlvbjogQVhSb3dDb3VudENoYW5nZWQKIE5vdGlmaWNhdGlvbjogQVhS b3dDb2xsYXBzZWQKIE5vdGlmaWNhdGlvbjogQVhSb3dDb3VudENoYW5nZWQKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtZXhwYW5kZWQtbm90aWZpY2F0aW9u cy5odG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1leHBhbmRlZC1ub3Rp ZmljYXRpb25zLmh0bWwKaW5kZXggZjJhMmZkZmQ0MWZhNWUyOTQzNWViNDdlNDFmMTBhMjI3YmJk YWI0Ny4uODQ3OTgxMjNmNWNiMGY2YzViZjBhNzA0ZTQ1M2MxNmVmM2IxMDcwMyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1leHBhbmRlZC1ub3RpZmljYXRp b25zLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1leHBhbmRl ZC1ub3RpZmljYXRpb25zLmh0bWwKQEAgLTMwLDkgKzMwLDExIEBACiAgICAgdmFyIG5vdGlmeU5h bWUgPSAwOwogICAgIC8vIFRoZSBvcmRlciBvZiBub3RpZmljYXRpb25zIHNob3VsZCBiZSBSb3cg Q291bnQsIFJvdyBDb2xsYXBzZWQsIFJvdyBDb3VudCwgUm93IEV4cGFuZGVkCiAgICAgZnVuY3Rp b24gbm90aWZ5Q2FsbGJhY2soZWxlbWVudCwgbm90aWZpY2F0aW9uKSB7ICAKKyAgICAgICAgaWYg KG5vdGlmaWNhdGlvbiA9PSAiQVhMb2FkQ29tcGxldGUiIHx8IG5vdGlmaWNhdGlvbiA9PSAiQVhM YXlvdXRDb21wbGV0ZSIpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIG5vdGlmeU5hbWUg PSBub3RpZmljYXRpb247CiAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJub3RpZmlj YXRpb25zIikuaW5uZXJIVE1MICs9ICJOb3RpZmljYXRpb246ICIgKyBub3RpZnlOYW1lICsgIjxi cj4iOwotICAgICAgICBpZiAobm90aWZ5Q291bnQgPT0gNCkgeworICAgICAgICBpZiAobm90aWZ5 Q291bnQgPT0gMykgewogICAgICAgICAgICAgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIucmVtb3Zl Tm90aWZpY2F0aW9uTGlzdGVuZXIoKTsKICAgICAgICAgICAgIHdpbmRvdy50ZXN0UnVubmVyLm5v dGlmeURvbmUoKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwppbmRleCAyYWQ1ZDUxM2M1MDhhOTcxMGU3MTgxZWRlNTIzNDFjOGM2YWJjMWFhLi40 Y2ZlMjcxMzc1MjZlZTJmNTkzZmVmYzIxNGQwNzE2NTgyMDlmMzg0IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTMzMSw3ICsxMzMxLDUgQEAgd2Via2l0 Lm9yZy9iLzE0OTQ0MCBmYXN0L3NoYWRvdy1kb20vY3NzLXNjb3Bpbmctc2hhZG93LWhvc3QtZnVu Y3Rpb25hbC1ydWxlLmh0bWwKIHdlYmtpdC5vcmcvYi8xNDk0NDEgZmFzdC9zaGFkb3ctZG9tL2Nz cy1zY29waW5nLXNoYWRvdy1zbG90dGVkLXJ1bGUuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQog d2Via2l0Lm9yZy9iLzE0OTQ0MSBmYXN0L3NoYWRvdy1kb20vY3NzLXNjb3Bpbmctc2hhZG93LXNs b3QtZGlzcGxheS1vdmVycmlkZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5v cmcvYi8xNDk1MTAgYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS1leHBhbmRlZC1ub3RpZmljYXRpb25z Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCiAjIFRpbWVzIG91dCBpbiBkZWJ1Zy4KIFsgRGVidWcg XSBqcy9yZWdyZXNzL2dldHRlci1yaWNoYXJkcy10cnktY2F0Y2guaHRtbCBbIFNraXAgXQo=