149506 2015-09-23 10:21:25 -0700 Web Inspector: Hitting ESC while editing element tag name leaves element in bad state 2015-09-28 15:04:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1128346 0 mattbaker 2015-09-23 10:21:25 -0700 * SUMMARY Hitting ESC while editing element tag name leaves element in bad state. * STEPS TO REPRODUCE 1. Open Elements tab 2. Double-click the tag text for an element, such as a <div> (must not be a self-closing tag) 3. Enter a new element name, hit ESC to cancel => The opening tag name reverts to the original text, but the closing tag does not 1128347 1 webkit-bug-importer 2015-09-23 10:21:41 -0700 <rdar://problem/22821316> 1128353 2 261828 joepeck 2015-09-23 10:36:52 -0700 Created attachment 261828 [PATCH] Proposed Fix 1128354 3 261828 mattbaker 2015-09-23 10:41:00 -0700 Comment on attachment 261828 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=261828&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:809 > + let originalClosingTagTextContent = closingTagElement ? closingTagElement.textContent : ""; const originalClosingTagTextContent = ... 1129066 4 261828 joepeck 2015-09-28 14:17:12 -0700 Comment on attachment 261828 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=261828&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:809 >> + let originalClosingTagTextContent = closingTagElement ? closingTagElement.textContent : ""; > > const originalClosingTagTextContent = ... Though true, we do this a lot and we haven't exactly standardized on this. I tend to use const when assigning a literal primitive to give it a better name. const betterNameForBool = true; const minimumSizeOfSomething = 15; const defaultDisplayString = "–"; Maybe we should start using const more for cases like this. 1129082 5 261828 commit-queue 2015-09-28 15:04:00 -0700 Comment on attachment 261828 [PATCH] Proposed Fix Clearing flags on attachment: 261828 Committed r190286: <http://trac.webkit.org/changeset/190286> 1129083 6 commit-queue 2015-09-28 15:04:03 -0700 All reviewed patches have been landed. Closing bug. 261828 2015-09-23 10:36:52 -0700 2015-09-28 15:04:00 -0700 [PATCH] Proposed Fix restore-original-text.patch text/plain 2075 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEzMDI1ZDEuLmViOTRiM2IgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTA5LTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGl0dGlu ZyBFU0Mgd2hpbGUgZWRpdGluZyBlbGVtZW50IHRhZyBuYW1lIGxlYXZlcyBlbGVtZW50IGluIGJh ZCBzdGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ5NTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRPTVRyZWVFbGVtZW50LnByb3RvdHlwZS5fc3RhcnRFZGl0aW5nVGFnTmFtZS5lZGl0 aW5nQ2FuY2VsbGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90 b3R5cGUuX3N0YXJ0RWRpdGluZ1RhZ05hbWUpOgorICAgICAgICBXaGVuIGNhbmNlbGxpbmcgZWRp dGluZyBvZiBhIHRhZyBuYW1lLCByZXZlcnQgYW55IGNoYW5nZXMgd2UgaGFkCisgICAgICAgIGJl ZW4gbWFraW5nIHRvIHRoZSBjbG9zaW5nIHRhZyBuYW1lLgorCiAyMDE1LTA5LTIyICBTYWFtIGJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHVwZGF0 ZSBFc3ByaW1hIHRvIGxhdGVzdCB2ZXJzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzCmluZGV4IDMz MGE4NjYuLmVhNWZlNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzCkBAIC04MDUsNyArODA1LDgg QEAgV2ViSW5zcGVjdG9yLkRPTVRyZWVFbGVtZW50ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0 ZW5kcyBXZWJJbnNwZWN0b3IuVHJlZUVsZW0KICAgICAgICAgaWYgKFdlYkluc3BlY3Rvci5pc0Jl aW5nRWRpdGVkKHRhZ05hbWVFbGVtZW50KSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogCi0g ICAgICAgIHZhciBjbG9zaW5nVGFnRWxlbWVudCA9IHRoaXMuX2Rpc3RpbmN0Q2xvc2luZ1RhZ0Vs ZW1lbnQoKTsKKyAgICAgICAgbGV0IGNsb3NpbmdUYWdFbGVtZW50ID0gdGhpcy5fZGlzdGluY3RD bG9zaW5nVGFnRWxlbWVudCgpOworICAgICAgICBsZXQgb3JpZ2luYWxDbG9zaW5nVGFnVGV4dENv bnRlbnQgPSBjbG9zaW5nVGFnRWxlbWVudCA/IGNsb3NpbmdUYWdFbGVtZW50LnRleHRDb250ZW50 IDogIiI7CiAKICAgICAgICAgZnVuY3Rpb24ga2V5dXBMaXN0ZW5lcihldmVudCkKICAgICAgICAg ewpAQCAtODIxLDYgKzgyMiw5IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudCA9IGNsYXNz IERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVFbGVtCiAKICAgICAgICAg ZnVuY3Rpb24gZWRpdGluZ0NhbmNlbGxlZCgpCiAgICAgICAgIHsKKyAgICAgICAgICAgIGlmIChj bG9zaW5nVGFnRWxlbWVudCkKKyAgICAgICAgICAgICAgICBjbG9zaW5nVGFnRWxlbWVudC50ZXh0 Q29udGVudCA9IG9yaWdpbmFsQ2xvc2luZ1RhZ1RleHRDb250ZW50OworCiAgICAgICAgICAgICB0 YWdOYW1lRWxlbWVudC5yZW1vdmVFdmVudExpc3RlbmVyKCJrZXl1cCIsIGtleXVwTGlzdGVuZXIs IGZhbHNlKTsKICAgICAgICAgICAgIHRoaXMuX2VkaXRpbmdDYW5jZWxsZWQuYXBwbHkodGhpcywg YXJndW1lbnRzKTsKICAgICAgICAgfQo=