149475 2015-09-22 14:53:11 -0700 URL of page visited in private browsing still appears in Activity Monitor after page is closed 2015-09-22 16:33:25 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1128112 0 andersca 2015-09-22 14:53:11 -0700 URL of page visited in private browsing still appears in Activity Monitor after page is closed 1128146 1 261773 andersca 2015-09-22 16:18:58 -0700 Created attachment 261773 Patch 1128147 2 261773 mitz 2015-09-22 16:22:49 -0700 Comment on attachment 261773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261773&action=review > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:269 > - CFArrayAppendValue(activePageURLs.get(), userVisibleString(originAsURL)); > + [activePageURLs addObject:originAsURL]; Why is it OK to change from passing an array of string to passing an array of URLs? Does WKSetApplicationInformationItem support both? 1128148 3 261774 andersca 2015-09-22 16:24:06 -0700 Created attachment 261774 Patch 1128153 4 andersca 2015-09-22 16:33:25 -0700 Committed r190141: <http://trac.webkit.org/changeset/190141> 261773 2015-09-22 16:18:58 -0700 2015-09-22 16:24:04 -0700 Patch bug-149475-20150922161840.patch text/plain 2910 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTFiZTMxNGNlZWNlY2Jk ODkwYmQwNDE2ZjZlMGEzMjA5OGIxMTU0My4uMTQ4MTgwZjFlN2RjYjUwOWE2NzM2OTQyNTVjZDMw M2I2MmFmNzQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA5LTIyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVVJMIG9mIHBhZ2Ug dmlzaXRlZCBpbiBwcml2YXRlIGJyb3dzaW5nIHN0aWxsIGFwcGVhcnMgaW4gQWN0aXZpdHkgTW9u aXRvciBhZnRlciBwYWdlIGlzIGNsb3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NDc1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIyNjg0NTIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmNs b3NlKToKKyAgICAgICAgTWFrZSBzdXJlIHRvIGNhbGwgdXBkYXRlQWN0aXZlUGFnZXMgYWZ0ZXIg cmVtb3ZpbmcgdGhlIHBhZ2UgZnJvbSB0aGUgcGFnZSBtYXAuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vz czo6dXBkYXRlQWN0aXZlUGFnZXMpOgorICAgICAgICBEb24ndCBpbmNsdWRlIHBhZ2VzIHRoYXQg aGF2ZSBwcml2YXRlIGJyb3dzaW5nIGVuYWJsZWQuCisKIDIwMTUtMDktMjIgIFRpbSBIb3J0b24g IDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBpdCBtb3JlIG9idmlv dXMgd2hlbiB1c2luZyBhbiB1bmFjY2VsZXJhdGVkIGltYWdlIGJ1ZmZlciwgYW5kIGZpeCBhIGZl dyBjYWxsZXJzIHdobyBkbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCmluZGV4IDJiYTI1YzY5OGY1NGFlZDAxNzk3MzU5YWQ2MzE3OTMzODg1NmRjZWEu LjM2ZmM5MjBhZDE4NGE1M2U2MDZkNzg5ZWIxZDBiMjg0MmFiYjA0YjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTEwMDQsNiArMTAwNCw4 IEBAIHZvaWQgV2ViUGFnZTo6Y2xvc2UoKQogICAgIC8vIFRoZSBXZWJQYWdlIGNhbiBiZSBkZXN0 cm95ZWQgYnkgdGhpcyBjYWxsLgogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnJlbW92ZVdl YlBhZ2UobV9wYWdlSUQpOwogCisgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkudXBkYXRlQWN0 aXZlUGFnZXMoKTsKKwogICAgIGlmIChpc1J1bm5pbmdNb2RhbCkKICAgICAgICAgUnVuTG9vcDo6 bWFpbigpLnN0b3AoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv Y29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2Nv YS9XZWJQcm9jZXNzQ29jb2EubW0KaW5kZXggYjM2MjBmZjE1Njc3NDkzNTI5YjU2MzAzOTJhMjM0 MjgzZTE3M2MwYy4uMmMyN2RlY2UzN2U0ZmY3MmY0YThkOWVjOTljYTZiMTVkOGQxNzg2NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0KQEAgLTI1OSwxMyArMjU5LDE4IEBAIHN0YXRpYyBOU1VSTCAqb3JpZ2luKFdlYlBhZ2UmIHBh Z2UpCiB2b2lkIFdlYlByb2Nlc3M6OnVwZGF0ZUFjdGl2ZVBhZ2VzKCkKIHsKICNpZiBQTEFURk9S TShNQUMpCi0gICAgUmV0YWluUHRyPENGTXV0YWJsZUFycmF5UmVmPiBhY3RpdmVQYWdlVVJMcyA9 IGFkb3B0Q0YoQ0ZBcnJheUNyZWF0ZU11dGFibGUoMCwgMCwgJmtDRlR5cGVBcnJheUNhbGxCYWNr cykpOworICAgIGF1dG8gYWN0aXZlUGFnZVVSTHMgPSBhZG9wdE5TKFtbTlNNdXRhYmxlQXJyYXkg YWxsb2NdIGluaXRdKTsKKwogICAgIGZvciAoYXV0byYgcGFnZSA6IG1fcGFnZU1hcC52YWx1ZXMo KSkgeworICAgICAgICBpZiAocGFnZS0+dXNlc0VwaGVtZXJhbFNlc3Npb24oKSkKKyAgICAgICAg ICAgIGNvbnRpbnVlOworCiAgICAgICAgIGlmIChOU1VSTCAqb3JpZ2luQXNVUkwgPSBvcmlnaW4o KnBhZ2UpKQotICAgICAgICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVlKGFjdGl2ZVBhZ2VVUkxzLmdl dCgpLCB1c2VyVmlzaWJsZVN0cmluZyhvcmlnaW5Bc1VSTCkpOworICAgICAgICAgICAgW2FjdGl2 ZVBhZ2VVUkxzIGFkZE9iamVjdDpvcmlnaW5Bc1VSTF07CiAgICAgfQorCiAgICAgZGlzcGF0Y2hf YXN5bmMoZGlzcGF0Y2hfZ2V0X2dsb2JhbF9xdWV1ZShESVNQQVRDSF9RVUVVRV9QUklPUklUWV9E RUZBVUxULCAwKSwgW2FjdGl2ZVBhZ2VVUkxzXSB7Ci0gICAgICAgIFdLU2V0QXBwbGljYXRpb25J bmZvcm1hdGlvbkl0ZW0oQ0ZTVFIoIkxTQWN0aXZlUGFnZVVzZXJWaXNpYmxlT3JpZ2luc0tleSIp LCBhY3RpdmVQYWdlVVJMcy5nZXQoKSk7CisgICAgICAgIFdLU2V0QXBwbGljYXRpb25JbmZvcm1h dGlvbkl0ZW0oQ0ZTVFIoIkxTQWN0aXZlUGFnZVVzZXJWaXNpYmxlT3JpZ2luc0tleSIpLCAoX19i cmlkZ2UgQ0ZBcnJheVJlZilhY3RpdmVQYWdlVVJMcy5nZXQoKSk7CiAgICAgfSk7CiAjZW5kaWYK IH0K 261774 2015-09-22 16:24:06 -0700 2015-09-22 16:32:35 -0700 Patch bug-149475-20150922162348.patch text/plain 2929 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTFiZTMxNGNlZWNlY2Jk ODkwYmQwNDE2ZjZlMGEzMjA5OGIxMTU0My4uMTQ4MTgwZjFlN2RjYjUwOWE2NzM2OTQyNTVjZDMw M2I2MmFmNzQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA5LTIyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVVJMIG9mIHBhZ2Ug dmlzaXRlZCBpbiBwcml2YXRlIGJyb3dzaW5nIHN0aWxsIGFwcGVhcnMgaW4gQWN0aXZpdHkgTW9u aXRvciBhZnRlciBwYWdlIGlzIGNsb3NlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NDc1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzIyNjg0NTIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmNs b3NlKToKKyAgICAgICAgTWFrZSBzdXJlIHRvIGNhbGwgdXBkYXRlQWN0aXZlUGFnZXMgYWZ0ZXIg cmVtb3ZpbmcgdGhlIHBhZ2UgZnJvbSB0aGUgcGFnZSBtYXAuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vz czo6dXBkYXRlQWN0aXZlUGFnZXMpOgorICAgICAgICBEb24ndCBpbmNsdWRlIHBhZ2VzIHRoYXQg aGF2ZSBwcml2YXRlIGJyb3dzaW5nIGVuYWJsZWQuCisKIDIwMTUtMDktMjIgIFRpbSBIb3J0b24g IDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBpdCBtb3JlIG9idmlv dXMgd2hlbiB1c2luZyBhbiB1bmFjY2VsZXJhdGVkIGltYWdlIGJ1ZmZlciwgYW5kIGZpeCBhIGZl dyBjYWxsZXJzIHdobyBkbwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuY3BwCmluZGV4IDJiYTI1YzY5OGY1NGFlZDAxNzk3MzU5YWQ2MzE3OTMzODg1NmRjZWEu LjM2ZmM5MjBhZDE4NGE1M2U2MDZkNzg5ZWIxZDBiMjg0MmFiYjA0YjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTEwMDQsNiArMTAwNCw4 IEBAIHZvaWQgV2ViUGFnZTo6Y2xvc2UoKQogICAgIC8vIFRoZSBXZWJQYWdlIGNhbiBiZSBkZXN0 cm95ZWQgYnkgdGhpcyBjYWxsLgogICAgIFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnJlbW92ZVdl YlBhZ2UobV9wYWdlSUQpOwogCisgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkudXBkYXRlQWN0 aXZlUGFnZXMoKTsKKwogICAgIGlmIChpc1J1bm5pbmdNb2RhbCkKICAgICAgICAgUnVuTG9vcDo6 bWFpbigpLnN0b3AoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv Y29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2Nv YS9XZWJQcm9jZXNzQ29jb2EubW0KaW5kZXggYjM2MjBmZjE1Njc3NDkzNTI5YjU2MzAzOTJhMjM0 MjgzZTE3M2MwYy4uNGY4ZDA5YWEzMmFhYzdkYmQzODFjNzZlOTQzODIxY2VmNGM2ZDNkNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0KQEAgLTI1OSwxMyArMjU5LDE4IEBAIHN0YXRpYyBOU1VSTCAqb3JpZ2luKFdlYlBhZ2UmIHBh Z2UpCiB2b2lkIFdlYlByb2Nlc3M6OnVwZGF0ZUFjdGl2ZVBhZ2VzKCkKIHsKICNpZiBQTEFURk9S TShNQUMpCi0gICAgUmV0YWluUHRyPENGTXV0YWJsZUFycmF5UmVmPiBhY3RpdmVQYWdlVVJMcyA9 IGFkb3B0Q0YoQ0ZBcnJheUNyZWF0ZU11dGFibGUoMCwgMCwgJmtDRlR5cGVBcnJheUNhbGxCYWNr cykpOworICAgIGF1dG8gYWN0aXZlUGFnZVVSTHMgPSBhZG9wdE5TKFtbTlNNdXRhYmxlQXJyYXkg YWxsb2NdIGluaXRdKTsKKwogICAgIGZvciAoYXV0byYgcGFnZSA6IG1fcGFnZU1hcC52YWx1ZXMo KSkgeworICAgICAgICBpZiAocGFnZS0+dXNlc0VwaGVtZXJhbFNlc3Npb24oKSkKKyAgICAgICAg ICAgIGNvbnRpbnVlOworCiAgICAgICAgIGlmIChOU1VSTCAqb3JpZ2luQXNVUkwgPSBvcmlnaW4o KnBhZ2UpKQotICAgICAgICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVlKGFjdGl2ZVBhZ2VVUkxzLmdl dCgpLCB1c2VyVmlzaWJsZVN0cmluZyhvcmlnaW5Bc1VSTCkpOworICAgICAgICAgICAgW2FjdGl2 ZVBhZ2VVUkxzIGFkZE9iamVjdDp1c2VyVmlzaWJsZVN0cmluZyhvcmlnaW5Bc1VSTCldOwogICAg IH0KKwogICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9nbG9iYWxfcXVldWUoRElTUEFU Q0hfUVVFVUVfUFJJT1JJVFlfREVGQVVMVCwgMCksIFthY3RpdmVQYWdlVVJMc10gewotICAgICAg ICBXS1NldEFwcGxpY2F0aW9uSW5mb3JtYXRpb25JdGVtKENGU1RSKCJMU0FjdGl2ZVBhZ2VVc2Vy VmlzaWJsZU9yaWdpbnNLZXkiKSwgYWN0aXZlUGFnZVVSTHMuZ2V0KCkpOworICAgICAgICBXS1Nl dEFwcGxpY2F0aW9uSW5mb3JtYXRpb25JdGVtKENGU1RSKCJMU0FjdGl2ZVBhZ2VVc2VyVmlzaWJs ZU9yaWdpbnNLZXkiKSwgKF9fYnJpZGdlIENGQXJyYXlSZWYpYWN0aXZlUGFnZVVSTHMuZ2V0KCkp OwogICAgIH0pOwogI2VuZGlmCiB9Cg==