149469 2015-09-22 11:11:47 -0700 RenderSVGResourceClipper::applyClippingToContext makes an unconditionally unaccelerated ImageBuffer 2023-06-14 17:02:00 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 thorton simon.fraser ahmad.saleem792 changseok dino esprehn+autocc ews-watchlist fmalita glenn gyuyoung.kim kondapallykalyan pdr sabouhallawa schenney sergio simon.fraser zimmermann oldest_to_newest 1128045 0 thorton 2015-09-22 11:11:47 -0700 The ImageBuffer should inherit the accelerated bit from the context it will eventually be painted into. However, doing so breaks some tests when run with --accelerated-drawing on, and clearly also breaks these tests in Safari. Needs more investigation (and possibly bugs filed on other components). 1805290 1 simon.fraser 2021-10-16 12:40:09 -0700 The only one I found in LayoutTests/svg was svg/gradients/spreadMethodClose2.svg which looks like a bug with accelerated drawing. 1805291 2 simon.fraser 2021-10-16 12:41:17 -0700 But svg/gradients/spreadMethodClose2.svg has different behavior in Chrome and Firefox (both of which show blues) so it's not clear what's going on. 1805292 3 441501 simon.fraser 2021-10-16 12:46:19 -0700 Created attachment 441501 Patch 1904350 4 ahmad.saleem792 2022-10-09 06:32:00 -0700 It seems this r+ patch didn't landed and we have FIXME about it as well: https://github.com/WebKit/WebKit/blob/ce878379210ced398d994217e26519b433761149/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp#L171 Just wanted to update. Thanks! 1961673 5 ahmad.saleem792 2023-06-14 17:02:00 -0700 NOTE - this patch also still work on WebKit ToT (tested locally). 441501 2021-10-16 12:46:19 -0700 2021-10-17 07:55:31 -0700 Patch bug-149469-20211016124618.patch text/plain 3478 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRmNDA3MDc5NTFmZjFj NTAxNGFhZGUxMzRmNzFmOTkyYTc1MWVlOS4uNDg0YTJhNThiYzhiNGYwMTY2ZjdlYmZlODVjYjdk OTBmYTAyM2RjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTEwLTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmRlclNWR1Jl c291cmNlQ2xpcHBlcjo6YXBwbHlDbGlwcGluZ1RvQ29udGV4dCBtYWtlcyBhbiB1bmNvbmRpdGlv bmFsbHkgdW5hY2NlbGVyYXRlZCBJbWFnZUJ1ZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xpcHBpbmcgYW5kIG1hc2tpbmcgUmVuZGVyU1ZHUmVz b3VyY2VzIHNob3VsZCBtYWtlIGltYWdlIGJ1ZmZlcnMgdGhhdCBtYXRjaCB0aGUKKyAgICAgICAg YWNjZWxlcmF0ZWQgc3RhdGUgb2YgdGhlaXIgdGFyZ2V0IGNvbnRleHQuCisKKyAgICAgICAgVGhp cyBkb2VzIHJlc3VsdCBpbiBhIGJlaGF2aW9yIGNoYW5nZSBpbiBzdmcvZ3JhZGllbnRzL3NwcmVh ZE1ldGhvZENsb3NlMi5zdmcgd2hlbgorICAgICAgICBhY2NlbGVyYXRlZCBkcmF3aW5nIGlzIGVu YWJsZWQsIGJ1dCBvdXIgcmVzdWx0cyBub3cgYXJlIGNsb3NlciB0byBDaHJvbWUgYW5kIEZpcmVm b3gKKyAgICAgICAgKHRoZSByZWZlcmVuY2UgaXMgb2J2aW91c2x5IHdyb25nKS4KKworICAgICAg ICAqIHJlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VDbGlwcGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclNWR1Jlc291cmNlQ2xpcHBlcjo6YXBwbHlDbGlwcGluZ1RvQ29udGV4 dCk6CisgICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZU1hc2tlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdSZXNvdXJjZU1hc2tlcjo6YXBwbHlSZXNvdXJj ZSk6CisKIDIwMjEtMTAtMTQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRnVydGhlciBhZGp1c3Qgc3R5bGUgb2YgYWx0ZXJuYXRlIGZvcm0gY29udHJv bCBkZXNpZ24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVy U1ZHUmVzb3VyY2VDbGlwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVu ZGVyU1ZHUmVzb3VyY2VDbGlwcGVyLmNwcAppbmRleCBmNjJkMGNjMTNjZTUyY2VmZTU3NDJhNTk2 YTE5ZTEzNWUyM2QxZjJhLi40ZTU4NWZjNjE3MGY2MGQyN2NhYzcxMDBjODhiMzM3ZDc4NmUwZDZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291 cmNlQ2xpcHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJT VkdSZXNvdXJjZUNsaXBwZXIuY3BwCkBAIC0xNTIsOCArMTUyLDcgQEAgYm9vbCBSZW5kZXJTVkdS ZXNvdXJjZUNsaXBwZXI6OmFwcGx5Q2xpcHBpbmdUb0NvbnRleHQoR3JhcGhpY3NDb250ZXh0JiBj b250ZXh0LAogCiAgICAgQWZmaW5lVHJhbnNmb3JtIGFic29sdXRlVHJhbnNmb3JtID0gU1ZHUmVu ZGVyaW5nQ29udGV4dDo6Y2FsY3VsYXRlVHJhbnNmb3JtYXRpb25Ub091dGVybW9zdENvb3JkaW5h dGVTeXN0ZW0ocmVuZGVyZXIpOwogICAgIGlmICghY2xpcHBlckRhdGEuaXNWYWxpZEZvckdlb21l dHJ5KG9iamVjdEJvdW5kaW5nQm94LCBhYnNvbHV0ZVRyYW5zZm9ybSkpIHsKLSAgICAgICAgLy8g RklYTUUgKDE0OTQ2OSk6IFRoaXMgaW1hZ2UgYnVmZmVyIHNob3VsZCBub3QgYmUgdW5jb25kaXRp b25hbGx5IHVuYWNjZWxlcmF0ZWQuIE1ha2luZyBpdCBtYXRjaCB0aGUgY29udGV4dCBicmVha3Mg bmVzdGVkIGNsaXBwaW5nLCB0aG91Z2guCi0gICAgICAgIGF1dG8gbWFza0ltYWdlID0gU1ZHUmVu ZGVyaW5nQ29udGV4dDo6Y3JlYXRlSW1hZ2VCdWZmZXIob2JqZWN0Qm91bmRpbmdCb3gsIGFic29s dXRlVHJhbnNmb3JtLCBEZXN0aW5hdGlvbkNvbG9yU3BhY2U6OlNSR0IoKSwgUmVuZGVyaW5nTW9k ZTo6VW5hY2NlbGVyYXRlZCwgJmNvbnRleHQpOworICAgICAgICBhdXRvIG1hc2tJbWFnZSA9IFNW R1JlbmRlcmluZ0NvbnRleHQ6OmNyZWF0ZUltYWdlQnVmZmVyKG9iamVjdEJvdW5kaW5nQm94LCBh YnNvbHV0ZVRyYW5zZm9ybSwgRGVzdGluYXRpb25Db2xvclNwYWNlOjpTUkdCKCksIGNvbnRleHQu cmVuZGVyaW5nTW9kZSgpLCAmY29udGV4dCk7CiAgICAgICAgIGlmICghbWFza0ltYWdlKQogICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlTWFza2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VNYXNrZXIuY3BwCmluZGV4IGIyMzg3ODYyZGRm MjIyMTcxZTRhNWQ5YzJkZjU1ZjZjOTgzOWJiNjIuLjc0ZWU3Yjc2MmMzOTM0NmJmNWE0MzFlNTEx NzNhOTdiNjJkN2VmMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHUmVzb3VyY2VNYXNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VNYXNrZXIuY3BwCkBAIC04Myw4ICs4Myw3IEBAIGJvb2wg UmVuZGVyU1ZHUmVzb3VyY2VNYXNrZXI6OmFwcGx5UmVzb3VyY2UoUmVuZGVyRWxlbWVudCYgcmVu ZGVyZXIsIGNvbnN0IFJlbmRlCiAgICAgICAgIH0KICNlbmRpZgogCi0gICAgICAgIC8vIEZJWE1F ICgxNDk0NzApOiBUaGlzIGltYWdlIGJ1ZmZlciBzaG91bGQgbm90IGJlIHVuY29uZGl0aW9uYWxs eSB1bmFjY2VsZXJhdGVkLiBNYWtpbmcgaXQgbWF0Y2ggdGhlIGNvbnRleHQgYnJlYWtzIGFscGhh IG1hc2tpbmcsIHRob3VnaC4KLSAgICAgICAgbWFza2VyRGF0YS0+bWFza0ltYWdlID0gU1ZHUmVu ZGVyaW5nQ29udGV4dDo6Y3JlYXRlSW1hZ2VCdWZmZXIocmVwYWludFJlY3QsIGFic29sdXRlVHJh bnNmb3JtLCBtYXNrQ29sb3JTcGFjZSwgUmVuZGVyaW5nTW9kZTo6VW5hY2NlbGVyYXRlZCwgY29u dGV4dCk7CisgICAgICAgIG1hc2tlckRhdGEtPm1hc2tJbWFnZSA9IFNWR1JlbmRlcmluZ0NvbnRl eHQ6OmNyZWF0ZUltYWdlQnVmZmVyKHJlcGFpbnRSZWN0LCBhYnNvbHV0ZVRyYW5zZm9ybSwgbWFz a0NvbG9yU3BhY2UsIGNvbnRleHQtPnJlbmRlcmluZ01vZGUoKSwgY29udGV4dCk7CiAgICAgICAg IGlmICghbWFza2VyRGF0YS0+bWFza0ltYWdlKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog Cg==