149457 2015-09-22 05:32:11 -0700 [CMake] Allow to enable OpenMP support. 2015-09-22 12:15:45 -0700 1 1 1 Unclassified WebKit SVG Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez achristensen commit-queue gyuyoung.kim mrobinson ossy zimmermann oldest_to_newest 1127987 0 clopez 2015-09-22 05:32:11 -0700 Revision <http://trac.webkit.org/r84911> added support for speeding up SVG Filters with OpenMP (instead of using native threads). There is currently no way to enable this with CMake system. 1127988 1 261739 clopez 2015-09-22 05:40:46 -0700 Created attachment 261739 Patch 1128023 2 achristensen 2015-09-22 10:21:25 -0700 I'm not familiar with any uses of OpenMP in WebKit. Could you give an example? 1128027 3 clopez 2015-09-22 10:45:58 -0700 (In reply to comment #2) > I'm not familiar with any uses of OpenMP in WebKit. Could you give an > example? OpenMP is used to parallelize the SVG Filters. If is not enabled, native threads will be used to parallelize the filters. 1128040 4 261739 ossy 2015-09-22 11:02:47 -0700 Comment on attachment 261739 Patch LGTM 1128074 5 261739 commit-queue 2015-09-22 12:15:39 -0700 Comment on attachment 261739 Patch Clearing flags on attachment: 261739 Committed r190126: <http://trac.webkit.org/changeset/190126> 1128075 6 commit-queue 2015-09-22 12:15:45 -0700 All reviewed patches have been landed. Closing bug. 261739 2015-09-22 05:40:46 -0700 2015-09-22 12:15:39 -0700 Patch bug-149457-20150922144029.patch text/plain 1930 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IGY2Y2FjNjZkN2VlZTk0Y2FlYjE5NGFlMTQ2MWZjNDRiY2U4MDNmOGUuLmU0MDI3MjgxNTBlNmNk OTUzZDA1YWZmOWFjYjU3N2Y1Mzk2YmMzZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0xMjQsNiArMTI0LDE1IEBAIGlmIChVTklYIEFORCBOT1QgQVBQTEUgQU5EIE5PVCBFTkFCTEVE X0NPTVBJTEVSX1NBTklUSVpFUlMpCiAgICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1Mg Ii1XbCwtLW5vLXVuZGVmaW5lZCAke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1N9IikKIGVuZGlm ICgpCiAKKyMgRW5hYmxlIHRoZSB1c2FnZSBvZiBPcGVuTVAuCisjICAtIEF0IHRoaXMgbW9tZW50 LCBPcGVuTVAgaXMgb25seSB1c2VkIGFzIGFuIGFsdGVybmF0aXZlIGltcGxlbWVudGF0aW9uCisj ICAgIHRvIG5hdGl2ZSB0aHJlYWRzIGZvciB0aGUgcGFyYWxsZWxpemF0aW9uIG9mIHRoZSBTVkcg ZmlsdGVycy4KK2lmIChVU0VfT1BFTk1QKQorICAgIGZpbmRfcGFja2FnZShPcGVuTVAgUkVRVUlS RUQpCisgICAgc2V0KENNQUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gJHtPcGVuTVBfQ19G TEFHU30iKQorICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hYX0ZMQUdTfSAke09w ZW5NUF9DWFhfRkxBR1N9IikKK2VuZGlmICgpCisKICMgR1RLIHVzZXMgdGhlIEdOVSBpbnN0YWxs YXRpb24gZGlyZWN0b3JpZXMgYXMgZGVmYXVsdHMuCiBpZiAoTk9UIFBPUlQgU1RSRVFVQUwgIkdU SyIpCiAgICAgc2V0KExJQl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxMX1BSRUZJWH0vbGli IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRvIGxpYnJhcnkgaW5zdGFsbGF0aW9uIGRpcmVj dG9yeSIpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYmI0ZjMzZjll M2NmZjcwNWYyNWE1MmM5NjJiOTQzOGI1NmZiZmI3Zi4uZjU2NDM0YzBlYTQ2NDFmMGIyYmI0NTAy ZjgzNDQwYzk1ZWM0MzcwYyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDE1LTA5LTIyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAg PGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gQWxsb3cgdG8gZW5hYmxlIE9w ZW5NUCBzdXBwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQ5NDU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZTogQWRkIHRoZSBvcHRpb24g VVNFX09QRU5NUCB0aGF0CisgICAgICAgIHdpbGwgZW5hYmxlIHRoZSBzdXBwb3J0IGZvciBPcGVu TVAuIEN1cnJlbnRseSB0aGlzIGlzIG9ubHkgdXNlZCBhcworICAgICAgICBhbiBhbHRlcm5hdGl2 ZSBpbXBsZW1lbnRhdGlvbiB0byBuYXRpdmUgdGhyZWFkcyBmb3IgdGhlIHBhcmFsbGVsaXphdGlv bgorICAgICAgICBvZiB0aGUgU1ZHIGZpbHRlcnMuIEJ1dCBuYW1lIHRoZSBvcHRpb24gd2l0aCBh IGdlbmVyaWMgbmFtZSAoVVNFX09QRU5NUCkKKyAgICAgICAgYXMgaXQgY291bGQgYmUgYWxzbyB1 c2VkIHRvIGVuYWJsZSBmdXR1cmUgZmVhdHVyZXMgdGhhdCBkZXBlbmQgb24gT3Blbk1QLgorCiAy MDE1LTA5LTIyICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgogCiAgICAg ICAgIFtFRkxdIEJ1aWxkIGJyZWFrIHdoZW4gREVWRUxPUEVSX01PREUgaXMgT0ZGCg==