149434 2015-09-21 16:35:25 -0700 The binding for getDistributedNodes unnecessarily makes a vector of nodes 2015-09-21 17:26:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 148695 1 rniwa rniwa cdumez koivisto oldest_to_newest 1127829 0 rniwa 2015-09-21 16:35:25 -0700 We shouldn't need to create a Vector<RefPtr<Node>> just so that the binding code can generate the right code. 1127838 1 261703 rniwa 2015-09-21 16:48:33 -0700 Created attachment 261703 Fixes the bug 1127841 2 261703 darin 2015-09-21 16:54:41 -0700 Comment on attachment 261703 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=261703&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:467 > +template<typename T> > +inline JSC::JSValue jsArray(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<T>* vector) > +{ > + JSC::MarkedArgumentBuffer list; > + if (vector) { > + for (auto& element : *vector) > + list.append(JSValueTraits<T>::arrayJSValue(exec, globalObject, element)); > + } > + return JSC::constructArray(exec, nullptr, globalObject, list); > +} I suggest writing this instead: template<typename T, size_t inlineCapacity> inline JSC::JSValue jsArray(JSC::ExecState* exec, JSDOMGlobalObject* globalObject, const Vector<T, inlineCapacity>* vector) { if (!vector) return JSC::constructEmptyArray(exec); return jsArray(exec, globalObject, *vector); } 1127855 3 rniwa 2015-09-21 17:26:21 -0700 Committed r190093: <http://trac.webkit.org/changeset/190093> 261703 2015-09-21 16:48:33 -0700 2015-09-21 16:54:41 -0700 Fixes the bug bug-149434-20150921164816.patch text/plain 3559 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDA4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTIxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFRoZSBiaW5kaW5nIGZvciBnZXRE aXN0cmlidXRlZE5vZGVzIHVubmVjZXNzYXJpbHkgbWFrZXMgYSB2ZWN0b3Igb2Ygbm9kZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTQzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEganNB cnJheSBmb3IgY29uc3QgVmVjdG9yPFQqPiogc28gdGhhdCB3ZSBjYW4gZ2VuZXJhdGUgdGhlIGJp bmRpbmcgY29kZSBmb3IgZ2V0RGlzdHJpYnV0ZWROb2RlcygpCisgICAgICAgIHdpdGhvdXQgaGF2 aW5nIHRvIGNyZWF0ZSBWZWN0b3I8UmVmUHRyPE5vZGU+PiBvdXQgb2YgVmVjdG9yPE5vZGUqPiou CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNv cmU6OmpzQXJyYXkpOiBBZGRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxTbG90RWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2xvdEVsZW1lbnQ6OmFzc2lnbmVkTm9kZXMpOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTFNsb3RFbGVtZW50OjpnZXREaXN0cmlidXRlZE5vZGVzKTogRGVs ZXRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxTbG90RWxlbWVudC5oOgorICAgICAgICAqIGh0bWwv SFRNTFNsb3RFbGVtZW50LmlkbDoKKwogMjAxNS0wOS0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFtKUyBCaW5kaW5nc10gcHJvdG90eXBlLmNvbnN0cnVjdG9y IHNob3VsZCBiZSB3cml0YWJsZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNE T01CaW5kaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNE T01CaW5kaW5nLmgJKHJldmlzaW9uIDE5MDA4NykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NQmluZGluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC00NTUsNiArNDU1LDE3IEBAIHRl bXBsYXRlPHR5cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2kKICAgICByZXR1cm4gSlNDOjpj b25zdHJ1Y3RBcnJheShleGVjLCBudWxscHRyLCBnbG9iYWxPYmplY3QsIGxpc3QpOwogfQogCit0 ZW1wbGF0ZTx0eXBlbmFtZSBUPgoraW5saW5lIEpTQzo6SlNWYWx1ZSBqc0FycmF5KEpTQzo6RXhl Y1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBjb25zdCBWZWN0 b3I8VD4qIHZlY3RvcikKK3sKKyAgICBKU0M6Ok1hcmtlZEFyZ3VtZW50QnVmZmVyIGxpc3Q7Cisg ICAgaWYgKHZlY3RvcikgeworICAgICAgICBmb3IgKGF1dG8mIGVsZW1lbnQgOiAqdmVjdG9yKQor ICAgICAgICAgICAgbGlzdC5hcHBlbmQoSlNWYWx1ZVRyYWl0czxUPjo6YXJyYXlKU1ZhbHVlKGV4 ZWMsIGdsb2JhbE9iamVjdCwgZWxlbWVudCkpOworICAgIH0KKyAgICByZXR1cm4gSlNDOjpjb25z dHJ1Y3RBcnJheShleGVjLCBudWxscHRyLCBnbG9iYWxPYmplY3QsIGxpc3QpOworfQorCiBXRUJD T1JFX0VYUE9SVCBKU0M6OkpTVmFsdWUganNBcnJheShKU0M6OkV4ZWNTdGF0ZSosIEpTRE9NR2xv YmFsT2JqZWN0KiwgUGFzc1JlZlB0cjxET01TdHJpbmdMaXN0Pik7CiAKIGlubGluZSBQYXNzUmVm UHRyPEpTQzo6QXJyYXlCdWZmZXJWaWV3PiB0b0FycmF5QnVmZmVyVmlldyhKU0M6OkpTVmFsdWUg dmFsdWUpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTbG90RWxlbWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2xvdEVsZW1lbnQuY3BwCShyZXZp c2lvbiAxOTAwODcpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTbG90RWxlbWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTk0LDE2ICs5NCw0IEBAIGNvbnN0IFZlY3RvcjxOb2RlKj4qIEhU TUxTbG90RWxlbWVudDo6YXMKICAgICByZXR1cm4gc2hhZG93Um9vdC0+YXNzaWduZWROb2Rlc0Zv clNsb3QoKnRoaXMpOwogfQogCi1WZWN0b3I8UmVmUHRyPE5vZGU+PiBIVE1MU2xvdEVsZW1lbnQ6 OmdldERpc3RyaWJ1dGVkTm9kZXMoKSBjb25zdAotewotICAgIFZlY3RvcjxSZWZQdHI8Tm9kZT4+ IGRpc3RyaWJ1dGVkTm9kZXM7Ci0KLSAgICBpZiAoYXV0byogYXNzaWduZWROb2RlcyA9IHRoaXMt PmFzc2lnbmVkTm9kZXMoKSkgewotICAgICAgICBmb3IgKGF1dG8qIG5vZGUgOiAqYXNzaWduZWRO b2RlcykKLSAgICAgICAgICAgIGRpc3RyaWJ1dGVkTm9kZXMuYXBwZW5kKG5vZGUpOwotICAgIH0K LQotICAgIHJldHVybiBkaXN0cmlidXRlZE5vZGVzOwotfQotCiB9CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxTbG90RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTFNsb3RFbGVtZW50LmgJKHJldmlzaW9uIDE5MDA4NykKKysrIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTFNsb3RFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTM4LDggKzM4LDYg QEAgcHVibGljOgogCiAgICAgY29uc3QgVmVjdG9yPE5vZGUqPiogYXNzaWduZWROb2RlcygpIGNv bnN0OwogCi0gICAgVmVjdG9yPFJlZlB0cjxOb2RlPj4gZ2V0RGlzdHJpYnV0ZWROb2RlcygpIGNv bnN0OwotCiBwcml2YXRlOgogICAgIEhUTUxTbG90RWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1l JiwgRG9jdW1lbnQmKTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2xvdEVsZW1l bnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNsb3RFbGVtZW50 LmlkbAkocmV2aXNpb24gMTkwMDg3KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2xvdEVs ZW1lbnQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw2IEBACiBdIGludGVyZmFjZSBI VE1MU2xvdEVsZW1lbnQgOiBIVE1MRWxlbWVudCB7CiAKICAgICBbUmVmbGVjdF0gYXR0cmlidXRl IERPTVN0cmluZyBuYW1lOwotICAgIHNlcXVlbmNlPE5vZGU+IGdldERpc3RyaWJ1dGVkTm9kZXMo KTsKKyAgICBbSW1wbGVtZW50ZWRBcz1hc3NpZ25lZE5vZGVzXSBzZXF1ZW5jZTxOb2RlPiBnZXRE aXN0cmlidXRlZE5vZGVzKCk7CiAKIH07Cg==