149424 2015-09-21 15:40:32 -0700 CSSFilterImageValue::image makes an unconditionally unaccelerated ImageBuffer 2022-01-19 12:49:12 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=235376 P2 Normal --- 1 thorton webkit-unassigned dino esprehn+autocc ews-watchlist frankhome61 glenn gyuyoung.kim macpherson menard sabouhallawa simon.fraser oldest_to_newest 1127787 0 thorton 2015-09-21 15:40:32 -0700 The ImageBuffer should inherit the accelerated bit from the context it will eventually be painted into. 1685360 1 407897 frankhome61 2020-09-03 11:22:03 -0700 Created attachment 407897 Patch 1685362 2 frankhome61 2020-09-03 11:23:43 -0700 Should just consult renderer.page().settings() to get the rendering mode setting. 1685369 3 407897 simon.fraser 2020-09-03 11:39:42 -0700 Comment on attachment 407897 Patch This seems wrong. It should only make an accelerated buffer if we know the filter chain can be rendered via Core Image. 1685377 4 frankhome61 2020-09-03 11:44:03 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 407897 [details] > Patch > > This seems wrong. It should only make an accelerated buffer if we know the > filter chain can be rendered via Core Image. Oh this has nothing to do with CoreImage, this is simply trying to address the fact that the ImageBuffer created inside CSSFilterImageValue is Unaccelerated unconditionally, and pass it on to CSSFilter. CoreImage is not involved in this process. 1685378 5 frankhome61 2020-09-03 11:45:19 -0700 (In reply to guowei_yang from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > Comment on attachment 407897 [details] > > Patch > > > > This seems wrong. It should only make an accelerated buffer if we know the > > filter chain can be rendered via Core Image. > > Oh this has nothing to do with CoreImage, this is simply trying to address > the fact that the ImageBuffer created inside CSSFilterImageValue is > Unaccelerated unconditionally, and pass it on to CSSFilter. CoreImage is not > involved in this process. P.S. this patch has nothing to do with my project, just something I spotted while looking through different files 1685379 6 frankhome61 2020-09-03 11:47:18 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 407897 [details] > Patch > > This seems wrong. It should only make an accelerated buffer if we know the > filter chain can be rendered via Core Image. Also before we introduced CoreImage into the codebase, CSSFilter::allocateBackingStoreIfNeeded() also consults renderer.page().settings() to determine which kind of ImageBuffer backend to create. So I would only assume the same procedure should happen here. 1685381 7 simon.fraser 2020-09-03 11:55:51 -0700 settings().acceleratedFiltersEnabled() was added for another platform and used to do nothing on Apple platforms. You've started to use it for the CI acceleration, which is fine. However, we know this code path (on Apple platforms) always hits the non-accelerated filter path, so we should not use this switch to make an accelerated buffer; that will slow things down. 1685382 8 frankhome61 2020-09-03 11:57:24 -0700 (In reply to Simon Fraser (smfr) from comment #7) > settings().acceleratedFiltersEnabled() was added for another platform and > used to do nothing on Apple platforms. You've started to use it for the CI > acceleration, which is fine. > > However, we know this code path (on Apple platforms) always hits the > non-accelerated filter path, so we should not use this switch to make an > accelerated buffer; that will slow things down. Oh okay. I guess this bug should be ignored then 1685383 9 frankhome61 2020-09-03 11:57:34 -0700 (In reply to guowei_yang from comment #8) > (In reply to Simon Fraser (smfr) from comment #7) > > settings().acceleratedFiltersEnabled() was added for another platform and > > used to do nothing on Apple platforms. You've started to use it for the CI > > acceleration, which is fine. > > > > However, we know this code path (on Apple platforms) always hits the > > non-accelerated filter path, so we should not use this switch to make an > > accelerated buffer; that will slow things down. > > Oh okay. I guess this bug should be ignored then "bug" 407897 2020-09-03 11:22:03 -0700 2020-09-03 13:44:07 -0700 Patch bug-149424-20200903112202.patch text/plain 1953 frankhome61 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWMxZjViYzkyNTFjNDRm ZTM5OTQ1YmJlNjkzMzUzNTNhMGFiZmJmZC4uMTExZjg5NTYyNTZkNDc5MDhlY2JkNjE2NmI1MjFm MGRhYWIyNDY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTAzICBGcmFu ayBZYW5nICA8Z3Vvd2VpX3lhbmdAYXBwbGUuY29tPgorCisgICAgICAgIENTU0ZpbHRlckltYWdl VmFsdWU6OmltYWdlIG1ha2VzIGFuIHVuY29uZGl0aW9uYWxseSB1bmFjY2VsZXJhdGVkIEltYWdl QnVmZmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDk0MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGNzcy9DU1NGaWx0ZXJJbWFnZVZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU0ZpbHRl ckltYWdlVmFsdWU6OmltYWdlKTogaW5zdGVhZCBvZiBoYXJkY29kaW5nIFJlbmRlcmluZ01vZGU6 OlVuYWNjZWxlcmF0ZWQKKyAgICAgICAgICAgIHdlIGNvbnN1bHQgcmVuZGVyZXIucGFnZSgpLnNl dHRpbmdzKCkgdG8gZ2V0IHRoZSByZW5kZXJpbmcgbW9kZS4KKwogMjAyMC0wOC0yOCAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgYWRvcHRlZCBub2Rl IGZyb20gVGV4dE1hbmlwdWxhdGlvbkNvbnRyb2xsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NGaWx0ZXJJbWFnZVZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NG aWx0ZXJJbWFnZVZhbHVlLmNwcAppbmRleCAyZmE1M2FhMzhjMWZjYzExNzM1NmFmOWYxNTVkMDE1 ZDQ0MzdmMGNlLi5iYjdmYzE0MGU2NzEzZTQzYmNjNzdiYzM0NDg0MDZiZGVhMDFkOWZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRmlsdGVySW1hZ2VWYWx1ZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU0ZpbHRlckltYWdlVmFsdWUuY3BwCkBAIC0zMyw2ICszMyw3 IEBACiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiSW1hZ2VCdWZmZXIu aCIKICNpbmNsdWRlICJSZW5kZXJFbGVtZW50LmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNp bmNsdWRlICJTdHlsZUJ1aWxkZXJTdGF0ZS5oIgogI2luY2x1ZGUgIlN0eWxlQ2FjaGVkSW1hZ2Uu aCIKICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CkBAIC0xMTUsOCArMTE2LDgg QEAgUmVmUHRyPEltYWdlPiBDU1NGaWx0ZXJJbWFnZVZhbHVlOjppbWFnZShSZW5kZXJFbGVtZW50 JiByZW5kZXJlciwgY29uc3QgRmxvYXRTaXoKICAgICAgICAgcmV0dXJuICZJbWFnZTo6bnVsbElt YWdlKCk7CiAKICAgICAvLyBUcmFuc2Zvcm0gSW1hZ2UgaW50byBJbWFnZUJ1ZmZlci4KLSAgICAv LyBGSVhNRSAoMTQ5NDI0KTogVGhpcyBidWZmZXIgc2hvdWxkIG5vdCBiZSB1bmNvbmRpdGlvbmFs bHkgdW5hY2NlbGVyYXRlZC4KLSAgICBhdXRvIHRleHR1cmUgPSBJbWFnZUJ1ZmZlcjo6Y3JlYXRl KHNpemUsIFJlbmRlcmluZ01vZGU6OlVuYWNjZWxlcmF0ZWQpOworICAgIGF1dG8gdGV4dHVyZSA9 IEltYWdlQnVmZmVyOjpjcmVhdGUoc2l6ZSwgcmVuZGVyZXIucGFnZSgpLnNldHRpbmdzKCkuYWNj ZWxlcmF0ZWRGaWx0ZXJzRW5hYmxlZCgpID8KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBSZW5kZXJpbmdNb2RlOjpBY2NlbGVyYXRlZCA6IFJlbmRlcmluZ01vZGU6OlVu YWNjZWxlcmF0ZWQpOwogICAgIGlmICghdGV4dHVyZSkKICAgICAgICAgcmV0dXJuICZJbWFnZTo6 bnVsbEltYWdlKCk7CiAK