149415 2015-09-21 14:01:06 -0700 REGRESSION (r182648): UIWebView does not set location.hash synchronously 2015-09-21 20:06:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap andersca commit-queue darin eoconnor joepeck mitz sam oldest_to_newest 1127754 0 ap 2015-09-21 14:01:06 -0700 <rdar://problem/22169467> 1127756 1 261684 ap 2015-09-21 14:07:14 -0700 Created attachment 261684 proposed fix 1127826 2 darin 2015-09-21 16:33:52 -0700 Is there some way to regression-test this? 1127850 3 261684 commit-queue 2015-09-21 17:21:41 -0700 Comment on attachment 261684 proposed fix Clearing flags on attachment: 261684 Committed r190092: <http://trac.webkit.org/changeset/190092> 1127851 4 commit-queue 2015-09-21 17:21:45 -0700 All reviewed patches have been landed. Closing bug. 1127858 5 ap 2015-09-21 17:40:39 -0700 I'm looking into what's going on with a test. There is already one that should cover this, but it doesn't fail for some reason, still not sure why. 1127859 6 ap 2015-09-21 17:51:23 -0700 It's because the bug would only occur when processing a user gesture. 1127866 7 ap 2015-09-21 18:07:52 -0700 EventSender is not implemented on iOS for WebKit2, but it is for WebKit1, which happens to be what we need. 1127867 8 261709 ap 2015-09-21 18:08:45 -0700 Created attachment 261709 adding a test 1127907 9 261709 commit-queue 2015-09-21 20:06:23 -0700 Comment on attachment 261709 adding a test Clearing flags on attachment: 261709 Committed r190100: <http://trac.webkit.org/changeset/190100> 1127908 10 commit-queue 2015-09-21 20:06:28 -0700 All reviewed patches have been landed. Closing bug. 261684 2015-09-21 14:07:14 -0700 2015-09-21 17:21:41 -0700 proposed fix AppLinks.txt text/plain 1641 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDA3OCkKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTA5LTIx ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04gKHIxODI2NDgpOiBVSVdlYlZpZXcgZG9lcyBub3Qgc2V0IGxvY2F0aW9uLmhhc2ggc3luY2hy b25vdXNseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ5NDE1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMjE2OTQ2Nz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSB3YXMgdGhhdCB0 aGUgZGVsZWdhdGUgaW4gVUkgdGhyZWFkIGJlY2FtZSBhc3luY2hyb25vdXMgZHVlIHRvIGNhbGxp bmcKKyAgICAgICAgaW50byBMYXVuY2hTZXJ2aWNlcy4KKworICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tOiAoc2hvdWxkVHJ5QXBwTGluayk6IERvbid0IGF0 dGVtcHQgYXBwCisgICAgICAgIGxpbmtzIGZvciBzYW1lIGRvbWFpbiBuYXZpZ2F0aW9ucy4gVGhp cyBjaGVjayBpcyBwYXJ0IG9mIHN1YnN0YW50aWFsbHkgbW9yZSBjb21wbGljYXRlZAorICAgICAg ICBsb2dpYyBpbiBXZWJLaXQyIHRoYXQgSSBkb24ndCB1bmRlcnN0YW5kLCBidXQgdGhhdCBzaG91 bGQgYmUgZW5vdWdoIHRvIGRlbW9uc3RyYXRlCisgICAgICAgIHRoYXQgdGhpcyBmaXggaXMgYW4g aW1wcm92ZW1lbnQgYXQgbGVhc3QuCisKIDIwMTUtMDktMjAgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBSZW1vdmUgWEhSX1RJTUVPVVQgY29t cGlsYXRpb24gZ3VhcmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dl YkZyYW1lTG9hZGVyQ2xpZW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dl YkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tCShyZXZpc2lvbiAxOTAwMzQpCisr KyBTb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5t bQkod29ya2luZyBjb3B5KQpAQCAtODg2LDYgKzg4Niw5IEBAIHN0YXRpYyBCT09MIHNob3VsZFRy eUFwcExpbmsoV2ViVmlldyAqd2UKICAgICBpZiAoIWFjdGlvbi5wcm9jZXNzaW5nVXNlckdlc3R1 cmUoKSkKICAgICAgICAgcmV0dXJuIE5POwogCisgICAgaWYgKHRhcmdldEZyYW1lICYmIHRhcmdl dEZyYW1lLT5kb2N1bWVudCgpICYmIHByb3RvY29sSG9zdEFuZFBvcnRBcmVFcXVhbCh0YXJnZXRG cmFtZS0+ZG9jdW1lbnQoKS0+dXJsKCksIGFjdGlvbi51cmwoKSkpCisgICAgICAgIHJldHVybiBO TzsKKwogICAgIHJldHVybiBZRVM7CiAjZWxzZQogICAgIHJldHVybiBOTzsK 261709 2015-09-21 18:08:45 -0700 2015-09-21 20:06:23 -0700 adding a test AppLinksTest.txt text/plain 3136 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MDA5NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTIxICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDk0MTUKKyAgICAgICAgUkVHUkVTU0lPTiAocjE4MjY0OCk6IFVJV2Vi VmlldyBkb2VzIG5vdCBzZXQgbG9jYXRpb24uaGFzaCBzeW5jaHJvbm91c2x5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yMjE2OTQ2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGZhc3QvbG9hZGVyL2xvY2F0aW9uLWhhc2gtdXNlci1nZXN0dXJl LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIvbG9jYXRpb24taGFz aC11c2VyLWdlc3R1cmUuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vaW9zLXNpbXVs YXRvci13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNS0wOS0yMSAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtKUyBCaW5kaW5nc10gcHJvdG90eXBlLmNvbnN0 cnVjdG9yIHNob3VsZCBiZSB3cml0YWJsZQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIv bG9jYXRpb24taGFzaC11c2VyLWdlc3R1cmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvbG9hZGVyL2xvY2F0aW9uLWhhc2gtdXNlci1nZXN0dXJlLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2xvY2F0aW9uLWhh c2gtdXNlci1nZXN0dXJlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEw IEBACitUZXN0IHRoYXQgbG9jYXRpb24uaGFzaCBpcyBzZXQgc3luY2hyb25vdXNseSBldmVuIHdo ZW4gaGFuZGxpbmcgYSB1c2VyIGdlc3R1cmUgKHNlZSBidWcgMTQ5NDE1KS4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgbG9jYXRpb24uaGFzaCBpcyAnI3gnCitQQVNTIHN1 Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9sb2FkZXIvbG9jYXRpb24taGFzaC11c2VyLWdlc3R1cmUuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9sb2NhdGlvbi1oYXNoLXVzZXItZ2VzdHVy ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvbG9jYXRpb24t aGFzaC11c2VyLWdlc3R1cmUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQwIEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbigiVGVzdCB0aGF0IGxvY2F0aW9uLmhh c2ggaXMgc2V0IHN5bmNocm9ub3VzbHkgZXZlbiB3aGVuIGhhbmRsaW5nIGEgdXNlciBnZXN0dXJl IChzZWUgYnVnIDE0OTQxNSkuIik7CisKK2pzVGVzdElzQXN5bmMgPSB0cnVlOworCitmdW5jdGlv biB0ZXN0KCkKK3sKKyAgICBsb2NhdGlvbi5oYXNoID0gIngiOworICAgIHNob3VsZEJlKCJsb2Nh dGlvbi5oYXNoIiwgIicjeCciKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KKworZnVuY3Rpb24g Y2xpY2tPbihlbGVtZW50KQoreworICAgIGlmICghd2luZG93LmV2ZW50U2VuZGVyKQorICAgICAg ICByZXR1cm47CisgICAgdmFyIHJlY3QgPSBlbGVtZW50LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgp OworICAgIHZhciB4ID0gcmVjdC5sZWZ0ICsgcmVjdC53aWR0aCAvIDI7CisgICAgdmFyIHkgPSBy ZWN0LnRvcCArIHJlY3QuaGVpZ2h0IC8gMjsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4 LCB5KTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3Vz ZVVwKCk7Cit9CisKK29ubG9hZCA9IGZ1bmN0aW9uKCkgeworICAgIGNsaWNrT24oZG9jdW1lbnQu Z2V0RWxlbWVudHNCeVRhZ05hbWUoImJ1dHRvbiIpWzBdKTsKK30KKworPC9zY3JpcHQ+Cis8YnV0 dG9uIG9uY2xpY2s9InRlc3QoKSI+PC9idXR0b24+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3Itd2syL1Rlc3RF eHBlY3RhdGlvbnMJKHJldmlzaW9uIDE5MDAzNCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2lv cy1zaW11bGF0b3Itd2syL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTIwNTIs MyArMjA1Miw2IEBAIHdlYmtpdC5vcmcvYi8xNDg3MDkgZmFzdC9ldmVudHMvd2hlZWxldmUKIHdl YmtpdC5vcmcvYi8xNDg3MDkgZmFzdC9ldmVudHMvd2hlZWxldmVudC1tb3VzZXdoZWVsLWludGVy YWN0aW9uLmh0bWwgWyBTa2lwIF0KIAogd2Via2l0Lm9yZy9iLzEyMzQzMSBodHRwL3Rlc3RzL2Nz cy9saW5rLWNzcy1kaXNhYmxlZC12YWx1ZS13aXRoLXNsb3ctbG9hZGluZy1zaGVldC5odG1sIFsg UGFzcyBGYWlsdXJlIF0KKworIyBldmVudFNlbmRlci5tb3VzZURvd24gaXMgbm90IGltcGxlbWVu dGVkCitmYXN0L2xvYWRlci9sb2NhdGlvbi1oYXNoLXVzZXItZ2VzdHVyZS5odG1sIFsgU2tpcCBd Cg==