149406 2015-09-21 07:47:36 -0700 Fix warnings in IDLParser.pm 2022-08-19 16:49:27 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cdumez mcatanzaro ossy sam oldest_to_newest 1127638 0 ossy 2015-09-21 07:47:36 -0700 There are many warnings come from IDLParser.pm because of using uninitialized value in regexps: Use of uninitialized value $type in pattern match (m//) at /home/ossy/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 303. Use of uninitialized value $type in substitution (s///) at /home/ossy/WebKit/Source/WebCore/bindings/scripts/IDLParser.pm line 309. 1127639 1 261655 ossy 2015-09-21 07:49:35 -0700 Created attachment 261655 Patch 1127813 2 261655 achristensen 2015-09-21 16:22:22 -0700 Comment on attachment 261655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261655&action=review r=me with nit > Source/WebCore/bindings/scripts/IDLParser.pm:311 > + } This needs another space of indentation. 1127966 3 ossy 2015-09-22 02:24:25 -0700 (In reply to comment #2) > Comment on attachment 261655 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261655&action=review > > r=me with nit > > > Source/WebCore/bindings/scripts/IDLParser.pm:311 > > + } > > This needs another space of indentation. Good catch, I'll fix it before landing. 1127967 4 ossy 2015-09-22 02:32:34 -0700 Committed r190111: <http://trac.webkit.org/changeset/190111> 1128198 5 261655 cdumez 2015-09-22 18:55:24 -0700 Comment on attachment 261655 Patch This looks like this may be papering over a real bug. How can an attribute or parameter not have a type? 1128199 6 cdumez 2015-09-22 19:02:59 -0700 It looks like the parser has trouble parsing: [Unscopeable, RaisesException, Custom] void prepend((Node or DOMString)... nodes); [Unscopeable, RaisesException, Custom] void append((Node or DOMString)... nodes); in ParentNode.idl and [Unscopeable, RaisesException, Custom] void before((Node or DOMString)... nodes); [Unscopeable, RaisesException, Custom] void after((Node or DOMString)... nodes); [Unscopeable, RaisesException, Custom] void replaceWith((Node or DOMString)... nodes); in ChildNode.idl Likely the issue is that our parser does not support unions or variadic arguments. Thankfully, even though the parser does not parse them properly, it does not cause problems because we use Custom bindings for these. The proper fix would be to add support for these type of parameters to our IDL parser. 1128200 7 cdumez 2015-09-22 19:05:22 -0700 FYI, the problem is unions (Node or DOMString). Variadic parameters seem to be fine. 1128987 8 ossy 2015-09-28 02:51:56 -0700 (In reply to comment #7) > FYI, the problem is unions (Node or DOMString). Variadic parameters seem to > be fine. Could you file a new bug report for this issue? 1892557 9 ap 2022-08-19 16:49:27 -0700 *** Bug 147132 has been marked as a duplicate of this bug. *** 261655 2015-09-21 07:49:35 -0700 2015-09-21 16:22:22 -0700 Patch bug-149406-20150921164918.patch text/plain 1328 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDllOThhOWFlODM1MzIw ZDE0YzQ1MWUzMzJlOTBhOGE1NmYzYmZhNC4uZDAxYWNhMjRhOThiMzQwZWQ5NjRmY2JjZTc4ZTMz M2EyZDY5YThmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA5LTIxICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHdhcm5pbmdz IGluIElETFBhcnNlci5wbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTQ5NDA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbToKKyAgICAgICAgKHR5cGVI YXNOdWxsYWJsZVN1ZmZpeCk6CisgICAgICAgICh0eXBlUmVtb3ZlTnVsbGFibGVTdWZmaXgpOgor CiAyMDE1LTA5LTIxICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4K IAogICAgICAgICBbR1RLXSBtZWRpYSBjb250cm9scyBkb2VzIG5vdCBzaG93IHVwIHdoZW4gcGxh eWluZyB2aWRlbyBmaW5pc2hlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvSURMUGFyc2VyLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9J RExQYXJzZXIucG0KaW5kZXggMjkyYTNlZDE5ZGViYWZiOTFjNjkzYmIyNjZmZTQ1ZGEyOGMzNWQx Mi4uN2Q4Mzk1NDQ1YzE4MzQxYzdjOTIzNzZmZDZiM2JhZGEzNGU4MGIyMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG0KQEAgLTMwMCwxMyArMzAwLDE1 IEBAIHN1YiB1bnF1b3RlU3RyaW5nCiBzdWIgdHlwZUhhc051bGxhYmxlU3VmZml4CiB7CiAgICAg bXkgJHR5cGUgPSBzaGlmdDsKLSAgICByZXR1cm4gJHR5cGUgPX4gL1w/JC87CisgICAgcmV0dXJu ICR0eXBlID8gJHR5cGUgPX4gL1w/JC8gOiAwOwogfQogCiBzdWIgdHlwZVJlbW92ZU51bGxhYmxl U3VmZml4CiB7CiAgICAgbXkgJHR5cGUgPSBzaGlmdDsKLSAgICAkdHlwZSA9fiBzL1w/Ly9nOwor ICAgIGlmICgkdHlwZSkgeworICAgICAgICAkdHlwZSA9fiBzL1w/Ly9nOworICAgfQogICAgIHJl dHVybiAkdHlwZTsKIH0KIAo=