149400 2015-09-21 03:33:53 -0700 Fix the !ENABLE(TEMPLATE_ELEMENT) build after r189945 2015-09-21 12:16:18 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149286 1 ossy ossy commit-queue darin gyuyoung.kim kling koivisto oldest_to_newest 1127613 0 ossy 2015-09-21 03:33:53 -0700 https://trac.webkit.org/changeset/189945/trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp updated only the ENABLE(TEMPLATE_ELEMENT) case, but we should update the else case too. build log: ----------- ../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp: In member function 'void WebCore::XMLDocumentParser::startElementNs(const xmlChar*, const xmlChar*, const xmlChar*, int, const xmlChar**, int, int, const xmlChar**)': ../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:856:37: error: no matching function for call to 'WebCore::XMLDocumentParser::pushCurrentNode(WebCore::Element&)' ../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:856:37: note: candidate is: In file included from ../../Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:29:0: ../../Source/WebCore/xml/parser/XMLDocumentParser.h:143:14: note: void WebCore::XMLDocumentParser::pushCurrentNode(WebCore::ContainerNode*) ../../Source/WebCore/xml/parser/XMLDocumentParser.h:143:14: note: no known conversion for argument 1 from 'WebCore::Element' to 'WebCore::ContainerNode*' 1127614 1 261644 ossy 2015-09-21 03:34:59 -0700 Created attachment 261644 Patch 1127715 2 261644 commit-queue 2015-09-21 12:16:14 -0700 Comment on attachment 261644 Patch Clearing flags on attachment: 261644 Committed r190068: <http://trac.webkit.org/changeset/190068> 1127716 3 commit-queue 2015-09-21 12:16:18 -0700 All reviewed patches have been landed. Closing bug. 261644 2015-09-21 03:34:59 -0700 2015-09-21 12:16:14 -0700 Patch bug-149400-20150921033442.patch text/plain 1361 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDllOThhOWFlODM1MzIw ZDE0YzQ1MWUzMzJlOTBhOGE1NmYzYmZhNC4uYmU1OWY5MjlhYzg4MTAxOTgzMzU3ZDczMzRlOTg4 YWJmMjA4NmI5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTIxICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFRFTVBMQVRFX0VMRU1FTlQpIGJ1aWxkIGFmdGVyIHIxODk5NDUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTQwMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogeG1sL3BhcnNlci9YTUxEb2N1bWVu dFBhcnNlckxpYnhtbDIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MRG9jdW1lbnRQYXJzZXI6 OnN0YXJ0RWxlbWVudE5zKToKKwogMjAxNS0wOS0yMSAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdzZW9r Lm9oQGNvbGxhYm9yYS5jb20+CiAKICAgICAgICAgW0dUS10gbWVkaWEgY29udHJvbHMgZG9lcyBu b3Qgc2hvdyB1cCB3aGVuIHBsYXlpbmcgdmlkZW8gZmluaXNoZXMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2VyTGlieG1sMi5jcHAKaW5kZXgg YTlmZTA0OTc3MzUwMTE4ZTA1YTY2ZWEyYjA5NWY0Y2FkMmI3MjJjNi4uZGE2MWI5NGI2ZTM4YjBm NDM3NWNmMWE2MTU1MDNkNzg1OTc0M2MzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1s L3BhcnNlci9YTUxEb2N1bWVudFBhcnNlckxpYnhtbDIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyLmNwcApAQCAtODUzLDcgKzg1Myw3 IEBAIHZvaWQgWE1MRG9jdW1lbnRQYXJzZXI6OnN0YXJ0RWxlbWVudE5zKGNvbnN0IHhtbENoYXIq IHhtbExvY2FsTmFtZSwgY29uc3QgeG1sQ2hhCiAgICAgZWxzZQogICAgICAgICBwdXNoQ3VycmVu dE5vZGUobmV3RWxlbWVudC5wdHIoKSk7CiAjZWxzZQotICAgIHB1c2hDdXJyZW50Tm9kZShuZXdF bGVtZW50LmdldCgpKTsKKyAgICBwdXNoQ3VycmVudE5vZGUobmV3RWxlbWVudC5wdHIoKSk7CiAj ZW5kaWYKIAogICAgIGlmIChpczxIVE1MSHRtbEVsZW1lbnQ+KG5ld0VsZW1lbnQpKQo=