149391 2015-09-20 14:13:37 -0700 WebKitTestRunner can leak user content script results between tests 2015-09-20 17:29:03 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton oldest_to_newest 1127520 0 ap 2015-09-20 14:13:37 -0700 WebKitTestRunner removes user content before starting a new test. But this means that user content scripts run in about:blank that is loaded between tests, and can produce output. They can even install timers that will run when WKTR thinks that it's already running a new test. 1127521 1 ap 2015-09-20 14:14:48 -0700 Steps to reproduce: run these tests in order, in a single process: userscripts/window-onerror-for-isolated-world-1.html userscripts/window-onerror-for-isolated-world-2.html webgl/1.0.2/conformance/glsl/literals/float_literal.vert.html 1127522 2 261613 ap 2015-09-20 14:17:08 -0700 Created attachment 261613 proposed fix 1127541 3 261613 commit-queue 2015-09-20 17:29:00 -0700 Comment on attachment 261613 proposed fix Clearing flags on attachment: 261613 Committed r190035: <http://trac.webkit.org/changeset/190035> 1127542 4 commit-queue 2015-09-20 17:29:03 -0700 All reviewed patches have been landed. Closing bug. 261613 2015-09-20 14:17:08 -0700 2015-09-20 17:29:00 -0700 proposed fix UserContent.txt text/plain 2420 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MDAzMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTA5LTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgY2FuIGxlYWsgdXNlciBjb250ZW50IHNjcmlw dCByZXN1bHRzIGJldHdlZW4gdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0OTM5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1vdmUgV0tCdW5kbGVQYWdlUmVtb3ZlQWxsVXNlckNvbnRlbnQgY2Fs bCBzbyB0aGF0IGl0J3MgZXhlY3V0ZWQgYmVmb3JlIGxvYWRpbmcKKyAgICAgICAgYWJvdXQ6Ymxh bmssIGFuZCB0aHVzIGFib3V0OmJsYW5rIGRvZXNuJ3QgaGF2ZSB1bmludGVuZGVkIHNpZGUgZWZm ZWN0cy4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGUuY3BwOgorICAgICAgICAoV1RSOjpJbmplY3RlZEJ1bmRsZTo6YmVnaW5UZXN0aW5n KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVu ZGxlUGFnZS5jcHA6CisgICAgICAgIChXVFI6OkluamVjdGVkQnVuZGxlUGFnZTo6cmVzZXRBZnRl clRlc3QpOgorCiAyMDE1LTA5LTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgogCiAgICAgICAgIFtNYWMsIGlPU10gQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIgZG9lc24ndCB1 bmluc3RhbGwgZ2xvYmFsIG5vdGlmaWNhdGlvbiBoYW5kbGVyCkluZGV4OiBUb29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNw cAkocmV2aXNpb24gMTkwMDMxKQorKysgVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4MSw4ICsyODEsNiBA QCB2b2lkIEluamVjdGVkQnVuZGxlOjpiZWdpblRlc3RpbmcoV0tEaWN0CiAgICAgV0tCdW5kbGVT ZXRQbHVnaW5zRW5hYmxlZChtX2J1bmRsZSwgbV9wYWdlR3JvdXAsIHRydWUpOwogICAgIFdLQnVu ZGxlU2V0UG9wdXBCbG9ja2luZ0VuYWJsZWQobV9idW5kbGUsIG1fcGFnZUdyb3VwLCBmYWxzZSk7 CiAKLSAgICBXS0J1bmRsZVBhZ2VSZW1vdmVBbGxVc2VyQ29udGVudChwYWdlKCktPnBhZ2UoKSk7 Ci0KICNpZiBQTEFURk9STShJT1MpCiAgICAgV0tCdW5kbGVQYWdlU2V0VXNlVGVzdGluZ1ZpZXdw b3J0Q29uZmlndXJhdGlvbihwYWdlKCktPnBhZ2UoKSwgIWJvb2xlYW5Gb3JLZXkoc2V0dGluZ3Ms ICJVc2VGbGV4aWJsZVZpZXdwb3J0IikpOwogI2VuZGlmCkluZGV4OiBUb29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBh Z2UuY3BwCShyZXZpc2lvbiAxOTAwMzEpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyNyw2 ICs0MjcsOSBAQCB2b2lkIEluamVjdGVkQnVuZGxlUGFnZTo6cmVzZXRBZnRlclRlc3QoCiAgICAg SlNHbG9iYWxDb250ZXh0UmVmIGNvbnRleHQgPSBXS0J1bmRsZUZyYW1lR2V0SmF2YVNjcmlwdENv bnRleHQoZnJhbWUpOwogICAgIFdlYkNvcmVUZXN0U3VwcG9ydDo6cmVzZXRJbnRlcm5hbHNPYmpl Y3QoY29udGV4dCk7CiAgICAgYXNzaWduZWRVcmxzQ2FjaGUuY2xlYXIoKTsKKworICAgIC8vIFVz ZXIgc2NyaXB0cyBuZWVkIHRvIGJlIHJlbW92ZWQgYWZ0ZXIgdGhlIHRlc3QgYW5kIGJlZm9yZSBs b2FkaW5nIGFib3V0OmJsYW5rLCBhcyBvdGhlcndpc2UgdGhleSB3b3VsZCBydW4gaW4gYWJvdXQ6 YmxhbmssIGFuZCBwb3RlbnRpYWxseSBsZWFrIHJlc3VsdHMgaW50byBhIHN1YnNlcXVlc3QgdGVz dC4KKyAgICBXS0J1bmRsZVBhZ2VSZW1vdmVBbGxVc2VyQ29udGVudChtX3BhZ2UpOwogfQogCiAv LyBMb2FkZXIgQ2xpZW50IENhbGxiYWNrcwo=