149390 2015-09-20 14:00:34 -0700 Web Inspector: requestAnimationFrame continues to be called after stopping the timeline recording 2015-09-21 09:30:44 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1127517 0 mattbaker 2015-09-20 14:00:34 -0700 * SUMMARY requestAnimationFrame continues to be called after stopping the timeline recording. This only happens if no records are added to the recording. * STEPS TO REPRODUCE 1. Open Inspector > Timelines 2. Inspect the Inspector 3. Set a logging breakpoint in TimelineRecordingContentView's _update method. 4. Press 'Start Recording' button (don't reload Inspected page) 5. Don't take any actions on inspected page (don't generate any timeline records) 6. Stop recording => Update messages continue to be logged to the console in Inspector² * NOTES TimelineRecordingContentView correctly sets "_updating" to false, but the animation frame callback will continue to self register until the recording start time is >= the end time. Since no records were added to the recording, the end time is NaN and the test always fails. 1127518 1 webkit-bug-importer 2015-09-20 14:00:56 -0700 <rdar://problem/22774849> 1127519 2 261612 mattbaker 2015-09-20 14:05:26 -0700 Created attachment 261612 [Patch] Proposed Fix 1127644 3 261612 bburg 2015-09-21 08:43:12 -0700 Comment on attachment 261612 [Patch] Proposed Fix r=me 1127653 4 261612 commit-queue 2015-09-21 09:30:41 -0700 Comment on attachment 261612 [Patch] Proposed Fix Clearing flags on attachment: 261612 Committed r190058: <http://trac.webkit.org/changeset/190058> 1127654 5 commit-queue 2015-09-21 09:30:44 -0700 All reviewed patches have been landed. Closing bug. 261612 2015-09-20 14:05:26 -0700 2015-09-21 09:30:41 -0700 [Patch] Proposed Fix bug-149390-20150920140510.patch text/plain 1959 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy Y2YzYWUwMGU5M2U0YzNlYzdmNjcxNWZkNjNmZWI4MTUyZjI4NTViLi4wOTc5NzkyZWYxMjYxY2Jj ZTdmMDYyMTg3M2E3MTU4YWY3ZDcwMDZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNS0wOS0yMCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVxdWVzdEFuaW1hdGlvbkZyYW1lIGNvbnRpbnVl cyB0byBiZSBjYWxsZWQgYWZ0ZXIgc3RvcHBpbmcgdGhlIHRpbWVsaW5lIHJlY29yZGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MzkwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZSk6 CisgICAgICAgIFN0b3AgY2FsbGluZyByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgaWYgdGhpcy5fdXBk YXRpbmcgaXMgZmFsc2UgYW5kIHJlY29yZGluZyBlbmQgdGltZSBpcyBOYU4uCisKIDIwMTUtMDkt MTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBTaW1wbGlmeSBzb21lIGZ1bmN0aW9uYWwgY2FsbGJhY2tzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29y ZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwppbmRleCBmZDIwMmRkMmQwZjBh YjMxNjY1ZDlmNmY0YTgxN2YzMWJlOTM0NDVlLi41NjI2ZThmNjdmMTcxMDQ1MjliNTZjMzQ3YWQ2 ZTBkNzZmZTI0ZGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcuanMKQEAgLTQwMiw4ICs0MDIsOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRp bmdDb250ZW50VmlldyA9IGNsYXNzIFRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgZQogCiAg ICAgICAgIHRoaXMuX3VwZGF0ZVRpbWVzKHN0YXJ0VGltZSwgY3VycmVudFRpbWUsIGVuZFRpbWUp OwogCi0gICAgICAgIC8vIE9ubHkgc3RvcCB1cGRhdGluZyBpZiB0aGUgY3VycmVudCB0aW1lIGlz IGdyZWF0ZXIgdGhhbiB0aGUgZW5kIHRpbWUuCi0gICAgICAgIGlmICghdGhpcy5fdXBkYXRpbmcg JiYgY3VycmVudFRpbWUgPj0gZW5kVGltZSkgeworICAgICAgICAvLyBPbmx5IHN0b3AgdXBkYXRp bmcgaWYgdGhlIGN1cnJlbnQgdGltZSBpcyBncmVhdGVyIHRoYW4gdGhlIGVuZCB0aW1lLCBvciB0 aGUgZW5kIHRpbWUgaXMgTmFOLgorICAgICAgICAvLyBUaGUgcmVjb3JkaW5nIGVuZCB0aW1lIHdp bGwgYmUgTmFOIGlmIG5vIHJlY29yZHMgd2VyZSBhZGRlZC4KKyAgICAgICAgaWYgKCF0aGlzLl91 cGRhdGluZyAmJiAoY3VycmVudFRpbWUgPj0gZW5kVGltZSB8fCBpc05hTihlbmRUaW1lKSkpIHsK ICAgICAgICAgICAgIHRoaXMuX2xhc3RVcGRhdGVUaW1lc3RhbXAgPSBOYU47CiAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0K