149389 2015-09-20 12:24:25 -0700 [OS X] Update for Xcode 7.0 on Yosemite 2015-09-23 22:21:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield ap ap commit-queue mitz ysuzuki oldest_to_newest 1127510 0 mmaxfield 2015-09-20 12:24:25 -0700 [OS X] Update for Xcode 7.0 on Yosemite 1127511 1 261610 mmaxfield 2015-09-20 12:25:58 -0700 Created attachment 261610 Patch 1127512 2 261610 ap 2015-09-20 12:47:47 -0700 Comment on attachment 261610 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261610&action=review > Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:56 > -#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 > @property (readonly) NSSpringLoadingHighlight springLoadingHighlight; > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100 springLoadingHighlight doesn't exist in NSDraggingInfo before El Capitan, so we shouldn't forward have on previous OS versions. Could you please clarify what the problem is (perhaps e-mail me the full build log)? Are you building for Yosemite using El Capitan SDK? > Tools/DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:57 > - (void)resetSpringLoading; Whatever we do, springLoadingHighlight and resetSpringLoading should be handled uniformly. 1127669 3 261664 ap 2015-09-21 10:51:12 -0700 Created attachment 261664 proposed fix Discussed this with Mitz, who explained that the problem is that Xcode 7 for Yosemite ships with 10.11 SDK. 1127695 4 261664 mitz 2015-09-21 11:55:07 -0700 Comment on attachment 261664 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=261664&action=review > Tools/ChangeLog:15 > + dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately). Seems OK for test code. 1127723 5 261664 commit-queue 2015-09-21 12:43:31 -0700 Comment on attachment 261664 proposed fix Clearing flags on attachment: 261664 Committed r190070: <http://trac.webkit.org/changeset/190070> 1127724 6 commit-queue 2015-09-21 12:43:35 -0700 All reviewed patches have been landed. Closing bug. 1128441 7 ap 2015-09-23 22:21:51 -0700 *** Bug 149357 has been marked as a duplicate of this bug. *** 261610 2015-09-20 12:25:58 -0700 2015-09-21 10:51:12 -0700 Patch bug-149389-20150920122543.patch text/plain 2335 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwMDMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTk5MTAxMTdmMjY5NzBmZmY2NDk2MGYxOTgyMzk4Mzlm NGYzNTE1MS4uZjRmNmIyZWQ1ZjBjMzJlOTIwMTVmYjViM2Q2YjM2ZmFiY2FmYjY1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA5LTIwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgW09TIFhdIFVwZGF0ZSBmb3IgWGNvZGUgNy4wIG9uIFlvc2VtaXRlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkzODkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBvbmx5 IGEgc2luZ2xlIGJ1aWxkIGVycm9yIHdoZW4gdXNpbmcgWGNvZGUgNzoKKyAgICAgICAgImF1dG8g cHJvcGVydHkgc3ludGhlc2lzIHdpbGwgbm90IHN5bnRoZXNpemUgcHJvcGVydHkgJ3NwcmluZ0xv YWRpbmdIaWdobGlnaHQnCisgICAgICAgIGRlY2xhcmVkIGluIHByb3RvY29sICdOU0RyYWdnaW5n SW5mbyciCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWVEcmFn Z2luZ0luZm8uaDoKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL21hYy9XZWJLaXRUZXN0UnVu bmVyRHJhZ2dpbmdJbmZvLmg6CisKIDIwMTUtMDktMjAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxh cEBhcHBsZS5jb20+CiAKICAgICAgICAgW01hYywgaU9TXSBBY2Nlc3NpYmlsaXR5Q29udHJvbGxl ciBkb2Vzbid0IHVuaW5zdGFsbCBnbG9iYWwgbm90aWZpY2F0aW9uIGhhbmRsZXIKZGlmZiAtLWdp dCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZURyYWdnaW5nSW5mby5o IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlRHJhZ2dpbmdJbmZvLmgK aW5kZXggYjRlMTNlYTdlYzQ4OWE4OWQ1MTJmNDU5NWRlMTAwNGQ3ZmJkZTE4Mi4uNmZlOWE3Mzc2 OWE1YWQ4YWVkMWQ0YTcxZTJlZjgyOTdlNzkwZGI2OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlRHJhZ2dpbmdJbmZvLmgKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlRHJhZ2dpbmdJbmZvLmgKQEAgLTUyLDggKzUy LDggQEAgQHByaXZhdGUKIC0gKHZvaWQpc2xpZGVEcmFnZ2VkSW1hZ2VUbzooTlNQb2ludClzY3Jl ZW5Qb2ludDsKIC0gKE5TQXJyYXkgKiluYW1lc09mUHJvbWlzZWRGaWxlc0Ryb3BwZWRBdERlc3Rp bmF0aW9uOihOU1VSTCAqKWRyb3BEZXN0aW5hdGlvbjsKIAotI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwCiBAcHJvcGVydHkgKHJlYWRvbmx5KSBOU1NwcmluZ0xv YWRpbmdIaWdobGlnaHQgc3ByaW5nTG9hZGluZ0hpZ2hsaWdodDsKKyNpZiBfX01BQ19PU19YX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTEwMAogLSAodm9pZClyZXNldFNwcmluZ0xvYWRpbmc7 CiAjZW5kaWYKIEBlbmQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1dl YktpdFRlc3RSdW5uZXJEcmFnZ2luZ0luZm8uaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFj L1dlYktpdFRlc3RSdW5uZXJEcmFnZ2luZ0luZm8uaAppbmRleCAxNzAwMjBlMzAwNzI0MDY3YjBi MmRiMDRkNGY3Mzc1OGZmOTM1MWQxLi5jNzk3ZDdiMTQ5NjRhZGU4NjE3Nzg3ZTM5OWVhNzE5N2Zm MjQ0YTlhIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9XZWJLaXRUZXN0 UnVubmVyRHJhZ2dpbmdJbmZvLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvV2Vi S2l0VGVzdFJ1bm5lckRyYWdnaW5nSW5mby5oCkBAIC00NSw4ICs0NSw4IEBAIEBwcml2YXRlCiAt ICh2b2lkKXNsaWRlRHJhZ2dlZEltYWdlVG86KE5TUG9pbnQpc2NyZWVuUG9pbnQ7CiAtIChOU0Fy cmF5ICopbmFtZXNPZlByb21pc2VkRmlsZXNEcm9wcGVkQXREZXN0aW5hdGlvbjooTlNVUkwgKilk cm9wRGVzdGluYXRpb247CiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwMTEwMAogQHByb3BlcnR5IChyZWFkb25seSkgTlNTcHJpbmdMb2FkaW5nSGlnaGxpZ2h0IHNw cmluZ0xvYWRpbmdIaWdobGlnaHQ7CisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSAxMDExMDAKIC0gKHZvaWQpcmVzZXRTcHJpbmdMb2FkaW5nOwogI2VuZGlmCiBAZW5kCg== 261664 2015-09-21 10:51:12 -0700 2015-09-21 12:43:31 -0700 proposed fix 10.11SDK.txt text/plain 3452 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MDA1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTA5LTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtPUyBYXSBVcGRhdGUgZm9yIFhjb2RlIDcuMCBvbiBZb3NlbWl0ZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5Mzg5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9tYWMvRHVtcFJlbmRlclRyZWVEcmFnZ2luZ0luZm8uaDoKKyAgICAgICAgKiBXZWJLaXRU ZXN0UnVubmVyL21hYy9XZWJLaXRUZXN0UnVubmVyRHJhZ2dpbmdJbmZvLmg6CisgICAgICAgIFJl bW92ZWQgdW5uZWVkZWQgZGVjbGFyYXRpb25zIC0gY29uZm9ybWluZyB0byBhIHByb3RvY29sIGlz IHN1ZmZpY2llbnQuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRy ZWVEcmFnZ2luZ0luZm8ubW06CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9tYWMvV2ViS2l0 VGVzdFJ1bm5lckRyYWdnaW5nSW5mby5tbToKKyAgICAgICAgQ2hhbmdlZCB0aGUgZGVmaW5pdGlv bnMgdG8gYmUgY29tcGlsZWQgd2hlbmV2ZXIgdGhlIFNESyByZXF1aXJlcyBpdCAoc28gd2Ugd2ls bCBoYXZlCisgICAgICAgIGRlYWQgY29kZSBjb21waWxlZCBpbiB3aGVuIGJ1aWxkaW5nIGZvciAx MC4xMCB3aXRoIDEwLjExIFNESywgc29tZXdoYXQgdW5mb3J0dW5hdGVseSkuCisKIDIwMTUtMDkt MjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtHVEtdIHJ1bi1ndGstdGVzdHMgZG9lc24ndCBwcm92aWRlIGZlZWRiYWNrIGFib3V0IGNyYXNo aW5nIGdvb2dsZSB0ZXN0cwpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5k ZXJUcmVlRHJhZ2dpbmdJbmZvLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUv bWFjL0R1bXBSZW5kZXJUcmVlRHJhZ2dpbmdJbmZvLmgJKHJldmlzaW9uIDE5MDA1OSkKKysrIFRv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZURyYWdnaW5nSW5mby5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01MSwxMSArNTEsNiBAQCBAaW50ZXJmYWNlIER1bXBSZW5kZXJUcmVlRHJh Z2dpbmdJbmZvIDogCiAKIC0gKHZvaWQpc2xpZGVEcmFnZ2VkSW1hZ2VUbzooTlNQb2ludClzY3Jl ZW5Qb2ludDsKIC0gKE5TQXJyYXkgKiluYW1lc09mUHJvbWlzZWRGaWxlc0Ryb3BwZWRBdERlc3Rp bmF0aW9uOihOU1VSTCAqKWRyb3BEZXN0aW5hdGlvbjsKLQotI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwCi1AcHJvcGVydHkgKHJlYWRvbmx5KSBOU1NwcmluZ0xv YWRpbmdIaWdobGlnaHQgc3ByaW5nTG9hZGluZ0hpZ2hsaWdodDsKLS0gKHZvaWQpcmVzZXRTcHJp bmdMb2FkaW5nOwotI2VuZGlmCiBAZW5kCiAKICNlbmRpZgpJbmRleDogVG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlRHJhZ2dpbmdJbmZvLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZURyYWdnaW5nSW5mby5tbQkocmV2 aXNpb24gMTkwMDU5KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVl RHJhZ2dpbmdJbmZvLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIsNyArMTQyLDcgQEAgLSAodm9p ZCllbnVtZXJhdGVEcmFnZ2luZ0l0ZW1zV2l0aE9wdGlvbgogICAgIC8vIElnbm9yZWQuCiB9CiAK LSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTEwMAorI2lmIF9fTUFD X09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA+PSAxMDExMDAKIC0oTlNTcHJpbmdMb2FkaW5nSGln aGxpZ2h0KXNwcmluZ0xvYWRpbmdIaWdobGlnaHQKIHsKICAgICByZXR1cm4gTlNTcHJpbmdMb2Fk aW5nSGlnaGxpZ2h0Tm9uZTsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1dlYktp dFRlc3RSdW5uZXJEcmFnZ2luZ0luZm8uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0 UnVubmVyL21hYy9XZWJLaXRUZXN0UnVubmVyRHJhZ2dpbmdJbmZvLmgJKHJldmlzaW9uIDE5MDA1 OSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1dlYktpdFRlc3RSdW5uZXJEcmFnZ2lu Z0luZm8uaAkod29ya2luZyBjb3B5KQpAQCAtNDQsOSArNDQsNCBAQCBAaW50ZXJmYWNlIFdlYktp dFRlc3RSdW5uZXJEcmFnZ2luZ0luZm8gCiAKIC0gKHZvaWQpc2xpZGVEcmFnZ2VkSW1hZ2VUbzoo TlNQb2ludClzY3JlZW5Qb2ludDsKIC0gKE5TQXJyYXkgKiluYW1lc09mUHJvbWlzZWRGaWxlc0Ry b3BwZWRBdERlc3RpbmF0aW9uOihOU1VSTCAqKWRyb3BEZXN0aW5hdGlvbjsKLQotI2lmIF9fTUFD X09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMTAwCi1AcHJvcGVydHkgKHJlYWRvbmx5 KSBOU1NwcmluZ0xvYWRpbmdIaWdobGlnaHQgc3ByaW5nTG9hZGluZ0hpZ2hsaWdodDsKLS0gKHZv aWQpcmVzZXRTcHJpbmdMb2FkaW5nOwotI2VuZGlmCiBAZW5kCkluZGV4OiBUb29scy9XZWJLaXRU ZXN0UnVubmVyL21hYy9XZWJLaXRUZXN0UnVubmVyRHJhZ2dpbmdJbmZvLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1dlYktpdFRlc3RSdW5uZXJEcmFnZ2luZ0lu Zm8ubW0JKHJldmlzaW9uIDE5MDA1OSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1dl YktpdFRlc3RSdW5uZXJEcmFnZ2luZ0luZm8ubW0JKHdvcmtpbmcgY29weSkKQEAgLTE0Niw3ICsx NDYsNyBAQCAtICh2b2lkKWVudW1lcmF0ZURyYWdnaW5nSXRlbXNXaXRoT3B0aW9uCiAgICAgLy8g SWdub3JlZC4KIH0KIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAx MTAwCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49IDEwMTEwMAogLShOU1Nw cmluZ0xvYWRpbmdIaWdobGlnaHQpc3ByaW5nTG9hZGluZ0hpZ2hsaWdodAogewogICAgIHJldHVy biBOU1NwcmluZ0xvYWRpbmdIaWdobGlnaHROb25lOwo=