149384 2015-09-20 00:36:07 -0700 [Mac, iOS] AccessibilityController doesn't uninstall global notification handler 2015-09-20 08:30:31 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 9 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=149217 P2 Normal --- 1 ap ap aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white oldest_to_newest 1127482 0 ap 2015-09-20 00:36:07 -0700 AccessibilityController::platformResetToConsistentState() clears the pointer, but the notification handle remains set. This is observable, as accessibility/mac/loaded-notification.html changes the behavior of subsequent accessibility tests. 1127483 1 261605 ap 2015-09-20 00:41:07 -0700 Created attachment 261605 proposed fix 1127499 2 261605 commit-queue 2015-09-20 08:30:27 -0700 Comment on attachment 261605 proposed fix Clearing flags on attachment: 261605 Committed r190026: <http://trac.webkit.org/changeset/190026> 1127500 3 commit-queue 2015-09-20 08:30:31 -0700 All reviewed patches have been landed. Closing bug. 261605 2015-09-20 00:41:07 -0700 2015-09-20 08:30:27 -0700 proposed fix GlobalNotificationHandler.txt text/plain 5075 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MDAyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTA5LTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWMsIGlPU10gQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIgZG9lc24ndCB1 bmluc3RhbGwgZ2xvYmFsIG5vdGlmaWNhdGlvbiBoYW5kbGVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkzODQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2lvcy9BY2Nlc3Np YmlsaXR5Q29udHJvbGxlcklPUy5tbToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlDb250cm9sbGVy OjphZGROb3RpZmljYXRpb25MaXN0ZW5lcik6IEZpeGVkIGEgbGVhaywgYW5kIGNsZWFuZWQgdXAg dGhlIGNvZGUuCisgICAgICAgIChBY2Nlc3NpYmlsaXR5Q29udHJvbGxlcjo6cGxhdGZvcm1SZXNl dFRvQ29uc2lzdGVudFN0YXRlKTogQWN0dWFsbHkgcmVtb3ZlIHRoZSBoYW5kbGVyLAorICAgICAg ICByZWdhcmRsZXNzIG9mIHdoZXRoZXIgc29tZW9uZSBlbHNlIGhvbGRzIGEgcmVmZXJlbmNlICh3 ZSBhbHNvIGNhbGwgLXN0b3BMaXN0ZW5pbmcgaW4KKyAgICAgICAgLWRlYWxsb2MpLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlDb250cm9sbGVyTWFjLm1tOgor ICAgICAgICAoQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXI6OnBsYXRmb3JtUmVzZXRUb0NvbnNpc3Rl bnRTdGF0ZSk6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5Q29udHJvbGxlcjo6YWRkTm90aWZpY2F0 aW9uTGlzdGVuZXIpOgorICAgICAgICBEaXR0by4KKwogMjAxNS0wOS0xOSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHRlZCBidWlsZCBmaXguCkluZGV4 OiBUb29scy9EdW1wUmVuZGVyVHJlZS9pb3MvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJJT1MubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL0FjY2Vzc2liaWxpdHlDb250 cm9sbGVySU9TLm1tCShyZXZpc2lvbiAxODk5NzEpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9p b3MvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTEyNiwx NSArMTI2LDE2IEBAIGJvb2wgQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXI6OmFkZE5vdGlmaWMKICAg ICAvLyBPdGhlciBwbGF0Zm9ybXMgbWF5IGJlIGRpZmZlcmVudC4KICAgICBpZiAobV9nbG9iYWxO b3RpZmljYXRpb25IYW5kbGVyKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgbV9nbG9iYWxO b3RpZmljYXRpb25IYW5kbGVyID0gW1tBY2Nlc3NpYmlsaXR5Tm90aWZpY2F0aW9uSGFuZGxlciBh bGxvY10gaW5pdF07Ci0gICAgW21fZ2xvYmFsTm90aWZpY2F0aW9uSGFuZGxlci5nZXQoKSBzZXRD YWxsYmFjazpmdW5jdGlvbkNhbGxiYWNrXTsKLSAgICBbbV9nbG9iYWxOb3RpZmljYXRpb25IYW5k bGVyLmdldCgpIHN0YXJ0T2JzZXJ2aW5nXTsKKyAgICBtX2dsb2JhbE5vdGlmaWNhdGlvbkhhbmRs ZXIgPSBhZG9wdE5TKFtbQWNjZXNzaWJpbGl0eU5vdGlmaWNhdGlvbkhhbmRsZXIgYWxsb2NdIGlu aXRdKTsKKyAgICBbbV9nbG9iYWxOb3RpZmljYXRpb25IYW5kbGVyIHNldENhbGxiYWNrOmZ1bmN0 aW9uQ2FsbGJhY2tdOworICAgIFttX2dsb2JhbE5vdGlmaWNhdGlvbkhhbmRsZXIgc3RhcnRPYnNl cnZpbmddOwogICAgIAogICAgIHJldHVybiB0cnVlOwogfQogCiB2b2lkIEFjY2Vzc2liaWxpdHlD b250cm9sbGVyOjpwbGF0Zm9ybVJlc2V0VG9Db25zaXN0ZW50U3RhdGUoKQogeworICAgIFttX2ds b2JhbE5vdGlmaWNhdGlvbkhhbmRsZXIgc3RvcE9ic2VydmluZ107CiAgICAgbV9nbG9iYWxOb3Rp ZmljYXRpb25IYW5kbGVyLmNsZWFyKCk7CiB9CiAKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVl L21hYy9BY2Nlc3NpYmlsaXR5Q29udHJvbGxlck1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9E dW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJNYWMubW0JKHJldmlzaW9u IDE4OTk3MSkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9BY2Nlc3NpYmlsaXR5Q29udHJv bGxlck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTIxLDYgKzEyMSw3IEBAIHZvaWQgQWNjZXNz aWJpbGl0eUNvbnRyb2xsZXI6OnNldExvZ0FjY2UKIAogdm9pZCBBY2Nlc3NpYmlsaXR5Q29udHJv bGxlcjo6cGxhdGZvcm1SZXNldFRvQ29uc2lzdGVudFN0YXRlKCkKIHsKKyAgICBbbV9nbG9iYWxO b3RpZmljYXRpb25IYW5kbGVyIHN0b3BPYnNlcnZpbmddOwogICAgIG1fZ2xvYmFsTm90aWZpY2F0 aW9uSGFuZGxlci5jbGVhcigpOwogfQogCkBAIC0xMzMsOSArMTM0LDkgQEAgYm9vbCBBY2Nlc3Np YmlsaXR5Q29udHJvbGxlcjo6YWRkTm90aWZpYwogICAgIC8vIE90aGVyIHBsYXRmb3JtcyBtYXkg YmUgZGlmZmVyZW50LgogICAgIGlmIChtX2dsb2JhbE5vdGlmaWNhdGlvbkhhbmRsZXIpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKLSAgICBtX2dsb2JhbE5vdGlmaWNhdGlvbkhhbmRsZXIgPSBbW0Fj Y2Vzc2liaWxpdHlOb3RpZmljYXRpb25IYW5kbGVyIGFsbG9jXSBpbml0XTsKLSAgICBbbV9nbG9i YWxOb3RpZmljYXRpb25IYW5kbGVyLmdldCgpIHNldENhbGxiYWNrOmZ1bmN0aW9uQ2FsbGJhY2td OwotICAgIFttX2dsb2JhbE5vdGlmaWNhdGlvbkhhbmRsZXIuZ2V0KCkgc3RhcnRPYnNlcnZpbmdd OworICAgIG1fZ2xvYmFsTm90aWZpY2F0aW9uSGFuZGxlciA9IGFkb3B0TlMoW1tBY2Nlc3NpYmls aXR5Tm90aWZpY2F0aW9uSGFuZGxlciBhbGxvY10gaW5pdF0pOworICAgIFttX2dsb2JhbE5vdGlm aWNhdGlvbkhhbmRsZXIgc2V0Q2FsbGJhY2s6ZnVuY3Rpb25DYWxsYmFja107CisgICAgW21fZ2xv YmFsTm90aWZpY2F0aW9uSGFuZGxlciBzdGFydE9ic2VydmluZ107CiAKICAgICByZXR1cm4gdHJ1 ZTsKIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDAyMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTA5LTIwICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWMsIGlPU10gQWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIgZG9lc24ndCB1bmluc3RhbGwgZ2xvYmFsIG5vdGlmaWNhdGlvbiBoYW5k bGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkz ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvbWFjL2xvYWRlZC1ub3RpZmljYXRpb24uaHRtbDogQ2xlYW5lZCB1cCB0aGUg dGVzdCAtIGpzLXRlc3QtcHJlIGlzCisgICAgICAgIGluY29tcGF0aWJsZSB3aXRoIGRpcmVjdGx5 IHVzaW5nIHdhaXRVbnRpbERvbmUuIAorCiAyMDE1LTA5LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dlYklETF0gU3BlY2lmeSBkZWZhdWx0IHBhcmFtZXRl ciB2YWx1ZXMgd2hlcmUgaXQgaXMgdXNlZnVsCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L21hYy9sb2FkZWQtbm90aWZpY2F0aW9uLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS9tYWMvbG9hZGVkLW5vdGlmaWNhdGlvbi5odG1sCShyZXZpc2lvbiAx ODk5NzEpCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L21hYy9sb2FkZWQtbm90aWZpY2F0 aW9uLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTE0LDE0ICsxNCwxMiBAQAogICAgIGRlc2NyaXB0 aW9uKCJUaGlzIHRlc3RzIHRoYXQgd2hlbiBlbmFibGUgZW5oYW5jZWQgYWNjZXNzaWJpbGl0eSBp cyB0cnVlIGFuZCBubyBvdGhlciBhY2Nlc3NpYmlsaXR5IEFQSSBpcyBjYWxsZWQsIHRoZSBsb2Fk IG5vdGlmaWNhdGlvbiB3aWxsIHN1Y2Nlc3NmdWxseSBmaXJlLiIpOwogCiAgICAgZnVuY3Rpb24g bm90aWZ5Q2FsbGJhY2soZWxlbWVudCwgbm90aWZpY2F0aW9uKSB7Ci0gICAgICAgIGlmIChub3Rp ZmljYXRpb24gPT0gIkFYTG9hZENvbXBsZXRlIikgewotICAgICAgICAgICAgYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIucmVtb3ZlTm90aWZpY2F0aW9uTGlzdGVuZXIoKTsKLSAgICAgICAgICAgIHdp bmRvdy50ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKLSAgICAgICAgfQorICAgICAgICBpZiAobm90 aWZpY2F0aW9uID09ICJBWExvYWRDb21wbGV0ZSIpCisgICAgICAgICAgICBmaW5pc2hKU1Rlc3Qo KTsKICAgICB9CiAKICAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7Ci0g ICAgICAgIHdpbmRvdy50ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAganNUZXN0 SXNBc3luYyA9IHRydWU7CiAgICAgICAgIGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmVuYWJsZUVu aGFuY2VkQWNjZXNzaWJpbGl0eSh0cnVlKTsKICAgICAgICAgdmFyIGFkZGVkTm90aWZpY2F0aW9u ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWRkTm90aWZpY2F0aW9uTGlzdGVuZXIobm90aWZ5 Q2FsbGJhY2spOwogICAgICAgICBzaG91bGRCZSgiYWRkZWROb3RpZmljYXRpb24iLCAidHJ1ZSIp Owo=