149358 2015-09-18 16:04:16 -0700 UserMediaClientMock leaks every test run 2015-09-21 11:05:13 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson commit-queue thorton oldest_to_newest 1127274 0 eric.carlson 2015-09-18 16:04:16 -0700 UserMediaClientMock leaks every test run 1127280 1 261539 eric.carlson 2015-09-18 16:07:17 -0700 Created attachment 261539 Proposed patch. 1127302 2 261539 commit-queue 2015-09-18 16:58:00 -0700 Comment on attachment 261539 Proposed patch. Clearing flags on attachment: 261539 Committed r190001: <http://trac.webkit.org/changeset/190001> 1127303 3 commit-queue 2015-09-18 16:58:04 -0700 All reviewed patches have been landed. Closing bug. 1127481 4 thorton 2015-09-20 00:28:21 -0700 This is still leaking, according to the leaks bot. 1127487 5 thorton 2015-09-20 01:07:25 -0700 https://bugs.webkit.org/show_bug.cgi?id=149358 made it so that we would only make a UserMediaController if we didn't already have one, so subsequent calls to provideUserMediaTo end up just leaking the client. I think instead of bailing if we already have one, we mean to be replacing it. But also it seems like the memory management surrounding Supplement/friends is quite fragile. 1127488 6 thorton 2015-09-20 01:18:08 -0700 I meant https://bugs.webkit.org/show_bug.cgi?id=130311 in the last comment. 1127489 7 261608 thorton 2015-09-20 01:19:38 -0700 Created attachment 261608 patch 1127677 8 thorton 2015-09-21 11:05:13 -0700 http://trac.webkit.org/changeset/190061 261539 2015-09-18 16:07:17 -0700 2015-09-18 16:58:00 -0700 Proposed patch. mock_leak_patch.txt text/plain 1213 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTk5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTA5LTE4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFVzZXJNZWRpYUNsaWVu dE1vY2sgbGVha3MgZXZlcnkgdGVzdCBydW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0OTM1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbW9jay9Vc2VyTWVkaWFDbGllbnRNb2NrLmg6 IEltcGxlbWVudCBwYWdlRGVzdHJveWVkLgorCiAyMDE1LTA5LTE4ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IFdpbmRvd3MgdGVzdHMg YWZ0ZXIgc3dpdGNoIHRvIENNYWtlLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9j ay9Vc2VyTWVkaWFDbGllbnRNb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbW9jay9Vc2VyTWVkaWFDbGllbnRNb2NrLmgJKHJldmlzaW9uIDE4OTk4MykKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svVXNlck1lZGlhQ2xpZW50TW9jay5oCSh3b3JraW5n IGNvcHkpCkBAIC01OCw3ICs1OCwxMCBAQCBwcml2YXRlOgogY2xhc3MgVXNlck1lZGlhQ2xpZW50 TW9jayBmaW5hbCA6IHB1YmxpYyBVc2VyTWVkaWFDbGllbnQsIHB1YmxpYyBUaW1lckV2ZW50QmFz ZWRNb2NrIHsKIHB1YmxpYzoKICAgICBwdWJsaWM6Ci0gICAgdmlydHVhbCB2b2lkIHBhZ2VEZXN0 cm95ZWQoKSBvdmVycmlkZSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgcGFnZURlc3Ryb3llZCgpIG92 ZXJyaWRlCisgICAgeworICAgICAgICBkZWxldGUgdGhpczsKKyAgICB9CiAKICAgICB2aXJ0dWFs IHZvaWQgcmVxdWVzdFBlcm1pc3Npb24oUmVmPFVzZXJNZWRpYVJlcXVlc3Q+JiYgcmVxdWVzdCkg b3ZlcnJpZGUKICAgICB7Cg== 261608 2015-09-20 01:19:38 -0700 2015-09-20 19:49:00 -0700 patch umc.diff text/plain 3346 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwY2NiMzU3Li5lYWMyNGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTUtMDktMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgVXNlck1lZGlhQ2xpZW50TW9jayBsZWFrcyBldmVyeSB0ZXN0IHJ1bgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MzU4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlh c3RyZWFtL1VzZXJNZWRpYUNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJvdmlk ZVVzZXJNZWRpYVRvKToKKyAgICAgICAgTWFrZSBwcm92aWRlVXNlck1lZGlhVG8gb3BlcmF0ZSB1 bmNvbmRpdGlvbmFsbHksIGp1c3QgbGlrZSBhbGwgb2YgdGhlCisgICAgICAgIG90aGVyIHNpbWls YXIgZnVuY3Rpb25zLCByZXZlcnRpbmcgcjE2NTczMy4KKworICAgICAgICAqIE1vZHVsZXMvbWVk aWFzdHJlYW0vVXNlck1lZGlhQ29udHJvbGxlci5oOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJu YWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6SW50ZXJuYWxzKToKKyAgICAg ICAgUmVtb3ZlIHRoZSBleGlzdGluZyBVc2VyTWVkaWFDb250cm9sbGVyIHN1cHBsZW1lbnQgYmVm b3JlIGluc3RhbGxpbmcgYSBuZXcgb25lLgorICAgICAgICBUaGlzIHdheSwgd2UncmUgcmVwbGFj aW5nIGl0IHdpdGggdGhlIG9uZSBJbnRlcm5hbHMgaXMgdHJ5aW5nIHRvIGluc3RhbGwsCisgICAg ICAgIGluc3RlYWQgb2YgbGVha2luZyBVc2VyTWVkaWFDbGllbnRNb2Nrcy4KKwogMjAxNS0wOS0x OSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWIgSURMXSBB ZGQgc3VwcG9ydCBmb3IgW1B1dEZvcndhcmRzPVhYWF0gSURMIGV4dGVuZGVkIGF0dHJpYnV0ZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFD b250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1l ZGlhQ29udHJvbGxlci5jcHAKaW5kZXggZDYwODU2Zi4uMTk5MWUxZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFDb250cm9sbGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYUNvbnRyb2xs ZXIuY3BwCkBAIC00Niw4ICs0Niw3IEBAIFVzZXJNZWRpYUNvbnRyb2xsZXI6On5Vc2VyTWVkaWFD b250cm9sbGVyKCkKIAogdm9pZCBwcm92aWRlVXNlck1lZGlhVG8oUGFnZSogcGFnZSwgVXNlck1l ZGlhQ2xpZW50KiBjbGllbnQpCiB7Ci0gICAgaWYgKCFTdXBwbGVtZW50PFBhZ2U+Ojpmcm9tKHBh Z2UsIFVzZXJNZWRpYUNvbnRyb2xsZXI6OnN1cHBsZW1lbnROYW1lKCkpKQotICAgICAgICBVc2Vy TWVkaWFDb250cm9sbGVyOjpwcm92aWRlVG8ocGFnZSwgVXNlck1lZGlhQ29udHJvbGxlcjo6c3Vw cGxlbWVudE5hbWUoKSwgc3RkOjptYWtlX3VuaXF1ZTxVc2VyTWVkaWFDb250cm9sbGVyPihjbGll bnQpKTsKKyAgICBVc2VyTWVkaWFDb250cm9sbGVyOjpwcm92aWRlVG8ocGFnZSwgVXNlck1lZGlh Q29udHJvbGxlcjo6c3VwcGxlbWVudE5hbWUoKSwgc3RkOjptYWtlX3VuaXF1ZTxVc2VyTWVkaWFD b250cm9sbGVyPihjbGllbnQpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9Vc2VyTWVkaWFDb250cm9s bGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYUNvbnRy b2xsZXIuaAppbmRleCA3NTc2ZGZhLi5hZTZmNjRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYUNvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYUNvbnRyb2xsZXIuaApAQCAtNDIs NyArNDIsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCByZXF1ZXN0UGVybWlzc2lvbihSZWY8VXNlck1l ZGlhUmVxdWVzdD4mJik7CiAgICAgdm9pZCBjYW5jZWxSZXF1ZXN0KFVzZXJNZWRpYVJlcXVlc3Qm KTsKIAotICAgIHN0YXRpYyBjb25zdCBjaGFyKiBzdXBwbGVtZW50TmFtZSgpOworICAgIFdFQkNP UkVfRVhQT1JUIHN0YXRpYyBjb25zdCBjaGFyKiBzdXBwbGVtZW50TmFtZSgpOwogICAgIHN0YXRp YyBVc2VyTWVkaWFDb250cm9sbGVyKiBmcm9tKFBhZ2UqIHBhZ2UpIHsgcmV0dXJuIHN0YXRpY19j YXN0PFVzZXJNZWRpYUNvbnRyb2xsZXIqPihTdXBwbGVtZW50PFBhZ2U+Ojpmcm9tKHBhZ2UsIHN1 cHBsZW1lbnROYW1lKCkpKTsgfQogCiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuY3BwCmluZGV4IDczZDBmZTYuLjNlZGQyMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5jcHAKQEAgLTExMiw2ICsxMTIsNyBAQAogI2luY2x1ZGUgIlRleHRJdGVyYXRvci5oIgog I2luY2x1ZGUgIlRyZWVTY29wZS5oIgogI2luY2x1ZGUgIlR5cGVDb252ZXJzaW9ucy5oIgorI2lu Y2x1ZGUgIlVzZXJNZWRpYUNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJWaWV3cG9ydEFyZ3VtZW50 cy5oIgogI2luY2x1ZGUgIldlYkNvbnNvbGVBZ2VudC5oIgogI2luY2x1ZGUgIldvcmtlclRocmVh ZC5oIgpAQCAtMzg1LDYgKzM4Niw3IEBAIEludGVybmFsczo6SW50ZXJuYWxzKERvY3VtZW50KiBk b2N1bWVudCkKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogICAgIE1vY2tSZWFsdGltZU1lZGlh U291cmNlQ2VudGVyOjpyZWdpc3Rlck1vY2tSZWFsdGltZU1lZGlhU291cmNlQ2VudGVyKCk7CiAg ICAgZW5hYmxlTW9ja1JUQ1BlZXJDb25uZWN0aW9uSGFuZGxlcigpOworICAgIGRvY3VtZW50LT5w YWdlKCktPnJlbW92ZVN1cHBsZW1lbnQoVXNlck1lZGlhQ29udHJvbGxlcjo6c3VwcGxlbWVudE5h bWUoKSk7CiAgICAgV2ViQ29yZTo6cHJvdmlkZVVzZXJNZWRpYVRvKGRvY3VtZW50LT5wYWdlKCks IG5ldyBVc2VyTWVkaWFDbGllbnRNb2NrKCkpOwogI2VuZGlmCiB9Cg==