149351 2015-09-18 12:47:13 -0700 isGitSVNDirectory() returns true when Git is not installed 2015-09-18 13:01:06 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates achristensen ap oldest_to_newest 1127186 0 dbates 2015-09-18 12:47:13 -0700 If Git is not installed then VCSUtils::isGitSVNDirectory() will return true for an arbitrary directory. 1127187 1 261510 dbates 2015-09-18 12:48:47 -0700 Created attachment 261510 Patch 1127189 2 261510 ap 2015-09-18 12:52:48 -0700 Comment on attachment 261510 Patch Looks fine as a short term fix, however doesn't this leave us with an error in console? Ideally, we should build without errors or warnings, so that new important errors don't get hidden in the noise. 1127190 3 dbates 2015-09-18 12:59:48 -0700 (In reply to comment #2) > Comment on attachment 261510 [details] > Patch > > Looks fine as a short term fix, however doesn't this leave us with an error > in console? No, it does not leave an error in the console. 1127192 4 261510 dbates 2015-09-18 13:01:02 -0700 Comment on attachment 261510 Patch Clearing flags on attachment: 261510 Committed r189977: <http://trac.webkit.org/changeset/189977> 1127193 5 dbates 2015-09-18 13:01:06 -0700 All reviewed patches have been landed. Closing bug. 261510 2015-09-18 12:48:47 -0700 2015-09-18 13:01:02 -0700 Patch bug-149351-20150918124833.patch text/plain 1490 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5MjYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGIxNGQ5ZGM0YWZkNDM1OWU3MDA4YmQ3MjhmZTJkNDU3 YTRhMDRlNC4uZmI3YWQzMTk1Yjc1M2UzYWNlZWU4NDYwODc2YjFjNTU4YjY5YzE1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE1LTA5LTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBpc0dpdFNWTkRpcmVjdG9yeSgpIHJldHVybnMgdHJ1ZSB3aGVuIEdpdCBpcyBub3QgaW5z dGFsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDkzNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXhlcyBhbiBpc3N1ZSB3aGVyZSBWQ1NVdGlsczo6aXNHaXRTVk5EaXJlY3RvcnkoKSByZXR1cm5z IHRydWUgZm9yIGFueSBhcmJpdHJhcnkgZGlyZWN0b3J5IGlmCisgICAgICAgIEdpdCBpcyBub3Qg aW5zdGFsbGVkIG9uIHRoZSBtYWNoaW5lLgorCisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5w bToKKyAgICAgICAgKGlzR2l0U1ZORGlyZWN0b3J5KTogRW5zdXJlIHRoYXQgYGdpdCBjb25maWcg LS1nZXQgc3ZuLXJlbW90ZS5zdm4uZmV0Y2ggMj4mIDFgIGV4aXRzIHdpdGgKKyAgICAgICAgc3Rh dHVzIGNvZGUgMCAoc3VjY2VzcykuCisKIDIwMTUtMDktMDkgIERhbmllbCBCYXRlcyAgPGRhYmF0 ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEV4cG9zZSBFbmFibGUvRGlzYWJsZSBBY2Nl bGVyYXRlZCBEcmF3aW5nIGluIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L1ZDU1V0aWxzLnBtIGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQppbmRleCAzMzU4OTc5OTYy ZDRhMzQ4OGU0MTI5YjMwMTZlM2Y2YTU5OTMzODI1Li4yNjM5NTQzOGFlMTI5YzVhNDJmOTFhZDU3 ZDVlZmIxMzQ2ZjA2MDk4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtCisr KyBiL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KQEAgLTIzNiw3ICsyMzYsNyBAQCBzdWIgaXNH aXRTVk5EaXJlY3RvcnkoJCkKICAgICAjIGlmIHlvdSdyZSBpbiBhIGdpdC1zdm4gY2hlY2tvdXQu IFRoZSBiZXN0IHN1Z2dlc3Rpb25zIHNlZW4gc28gZmFyCiAgICAgIyBhbGwgdXNlIHNvbWV0aGlu ZyBsaWtlIHRoZSBmb2xsb3dpbmc6CiAgICAgbXkgJG91dHB1dCA9IGBnaXQgY29uZmlnIC0tZ2V0 IHN2bi1yZW1vdGUuc3ZuLmZldGNoIDI+JiAxYDsKLSAgICAkaXNHaXRTVk4gPSAkb3V0cHV0IG5l ICcnOworICAgICRpc0dpdFNWTiA9IGV4aXRTdGF0dXMoJD8pID09IDAgJiYgJG91dHB1dCBuZSAi IjsKICAgICBjaGRpcigkc2F2ZWRXb3JraW5nRGlyZWN0b3J5KTsKICAgICByZXR1cm4gJGlzR2l0 U1ZOOwogfQo=