149349 2015-09-18 12:03:29 -0700 line-break-language-sensitive tests should be marked as flaky 2015-09-18 14:31:31 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified NEW P2 Normal --- 1 jake.nielsen.webkit webkit-unassigned commit-queue mmaxfield oldest_to_newest 1127171 0 jake.nielsen.webkit 2015-09-18 12:03:29 -0700 More specifically, these four: css3/line-break-language-sensitive/line-break-loose-centered.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-loose-postfixes.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-loose-sound-marks.html [ ImageOnlyFailure ] css3/line-break-language-sensitive/line-break-normal-sound-marks.html [ ImageOnlyFailure ] 1127172 1 261507 jake.nielsen.webkit 2015-09-18 12:08:46 -0700 Created attachment 261507 Marks appropriate tests as flaky. 1127176 2 261507 ap 2015-09-18 12:13:45 -0700 Comment on attachment 261507 Marks appropriate tests as flaky. View in context: https://bugs.webkit.org/attachment.cgi?id=261507&action=review Looks good to me > TestExpectations:2828 > +# Flaky tests I'd put a comment mentioning bug 149320 here. 1127177 3 261507 ap 2015-09-18 12:14:21 -0700 Comment on attachment 261507 Marks appropriate tests as flaky. Oh wait, this should be in iOS expectations, not in the root. platform/ios-simulator/TestExpectations 1127202 4 jake.nielsen.webkit 2015-09-18 13:13:27 -0700 (In reply to comment #3) > Comment on attachment 261507 [details] > Marks appropriate tests as flaky. > > Oh wait, this should be in iOS expectations, not in the root. > > platform/ios-simulator/TestExpectations Ooops, my bad. I didn't generate the diff from the right directory 1127204 5 261516 jake.nielsen.webkit 2015-09-18 13:15:56 -0700 Created attachment 261516 Patch two 1127215 6 261516 ddkilzer 2015-09-18 13:42:09 -0700 Comment on attachment 261516 Patch two This should really have a ChangeLog. 1127234 7 mmaxfield 2015-09-18 14:26:33 -0700 For the long term, I should fix these tests instead of leaving them marked as flakey. 1127240 8 mmaxfield 2015-09-18 14:31:31 -0700 Oh whoops, I misunderstood which tests these are. These tests should only run on particular versions of iOS, and on those versions, they should consistently pass. 261507 2015-09-18 12:08:46 -0700 2015-09-18 13:15:56 -0700 Marks appropriate tests as flaky. flakiness.diff text/plain 929 jake.nielsen.webkit SW5kZXg6IFRlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVGVzdEV4cGVjdGF0aW9ucwko cmV2aXNpb24gMTg5OTc1KQorKysgVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAt MjgyNCwzICsyODI0LDEwIEBACiB3ZWJraXQub3JnL2IvMTQ4ODA2IGltcG9ydGVkL3czYy9jc3Mv Y3NzLW11bHRpY29sLTEvbXVsdGljb2wtc2hvcnRoYW5kLTAwMS54aHQgWyBJbWFnZU9ubHlGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xNDg4MDYgaW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wt MS9tdWx0aWNvbC1zcGFuLWFsbC1ibG9jay1zaWJsaW5nLTAwMy54aHQgWyBJbWFnZU9ubHlGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xNDg4MDYgaW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wt MS9tdWx0aWNvbC1zcGFuLWFsbC1tYXJnaW4tbmVzdGVkLWZpcnN0Y2hpbGQtMDAxLnhodCBbIElt YWdlT25seUZhaWx1cmUgXQorCisjIEZsYWt5IHRlc3RzCisKK2NzczMvbGluZS1icmVhay1sYW5n dWFnZS1zZW5zaXRpdmUvbGluZS1icmVhay1sb29zZS1jZW50ZXJlZC5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBQYXNzIF0KK2NzczMvbGluZS1icmVhay1sYW5ndWFnZS1zZW5zaXRpdmUvbGluZS1i cmVhay1sb29zZS1wb3N0Zml4ZXMuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCitjc3Mz L2xpbmUtYnJlYWstbGFuZ3VhZ2Utc2Vuc2l0aXZlL2xpbmUtYnJlYWstbG9vc2Utc291bmQtbWFy a3MuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCitjc3MzL2xpbmUtYnJlYWstbGFuZ3Vh Z2Utc2Vuc2l0aXZlL2xpbmUtYnJlYWstbm9ybWFsLXNvdW5kLW1hcmtzLmh0bWwgWyBJbWFnZU9u bHlGYWlsdXJlIFBhc3MgXQo= 261516 2015-09-18 13:15:56 -0700 2015-09-18 14:03:11 -0700 Patch two flakiness.diff text/plain 1114 jake.nielsen.webkit SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3IvVGVzdEV4cGVjdGF0aW9u cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL1Rlc3RF eHBlY3RhdGlvbnMJKHJldmlzaW9uIDE4OTk3NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2lv cy1zaW11bGF0b3IvVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMjgyNCwzICsy ODI0LDEwIEBACiB3ZWJraXQub3JnL2IvMTQ4ODA2IGltcG9ydGVkL3czYy9jc3MvY3NzLW11bHRp Y29sLTEvbXVsdGljb2wtc2hvcnRoYW5kLTAwMS54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdl YmtpdC5vcmcvYi8xNDg4MDYgaW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wtMS9tdWx0aWNv bC1zcGFuLWFsbC1ibG9jay1zaWJsaW5nLTAwMy54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdl YmtpdC5vcmcvYi8xNDg4MDYgaW1wb3J0ZWQvdzNjL2Nzcy9jc3MtbXVsdGljb2wtMS9tdWx0aWNv bC1zcGFuLWFsbC1tYXJnaW4tbmVzdGVkLWZpcnN0Y2hpbGQtMDAxLnhodCBbIEltYWdlT25seUZh aWx1cmUgXQorCisjIEZsYWt5IHRlc3RzICggdGhlc2UgdGVzdHMgd2VyZSBhZmZlY3RlZCBieSBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MzIwICkKKworY3NzMy9s aW5lLWJyZWFrLWxhbmd1YWdlLXNlbnNpdGl2ZS9saW5lLWJyZWFrLWxvb3NlLWNlbnRlcmVkLmh0 bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQorY3NzMy9saW5lLWJyZWFrLWxhbmd1YWdlLXNl bnNpdGl2ZS9saW5lLWJyZWFrLWxvb3NlLXBvc3RmaXhlcy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVy ZSBQYXNzIF0KK2NzczMvbGluZS1icmVhay1sYW5ndWFnZS1zZW5zaXRpdmUvbGluZS1icmVhay1s b29zZS1zb3VuZC1tYXJrcy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KK2NzczMvbGlu ZS1icmVhay1sYW5ndWFnZS1zZW5zaXRpdmUvbGluZS1icmVhay1ub3JtYWwtc291bmQtbWFya3Mu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCg==