149339 2015-09-17 23:59:25 -0700 Fix tests on Windows after switching to CMake 2015-09-18 11:02:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen webkit-unassigned bfulgham commit-queue gyuyoung.kim mrobinson oldest_to_newest 1127079 0 achristensen 2015-09-17 23:59:25 -0700 testapi and testRegExp aren't built. They should be. 1127080 1 261495 achristensen 2015-09-18 00:00:22 -0700 Created attachment 261495 patch 1127081 2 commit-queue 2015-09-18 00:02:47 -0700 Attachment 261495 did not pass style-queue: ERROR: Source/JavaScriptCore/shell/PlatformWin.cmake:31: No trailing spaces [whitespace/trailing] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1127087 3 261496 achristensen 2015-09-18 00:42:20 -0700 Created attachment 261496 patch 1127141 4 261496 bfulgham 2015-09-18 10:02:36 -0700 Comment on attachment 261496 patch r=me. 1127160 5 achristensen 2015-09-18 11:02:27 -0700 http://trac.webkit.org/changeset/189972 261495 2015-09-18 00:00:22 -0700 2015-09-18 00:42:20 -0700 patch patch text/plain 2594 achristensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODk5NjQpDQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwx MyBAQA0KKzIwMTUtMDktMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0 Lm9yZz4KKworICAgICAgICBGaXgganNjIHRlc3RzIG9uIFdpbmRvd3MgYWZ0ZXIgc3dpdGNoaW5n IHRvIENNYWtlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ5MzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBzaGVsbC9QbGF0Zm9ybVdpbi5jbWFrZToKKyAgICAgICAgQnVpbGQgdGVzdGFwaSBhbmQg dGVzdFJlZ0V4cCAod2hpY2ggZG9lc24ndCBzZWVtIHRvIGJlIHVzZWQgYW55IG1vcmUpLgorCiAy MDE1LTA5LTE3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHVudXNlZCBjYW5DbGVhckJyb3dzZXJDb29raWVzIC8g Y2FuQ2xlYXJCcm93c2VyQ2FjaGUgcHJvdG9jb2wgbWV0aG9kcwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtV2luLmNtYWtlDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtV2luLmNtYWtlCShyZXZpc2lvbiAxODk5NjQp DQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtV2luLmNtYWtlCSh3b3Jr aW5nIGNvcHkpDQpAQCAtMTgsMyArMTgsMzYgQEANCiBhZGRfZGVmaW5pdGlvbnMoLURVU0VfQ09O U09MRV9FTlRSWV9QT0lOVCkKIAogc2V0KEpTQ19PVVRQVVRfTkFNRSAianNjJHtERUJVR19TVUZG SVh9IikKKworYWRkX2xpYnJhcnkodGVzdFJlZ0V4cExpYiBTSEFSRUQgLi4vdGVzdFJlZ0V4cC5j cHApCitzZXRfdGFyZ2V0X3Byb3BlcnRpZXModGVzdFJlZ0V4cExpYiBQUk9QRVJUSUVTIEZPTERF UiAiSmF2YVNjcmlwdENvcmUiKQorc2V0X3RhcmdldF9wcm9wZXJ0aWVzKHRlc3RSZWdFeHBMaWIg UFJPUEVSVElFUyBPVVRQVVRfTkFNRSAidGVzdFJlZ0V4cCR7REVCVUdfU1VGRklYfSIpCithZGRf ZXhlY3V0YWJsZSh0ZXN0UmVnRXhwICR7SlNDX1NPVVJDRVN9KQorc2V0X3RhcmdldF9wcm9wZXJ0 aWVzKHRlc3RSZWdFeHAgUFJPUEVSVElFUyBPVVRQVVRfTkFNRSAidGVzdFJlZ0V4cCR7REVCVUdf U1VGRklYfSIpCit0YXJnZXRfbGlua19saWJyYXJpZXModGVzdFJlZ0V4cCBzaGx3YXBpKQorYWRk X2RlcGVuZGVuY2llcyh0ZXN0UmVnRXhwIHRlc3RSZWdFeHBMaWIpCit0YXJnZXRfbGlua19saWJy YXJpZXModGVzdFJlZ0V4cExpYiBKYXZhU2NyaXB0Q29yZSkKKworYWRkX2xpYnJhcnkodGVzdGFw aUxpYiBTSEFSRUQgCisgICAgLi4vQVBJL3Rlc3RzL0NvbXBhcmVBbmRTd2FwVGVzdC5jcHAKKyAg ICAuLi9BUEkvdGVzdHMvQ3VzdG9tR2xvYmFsT2JqZWN0Q2xhc3NUZXN0LmMKKyAgICAuLi9BUEkv dGVzdHMvRXhlY3V0aW9uVGltZUxpbWl0VGVzdC5jcHAKKyAgICAuLi9BUEkvdGVzdHMvR2xvYmFs Q29udGV4dFdpdGhGaW5hbGl6ZXJUZXN0LmNwcAorICAgIC4uL0FQSS90ZXN0cy9QaW5nUG9uZ1N0 YWNrT3ZlcmZsb3dUZXN0LmNwcAorICAgIC4uL0FQSS90ZXN0cy90ZXN0YXBpLmMKKykKK3NldF9z b3VyY2VfZmlsZXNfcHJvcGVydGllcyguLi9BUEkvdGVzdHMvQ3VzdG9tR2xvYmFsT2JqZWN0Q2xh c3NUZXN0LmMgUFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTICIvVFAgL01UIikKK3NldF9zb3VyY2Vf ZmlsZXNfcHJvcGVydGllcyguLi9BUEkvdGVzdHMvdGVzdGFwaS5jIFBST1BFUlRJRVMgQ09NUElM RV9GTEFHUyAiL1RQIC9NVCIpCitzZXRfdGFyZ2V0X3Byb3BlcnRpZXModGVzdGFwaUxpYiBQUk9Q RVJUSUVTIEZPTERFUiAiSmF2YVNjcmlwdENvcmUiKQorc2V0X3RhcmdldF9wcm9wZXJ0aWVzKHRl c3RhcGlMaWIgUFJPUEVSVElFUyBPVVRQVVRfTkFNRSAidGVzdGFwaSR7REVCVUdfU1VGRklYfSIp CithZGRfZXhlY3V0YWJsZSh0ZXN0YXBpICR7SlNDX1NPVVJDRVN9KQorc2V0X3RhcmdldF9wcm9w ZXJ0aWVzKHRlc3RhcGkgUFJPUEVSVElFUyBPVVRQVVRfTkFNRSAidGVzdGFwaSR7REVCVUdfU1VG RklYfSIpCit0YXJnZXRfbGlua19saWJyYXJpZXModGVzdGFwaSBzaGx3YXBpKQorYWRkX2RlcGVu ZGVuY2llcyh0ZXN0YXBpIHRlc3RhcGlMaWIpCit0YXJnZXRfbGlua19saWJyYXJpZXModGVzdGFw aUxpYiBKYXZhU2NyaXB0Q29yZSkKKworZmlsZShDT1BZCisgICAgIiR7SkFWQVNDUklQVENPUkVf RElSfS9BUEkvdGVzdHMvdGVzdGFwaS5qcyIKKyAgICBERVNUSU5BVElPTgorICAgICR7Q01BS0Vf UlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfQorKQo= 261496 2015-09-18 00:42:20 -0700 2015-09-18 10:02:36 -0700 patch patch text/plain 4209 achristensen SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMTg5 OTY0KQ0KKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsNSArMSwxNCBAQA0KIDIw MTUtMDktMTcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAor ICAgICAgICBGaXggdGVzdHMgb24gV2luZG93cyBhZnRlciBzd2l0Y2hpbmcgdG8gQ01ha2UuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkzMzkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMpLgorCisgICAgICAgICogU291cmNlL1Bs YXRmb3JtV2luLmNtYWtlOiBBZGRlZCB0byBjb3B5IFdlYkluc3BlY3RvclVJLgorCisyMDE1LTA5 LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKICAgICAg ICAgRml4IFdpbmRvd3MgRVdTIGJ1aWxkIGFmdGVyIHIxODk5MzQuCiAKICAgICAgICAgKiBTb3Vy Y2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZToKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0NCi0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxODk5NjQpDQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwxMyBAQA0KKzIwMTUtMDktMTcgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggdGVzdHMgb24g V2luZG93cyBhZnRlciBzd2l0Y2hpbmcgdG8gQ01ha2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkzMzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNoZWxsL1BsYXRmb3JtV2luLmNtYWtlOgorICAg ICAgICBCdWlsZCB0ZXN0YXBpIGFuZCB0ZXN0UmVnRXhwICh3aGljaCBkb2Vzbid0IHNlZW0gdG8g YmUgdXNlZCBhbnkgbW9yZSkuCisKIDIwMTUtMDktMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2VkIGNh bkNsZWFyQnJvd3NlckNvb2tpZXMgLyBjYW5DbGVhckJyb3dzZXJDYWNoZSBwcm90b2NvbCBtZXRo b2RzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvUGxhdGZvcm1XaW4uY21ha2UN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NCi0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvUGxhdGZvcm1XaW4u Y21ha2UJKHJldmlzaW9uIDE4OTk2NCkNCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwv UGxhdGZvcm1XaW4uY21ha2UJKHdvcmtpbmcgY29weSkNCkBAIC0xOCwzICsxOCwzNiBAQA0KIGFk ZF9kZWZpbml0aW9ucygtRFVTRV9DT05TT0xFX0VOVFJZX1BPSU5UKQogCiBzZXQoSlNDX09VVFBV VF9OQU1FICJqc2Mke0RFQlVHX1NVRkZJWH0iKQorCithZGRfbGlicmFyeSh0ZXN0UmVnRXhwTGli IFNIQVJFRCAuLi90ZXN0UmVnRXhwLmNwcCkKK3NldF90YXJnZXRfcHJvcGVydGllcyh0ZXN0UmVn RXhwTGliIFBST1BFUlRJRVMgRk9MREVSICJKYXZhU2NyaXB0Q29yZSIpCitzZXRfdGFyZ2V0X3By b3BlcnRpZXModGVzdFJlZ0V4cExpYiBQUk9QRVJUSUVTIE9VVFBVVF9OQU1FICJ0ZXN0UmVnRXhw JHtERUJVR19TVUZGSVh9IikKK2FkZF9leGVjdXRhYmxlKHRlc3RSZWdFeHAgJHtKU0NfU09VUkNF U30pCitzZXRfdGFyZ2V0X3Byb3BlcnRpZXModGVzdFJlZ0V4cCBQUk9QRVJUSUVTIE9VVFBVVF9O QU1FICJ0ZXN0UmVnRXhwJHtERUJVR19TVUZGSVh9IikKK3RhcmdldF9saW5rX2xpYnJhcmllcyh0 ZXN0UmVnRXhwIHNobHdhcGkpCithZGRfZGVwZW5kZW5jaWVzKHRlc3RSZWdFeHAgdGVzdFJlZ0V4 cExpYikKK3RhcmdldF9saW5rX2xpYnJhcmllcyh0ZXN0UmVnRXhwTGliIEphdmFTY3JpcHRDb3Jl KQorCithZGRfbGlicmFyeSh0ZXN0YXBpTGliIFNIQVJFRAorICAgIC4uL0FQSS90ZXN0cy9Db21w YXJlQW5kU3dhcFRlc3QuY3BwCisgICAgLi4vQVBJL3Rlc3RzL0N1c3RvbUdsb2JhbE9iamVjdENs YXNzVGVzdC5jCisgICAgLi4vQVBJL3Rlc3RzL0V4ZWN1dGlvblRpbWVMaW1pdFRlc3QuY3BwCisg ICAgLi4vQVBJL3Rlc3RzL0dsb2JhbENvbnRleHRXaXRoRmluYWxpemVyVGVzdC5jcHAKKyAgICAu Li9BUEkvdGVzdHMvUGluZ1BvbmdTdGFja092ZXJmbG93VGVzdC5jcHAKKyAgICAuLi9BUEkvdGVz dHMvdGVzdGFwaS5jCispCitzZXRfc291cmNlX2ZpbGVzX3Byb3BlcnRpZXMoLi4vQVBJL3Rlc3Rz L0N1c3RvbUdsb2JhbE9iamVjdENsYXNzVGVzdC5jIFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAi L1RQIC9NVCIpCitzZXRfc291cmNlX2ZpbGVzX3Byb3BlcnRpZXMoLi4vQVBJL3Rlc3RzL3Rlc3Rh cGkuYyBQUk9QRVJUSUVTIENPTVBJTEVfRkxBR1MgIi9UUCAvTVQiKQorc2V0X3RhcmdldF9wcm9w ZXJ0aWVzKHRlc3RhcGlMaWIgUFJPUEVSVElFUyBGT0xERVIgIkphdmFTY3JpcHRDb3JlIikKK3Nl dF90YXJnZXRfcHJvcGVydGllcyh0ZXN0YXBpTGliIFBST1BFUlRJRVMgT1VUUFVUX05BTUUgInRl c3RhcGkke0RFQlVHX1NVRkZJWH0iKQorYWRkX2V4ZWN1dGFibGUodGVzdGFwaSAke0pTQ19TT1VS Q0VTfSkKK3NldF90YXJnZXRfcHJvcGVydGllcyh0ZXN0YXBpIFBST1BFUlRJRVMgT1VUUFVUX05B TUUgInRlc3RhcGkke0RFQlVHX1NVRkZJWH0iKQordGFyZ2V0X2xpbmtfbGlicmFyaWVzKHRlc3Rh cGkgc2hsd2FwaSkKK2FkZF9kZXBlbmRlbmNpZXModGVzdGFwaSB0ZXN0YXBpTGliKQordGFyZ2V0 X2xpbmtfbGlicmFyaWVzKHRlc3RhcGlMaWIgSmF2YVNjcmlwdENvcmUpCisKK2ZpbGUoQ09QWQor ICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0vQVBJL3Rlc3RzL3Rlc3RhcGkuanMiCisgICAgREVT VElOQVRJT04KKyAgICAke0NNQUtFX1JVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWX0KKykKSW5kZXg6 IFNvdXJjZS9QbGF0Zm9ybVdpbi5jbWFrZQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9QbGF0Zm9y bVdpbi5jbWFrZQkocmV2aXNpb24gMCkNCisrKyBTb3VyY2UvUGxhdGZvcm1XaW4uY21ha2UJKHdv cmtpbmcgY29weSkNCkBAIC0wLDAgKzEsMTIgQEANCitzZXQoV0VCSU5TUEVDVE9SVUlfRElSICIk e0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9XZWJJbnNwZWN0b3JVSSIpDQorc2V0KFdFQl9JTlNQ RUNUT1JfRElSICR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfS9XZWJLaXQucmVzb3Vy Y2VzL1dlYkluc3BlY3RvclVJKQ0KKw0KK2FkZF9jdXN0b21fdGFyZ2V0KA0KKyAgICB3ZWItaW5z cGVjdG9yLXJlc291cmNlcyBBTEwNCisgICAgQ09NTUFORCAke0NNQUtFX0NPTU1BTkR9IC1FIGNv cHlfZGlyZWN0b3J5ICR7V0VCSU5TUEVDVE9SVUlfRElSfS9Vc2VySW50ZXJmYWNlICR7V0VCX0lO U1BFQ1RPUl9ESVJ9DQorICAgIENPTU1BTkQgJHtDTUFLRV9DT01NQU5EfSAtRSBjb3B5ICR7REVS SVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5zcGVjdG9yL0luc3BlY3RvckJhY2tl bmRDb21tYW5kcy5qcyAke1dFQl9JTlNQRUNUT1JfRElSfS9Qcm90b2NvbA0KKyAgICBDT01NQU5E ICR7Q01BS0VfQ09NTUFORH0gLUUgY29weSAke1dFQklOU1BFQ1RPUlVJX0RJUn0vTG9jYWxpemF0 aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzICR7V0VCX0lOU1BFQ1RPUl9ESVJ9DQor ICAgIENPTU1BTkQgJHtDTUFLRV9DT01NQU5EfSAtRSBjb3B5ICR7V0VCS0lUMl9ESVJ9L1VJUHJv Y2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvZnJvbnQtZW5kL2luc3BlY3RvclBhZ2VJbmRleC5odG1sICR7 V0VCX0lOU1BFQ1RPUl9ESVJ9DQorICAgIERFUEVORFMgSmF2YVNjcmlwdENvcmUgV2ViQ29yZQ0K KyAgICBXT1JLSU5HX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9DQorKQ0K