149333 2015-09-17 21:23:10 -0700 Web Inspector: Simplify some functional callbacks 2015-09-18 00:36:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1127042 0 joepeck 2015-09-17 21:23:10 -0700 * SUMMARY Simplify some functional callbacks. We have a few cases of: arr.map( (x) => { return foo(x) } ) Which can just be: arr.map(foo) 1127058 1 261487 joepeck 2015-09-17 21:50:56 -0700 Created attachment 261487 [PATCH] Proposed Fix 1127065 2 261487 bburg 2015-09-17 22:18:02 -0700 Comment on attachment 261487 [PATCH] Proposed Fix r=me I did not know you could Array.map a constructor, but i guess it works! 1127075 3 261487 commit-queue 2015-09-17 23:04:56 -0700 Comment on attachment 261487 [PATCH] Proposed Fix Clearing flags on attachment: 261487 Committed r189965: <http://trac.webkit.org/changeset/189965> 1127076 4 commit-queue 2015-09-17 23:05:00 -0700 All reviewed patches have been landed. Closing bug. 1127086 5 joepeck 2015-09-18 00:36:02 -0700 > I did not know you could Array.map a constructor To be clear, none of these were replacing calls to constructors. They happened to be functions that took in an argument and returned a value. `Number`, `isNaN`, `WebInspector.Foo.fromProtocol`. Number is just weird in that it can be used with `new` but is even better when used without it =). 261487 2015-09-17 21:50:56 -0700 2015-09-17 23:04:56 -0700 [PATCH] Proposed Fix simplify.patch text/plain 7439 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDljZWU3ZjEuLjBiMTAwNjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDE1LTA5LTE3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2ltcGxp Znkgc29tZSBmdW5jdGlvbmFsIGNhbGxiYWNrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0xvZ01hbmFn ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTG9nTWFuYWdlci5wcm90b3R5cGUubWVzc2Fn ZVdhc0FkZGVkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9Db2xvci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db2xvcik6CisgICAgICAgICogVXNlckludGVyZmFjZS9Nb2Rl bHMvR2VvbWV0cnkuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ3ViaWNCZXppZXIuZnJvbUNv b3JkaW5hdGVzKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9PYmplY3RQcmV2aWV3 LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk9iamVjdFByZXZpZXcuZnJvbVBheWxvYWQpOgor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1R5cGVEZXNjcmlwdGlvbi5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UeXBlRGVzY3JpcHRpb24uZnJvbVBheWxvYWQpOgorICAgICAgICAq IFVzZXJJbnRlcmZhY2UvUHJvdG9jb2wvUmVtb3RlT2JqZWN0LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlJlbW90ZU9iamVjdC5wcm90b3R5cGUuZ2V0Q29sbGVjdGlvbkVudHJpZXMpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlJlbW90ZU9iamVjdC5wcm90b3R5cGUuZ2V0Q29sbGVjdGlvbkVu dHJpZXMuKTogRGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0 b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUuZ2V0IG1h cmtlcnMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlLm1hcmtl cnNBdFBvc2l0aW9uKToKKworMjAxNS0wOS0xNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92ZSB1bnVzZWQgY2FuQ2xl YXJCcm93c2VyQ29va2llcyAvIGNhbkNsZWFyQnJvd3NlckNhY2hlIHByb3RvY29sIG1ldGhvZHMK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTMwNwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9Mb2dNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvTG9nTWFuYWdlci5qcwppbmRleCBjNzBhN2VhLi4xNTY3NjM4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Mb2dN YW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRy b2xsZXJzL0xvZ01hbmFnZXIuanMKQEAgLTQ3LDcgKzQ3LDcgQEAgV2ViSW5zcGVjdG9yLkxvZ01h bmFnZXIgPSBjbGFzcyBMb2dNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAg ICAgICAvLyBGSVhNRTogR2V0IGEgcmVxdWVzdCBmcm9tIHJlcXVlc3QgSUQuCiAKICAgICAgICAg aWYgKHBhcmFtZXRlcnMpCi0gICAgICAgICAgICBwYXJhbWV0ZXJzID0gcGFyYW1ldGVycy5tYXAo ZnVuY3Rpb24oeCkgeyByZXR1cm4gV2ViSW5zcGVjdG9yLlJlbW90ZU9iamVjdC5mcm9tUGF5bG9h ZCh4KTsgfSk7CisgICAgICAgICAgICBwYXJhbWV0ZXJzID0gcGFyYW1ldGVycy5tYXAoV2ViSW5z cGVjdG9yLlJlbW90ZU9iamVjdC5mcm9tUGF5bG9hZCk7CiAKICAgICAgICAgdmFyIG1lc3NhZ2Ug PSBuZXcgV2ViSW5zcGVjdG9yLkNvbnNvbGVNZXNzYWdlKHNvdXJjZSwgbGV2ZWwsIHRleHQsIHR5 cGUsIHVybCwgbGluZSwgY29sdW1uLCByZXBlYXRDb3VudCwgcGFyYW1ldGVycywgc3RhY2tUcmFj ZSwgbnVsbCk7CiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3Bl Y3Rvci5Mb2dNYW5hZ2VyLkV2ZW50Lk1lc3NhZ2VBZGRlZCwge21lc3NhZ2V9KTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Db2xvci5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9Db2xvci5qcwppbmRl eCBhZTkzODI3Li43MDE0MmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Nb2RlbHMvQ29sb3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvTW9kZWxzL0NvbG9yLmpzCkBAIC0zOCw5ICszOCw3IEBAIFdlYkluc3BlY3Rv ci5Db2xvciA9IGNsYXNzIENvbG9yCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIHRoaXMuX3Jn YmEgPSBjb21wb25lbnRzOwogCi0gICAgICAgIHRoaXMudmFsaWQgPSAhY29tcG9uZW50cy5zb21l KGZ1bmN0aW9uKGNvbXBvbmVudCkgewotICAgICAgICAgICAgcmV0dXJuIGlzTmFOKGNvbXBvbmVu dCk7Ci0gICAgICAgIH0pOworICAgICAgICB0aGlzLnZhbGlkID0gIWNvbXBvbmVudHMuc29tZShp c05hTik7CiAgICAgfQogCiAgICAgLy8gU3RhdGljCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvR2VvbWV0cnkuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvR2VvbWV0cnkuanMKaW5kZXggZTVlOGFjZS4u NTkxMGM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL0dlb21ldHJ5LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL01vZGVscy9HZW9tZXRyeS5qcwpAQCAtMzQ5LDcgKzM0OSw3IEBAIFdlYkluc3BlY3Rvci5D dWJpY0JlemllciA9IGNsYXNzIEN1YmljQmV6aWVyCiAgICAgICAgIGlmICghY29vcmRpbmF0ZXMg fHwgY29vcmRpbmF0ZXMubGVuZ3RoIDwgNCkKICAgICAgICAgICAgIHJldHVybiBudWxsOwogCi0g ICAgICAgIGNvb3JkaW5hdGVzID0gY29vcmRpbmF0ZXMubWFwKCh4KSA9PiBOdW1iZXIoeCkpOwor ICAgICAgICBjb29yZGluYXRlcyA9IGNvb3JkaW5hdGVzLm1hcChOdW1iZXIpOwogICAgICAgICBp ZiAoY29vcmRpbmF0ZXMuaW5jbHVkZXMoTmFOKSkKICAgICAgICAgICAgIHJldHVybiBudWxsOwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv T2JqZWN0UHJldmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9PYmplY3RQcmV2aWV3LmpzCmluZGV4IDk4YThjZmEuLjVmNmViNmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9PYmplY3RQcmV2aWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9PYmpl Y3RQcmV2aWV3LmpzCkBAIC01MSw5ICs1MSw5IEBAIFdlYkluc3BlY3Rvci5PYmplY3RQcmV2aWV3 ID0gY2xhc3MgT2JqZWN0UHJldmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICBz dGF0aWMgZnJvbVBheWxvYWQocGF5bG9hZCkKICAgICB7CiAgICAgICAgIGlmIChwYXlsb2FkLnBy b3BlcnRpZXMpCi0gICAgICAgICAgICBwYXlsb2FkLnByb3BlcnRpZXMgPSBwYXlsb2FkLnByb3Bl cnRpZXMubWFwKGZ1bmN0aW9uKHByb3BlcnR5KSB7IHJldHVybiBXZWJJbnNwZWN0b3IuUHJvcGVy dHlQcmV2aWV3LmZyb21QYXlsb2FkKHByb3BlcnR5KTsgfSk7CisgICAgICAgICAgICBwYXlsb2Fk LnByb3BlcnRpZXMgPSBwYXlsb2FkLnByb3BlcnRpZXMubWFwKFdlYkluc3BlY3Rvci5Qcm9wZXJ0 eVByZXZpZXcuZnJvbVBheWxvYWQpOwogICAgICAgICBpZiAocGF5bG9hZC5lbnRyaWVzKQotICAg ICAgICAgICAgcGF5bG9hZC5lbnRyaWVzID0gcGF5bG9hZC5lbnRyaWVzLm1hcChmdW5jdGlvbihl bnRyeSkgeyByZXR1cm4gV2ViSW5zcGVjdG9yLkNvbGxlY3Rpb25FbnRyeVByZXZpZXcuZnJvbVBh eWxvYWQoZW50cnkpOyB9KTsKKyAgICAgICAgICAgIHBheWxvYWQuZW50cmllcyA9IHBheWxvYWQu ZW50cmllcy5tYXAoV2ViSW5zcGVjdG9yLkNvbGxlY3Rpb25FbnRyeVByZXZpZXcuZnJvbVBheWxv YWQpOwogCiAgICAgICAgIGlmIChwYXlsb2FkLnN1YnR5cGUgPT09ICJhcnJheSIpIHsKICAgICAg ICAgICAgIC8vIENPTVBBVElCSUxJVFkgKGlPUyA4KTogUnVudGltZS5PYmplY3RQcmV2aWV3IGRp ZCBub3QgaGF2ZSBzaXplIHByb3BlcnR5LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1R5cGVEZXNjcmlwdGlvbi5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9UeXBlRGVzY3JpcHRpb24uanMKaW5kZXgg OTRlMjliMC4uZjhmYzZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL1R5cGVEZXNjcmlwdGlvbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVHlwZURlc2NyaXB0aW9uLmpzCkBAIC01MSw3ICs1 MSw3IEBAIFdlYkluc3BlY3Rvci5UeXBlRGVzY3JpcHRpb24gPSBjbGFzcyBUeXBlRGVzY3JpcHRp b24gZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICAgICAgdmFyIHN0cnVjdHVyZXMg PSB1bmRlZmluZWQ7CiAgICAgICAgIGlmIChwYXlsb2FkLnN0cnVjdHVyZXMpCi0gICAgICAgICAg ICBzdHJ1Y3R1cmVzID0gcGF5bG9hZC5zdHJ1Y3R1cmVzLm1hcChmdW5jdGlvbih4KSB7IHJldHVy biBXZWJJbnNwZWN0b3IuU3RydWN0dXJlRGVzY3JpcHRpb24uZnJvbVBheWxvYWQoeCk7IH0pOwor ICAgICAgICAgICAgc3RydWN0dXJlcyA9IHBheWxvYWQuc3RydWN0dXJlcy5tYXAoV2ViSW5zcGVj dG9yLlN0cnVjdHVyZURlc2NyaXB0aW9uLmZyb21QYXlsb2FkKTsKIAogICAgICAgICByZXR1cm4g bmV3IFdlYkluc3BlY3Rvci5UeXBlRGVzY3JpcHRpb24ocGF5bG9hZC5sZWFzdENvbW1vbkFuY2Vz dG9yLCB0eXBlU2V0LCBzdHJ1Y3R1cmVzLCBwYXlsb2FkLmlzVmFsaWQsIHBheWxvYWQuaXNUcnVu Y2F0ZWQpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1Byb3RvY29sL1JlbW90ZU9iamVjdC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1Byb3RvY29sL1JlbW90ZU9iamVjdC5qcwppbmRleCA0ODNlZjViLi4wMTZi NTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90 b2NvbC9SZW1vdGVPYmplY3QuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvUHJvdG9jb2wvUmVtb3RlT2JqZWN0LmpzCkBAIC0zOTEsNyArMzkxLDcgQEAgV2ViSW5z cGVjdG9yLlJlbW90ZU9iamVjdCA9IGNsYXNzIFJlbW90ZU9iamVjdAogICAgICAgICB2YXIgb2Jq ZWN0R3JvdXAgPSB0aGlzLmlzV2Vha0NvbGxlY3Rpb24oKSA/IHRoaXMuX3dlYWtDb2xsZWN0aW9u T2JqZWN0R3JvdXAoKSA6ICIiOwogCiAgICAgICAgIFJ1bnRpbWVBZ2VudC5nZXRDb2xsZWN0aW9u RW50cmllcyh0aGlzLl9vYmplY3RJZCwgb2JqZWN0R3JvdXAsIHN0YXJ0LCBudW1iZXJUb0ZldGNo LCBmdW5jdGlvbihlcnJvciwgZW50cmllcykgewotICAgICAgICAgICAgZW50cmllcyA9IGVudHJp ZXMubWFwKGZ1bmN0aW9uKGVudHJ5KSB7IHJldHVybiBXZWJJbnNwZWN0b3IuQ29sbGVjdGlvbkVu dHJ5LmZyb21QYXlsb2FkKGVudHJ5KTsgfSk7CisgICAgICAgICAgICBlbnRyaWVzID0gZW50cmll cy5tYXAoV2ViSW5zcGVjdG9yLkNvbGxlY3Rpb25FbnRyeS5mcm9tUGF5bG9hZCk7CiAgICAgICAg ICAgICBjYWxsYmFjayhlbnRyaWVzKTsKICAgICAgICAgfSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMK aW5kZXggNzg4MTA0Ny4uZWFiMDFiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCkBAIC02MjAsMTYgKzYyMCwx MiBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuT2JqZWN0CiAKICAgICBnZXQgbWFya2VycygpCiAgICAgewotICAgICAgICBy ZXR1cm4gdGhpcy5fY29kZU1pcnJvci5nZXRBbGxNYXJrcygpLm1hcChmdW5jdGlvbihjb2RlTWly cm9yVGV4dE1hcmtlcikgewotICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5UZXh0TWFy a2VyLnRleHRNYXJrZXJGb3JDb2RlTWlycm9yVGV4dE1hcmtlcihjb2RlTWlycm9yVGV4dE1hcmtl cik7Ci0gICAgICAgIH0pOworICAgICAgICByZXR1cm4gdGhpcy5fY29kZU1pcnJvci5nZXRBbGxN YXJrcygpLm1hcChXZWJJbnNwZWN0b3IuVGV4dE1hcmtlci50ZXh0TWFya2VyRm9yQ29kZU1pcnJv clRleHRNYXJrZXIpOwogICAgIH0KIAogICAgIG1hcmtlcnNBdFBvc2l0aW9uKHBvc2l0aW9uKQog ICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuX2NvZGVNaXJyb3IuZmluZE1hcmtzQXQocG9zaXRp b24pLm1hcChmdW5jdGlvbihjb2RlTWlycm9yVGV4dE1hcmtlcikgewotICAgICAgICAgICAgcmV0 dXJuIFdlYkluc3BlY3Rvci5UZXh0TWFya2VyLnRleHRNYXJrZXJGb3JDb2RlTWlycm9yVGV4dE1h cmtlcihjb2RlTWlycm9yVGV4dE1hcmtlcik7Ci0gICAgICAgIH0pOworICAgICAgICByZXR1cm4g dGhpcy5fY29kZU1pcnJvci5maW5kTWFya3NBdChwb3NpdGlvbikubWFwKFdlYkluc3BlY3Rvci5U ZXh0TWFya2VyLnRleHRNYXJrZXJGb3JDb2RlTWlycm9yVGV4dE1hcmtlcik7CiAgICAgfQogCiAg ICAgY3JlYXRlQ29sb3JNYXJrZXJzKHJhbmdlKQo=