149304 2015-09-17 15:27:31 -0700 Heavy taps on links are sometimes interpreted as the preview gesture 2015-09-28 14:45:27 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1126894 0 bdakin 2015-09-17 15:27:31 -0700 Heavy taps on links are sometimes interpreted as the preview gesture rdar://problem/22689258 1126896 1 261439 bdakin 2015-09-17 15:30:11 -0700 Created attachment 261439 Patch 1126913 2 261439 mitz 2015-09-17 16:06:12 -0700 Comment on attachment 261439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261439&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162 > + double _lastPreviewStartTime; Is there a way to use std::chrono types for this instead of a mix of doubles and floats? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386 > +static const double gMaximumAccidentalPreviewTime = 250; Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix. 1126922 3 261439 thorton 2015-09-17 16:21:40 -0700 Comment on attachment 261439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261439&action=review >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162 >> + double _lastPreviewStartTime; > > Is there a way to use std::chrono types for this instead of a mix of doubles and floats? Chrono would be good (at the very least, using double everywhere). You can store the time from std::chrono::steady_clock::now() and do something like "std::chrono::duration_cast<std::chrono::milliseconds>( std::chrono::steady_clock::now() - _lastPreviewStartTime)" and compare to the literal 250_ms >> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386 >> +static const double gMaximumAccidentalPreviewTime = 250; > > Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix. Agreed about the g. Don't care if you keep the named constant, but it should at least be inside the function, I guess? 1129078 4 bdakin 2015-09-28 14:45:27 -0700 I rolled this patch out with http://trac.webkit.org/changeset/190284 We're going to try to fix this at a different level. 261439 2015-09-17 15:30:11 -0700 2015-09-17 16:21:40 -0700 Patch for-review.txt text/plain 2795 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTk0MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA5LTE3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBIZWF2eSB0YXBzIG9uIGxpbmtzIGFy ZSBzb21ldGltZXMgaW50ZXJwcmV0ZWQgYXMgdGhlIHByZXZpZXcgZ2VzdHVyZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MzA0CisgICAgICAgIC1h bmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjI2ODkyNTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgcHJldmll dyBnZXN0dXJlIHN0YXJ0cyBhbmQgc3RvcCBhbmQgbGVzcyB0aGFuIDI1MCBtaWxsaXNlY29uZHMg aGF2ZSAKKyAgICAgICAgcGFzc2VkLCB0aGVuIGNhbGwgX2F0dGVtcHRDbGlja0F0TG9jYXRpb24g dG8gdHJlYXQgaXQgYXMgYSBub3JtYWwgdGFwLgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX2ludGVyYWN0 aW9uU2hvdWxkQmVnaW5Gcm9tUHJldmlld0l0ZW1Db250cm9sbGVyOmZvclBvc2l0aW9uOl0pOgor ICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnRlcmFjdGlvblN0YXJ0ZWRGcm9tUHJldmlld0l0 ZW1Db250cm9sbGVyOl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9pbnRlcmFjdGlvblN0 b3BwZWRGcm9tUHJldmlld0l0ZW1Db250cm9sbGVyOl0pOgorCiAyMDE1LTA5LTE3ICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIEFmdGVyIHJlc3Rvcmlu ZyB0YWJzLCBzd2lwZXMgYmFjayB0byBmYXN0IGxvYWRpbmcgcGFnZXMgaGFuZyBmb3IgMyBzZWNv bmRzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLmgJKHJldmlzaW9uIDE4OTgyMSkKKysrIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgJKHdvcmtpbmcgY29w eSkKQEAgLTE1OCw2ICsxNTgsOCBAQCBzdHJ1Y3QgV0tBdXRvQ29ycmVjdGlvbkRhdGEgewogICAg IEJPT0wgX3VzaW5nR2VzdHVyZUZvclNlbGVjdGlvbjsKICAgICBCT09MIF9pbnNwZWN0b3JOb2Rl U2VhcmNoRW5hYmxlZDsKICAgICBCT09MIF9kaWRBY2Nlc3NvcnlUYWJJbml0aWF0ZUZvY3VzOwor CisgICAgZG91YmxlIF9sYXN0UHJldmlld1N0YXJ0VGltZTsKIH0KIAogQGVuZApJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDE4OTgyMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMjM4 LDYgKzMyMzgsOCBAQCAtICh2b2lkKV91bnJlZ2lzdGVyUHJldmlldwogCiAtIChCT09MKV9pbnRl cmFjdGlvblNob3VsZEJlZ2luRnJvbVByZXZpZXdJdGVtQ29udHJvbGxlcjooVUlQcmV2aWV3SXRl bUNvbnRyb2xsZXIgKiljb250cm9sbGVyIGZvclBvc2l0aW9uOihDR1BvaW50KXBvc2l0aW9uCiB7 CisgICAgX2xhc3RQcmV2aWV3U3RhcnRUaW1lID0gbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1l TVMoKTsKKwogICAgIGlmICghX2hpZ2hsaWdodExvbmdQcmVzc0NhbkNsaWNrKQogICAgICAgICBy ZXR1cm4gTk87CiAKQEAgLTMzODEsOCArMzM4MywxNSBAQCAtICh2b2lkKV9pbnRlcmFjdGlvblN0 YXJ0ZWRGcm9tUHJldmlld0l0CiAgICAgW3NlbGYgX2NhbmNlbEludGVyYWN0aW9uXTsKIH0KIAor c3RhdGljIGNvbnN0IGRvdWJsZSBnTWF4aW11bUFjY2lkZW50YWxQcmV2aWV3VGltZSA9IDI1MDsK KwogLSAodm9pZClfaW50ZXJhY3Rpb25TdG9wcGVkRnJvbVByZXZpZXdJdGVtQ29udHJvbGxlcjoo VUlQcmV2aWV3SXRlbUNvbnRyb2xsZXIgKiljb250cm9sbGVyCiB7CisgICAgZmxvYXQgZWxhcHNl ZFRpbWUgPSBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWVNUygpIC0gX2xhc3RQcmV2aWV3U3Rh cnRUaW1lOworCisgICAgaWYgKGVsYXBzZWRUaW1lIDw9IGdNYXhpbXVtQWNjaWRlbnRhbFByZXZp ZXdUaW1lKQorICAgICAgICBbc2VsZiBfYXR0ZW1wdENsaWNrQXRMb2NhdGlvbjpfcG9zaXRpb25J bmZvcm1hdGlvbi5wb2ludF07CisKICAgICBbc2VsZiBfYWRkRGVmYXVsdEdlc3R1cmVSZWNvZ25p emVyc107CiAKICAgICBpZiAoIVtfYWN0aW9uU2hlZXRBc3Npc3RhbnQgaXNTaG93aW5nU2hlZXRd KQo=