<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>149284</bug_id>
          
          <creation_ts>2015-09-17 14:06:29 -0700</creation_ts>
          <short_desc>Web Inspector: Add UI and settings management logic for SettingsTabContentView</short_desc>
          <delta_ts>2017-01-13 14:09:11 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>149120</blocked>
    
    <blocked>149261</blocked>
    
    <blocked>149487</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Baker">mattbaker</reporter>
          <assigned_to name="Devin Rousso">hi</assigned_to>
          <cc>bburg</cc>
    
    <cc>graouts</cc>
    
    <cc>hi</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>ksdshack</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1126828</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Baker">mattbaker</who>
    <bug_when>2015-09-17 14:06:29 -0700</bug_when>
    <thetext>* SUMMARY
Add UI and settings management logic for SettingsTabContentView. Some things we&apos;ll likely need:

- UI/CSS for setting groups (Text Editor, Console, etc), and setting items (toggle, radio/picker, nested settings)
- A manager class for persisting settings, dispatching settings change notifications, storing defaults
- A way to reset all settings to their defaults

* NOTES
This issue covers generic infrastructure only. The addition of specific settings will be tracked by separate issues as needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1126829</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2015-09-17 14:06:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/22745863&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266317</commentid>
    <comment_count>2</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2017-01-12 15:11:12 -0800</bug_when>
    <thetext>What is left to do here? Aren&apos;t most settings saved as WI.Setting which has events already?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266418</commentid>
    <comment_count>3</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2017-01-12 20:49:32 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; What is left to do here? Aren&apos;t most settings saved as WI.Setting which has
&gt; events already?

I think this bug was kept open because &lt;https://webkit.org/b/149487&gt; is still open and this bug blocks it.  This bug was really a META bug, but never marked as such.  Unless anyone has an issue, I think we can close it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266571</commentid>
    <comment_count>4</comment_count>
    <who name="Matt Baker">mattbaker</who>
    <bug_when>2017-01-13 13:29:31 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; What is left to do here? Aren&apos;t most settings saved as WI.Setting which has
&gt; &gt; events already?
&gt; 
&gt; I think this bug was kept open because &lt;https://webkit.org/b/149487&gt; is
&gt; still open and this bug blocks it.  This bug was really a META bug, but
&gt; never marked as such.  Unless anyone has an issue, I think we can close it.

Let&apos;s close it.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>