149254 2015-09-17 02:08:30 -0700 Calling a float function on x86 in WebAssembly incorrectly returns a double 2015-09-17 10:40:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146064 1 sukolsak webkit-unassigned commit-queue fpizlo ggaren mark.lam msaboff sukolsak oldest_to_newest 1126650 0 sukolsak 2015-09-17 02:08:30 -0700 In WebAssembly on x86 (32-bit), when we call a function that returns a float or a double, we use the FSTP instruction to read the return value from the FPU register stack. The FSTP instruction converts the value to single-precision or double-precision floating-point format, depending on the destination operand. Currently, we always use double as the destination. This is wrong. We should use the correct type. 1126654 1 261380 sukolsak 2015-09-17 02:16:07 -0700 Created attachment 261380 Patch 1126695 2 261380 msaboff 2015-09-17 08:01:27 -0700 Comment on attachment 261380 Patch r=me 1126730 3 261380 commit-queue 2015-09-17 10:40:23 -0700 Comment on attachment 261380 Patch Clearing flags on attachment: 261380 Committed r189918: <http://trac.webkit.org/changeset/189918> 1126731 4 commit-queue 2015-09-17 10:40:27 -0700 All reviewed patches have been landed. Closing bug. 261380 2015-09-17 02:16:07 -0700 2015-09-17 10:40:23 -0700 Patch bug-149254-20150917021633.patch text/plain 5802 sukolsak U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 ZmZiNDljMTE3NGJkNTA1OWNlZDM2YmNjODExNmFiYWYyYjQ1MTkyLi41MjVlMjU3NzgzNzBhYjg0 OGI1MTlhMWU5ZGJlNmFkZDk3Y2MwNjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxNS0wOS0xNyAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdt YWlsLmNvbT4KKworICAgICAgICBDYWxsaW5nIGEgZmxvYXQgZnVuY3Rpb24gb24geDg2IGluIFdl YkFzc2VtYmx5IGluY29ycmVjdGx5IHJldHVybnMgYSBkb3VibGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTI1NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFdlYkFzc2VtYmx5IG9uIHg4NiAoMzIt Yml0KSwgd2hlbiB3ZSBjYWxsIGEgZnVuY3Rpb24gdGhhdCByZXR1cm5zIGEKKyAgICAgICAgZmxv YXQgb3IgYSBkb3VibGUsIHdlIHVzZSB0aGUgRlNUUCBpbnN0cnVjdGlvbiB0byByZWFkIHRoZSBy ZXR1cm4gdmFsdWUKKyAgICAgICAgZnJvbSB0aGUgRlBVIHJlZ2lzdGVyIHN0YWNrLiBUaGUgRlNU UCBpbnN0cnVjdGlvbiBjb252ZXJ0cyB0aGUgdmFsdWUgdG8KKyAgICAgICAgc2luZ2xlLXByZWNp c2lvbiBvciBkb3VibGUtcHJlY2lzaW9uIGZsb2F0aW5nLXBvaW50IGZvcm1hdCwgZGVwZW5kaW5n IG9uCisgICAgICAgIHRoZSBkZXN0aW5hdGlvbiBvcGVyYW5kLiBDdXJyZW50bHksIHdlIGFsd2F5 cyB1c2UgZG91YmxlIGFzIHRoZQorICAgICAgICBkZXN0aW5hdGlvbiwgd2hpY2ggaXMgd3Jvbmcu IFRoaXMgcGF0Y2ggdXNlcyB0aGUgY29ycmVjdCByZXR1cm4gdHlwZS4KKyAgICAgICAgVGhpcyBz aG91bGQgZml4IHRoZSB0ZXN0IGVycm9ycyBpbiB0ZXN0cy9zdHJlc3Mvd2FzbS1hcml0aG1ldGlj LWZsb2F0MzIuanMKKworICAgICAgICAqIGFzc2VtYmxlci9YODZBc3NlbWJsZXIuaDoKKyAgICAg ICAgKEpTQzo6WDg2QXNzZW1ibGVyOjpmc3Rwcyk6CisgICAgICAgICogd2FzbS9XQVNNRnVuY3Rp b25Db21waWxlci5oOgorICAgICAgICAoSlNDOjpXQVNNRnVuY3Rpb25Db21waWxlcjo6YXBwZW5k Q2FsbFNldFJlc3VsdCk6CisgICAgICAgIChKU0M6OldBU01GdW5jdGlvbkNvbXBpbGVyOjpjYWxs T3BlcmF0aW9uKToKKwogMjAxNS0wOS0xNiAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2Fr QGdtYWlsLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgaW5kaXJlY3QgY2FsbHMgaW4gV2ViQXNz ZW1ibHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNz ZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5o CmluZGV4IDE5NmM2NzU2NTQ5NmRlNDlhNGI3YjhhZDU5OGMwN2MzYmZkMjllNjEuLjE4MGQzM2Mx NzI5MmZiNDIwMjdiYmI5YzgwNjM3YmI1Y2Q0NmMzYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaApAQCAtMjI3LDYgKzIyNyw3IEBAIHByaXZh dGU6CiAgICAgICAgIE9QX0lOVDMgICAgICAgICAgICAgICAgICAgICAgICAgPSAweENDLAogICAg ICAgICBPUF9HUk9VUDJfRXYxICAgICAgICAgICAgICAgICAgID0gMHhEMSwKICAgICAgICAgT1Bf R1JPVVAyX0V2Q0wgICAgICAgICAgICAgICAgICA9IDB4RDMsCisgICAgICAgIE9QX0VTQ0FQRV9E OSAgICAgICAgICAgICAgICAgICAgPSAweEQ5LAogICAgICAgICBPUF9FU0NBUEVfREQgICAgICAg ICAgICAgICAgICAgID0gMHhERCwKICAgICAgICAgT1BfQ0FMTF9yZWwzMiAgICAgICAgICAgICAg ICAgICA9IDB4RTgsCiAgICAgICAgIE9QX0pNUF9yZWwzMiAgICAgICAgICAgICAgICAgICAgPSAw eEU5LApAQCAtMzIzLDYgKzMyNCw3IEBAIHByaXZhdGU6CiAgICAgICAgIEdST1VQMTRfT1BfUFNM TFEgPSA2LAogICAgICAgICBHUk9VUDE0X09QX1BTUkxRID0gMiwKIAorICAgICAgICBFU0NBUEVf RDlfRlNUUF9zaW5nbGVSZWFsID0gMywKICAgICAgICAgRVNDQVBFX0REX0ZTVFBfZG91YmxlUmVh bCA9IDMsCiAgICAgfSBHcm91cE9wY29kZUlEOwogICAgIApAQCAtMTI2NSw2ICsxMjY3LDExIEBA IHB1YmxpYzoKICAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0ZU9wKE9QX0NEUSk7CiAgICAgfQog CisgICAgdm9pZCBmc3RwcyhpbnQgb2Zmc2V0LCBSZWdpc3RlcklEIGJhc2UpCisgICAgeworICAg ICAgICBtX2Zvcm1hdHRlci5vbmVCeXRlT3AoT1BfRVNDQVBFX0Q5LCBFU0NBUEVfRDlfRlNUUF9z aW5nbGVSZWFsLCBiYXNlLCBvZmZzZXQpOworICAgIH0KKwogICAgIHZvaWQgZnN0cGwoaW50IG9m ZnNldCwgUmVnaXN0ZXJJRCBiYXNlKQogICAgIHsKICAgICAgICAgbV9mb3JtYXR0ZXIub25lQnl0 ZU9wKE9QX0VTQ0FQRV9ERCwgRVNDQVBFX0REX0ZTVFBfZG91YmxlUmVhbCwgYmFzZSwgb2Zmc2V0 KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkNv bXBpbGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XQVNNRnVuY3Rpb25Db21waWxl ci5oCmluZGV4IDM1ZGVlNzQyYTE2ZTg3M2I1MzIxNTc2NjY5NGU4ZTVkYWJiZDIxYmIuLmRmNjdl NDhlOWVlN2ZiMzQ5MWQwMmJhN2ZhYWQ2YTRhOGZmYzZjYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkNvbXBpbGVyLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3dhc20vV0FTTUZ1bmN0aW9uQ29tcGlsZXIuaApAQCAtODAxLDYgKzgwMSw4 IEBAIHByaXZhdGU6CiAgICAgICAgIGRvdWJsZSBkb3VibGVWYWx1ZTsKICAgICB9OwogCisgICAg ZW51bSBjbGFzcyBGbG9hdGluZ1BvaW50UHJlY2lzaW9uIHsgU2luZ2xlLCBEb3VibGUgfTsKKwog ICAgIEFkZHJlc3MgbG9jYWxBZGRyZXNzKHVuc2lnbmVkIGxvY2FsSW5kZXgpIGNvbnN0CiAgICAg ewogICAgICAgICBBU1NFUlQobG9jYWxJbmRleCA8IG1fbnVtYmVyT2ZMb2NhbHMpOwpAQCAtODM4 LDIwICs4NDAsMjcgQEAgcHJpdmF0ZToKICAgICB9CiAKICNpZiBDUFUoWDg2KQotICAgIHZvaWQg YXBwZW5kQ2FsbFNldFJlc3VsdChjb25zdCBGdW5jdGlvblB0ciYgZnVuY3Rpb24sIEZQUlJlZyBy ZXN1bHQpCisgICAgdm9pZCBhcHBlbmRDYWxsU2V0UmVzdWx0KGNvbnN0IEZ1bmN0aW9uUHRyJiBm dW5jdGlvbiwgRlBSUmVnIHJlc3VsdCwgRmxvYXRpbmdQb2ludFByZWNpc2lvbiBwcmVjaXNpb24p CiAgICAgewogICAgICAgICBhcHBlbmRDYWxsKGZ1bmN0aW9uKTsKLSAgICAgICAgbV9hc3NlbWJs ZXIuZnN0cGwoMCwgc3RhY2tQb2ludGVyUmVnaXN0ZXIpOworICAgICAgICBzd2l0Y2ggKHByZWNp c2lvbikgeworICAgICAgICBjYXNlIEZsb2F0aW5nUG9pbnRQcmVjaXNpb246OlNpbmdsZToKKyAg ICAgICAgICAgIG1fYXNzZW1ibGVyLmZzdHBzKDAsIHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKKyAg ICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEZsb2F0aW5nUG9pbnRQcmVjaXNpb246OkRv dWJsZToKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLmZzdHBsKDAsIHN0YWNrUG9pbnRlclJlZ2lz dGVyKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICB9CiAgICAgICAgIGxvYWREb3VibGUo c3RhY2tQb2ludGVyUmVnaXN0ZXIsIHJlc3VsdCk7CiAgICAgfQogI2VsaWYgQ1BVKEFSTSkgJiYg IUNQVShBUk1fSEFSREZQKQotICAgIHZvaWQgYXBwZW5kQ2FsbFNldFJlc3VsdChjb25zdCBGdW5j dGlvblB0ciYgZnVuY3Rpb24sIEZQUlJlZyByZXN1bHQpCisgICAgdm9pZCBhcHBlbmRDYWxsU2V0 UmVzdWx0KGNvbnN0IEZ1bmN0aW9uUHRyJiBmdW5jdGlvbiwgRlBSUmVnIHJlc3VsdCwgRmxvYXRp bmdQb2ludFByZWNpc2lvbikKICAgICB7CiAgICAgICAgIGFwcGVuZENhbGwoZnVuY3Rpb24pOwog ICAgICAgICBtX2Fzc2VtYmxlci52bW92KHJlc3VsdCwgR1BSSW5mbzo6cmV0dXJuVmFsdWVHUFIs IEdQUkluZm86OnJldHVyblZhbHVlR1BSMik7CiAgICAgfQogI2Vsc2UgLy8gQ1BVKFg4Nl82NCkg fHwgKENQVShBUk0pICYmIENQVShBUk1fSEFSREZQKSkgfHwgQ1BVKEFSTTY0KSB8fCBDUFUoTUlQ UykgfHwgQ1BVKFNINCkKLSAgICB2b2lkIGFwcGVuZENhbGxTZXRSZXN1bHQoY29uc3QgRnVuY3Rp b25QdHImIGZ1bmN0aW9uLCBGUFJSZWcgcmVzdWx0KQorICAgIHZvaWQgYXBwZW5kQ2FsbFNldFJl c3VsdChjb25zdCBGdW5jdGlvblB0ciYgZnVuY3Rpb24sIEZQUlJlZyByZXN1bHQsIEZsb2F0aW5n UG9pbnRQcmVjaXNpb24pCiAgICAgewogICAgICAgICBhcHBlbmRDYWxsKGZ1bmN0aW9uKTsKICAg ICAgICAgbW92ZURvdWJsZShGUFJJbmZvOjpyZXR1cm5WYWx1ZUZQUiwgcmVzdWx0KTsKQEAgLTg2 OCw3ICs4NzcsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgY2FsbE9wZXJhdGlvbihEX0pJVE9wZXJh dGlvbl9FSiBvcGVyYXRpb24sIEdQUlJlZyBzcmMsIEZQUlJlZyBkc3QpCiAgICAgewogICAgICAg ICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoc3JjKTsKLSAgICAgICAgYXBwZW5kQ2FsbFNl dFJlc3VsdChvcGVyYXRpb24sIGRzdCk7CisgICAgICAgIGFwcGVuZENhbGxTZXRSZXN1bHQob3Bl cmF0aW9uLCBkc3QsIEZsb2F0aW5nUG9pbnRQcmVjaXNpb246OkRvdWJsZSk7CiAgICAgfQogI2Vs c2UKICAgICAvLyBFbmNvZGVkSlNWYWx1ZSBpbiBKU1ZBTFVFMzJfNjQgaXMgYSA2NC1iaXQgaW50 ZWdlci4gV2hlbiBiZWluZyBjb21waWxlZCBpbiBBUk0gRUFCSSwgaXQgbXVzdCBiZSBhbGlnbmVk IGV2ZW4tbnVtYmVyZWQgcmVnaXN0ZXIgKHIwLCByMiBvciBbc3BdKS4KQEAgLTg4OCwxNCArODk3 LDE0IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjYWxsT3BlcmF0aW9uKERfSklUT3BlcmF0aW9uX0VK IG9wZXJhdGlvbiwgR1BSUmVnIHNyY1RhZywgR1BSUmVnIHNyY1BheWxvYWQsIEZQUlJlZyBkc3Qp CiAgICAgewogICAgICAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoRUFCSV8zMkJJVF9E VU1NWV9BUkcgc3JjUGF5bG9hZCwgc3JjVGFnKTsKLSAgICAgICAgYXBwZW5kQ2FsbFNldFJlc3Vs dChvcGVyYXRpb24sIGRzdCk7CisgICAgICAgIGFwcGVuZENhbGxTZXRSZXN1bHQob3BlcmF0aW9u LCBkc3QsIEZsb2F0aW5nUG9pbnRQcmVjaXNpb246OkRvdWJsZSk7CiAgICAgfQogI2VuZGlmCiAK ICAgICB2b2lkIGNhbGxPcGVyYXRpb24oZmxvYXQgSklUX09QRVJBVElPTiAoKm9wZXJhdGlvbiko ZmxvYXQpLCBGUFJlZ2lzdGVySUQgc3JjLCBGUFJlZ2lzdGVySUQgZHN0KQogICAgIHsKICAgICAg ICAgc2V0dXBBcmd1bWVudHMoc3JjKTsKLSAgICAgICAgYXBwZW5kQ2FsbFNldFJlc3VsdChvcGVy YXRpb24sIGRzdCk7CisgICAgICAgIGFwcGVuZENhbGxTZXRSZXN1bHQob3BlcmF0aW9uLCBkc3Qs IEZsb2F0aW5nUG9pbnRQcmVjaXNpb246OlNpbmdsZSk7CiAgICAgfQogCiAgICAgdm9pZCBjYWxs T3BlcmF0aW9uKGludDMyX3QgSklUX09QRVJBVElPTiAoKm9wZXJhdGlvbikoaW50MzJfdCwgaW50 MzJfdCksIEdQUlJlZyBzcmMxLCBHUFJSZWcgc3JjMiwgR1BSUmVnIGRzdCkK