149252 2015-09-17 01:23:09 -0700 [GTK] run-gtk-tests doesn't provide feedback about crashing google tests 2015-09-21 00:28:39 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned mcatanzaro pnormand zan oldest_to_newest 1126644 0 cgarcia 2015-09-17 01:23:09 -0700 In case of glib tests the test runner notifies about test crashing, but for google tests we don't get any feedback, which means that in case of a test crashign we get a list of **PASS** messages but at the summary we are notified that the test suite has failed: Tests failed (1): bin/TestWebKitAPI/WebKit2/TestWebKit2 But we don't know which test case failed, we would need to check which ones are missing from the output. 1126645 1 261376 cgarcia 2015-09-17 01:27:14 -0700 Created attachment 261376 Patch 1126675 2 mcatanzaro 2015-09-17 05:38:00 -0700 SIGTRAP is another quite common crash signal. There are many less-common signals that can crash the program, but I guess we can't test for them all.... 1127587 3 cgarcia 2015-09-21 00:28:39 -0700 Committed r190046: <http://trac.webkit.org/changeset/190046> 261376 2015-09-17 01:27:14 -0700 2015-09-19 15:33:46 -0700 Patch wk-tests-crashing-feedback.diff text/plain 1652 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmN2Vk MTY3Li43YWY4MzEwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTUtMDktMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIHJ1bi1ndGstdGVzdHMgZG9l c24ndCBwcm92aWRlIGZlZWRiYWNrIGFib3V0IGNyYXNoaW5nIGdvb2dsZSB0ZXN0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MjUyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gY2FzZSBvZiBnbGli IHRlc3RzIHRoZSB0ZXN0IHJ1bm5lciBub3RpZmllcyBhYm91dCB0ZXN0cworICAgICAgICBjcmFz aGluZywgYnV0IGZvciBnb29nbGUgdGVzdHMgd2UgZG9uJ3QgZ2V0IGFueSBmZWVkYmFjaywgd2hp Y2gKKyAgICAgICAgbWVhbnMgdGhhdCBpbiBjYXNlIG9mIGEgdGVzdCBjcmFzaGluZyB3ZSBnZXQg YSBsaXN0IG9mICoqUEFTUyoqCisgICAgICAgIG1lc3NhZ2VzIGFuZCBhdCB0aGUgc3VtbWFyeSB3 ZSBhcmUgbm90aWZpZWQgdGhhdCB0aGUgdGVzdCBzdWl0ZQorICAgICAgICBoYXMgZmFpbGVkLCBi dXQgaXQncyBpbXBvc3NpYmxlIHRvIGtub3cgd2hpY2ggdGVzdCBjYXNlcyBoYXZlIGZhaWxlZC4K KworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIu X3J1bl9nb29nbGVfdGVzdCk6IEFkZCBhICoqQ1JBU0gqKiBtZXNzYWdlIGlmIHRlc3QKKyAgICAg ICAgY2FzZSBjcmFzaGVkLgorCiAyMDE1LTA5LTE2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBwcmludGluZyBkb2VzIG5vdCB1c2UgbWluaW11 bSBwYWdlIHpvb20gZmFjdG9yCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVz dHMgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggYzU3ZmI0MS4uYWRmM2MyMiAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBiL1Rvb2xzL1Njcmlw dHMvcnVuLWd0ay10ZXN0cwpAQCAtMzQ4LDcgKzM0OCwxMiBAQCBjbGFzcyBUZXN0UnVubmVyOgog ICAgICAgICB0aW1lb3V0ID0gc2VsZi5fb3B0aW9ucy50aW1lb3V0CiAgICAgICAgIGlmIHN1YnRl c3QgaW4gVGVzdFJ1bm5lci5TTE9XOgogICAgICAgICAgICAgdGltZW91dCAqPSA1Ci0gICAgICAg IHJldHVybiBzZWxmLl9ydW5fdGVzdF9jb21tYW5kKHRlc3RfY29tbWFuZCwgdGltZW91dCkKKwor ICAgICAgICBzdGF0dXMgPSBzZWxmLl9ydW5fdGVzdF9jb21tYW5kKHRlc3RfY29tbWFuZCwgdGlt ZW91dCkKKyAgICAgICAgaWYgc3RhdHVzID09IC1TSUdTRUdWOgorICAgICAgICAgICAgc3lzLnN0 ZG91dC53cml0ZSgiKipDUkFTSCoqICVzXG4iICUgc3VidGVzdCkKKyAgICAgICAgICAgIHN5cy5z dGRvdXQuZmx1c2goKQorICAgICAgICByZXR1cm4gc3RhdHVzCiAKICAgICBkZWYgX3J1bl9nb29n bGVfdGVzdF9zdWl0ZShzZWxmLCB0ZXN0X3Byb2dyYW0pOgogICAgICAgICByZXRjb2RlID0gMAo=