149238 2015-09-16 16:40:07 -0700 Element's attribute NS API should treat defined undefined namespace as null 2015-09-16 18:25:12 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 1 cdumez cdumez ap rniwa webkit-bug-importer oldest_to_newest 1126514 0 cdumez 2015-09-16 16:40:07 -0700 Element's attribute NS API should defined undefined namespace as null instead of converting it to the "undefined" String. This is because the namespace parameter is a nullable String as per the DOM spec: https://dom.spec.whatwg.org/#element The attribute is nullable and WebIDL says undefined should be converted to null for nullable parameters: https://heycam.github.io/webidl/#es-nullable-type (step 3) 1126518 1 261338 cdumez 2015-09-16 16:45:51 -0700 Created attachment 261338 Patch 1126519 2 cdumez 2015-09-16 16:46:22 -0700 rdar://problem/22562204 1126550 3 261338 rniwa 2015-09-16 18:23:02 -0700 Comment on attachment 261338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261338&action=review > Source/WebCore/ChangeLog:9 > + Element's attribute NS API should defined undefined namespace as null should treat? 1126554 4 cdumez 2015-09-16 18:25:12 -0700 Committed r189893: <http://trac.webkit.org/changeset/189893> 261338 2015-09-16 16:45:51 -0700 2015-09-16 18:23:02 -0700 Patch bug-149238-20150916164538.patch text/plain 5912 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU3MzYwMjU1NzEwM2Fl ZGUyNDYyMjc2MTAwYTk4MGNkMDAyNjdjZS4uM2ZlNjM5YTY5ZGQ2YjdjMGRkMWIwMGZlYWI5N2Rk Y2M4N2FiZWIwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA5LTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRWxlbWVudCdzIGF0dHJpYnV0 ZSBOUyBBUEkgc2hvdWxkIGRlZmluZWQgdW5kZWZpbmVkIG5hbWVzcGFjZSBhcyBudWxsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkyMzgKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzIyNTYyMjA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEVsZW1lbnQncyBhdHRyaWJ1dGUgTlMgQVBJIHNob3VsZCBk ZWZpbmVkIHVuZGVmaW5lZCBuYW1lc3BhY2UgYXMgbnVsbAorICAgICAgICBpbnN0ZWFkIG9mIGNv bnZlcnRpbmcgaXQgdG8gdGhlICJ1bmRlZmluZWQiIFN0cmluZy4gVGhpcyBpcyBiZWNhdXNlIHRo ZQorICAgICAgICBuYW1lc3BhY2UgcGFyYW1ldGVyIGlzIGEgbnVsbGFibGUgU3RyaW5nIGFzIHBl ciB0aGUgRE9NIHNwZWM6CisgICAgICAgIC0gaHR0cHM6Ly9kb20uc3BlYy53aGF0d2cub3JnLyNl bGVtZW50CisKKyAgICAgICAgVGhlIGF0dHJpYnV0ZSBpcyBudWxsYWJsZSBhbmQgV2ViSURMIHNh eXMgdW5kZWZpbmVkIHNob3VsZCBiZSBjb252ZXJ0ZWQKKyAgICAgICAgdG8gbnVsbCBmb3IgbnVs bGFibGUgcGFyYW1ldGVyczoKKyAgICAgICAgLSBodHRwczovL2hleWNhbS5naXRodWIuaW8vd2Vi aWRsLyNlcy1udWxsYWJsZS10eXBlIChzdGVwIDMpCisKKyAgICAgICAgRmlyZWZveCBmb2xsb3dz IHRoZSBzcGVjaWZpY2F0aW9uLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3Zl cmVkIGJ5IGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5pZGw6CisKIDIw MTUtMDktMTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEhh dmUgd2luZG93LmluZGV4ZWREQi5kZWxldGVEYXRhYmFzZSByZXR1cm4gYW4gSURCT3BlbkRCUmVx dWVzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmlkbCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9FbGVtZW50LmlkbAppbmRleCAwNDUzN2E2ZjIxMWU5ZmQ3ZGE4ZTRkMWFk YzA5NTJjMjNkMWVhNWFlLi5iMzM1MGIzNTZkNWQ4YTYwNjM2MDY3MjhhMDg3Mjg4ZGM1MDE3YWIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaWRsCkBAIC00OSwxMiArNDksMTIgQEAKIAogICAgIC8vIERP TSBMZXZlbCAyIENvcmUKIAotICAgIFtPYmpDTGVnYWN5VW5uYW1lZFBhcmFtZXRlcnMsIFRyZWF0 UmV0dXJuZWROdWxsU3RyaW5nQXM9TnVsbF0gRE9NU3RyaW5nIGdldEF0dHJpYnV0ZU5TKFtUcmVh dE51bGxBcz1OdWxsU3RyaW5nLERlZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBET01TdHJpbmcg bmFtZXNwYWNlVVJJLAorICAgIFtPYmpDTGVnYWN5VW5uYW1lZFBhcmFtZXRlcnMsIFRyZWF0UmV0 dXJuZWROdWxsU3RyaW5nQXM9TnVsbF0gRE9NU3RyaW5nIGdldEF0dHJpYnV0ZU5TKFtUcmVhdE51 bGxBcz1OdWxsU3RyaW5nLCBUcmVhdFVuZGVmaW5lZEFzPU51bGxTdHJpbmcsIERlZmF1bHQ9VW5k ZWZpbmVkXSBvcHRpb25hbCBET01TdHJpbmcgbmFtZXNwYWNlVVJJLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFs IERPTVN0cmluZyBsb2NhbE5hbWUpOwotICAgIFtPYmpDTGVnYWN5VW5uYW1lZFBhcmFtZXRlcnMs IFJhaXNlc0V4Y2VwdGlvbl0gdm9pZCBzZXRBdHRyaWJ1dGVOUyhbVHJlYXROdWxsQXM9TnVsbFN0 cmluZyxEZWZhdWx0PVVuZGVmaW5lZF0gb3B0aW9uYWwgRE9NU3RyaW5nIG5hbWVzcGFjZVVSSSwK KyAgICBbT2JqQ0xlZ2FjeVVubmFtZWRQYXJhbWV0ZXJzLCBSYWlzZXNFeGNlcHRpb25dIHZvaWQg c2V0QXR0cmlidXRlTlMoW1RyZWF0TnVsbEFzPU51bGxTdHJpbmcsIFRyZWF0VW5kZWZpbmVkQXM9 TnVsbFN0cmluZywgRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBuYW1lc3Bh Y2VVUkksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbRGVmYXVsdD1V bmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBxdWFsaWZpZWROYW1lLCAKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtEZWZhdWx0PVVuZGVmaW5lZF0gb3B0aW9uYWwg RE9NU3RyaW5nIHZhbHVlKTsKLSAgICBbT2JqQ0xlZ2FjeVVubmFtZWRQYXJhbWV0ZXJzXSB2b2lk IHJlbW92ZUF0dHJpYnV0ZU5TKFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nXSBET01TdHJpbmcgbmFt ZXNwYWNlVVJJLAorICAgIFtPYmpDTGVnYWN5VW5uYW1lZFBhcmFtZXRlcnNdIHZvaWQgcmVtb3Zl QXR0cmlidXRlTlMoW1RyZWF0TnVsbEFzPU51bGxTdHJpbmcsIFRyZWF0VW5kZWZpbmVkQXM9TnVs bFN0cmluZ10gRE9NU3RyaW5nIG5hbWVzcGFjZVVSSSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIERPTVN0cmluZyBsb2NhbE5hbWUpOwogCiAjaWYgZGVmaW5lZChM QU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKQEAgLTYyLDExICs2 MiwxMSBAQAogI2Vsc2UKICAgICBIVE1MQ29sbGVjdGlvbiBnZXRFbGVtZW50c0J5VGFnTmFtZU5T KFtUcmVhdE51bGxBcz1OdWxsU3RyaW5nLERlZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBET01T dHJpbmcgbmFtZXNwYWNlVVJJLCBbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmlu ZyBsb2NhbE5hbWUpOwogI2VuZGlmCi0gICAgW09iakNMZWdhY3lVbm5hbWVkUGFyYW1ldGVyc10g QXR0ciBnZXRBdHRyaWJ1dGVOb2RlTlMoW1RyZWF0TnVsbEFzPU51bGxTdHJpbmcsRGVmYXVsdD1V bmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBuYW1lc3BhY2VVUkksCisgICAgW09iakNMZWdh Y3lVbm5hbWVkUGFyYW1ldGVyc10gQXR0ciBnZXRBdHRyaWJ1dGVOb2RlTlMoW1RyZWF0TnVsbEFz PU51bGxTdHJpbmcsIFRyZWF0VW5kZWZpbmVkQXM9TnVsbFN0cmluZywgRGVmYXVsdD1VbmRlZmlu ZWRdIG9wdGlvbmFsIERPTVN0cmluZyBuYW1lc3BhY2VVUkksCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgW0RlZmF1bHQ9VW5kZWZpbmVkXSBvcHRpb25hbCBET01T dHJpbmcgbG9jYWxOYW1lKTsKICAgICBbUmFpc2VzRXhjZXB0aW9uXSBBdHRyIHNldEF0dHJpYnV0 ZU5vZGVOUyhbRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIEF0dHIgbmV3QXR0cik7CiAgICAg Ym9vbGVhbiBoYXNBdHRyaWJ1dGUoRE9NU3RyaW5nIG5hbWUpOwotICAgIFtPYmpDTGVnYWN5VW5u YW1lZFBhcmFtZXRlcnNdIGJvb2xlYW4gaGFzQXR0cmlidXRlTlMoW1RyZWF0TnVsbEFzPU51bGxT dHJpbmcsRGVmYXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBuYW1lc3BhY2VVUkks CisgICAgW09iakNMZWdhY3lVbm5hbWVkUGFyYW1ldGVyc10gYm9vbGVhbiBoYXNBdHRyaWJ1dGVO UyhbVHJlYXROdWxsQXM9TnVsbFN0cmluZywgVHJlYXRVbmRlZmluZWRBcz1OdWxsU3RyaW5nLCBE ZWZhdWx0PVVuZGVmaW5lZF0gb3B0aW9uYWwgRE9NU3RyaW5nIG5hbWVzcGFjZVVSSSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtEZWZhdWx0PVVuZGVmaW5lZF0g b3B0aW9uYWwgRE9NU3RyaW5nIGxvY2FsTmFtZSk7CiAKICAgICByZWFkb25seSBhdHRyaWJ1dGUg Q1NTU3R5bGVEZWNsYXJhdGlvbiBzdHlsZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmlu ZGV4IDExYTVlYzJhNDg3OWJlYmQ2ZWY3MzIyMWM0ZmQyZDZiNzg4OTA3ZGYuLjRhMjA2NWI3ZWM3 MDA0ZjhlNjgxMGQyOGNhN2VjNTlmZjAzZmVlNmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTE2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CisKKyAgICAgICAgRWxlbWVudCdzIGF0dHJpYnV0ZSBOUyBBUEkgc2hvdWxkIGRl ZmluZWQgdW5kZWZpbmVkIG5hbWVzcGFjZSBhcyBudWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkyMzgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzIyNTYyMjA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlYmFzZWxpbmUgVzNDIERPTSB0ZXN0IHRoYXQgb25lIG1vcmUgY2hlY2sgaXMgcGFzc2lu Zy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvYXR0cmlidXRlcy1l eHBlY3RlZC50eHQ6CisKIDIwMTUtMDktMTUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBEb2N1bWVudC5jcmVhdGVFbGVtZW50KGxvY2FsTmFtZSkgZG9lcyBub3Qg aGFuZGxlIGNvcnJlY3RseSBtaXNzaW5nIG9yIG51bGwgcGFyYW1ldGVyCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9hdHRy aWJ1dGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvZG9tL25vZGVzL2F0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CmluZGV4IDY1ZjhkZmNj ZGYzNTk3ZWMzNmVkYWI3ZjJjODc4NjU4MDQ0NjY0OWYuLmExOWYyNjlkMzE5ZDg2NjkzYzJjY2Zk Y2Y1NjgzNTk4NWU3MDhhNDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL2F0dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL2F0 dHJpYnV0ZXMtZXhwZWN0ZWQudHh0CkBAIC0zMyw3ICszMyw3IEBAIFBBU1MgT25seSBsb3dlcmNh c2UgYXR0cmlidXRlcyBhcmUgcmV0dXJuZWQgb24gSFRNTCBlbGVtZW50cyAodXBwZXIgY2FzZSBh dHRyaWJ1CiBQQVNTIE9ubHkgbG93ZXJjYXNlIGF0dHJpYnV0ZXMgYXJlIHJldHVybmVkIG9uIEhU TUwgZWxlbWVudHMgKG1peGVkIGNhc2UgYXR0cmlidXRlKSAKIFBBU1MgRmlyc3Qgc2V0IGF0dHJp YnV0ZSBpcyByZXR1cm5lZCB3aXRoIG1hcHBlZCBhdHRyaWJ1dGUgc2V0IGZpcnN0IAogUEFTUyBG aXJzdCBzZXQgYXR0cmlidXRlIGlzIHJldHVybmVkIHdpdGggbWFwcGVkIGF0dHJpYnV0ZSBzZXQg bGF0ZXIgCi1GQUlMIE5vbi1IVE1MIGVsZW1lbnQgd2l0aCB1cHBlci1jYXNlIGF0dHJpYnV0ZSBh c3NlcnRfZXF1YWxzOiBlbC5oYXNBdHRyaWJ1dGVOUyh1bmRlZmluZWQpIGV4cGVjdGVkIHRydWUg YnV0IGdvdCBmYWxzZQorUEFTUyBOb24tSFRNTCBlbGVtZW50IHdpdGggdXBwZXItY2FzZSBhdHRy aWJ1dGUgCiBQQVNTIEF0dHJpYnV0ZSB3aXRoIHByZWZpeCBpbiBsb2NhbCBuYW1lIAogUEFTUyBB dHRyaWJ1dGUgbG9zZXMgaXRzIG93bmVyIHdoZW4gcmVtb3ZlZCAKIAo=