149234 2015-09-16 15:10:49 -0700 Have window.indexedDB.open return an IDBOpenDBRequest 2015-09-16 21:28:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 1 beidson beidson achristensen alecflett commit-queue jsbell oldest_to_newest 1126478 0 beidson 2015-09-16 15:10:49 -0700 Have window.indexedDB.open return an IDBOpenDBRequest The request will be non-functional, and a database connection will never actually be opened. But an instance of the object will exist. 1126479 1 261330 beidson 2015-09-16 15:12:57 -0700 Created attachment 261330 Patch v1 1126508 2 beidson 2015-09-16 16:20:54 -0700 The iOS build break is weird and seems unrelated to this patch. The logs don't even tell me what broke. (Maybe it's in there but not obvious to me...?) 1126585 3 261330 achristensen 2015-09-16 20:29:48 -0700 Comment on attachment 261330 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=261330&action=review > Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp:76 > +PassRefPtr<WebCore::IDBOpenDBRequest> IDBFactory::open(ScriptExecutionContext* context, const String& name, ExceptionCode& ec) You really ought to make these ScriptExecutionContext& > Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp:108 > + ASSERT(context->securityOrigin()); > + ASSERT(context->topOrigin()); Why are these always non-null? 1126591 4 beidson 2015-09-16 20:40:54 -0700 (In reply to comment #3) > Comment on attachment 261330 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261330&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp:76 > > +PassRefPtr<WebCore::IDBOpenDBRequest> IDBFactory::open(ScriptExecutionContext* context, const String& name, ExceptionCode& ec) > > You really ought to make these ScriptExecutionContext& Definitely part of 149117. But hacking on IDL/binding generation is not my priority right now. > > > Source/WebCore/Modules/indexeddb/client/IDBFactoryImpl.cpp:108 > > + ASSERT(context->securityOrigin()); > > + ASSERT(context->topOrigin()); > > Why are these always non-null? In practice, the only ScriptExecutionContext ever used is Document, and one can verify through code inspection these are non-null by the time script runs. The Legacy IDB code blindly assumed they were non-null, but the ASSERTs are definitely warranted in case that ever changes. Or, also to capture any non-document context starting to be used where one/both are null. Thanks for the review! 1126596 5 261330 commit-queue 2015-09-16 21:28:01 -0700 Comment on attachment 261330 Patch v1 Clearing flags on attachment: 261330 Committed r189901: <http://trac.webkit.org/changeset/189901> 1126597 6 commit-queue 2015-09-16 21:28:05 -0700 All reviewed patches have been landed. Closing bug. 261330 2015-09-16 15:12:57 -0700 2015-09-16 21:28:01 -0700 Patch v1 patch text/plain 6023 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiODE1NmJjLi5jZTAxMjIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTUtMDkt MTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIEhhdmUgd2lu ZG93LmluZGV4ZWREQi5vcGVuIHJldHVybiBhbiBJREJPcGVuREJSZXF1ZXN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MjM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRk Yi9tb2Rlcm4vb3BlbmRhdGFiYXNlLXJlcXVlc3QtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vb3BlbmRhdGFiYXNlLXJlcXVlc3QuaHRtbDog QWRkZWQuCisKKzIwMTUtMDktMTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgor CiAgICAgICAgIEhhdmUgd2luZG93LmluZGV4ZWREQi5kZWxldGVEYXRhYmFzZSByZXR1cm4gYW4g SURCT3BlbkRCUmVxdWVzdC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE0OTIyOQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9tb2Rlcm4vb3BlbmRhdGFiYXNlLXJlcXVlc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL29wZW5kYXRhYmFzZS1yZXF1ZXN0LWV4cGVjdGVk LnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zZmFkMjkxCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL29wZW5kYXRh YmFzZS1yZXF1ZXN0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYgQEAKK0FMRVJUOiBbb2JqZWN0 IElEQk9wZW5EQlJlcXVlc3RdCitBTEVSVDogW29iamVjdCBJREJPcGVuREJSZXF1ZXN0XQorQUxF UlQ6IFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMKK0FMRVJUOiBUeXBlRXJyb3I6IFR5 cGUgZXJyb3IKK0FMRVJUOiBEb25lCitUaGlzIHRlc3QgY2FsbHMgb3BlbiBvbiB3aW5kb3cuaW5k ZXhlZERCIGluIHZhcmlvdXMgd2F5cywgdmVyaWZ5aW5nIHRoYXQgSURCT3BlbkRCUmVxdWVzdCBv YmplY3RzIGFyZSByZXR1cm5lZCB3aGVuIGV4cGVjdGVkIGFuZCBleGNlcHRpb25zIGFyZSB0aHJv d24gd2hlbiBleHBlY3RlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL21vZGVybi9vcGVuZGF0YWJhc2UtcmVxdWVzdC5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvbW9kZXJuL29wZW5kYXRhYmFzZS1yZXF1ZXN0Lmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMGY3ZTdkNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9vcGVuZGF0YWJhc2UtcmVxdWVzdC5odG1s CkBAIC0wLDAgKzEsMzUgQEAKK1RoaXMgdGVzdCBjYWxscyBvcGVuIG9uIHdpbmRvdy5pbmRleGVk REIgaW4gdmFyaW91cyB3YXlzLCB2ZXJpZnlpbmcgdGhhdCBJREJPcGVuREJSZXF1ZXN0IG9iamVj dHMgYXJlIHJldHVybmVkIHdoZW4gZXhwZWN0ZWQgYW5kIGV4Y2VwdGlvbnMgYXJlIHRocm93biB3 aGVuIGV4cGVjdGVkLgorPHNjcmlwdD4KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAg dGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7 Cit9CisKK2Z1bmN0aW9uIGRvbmUoKQoreworICAgIGFsZXJ0KCJEb25lIik7CisgICAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKK30KKwor dmFyIHJlcXVlc3QgPSB3aW5kb3cuaW5kZXhlZERCLm9wZW4oIlRlc3REYXRhYmFzZSIpOworYWxl cnQocmVxdWVzdCk7CisKK3JlcXVlc3QgPSB3aW5kb3cuaW5kZXhlZERCLm9wZW4oIiIpOworYWxl cnQocmVxdWVzdCk7CisKK3RyeSB7CisJdmFyIHJlcXVlc3QgPSB3aW5kb3cuaW5kZXhlZERCLm9w ZW4oKTsKK30gY2F0Y2ggKGUpIHsKKwlhbGVydChlKTsKK30KKwordHJ5IHsKKwl2YXIgcmVxdWVz dCA9IHdpbmRvdy5pbmRleGVkREIub3BlbigibmFtZSIsIDApOworfSBjYXRjaCAoZSkgeworCWFs ZXJ0KGUpOworfQorCitkb25lKCk7Cis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlNTczNjAyLi5m ZjkyN2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTUtMDktMTYgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAgICAgIEhhdmUgd2luZG93LmluZGV4ZWRE Qi5vcGVuIHJldHVybiBhbiBJREJPcGVuREJSZXF1ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJu L29wZW5kYXRhYmFzZS1yZXF1ZXN0Lmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRi L2NsaWVudC9JREJGYWN0b3J5SW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJDbGllbnQ6 OklEQkZhY3Rvcnk6Om9wZW4pOgorICAgICAgICAoV2ViQ29yZTo6SURCQ2xpZW50OjpJREJGYWN0 b3J5OjpvcGVuSW50ZXJuYWwpOgorICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9J REJGYWN0b3J5SW1wbC5oOgorCisyMDE1LTA5LTE2ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFw cGxlLmNvbT4KKwogICAgICAgICBIYXZlIHdpbmRvdy5pbmRleGVkREIuZGVsZXRlRGF0YWJhc2Ug cmV0dXJuIGFuIElEQk9wZW5EQlJlcXVlc3QuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkyMjkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQkZhY3RvcnlJbXBsLmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9JREJGYWN0b3J5SW1wbC5jcHAKaW5kZXggMTQ0 ZjFkNi4uNzBmZWFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvY2xpZW50L0lEQkZhY3RvcnlJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9jbGllbnQvSURCRmFjdG9yeUltcGwuY3BwCkBAIC03MywxNCArNzMsNDcgQEAg UGFzc1JlZlB0cjxXZWJDb3JlOjpJREJSZXF1ZXN0PiBJREJGYWN0b3J5OjpnZXREYXRhYmFzZU5h bWVzKFNjcmlwdEV4ZWN1dGlvbkNvbnQKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAotUGFzc1Jl ZlB0cjxXZWJDb3JlOjpJREJPcGVuREJSZXF1ZXN0PiBJREJGYWN0b3J5OjpvcGVuKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQqLCBjb25zdCBTdHJpbmcmLCBFeGNlcHRpb25Db2RlJikKK1Bhc3NSZWZQ dHI8V2ViQ29yZTo6SURCT3BlbkRCUmVxdWVzdD4gSURCRmFjdG9yeTo6b3BlbihTY3JpcHRFeGVj dXRpb25Db250ZXh0KiBjb250ZXh0LCBjb25zdCBTdHJpbmcmIG5hbWUsIEV4Y2VwdGlvbkNvZGUm IGVjKQogewotICAgIHJldHVybiBudWxscHRyOworICAgIExPRyhJbmRleGVkREIsICJJREJGYWN0 b3J5OjpvcGVuIik7CisgICAgCisgICAgcmV0dXJuIG9wZW5JbnRlcm5hbChjb250ZXh0LCBuYW1l LCAwLCBlYykucmVsZWFzZSgpOwogfQogCi1QYXNzUmVmUHRyPFdlYkNvcmU6OklEQk9wZW5EQlJl cXVlc3Q+IElEQkZhY3Rvcnk6Om9wZW4oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIGNvbnN0IFN0 cmluZyYsIHVuc2lnbmVkIGxvbmcgbG9uZywgRXhjZXB0aW9uQ29kZSYpCitQYXNzUmVmUHRyPFdl YkNvcmU6OklEQk9wZW5EQlJlcXVlc3Q+IElEQkZhY3Rvcnk6Om9wZW4oU2NyaXB0RXhlY3V0aW9u Q29udGV4dCogY29udGV4dCwgY29uc3QgU3RyaW5nJiBuYW1lLCB1bnNpZ25lZCBsb25nIGxvbmcg dmVyc2lvbiwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgcmV0dXJuIG51bGxwdHI7CisgICAg TE9HKEluZGV4ZWREQiwgIklEQkZhY3Rvcnk6Om9wZW4iKTsKKyAgICAKKyAgICBpZiAoIXZlcnNp b24pIHsKKyAgICAgICAgZWMgPSBUeXBlRXJyb3I7CisgICAgICAgIHJldHVybiBudWxscHRyOwor ICAgIH0KKworICAgIHJldHVybiBvcGVuSW50ZXJuYWwoY29udGV4dCwgbmFtZSwgMCwgZWMpLnJl bGVhc2UoKTsKK30KKworUmVmUHRyPElEQk9wZW5EQlJlcXVlc3Q+IElEQkZhY3Rvcnk6Om9wZW5J bnRlcm5hbChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBjb25zdCBTdHJpbmcmIG5h bWUsIHVuc2lnbmVkIGxvbmcgbG9uZywgRXhjZXB0aW9uQ29kZSYgZWMpCit7CisgICAgaWYgKG5h bWUuaXNOdWxsKCkpIHsKKyAgICAgICAgZWMgPSBUeXBlRXJyb3I7CisgICAgICAgIHJldHVybiBu dWxscHRyOworICAgIH0KKworICAgIGlmIChzaG91bGRUaHJvd1NlY3VyaXR5RXhjZXB0aW9uKGNv bnRleHQpKSB7CisgICAgICAgIGVjID0gU0VDVVJJVFlfRVJSOworICAgICAgICByZXR1cm4gbnVs bHB0cjsKKyAgICB9CisKKyAgICBBU1NFUlQoY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKSk7Cisg ICAgQVNTRVJUKGNvbnRleHQtPnRvcE9yaWdpbigpKTsKKyAgICBJREJEYXRhYmFzZUlkZW50aWZp ZXIgZGF0YWJhc2VJZGVudGlmaWVyKG5hbWUsICpjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLCAq Y29udGV4dC0+dG9wT3JpZ2luKCkpOworICAgIGlmICghZGF0YWJhc2VJZGVudGlmaWVyLmlzVmFs aWQoKSkgeworICAgICAgICBlYyA9IFR5cGVFcnJvcjsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7 CisgICAgfQorCisgICAgYXV0byByZXF1ZXN0ID0gSURCT3BlbkRCUmVxdWVzdDo6Y3JlYXRlKGNv bnRleHQpOworICAgIHJldHVybiBhZG9wdFJlZigmcmVxdWVzdC5sZWFrUmVmKCkpOwogfQogCiBQ YXNzUmVmUHRyPFdlYkNvcmU6OklEQk9wZW5EQlJlcXVlc3Q+IElEQkZhY3Rvcnk6OmRlbGV0ZURh dGFiYXNlKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIGNvbnN0IFN0cmluZyYgbmFt ZSwgRXhjZXB0aW9uQ29kZSYgZWMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9jbGllbnQvSURCRmFjdG9yeUltcGwuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL2NsaWVudC9JREJGYWN0b3J5SW1wbC5oCmluZGV4IDljNzA5YjQuLjhjMjE1 ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2NsaWVudC9J REJGYWN0b3J5SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2Ns aWVudC9JREJGYWN0b3J5SW1wbC5oCkBAIC0zMyw2ICszMyw4IEBACiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBuYW1lc3BhY2UgSURCQ2xpZW50IHsKIAorY2xhc3MgSURCT3BlbkRCUmVxdWVzdDsKKwog Y2xhc3MgSURCRmFjdG9yeSA6IHB1YmxpYyBXZWJDb3JlOjpJREJGYWN0b3J5IHsKIHB1YmxpYzoK ICAgICBzdGF0aWMgUmVmPElEQkZhY3Rvcnk+IGNyZWF0ZSgpOwpAQCAtNDcsNiArNDksOCBAQCBw dWJsaWM6CiAKIHByaXZhdGU6CiAgICAgSURCRmFjdG9yeSgpOworICAgIAorICAgIFJlZlB0cjxJ REJPcGVuREJSZXF1ZXN0PiBvcGVuSW50ZXJuYWwoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIGNv bnN0IFN0cmluZyYgbmFtZSwgdW5zaWduZWQgbG9uZyBsb25nIHZlcnNpb24sIEV4Y2VwdGlvbkNv ZGUmKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIElEQkNsaWVudAo=