149224 2015-09-16 11:12:00 -0700 [iOS] Inline implementation of -[WKImagePreviewViewController previewActions] 2015-09-16 12:52:46 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz bdakin commit-queue sam thorton oldest_to_newest 1126410 0 mitz 2015-09-16 11:12:00 -0700 [iOS] Inline implementation of -[WKImagePreviewViewController previewActions] 1126430 1 261321 mitz 2015-09-16 12:02:38 -0700 Created attachment 261321 Add -previewActions 1126432 2 commit-queue 2015-09-16 12:05:03 -0700 Attachment 261321 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WKImagePreviewViewController.mm:99: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1126436 3 mitz 2015-09-16 12:52:46 -0700 Committed <http://trac.webkit.org/r189877>. 261321 2015-09-16 12:02:38 -0700 2015-09-16 12:17:15 -0700 Add -previewActions bug-149224-20150916120226.patch text/plain 2652 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4OTg3NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA5LTE2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gSW5saW5lIGltcGxlbWVu dGF0aW9uIG9mIC1bV0tJbWFnZVByZXZpZXdWaWV3Q29udHJvbGxlciBwcmV2aWV3QWN0aW9uc10K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTIyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZv cm0vc3BpL2lvcy9VSUtpdFNQSS5oOiBEZWNsYXJlIFVJVmlld0NvbnRyb2xsZXJQcmV2aWV3QWN0 aW9uIGFuZCBpdHMgZmFjdG9yeSBtZXRob2QuCisgICAgICAgICogVUlQcm9jZXNzL1dLSW1hZ2VQ cmV2aWV3Vmlld0NvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLSW1hZ2VQcmV2aWV3Vmlld0Nv bnRyb2xsZXIgcHJldmlld0FjdGlvbnNdKTogTW92ZWQgaGVyZS4KKwogMjAxNS0wOS0xNiAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBBbGxvdyBy ZWFkaW5nIGZyb20gU3VibWl0RGlhZ0luZm8uZG9tYWlucyBpbiBOZXR3b3JraW5nIHByb2Nlc3MK SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEkuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9zcGkvaW9zL1VJS2l0U1BJLmgJKHJldmlz aW9uIDE4OTg2NykKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL3NwaS9pb3MvVUlLaXRTUEku aAkod29ya2luZyBjb3B5KQpAQCAtNzU3LDYgKzc1NywxMyBAQCB0eXBlZGVmIGVudW0gewogCiBA ZW5kCiAKK0BpbnRlcmZhY2UgVUlWaWV3Q29udHJvbGxlclByZXZpZXdBY3Rpb24gOiBOU09iamVj dCA8TlNDb3B5aW5nPgorQGVuZAorCitAaW50ZXJmYWNlIFVJVmlld0NvbnRyb2xsZXJQcmV2aWV3 QWN0aW9uICgpCisrIChpbnN0YW5jZXR5cGUpYWN0aW9uV2l0aFRpdGxlOihOU1N0cmluZyAqKXRp dGxlIGhhbmRsZXI6KHZvaWQgKF4pKFVJVmlld0NvbnRyb2xsZXJQcmV2aWV3QWN0aW9uICphY3Rp b24sIFVJVmlld0NvbnRyb2xsZXIgKnByZXZpZXdWaWV3Q29udHJvbGxlcikpaGFuZGxlcjsKK0Bl bmQKKwogI2VuZGlmIC8vIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCiAKIEBpbnRlcmZhY2UgVUlW aWV3IChJUEkpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV0tJbWFnZVByZXZpZXdW aWV3Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V0tJbWFnZVByZXZpZXdWaWV3Q29udHJvbGxlci5tbQkocmV2aXNpb24gMTg5ODY3KQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dLSW1hZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIubW0JKHdv cmtpbmcgY29weSkKQEAgLTkxLDggKzkxLDIxIEBAIHN0YXRpYyBDR1NpemUgX3NjYWxlU2l6ZVdp dGhpblNpemUoQ0dTaXoKICAgICByZXR1cm4gc2l6ZTsKIH0KIAotI2lmIFVTRShBUFBMRV9JTlRF Uk5BTF9TREspCi0jaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvV0tJbWFnZVByZXZpZXdWaWV3Q29u dHJvbGxlci5tbT4KKyNpZiBIQVZFKExJTktfUFJFVklFVykKKy0gKE5TQXJyYXkgPFVJVmlld0Nv bnRyb2xsZXJQcmV2aWV3QWN0aW9uICo+ICopcHJldmlld0FjdGlvbnMKK3sKKyAgICBOU011dGFi bGVBcnJheTxVSVZpZXdDb250cm9sbGVyUHJldmlld0FjdGlvbiAqPiAqcHJldmlld0FjdGlvbnMg PSBbTlNNdXRhYmxlQXJyYXkgYXJyYXldOworICAgIGZvciAoX1dLRWxlbWVudEFjdGlvbiAqaW1h Z2VBY3Rpb24gaW4gX2ltYWdlQWN0aW9ucy5nZXQoKSkgeworICAgICAgICBVSVZpZXdDb250cm9s bGVyUHJldmlld0FjdGlvbiAqcHJldmlld0FjdGlvbiA9IFtVSVZpZXdDb250cm9sbGVyUHJldmll d0FjdGlvbiBhY3Rpb25XaXRoVGl0bGU6aW1hZ2VBY3Rpb24udGl0bGUgaGFuZGxlcjpeKFVJVmll d0NvbnRyb2xsZXJQcmV2aWV3QWN0aW9uICphY3Rpb24sIFVJVmlld0NvbnRyb2xsZXIgKnByZXZp ZXdWaWV3Q29udHJvbGxlcikgeworICAgICAgICAgICAgaWYgKFtpbWFnZUFjdGlvbiByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKHJ1bkFjdGlvbldpdGhFbGVtZW50SW5mbzopXSkKKyAgICAg ICAgICAgICAgICBbaW1hZ2VBY3Rpb24gcnVuQWN0aW9uV2l0aEVsZW1lbnRJbmZvOl9hY3RpdmF0 ZWRFbGVtZW50SW5mby5nZXQoKV07CisgICAgICAgIH1dOworCisgICAgICAgIFtwcmV2aWV3QWN0 aW9ucyBhZGRPYmplY3Q6cHJldmlld0FjdGlvbl07CisgICAgfQorCisgICAgcmV0dXJuIHByZXZp ZXdBY3Rpb25zOworfQogI2VuZGlmCiAKIEBlbmQK