149206 2015-09-15 21:33:41 -0700 Implement imported global variables in WebAssembly 2015-09-15 22:49:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146064 1 sukolsak webkit-unassigned commit-queue oldest_to_newest 1126278 0 sukolsak 2015-09-15 21:33:41 -0700 Implement imported global variables in WebAssembly 1126279 1 261296 sukolsak 2015-09-15 21:56:28 -0700 Created attachment 261296 Patch 1126282 2 261296 commit-queue 2015-09-15 22:49:26 -0700 Comment on attachment 261296 Patch Clearing flags on attachment: 261296 Committed r189846: <http://trac.webkit.org/changeset/189846> 1126283 3 commit-queue 2015-09-15 22:49:28 -0700 All reviewed patches have been landed. Closing bug. 261296 2015-09-15 21:56:28 -0700 2015-09-15 22:49:26 -0700 Patch diff.txt text/plain 7451 sukolsak ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQyYTIxNWRjOWE4NjFjZDNmZGM5N2NiMDQ0NWI0 Y2Q2YjcxN2ZjYzUuLjM4ZTg4NDRhZjZiMGNjOWFlMjM1NGMwN2EwMWE3NjA3MzVkOWM1YWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE1LTA5LTE1ICBTdWtv bHNhayBTYWtzaHV3b25nICA8c3Vrb2xzYWtAZ21haWwuY29tPgorCisgICAgICAgIEltcGxlbWVu dCBpbXBvcnRlZCBnbG9iYWwgdmFyaWFibGVzIGluIFdlYkFzc2VtYmx5CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkyMDYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBWYWx1ZXMgY2FuIG5vdyBiZSBpbXBv cnRlZCB0byBhIFdlYkFzc2VtYmx5IG1vZHVsZSB0aHJvdWdoIHByb3BlcnRpZXMgb2YKKyAgICAg ICAgdGhlIGltcG9ydHMgb2JqZWN0IHRoYXQgaXMgcGFzc2VkIHRvIGxvYWRXZWJBc3NlbWJseSgp LiBJbiBvcmRlciB0bworICAgICAgICBhdm9pZCBhbnkgc2lkZSBlZmZlY3Qgd2hlbiBhY2Nlc3Np bmcgdGhlIGltcG9ydHMgb2JqZWN0LCB3ZSBjaGVjayB0aGF0CisgICAgICAgIHRoZSBwcm9wZXJ0 aWVzIGFyZSBkYXRhIHByb3BlcnRpZXMuIFdlIGFsc28gY2hlY2sgdGhhdCBlYWNoIHZhbHVlIGlz IGEKKyAgICAgICAgcHJpbWl0aXZlIGFuZCBpcyBub3QgYSBTeW1ib2wuIEFjY29yZGluZyB0byB0 aGUgRUNNQTI2MiA2LjAgc3BlYywKKyAgICAgICAgY2FsbGluZyBUb051bWJlcigpIG9uIGEgcHJp bWl0aXZlIHRoYXQgaXMgbm90IGEgU3ltYm9sIHNob3VsZCBub3QgY2F1c2UKKyAgICAgICAgYW55 IHNpZGUgZWZmZWN0LlsxXQorCisgICAgICAgIFsxXTogaHR0cDovL3d3dy5lY21hLWludGVybmF0 aW9uYWwub3JnL2VjbWEtMjYyLzYuMC8jc2VjLXRvbnVtYmVyCisKKyAgICAgICAgKiB0ZXN0cy9z dHJlc3Mvd2FzbS1nbG9iYWxzLmpzOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy93YXNtL2dsb2Jh bHMud2FzbToKKyAgICAgICAgKiB3YXNtL1dBU01Nb2R1bGVQYXJzZXIuY3BwOgorICAgICAgICAo SlNDOjpXQVNNTW9kdWxlUGFyc2VyOjpwYXJzZU1vZHVsZSk6CisgICAgICAgIChKU0M6OldBU01N b2R1bGVQYXJzZXI6OnBhcnNlR2xvYmFsU2VjdGlvbik6CisgICAgICAgICogd2FzbS9XQVNNTW9k dWxlUGFyc2VyLmg6CisKIDIwMTUtMDktMTUgIFN1a29sc2FrIFNha3NodXdvbmcgIDxzdWtvbHNh a0BnbWFpbC5jb20+CiAKICAgICAgICAgRml4IGFzbS5qcyBlcnJvcnMgaW4gV2ViQXNzZW1ibHkg dGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvd2Fz bS1nbG9iYWxzLmpzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy93YXNtLWds b2JhbHMuanMKaW5kZXggMWY5N2QwOTNhMzFiODg1Y2E0ZGVmNTI5ZTkwNDNhMzY3MjU2YWE0NS4u YWZhMGU2OTk2ZGMyNjkyNTUyNzYyY2Q2YWM4OGUwYTNiMzA3NGE0MyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy93YXNtLWdsb2JhbHMuanMKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy93YXNtLWdsb2JhbHMuanMKQEAgLTgsMTQg KzgsMjkgQEAgZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgewogLyoKIHdhc20v Z2xvYmFscy53YXNtIGlzIGdlbmVyYXRlZCBieSBwYWNrLWFzbWpzIDxodHRwczovL2dpdGh1Yi5j b20vV2ViQXNzZW1ibHkvcG9seWZpbGwtcHJvdG90eXBlLTE+IGZyb20gdGhlIGZvbGxvd2luZyBz Y3JpcHQ6CiAKLWZ1bmN0aW9uIGFzbU1vZHVsZShnbG9iYWwsIGVudiwgYnVmZmVyKSB7CitmdW5j dGlvbiBhc21Nb2R1bGUoZ2xvYmFsLCBpbXBvcnRzLCBidWZmZXIpIHsKICAgICAidXNlIGFzbSI7 CiAKICAgICB2YXIgZnJvdW5kID0gZ2xvYmFsLk1hdGguZnJvdW5kOworICAgIHZhciBhID0gaW1w b3J0cy5hIHwgMDsKKyAgICB2YXIgYiA9IGZyb3VuZChpbXBvcnRzLmIpOworICAgIHZhciBjID0g K2ltcG9ydHMuYzsKICAgICB2YXIgeCA9IDA7CiAgICAgdmFyIHkgPSBmcm91bmQoMCk7CiAgICAg dmFyIHogPSAwLjA7CiAKKyAgICBmdW5jdGlvbiBnZXRBKCkgeworICAgICAgICByZXR1cm4gYSB8 IDA7CisgICAgfQorCisgICAgZnVuY3Rpb24gZ2V0QigpIHsKKyAgICAgICAgcmV0dXJuIGI7Cisg ICAgfQorCisgICAgZnVuY3Rpb24gZ2V0QygpIHsKKyAgICAgICAgcmV0dXJuIGM7CisgICAgfQor CiAgICAgZnVuY3Rpb24gZ2V0WCgpIHsKICAgICAgICAgcmV0dXJuIHggfCAwOwogICAgIH0KQEAg LTQ0LDYgKzU5LDkgQEAgZnVuY3Rpb24gYXNtTW9kdWxlKGdsb2JhbCwgZW52LCBidWZmZXIpIHsK ICAgICB9CiAKICAgICByZXR1cm4geworICAgICAgICBnZXRBOiBnZXRBLAorICAgICAgICBnZXRC OiBnZXRCLAorICAgICAgICBnZXRDOiBnZXRDLAogICAgICAgICBnZXRYOiBnZXRYLAogICAgICAg ICBnZXRZOiBnZXRZLAogICAgICAgICBnZXRaOiBnZXRaLApAQCAtNTQsNyArNzIsMTYgQEAgZnVu Y3Rpb24gYXNtTW9kdWxlKGdsb2JhbCwgZW52LCBidWZmZXIpIHsKIH0KICovCiAKLXZhciBtb2R1 bGUgPSBsb2FkV2ViQXNzZW1ibHkoIndhc20vZ2xvYmFscy53YXNtIik7Cit2YXIgaW1wb3J0cyA9 IHsKKyAgICBhOiA0MiwKKyAgICBiOiA0LjIsCisgICAgYzogNC4yLAorfTsKK3ZhciBtb2R1bGUg PSBsb2FkV2ViQXNzZW1ibHkoIndhc20vZ2xvYmFscy53YXNtIiwgaW1wb3J0cyk7CisKK3Nob3Vs ZEJlKG1vZHVsZS5nZXRBKCksIDQyKTsKK3Nob3VsZEJlKG1vZHVsZS5nZXRCKCksIDQuMTk5OTk5 ODA5MjY1MTM3KTsKK3Nob3VsZEJlKG1vZHVsZS5nZXRDKCksIDQuMik7CiAKIHNob3VsZEJlKG1v ZHVsZS5nZXRYKCksIDApOwogc2hvdWxkQmUobW9kdWxlLmdldFkoKSwgMCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3dhc20vZ2xvYmFscy53YXNtIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy93YXNtL2dsb2JhbHMud2FzbQppbmRl eCBkYWM1NjhiMTVkZWIxN2ViNjEwOTcyZmM1MTZlYTg1MGFmY2I5M2IzLi42NDdjODk1YmU1N2Fk N2QwMTg1OGIzMjk4YzI5YjYzZjRhYzJkOWVhIDEwMDY0NApHSVQgYmluYXJ5IHBhdGNoCmxpdGVy YWwgMTUwCnpjbVc7QUYlRS0zNUNjR2FfWU9rRW8wNUQyPXBjJHhRR3R+OW9ecmBjY3A2QDspeVY3 YnlzY3xPcXlZJG5RJTklaQp6eSl0OUwzbXZyM0pZXkwyP20tSDJhQllsY2g0bT0+KXh2KmVfaiZK a0t0NGVFZ3ZrTGVNPGg4Ulo/UUNUTEBPdVUKRVBVfG9sLVQoanEKCmxpdGVyYWwgMTA4CnpjbVc7 QXU/PkpRMzxTVmBKNHdyV0JwbjUhcURteE1qfW4tSzhKR3dzdWgrQGBZcGRzezcpYnlqUDxwOHBm NjJMMQpqRyg7RXxvcDQtWT82MnxlIy19cUtkc19pRmdLbU07djhiQzcrPUJRNkc5NDRKCgpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV0FTTU1vZHVsZVBhcnNlci5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XQVNNTW9kdWxlUGFyc2VyLmNwcAppbmRleCBm NzdmOGY3ZWZiMmNkODU3N2IwY2UxMGJmN2RkZjQzYzcxMzljNDczLi44MGE3ZWI4YTVmNzg3NDgy OGNmYjMzN2ExZjg4ZDBhNWEwMjA4Njc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9XQVNNTW9kdWxlUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d2FzbS9XQVNNTW9kdWxlUGFyc2VyLmNwcApAQCAtODQsNyArODQsNyBAQCB2b2lkIFdBU01Nb2R1 bGVQYXJzZXI6OnBhcnNlTW9kdWxlKEV4ZWNTdGF0ZSogZXhlYykKICAgICBQUk9QQUdBVEVfRVJS T1IoKTsKICAgICBwYXJzZUZ1bmN0aW9uSW1wb3J0U2VjdGlvbihleGVjKTsKICAgICBQUk9QQUdB VEVfRVJST1IoKTsKLSAgICBwYXJzZUdsb2JhbFNlY3Rpb24oKTsKKyAgICBwYXJzZUdsb2JhbFNl Y3Rpb24oZXhlYyk7CiAgICAgUFJPUEFHQVRFX0VSUk9SKCk7CiAgICAgcGFyc2VGdW5jdGlvbkRl Y2xhcmF0aW9uU2VjdGlvbigpOwogICAgIFBST1BBR0FURV9FUlJPUigpOwpAQCAtMTgxLDcgKzE4 MSw3IEBAIHZvaWQgV0FTTU1vZHVsZVBhcnNlcjo6cGFyc2VGdW5jdGlvbkltcG9ydFNlY3Rpb24o RXhlY1N0YXRlKiBleGVjKQogICAgIEZBSUxfSUZfRkFMU0UobV9tb2R1bGUtPmZ1bmN0aW9uSW1w b3J0U2lnbmF0dXJlcygpLnNpemUoKSA9PSBudW1iZXJPZkZ1bmN0aW9uSW1wb3J0U2lnbmF0dXJl cywgIlRoZSBudW1iZXIgb2YgZnVuY3Rpb24gaW1wb3J0IHNpZ25hdHVyZXMgaXMgaW5jb3JyZWN0 LiIpOwogfQogCi12b2lkIFdBU01Nb2R1bGVQYXJzZXI6OnBhcnNlR2xvYmFsU2VjdGlvbigpCit2 b2lkIFdBU01Nb2R1bGVQYXJzZXI6OnBhcnNlR2xvYmFsU2VjdGlvbihFeGVjU3RhdGUqIGV4ZWMp CiB7CiAgICAgdWludDMyX3QgbnVtYmVyT2ZJbnRlcm5hbEkzMkdsb2JhbFZhcmlhYmxlczsKICAg ICB1aW50MzJfdCBudW1iZXJPZkludGVybmFsRjMyR2xvYmFsVmFyaWFibGVzOwpAQCAtMjE4LDE5 ICsyMTgsMzEgQEAgdm9pZCBXQVNNTW9kdWxlUGFyc2VyOjpwYXJzZUdsb2JhbFNlY3Rpb24oKQog ICAgICAgICBTdHJpbmcgaW1wb3J0TmFtZTsKICAgICAgICAgUkVBRF9TVFJJTkdfT1JfRkFJTChp bXBvcnROYW1lLCAiQ2Fubm90IHJlYWQgdGhlIGltcG9ydCBuYW1lIG9mIGFuIGludDMyIGdsb2Jh bCB2YXJpYWJsZS4iKTsKICAgICAgICAgZ2xvYmFsVmFyaWFibGVUeXBlcy51bmNoZWNrZWRBcHBl bmQoV0FTTVR5cGU6OkkzMik7Ci0gICAgICAgIGdsb2JhbFZhcmlhYmxlcy51bmNoZWNrZWRBcHBl bmQoSlNXQVNNTW9kdWxlOjpHbG9iYWxWYXJpYWJsZSgwKSk7IC8vIEZJWE1FOiBJbXBvcnQgdGhl IHZhbHVlLgorICAgICAgICBKU1ZhbHVlIHZhbHVlOworICAgICAgICBnZXRJbXBvcnRlZFZhbHVl KGV4ZWMsIGltcG9ydE5hbWUsIHZhbHVlKTsKKyAgICAgICAgUFJPUEFHQVRFX0VSUk9SKCk7Cisg ICAgICAgIEZBSUxfSUZfRkFMU0UodmFsdWUuaXNQcmltaXRpdmUoKSAmJiAhdmFsdWUuaXNTeW1i b2woKSwgIlwiIiArIGltcG9ydE5hbWUgKyAiXCIgaXMgbm90IGEgcHJpbWl0aXZlIG9yIGlzIGEg U3ltYm9sLiIpOworICAgICAgICBnbG9iYWxWYXJpYWJsZXMudW5jaGVja2VkQXBwZW5kKEpTV0FT TU1vZHVsZTo6R2xvYmFsVmFyaWFibGUodmFsdWUudG9JbnQzMihleGVjKSkpOwogICAgIH0KICAg ICBmb3IgKHVpbnQzMl90IGkgPSAwOyBpIDwgbnVtYmVyT2ZJbXBvcnRlZEYzMkdsb2JhbFZhcmlh YmxlczsgKytpKSB7CiAgICAgICAgIFN0cmluZyBpbXBvcnROYW1lOwogICAgICAgICBSRUFEX1NU UklOR19PUl9GQUlMKGltcG9ydE5hbWUsICJDYW5ub3QgcmVhZCB0aGUgaW1wb3J0IG5hbWUgb2Yg YSBmbG9hdDMyIGdsb2JhbCB2YXJpYWJsZS4iKTsKICAgICAgICAgZ2xvYmFsVmFyaWFibGVUeXBl cy51bmNoZWNrZWRBcHBlbmQoV0FTTVR5cGU6OkYzMik7Ci0gICAgICAgIGdsb2JhbFZhcmlhYmxl cy51bmNoZWNrZWRBcHBlbmQoSlNXQVNNTW9kdWxlOjpHbG9iYWxWYXJpYWJsZSgwLjBmKSk7IC8v IEZJWE1FOiBJbXBvcnQgdGhlIHZhbHVlLgorICAgICAgICBKU1ZhbHVlIHZhbHVlOworICAgICAg ICBnZXRJbXBvcnRlZFZhbHVlKGV4ZWMsIGltcG9ydE5hbWUsIHZhbHVlKTsKKyAgICAgICAgUFJP UEFHQVRFX0VSUk9SKCk7CisgICAgICAgIEZBSUxfSUZfRkFMU0UodmFsdWUuaXNQcmltaXRpdmUo KSAmJiAhdmFsdWUuaXNTeW1ib2woKSwgIlwiIiArIGltcG9ydE5hbWUgKyAiXCIgaXMgbm90IGEg cHJpbWl0aXZlIG9yIGlzIGEgU3ltYm9sLiIpOworICAgICAgICBnbG9iYWxWYXJpYWJsZXMudW5j aGVja2VkQXBwZW5kKEpTV0FTTU1vZHVsZTo6R2xvYmFsVmFyaWFibGUoc3RhdGljX2Nhc3Q8Zmxv YXQ+KHZhbHVlLnRvTnVtYmVyKGV4ZWMpKSkpOwogICAgIH0KICAgICBmb3IgKHVpbnQzMl90IGkg PSAwOyBpIDwgbnVtYmVyT2ZJbXBvcnRlZEY2NEdsb2JhbFZhcmlhYmxlczsgKytpKSB7CiAgICAg ICAgIFN0cmluZyBpbXBvcnROYW1lOwogICAgICAgICBSRUFEX1NUUklOR19PUl9GQUlMKGltcG9y dE5hbWUsICJDYW5ub3QgcmVhZCB0aGUgaW1wb3J0IG5hbWUgb2YgYSBmbG9hdDY0IGdsb2JhbCB2 YXJpYWJsZS4iKTsKICAgICAgICAgZ2xvYmFsVmFyaWFibGVUeXBlcy51bmNoZWNrZWRBcHBlbmQo V0FTTVR5cGU6OkY2NCk7Ci0gICAgICAgIGdsb2JhbFZhcmlhYmxlcy51bmNoZWNrZWRBcHBlbmQo SlNXQVNNTW9kdWxlOjpHbG9iYWxWYXJpYWJsZSgwLjApKTsgLy8gRklYTUU6IEltcG9ydCB0aGUg dmFsdWUuCisgICAgICAgIEpTVmFsdWUgdmFsdWU7CisgICAgICAgIGdldEltcG9ydGVkVmFsdWUo ZXhlYywgaW1wb3J0TmFtZSwgdmFsdWUpOworICAgICAgICBQUk9QQUdBVEVfRVJST1IoKTsKKyAg ICAgICAgRkFJTF9JRl9GQUxTRSh2YWx1ZS5pc1ByaW1pdGl2ZSgpICYmICF2YWx1ZS5pc1N5bWJv bCgpLCAiXCIiICsgaW1wb3J0TmFtZSArICJcIiBpcyBub3QgYSBwcmltaXRpdmUgb3IgaXMgYSBT eW1ib2wuIik7CisgICAgICAgIGdsb2JhbFZhcmlhYmxlcy51bmNoZWNrZWRBcHBlbmQoSlNXQVNN TW9kdWxlOjpHbG9iYWxWYXJpYWJsZSh2YWx1ZS50b051bWJlcihleGVjKSkpOwogICAgIH0KIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV0FTTU1vZHVsZVBhcnNl ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV0FTTU1vZHVsZVBhcnNlci5oCmluZGV4 IGQ2ZTdmZGJhY2I3ZTI4OTU0OWZjZjFhODcwMTJkNDk3OWZmYjY2NzAuLmY4YjMxMTNkZWIzMThm NDhhOGZmZjJmYzY3NzgzNTIxZGIyMGMyMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93YXNtL1dBU01Nb2R1bGVQYXJzZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d2FzbS9XQVNNTW9kdWxlUGFyc2VyLmgKQEAgLTUwLDcgKzUwLDcgQEAgcHJpdmF0ZToKICAgICB2 b2lkIHBhcnNlQ29uc3RhbnRQb29sU2VjdGlvbigpOwogICAgIHZvaWQgcGFyc2VTaWduYXR1cmVT ZWN0aW9uKCk7CiAgICAgdm9pZCBwYXJzZUZ1bmN0aW9uSW1wb3J0U2VjdGlvbihFeGVjU3RhdGUq KTsKLSAgICB2b2lkIHBhcnNlR2xvYmFsU2VjdGlvbigpOworICAgIHZvaWQgcGFyc2VHbG9iYWxT ZWN0aW9uKEV4ZWNTdGF0ZSopOwogICAgIHZvaWQgcGFyc2VGdW5jdGlvbkRlY2xhcmF0aW9uU2Vj dGlvbigpOwogICAgIHZvaWQgcGFyc2VGdW5jdGlvblBvaW50ZXJUYWJsZVNlY3Rpb24oKTsKICAg ICB2b2lkIHBhcnNlRnVuY3Rpb25EZWZpbml0aW9uU2VjdGlvbigpOwo=