149197 2015-09-15 16:59:13 -0700 REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out 2015-09-17 00:29:12 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck hi bburg commit-queue graouts hi joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1126200 0 joepeck 2015-09-15 16:59:13 -0700 * SUMMARY Extra whitespace left behind in styles sidebar after clicking in and out. * STEPS TO REPRODUCE 1. Inspect <body> on <http://daringfireball.net> 2. Show Styles > Rules sidebar 3. Click in the first CSSStyleDeclarationTextEditor at the end of the line-height line => newline added to add a new property 4. Click out of the editor => expected newline to be removed, it remains * NOTES - Regressed with r188427 - bug 145679 1126201 1 webkit-bug-importer 2015-09-15 16:59:30 -0700 <rdar://problem/22711632> 1126255 2 hi 2015-09-15 19:58:03 -0700 Just so I understand, we want to have it such that new CSS styles that are added follow the same indentation of existing CSS, but remove any leading/trailing whitespace and extra newlines in the middle. So it would format body { color: red; background-color: black; } into the style declaration with the following formatting: body { color: red; background-color: black; } 1126413 3 joepeck 2015-09-16 11:27:15 -0700 (In reply to comment #2) > Just so I understand, we want to have it such that new CSS styles that are > added follow the same indentation of existing CSS, but remove any > leading/trailing whitespace and extra newlines in the middle. So it would > format > > body { > color: red; > > background-color: black; > > } > > into the style declaration with the following formatting: > > body { > color: red; > background-color: black; > } Yep! In the sidebar I don't expect extra newlines in the middle if the editor is not focused. Preserving newlines in the actual StyleSheet's text would be nice, but I don't think we do that now so its fine if we reformat that a little. 1126600 4 261365 hi 2015-09-16 21:42:26 -0700 Created attachment 261365 Patch 1126641 5 261365 commit-queue 2015-09-17 00:29:08 -0700 Comment on attachment 261365 Patch Clearing flags on attachment: 261365 Committed r189909: <http://trac.webkit.org/changeset/189909> 1126642 6 commit-queue 2015-09-17 00:29:12 -0700 All reviewed patches have been landed. Closing bug. 261365 2015-09-16 21:42:26 -0700 2015-09-17 00:29:08 -0700 Patch bug-149197-20150916214213.patch text/plain 2055 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM0OTU4YjQ2ZjQwZmZkY2Q5MzE0YTEwZjU5NmNl N2E2Yjc4NmM4OTYuLjI4YjczMjUzNmFlODc1Y2QwNmZiMWNkOGE1MDM2MzQ0YzFlZjJlOGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA5LTE2ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjE4ODQyNyk6IFdlYiBJbnNwZWN0b3I6IEV4dHJhIHdoaXRlc3BhY2UgbGVmdCBiZWhpbmQg aW4gc3R5bGVzIHNpZGViYXIgYWZ0ZXIgY2xpY2tpbmcgaW4gYW5kIG91dAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5MTk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gcjE4ODQyNywgbG9naWMgd2Fz IGFkZGVkIHRvIHByZXNlcnZlIHRoZSBsZWFkaW5nIHdoaXRlc3BhY2Ugb2Ygc3R5bGVzIGluIGEg Q1NTIGZpbGUuCisgICAgICAgIEFuIHVuZm9ydHVuYXRlIHNpZGUgZWZmZWN0IG9mIHRoaXMgd2Fz IHRoYXQgZXh0cmEgbmV3bGluZXMgaW4gYmV0d2VlbiBDU1MgcHJvcGVydGllcworICAgICAgICB3 ZXJlIHRyZWF0ZWQgYXMgdmFsaWQgYW5kIGxlZnQgd2hlcmUgdGhleSB3ZXJlLiAgVGhpcyBpcyB1 bmRlc2lyZWQgYmVoYXZpb3VyIGFuZCBvZnRlbgorICAgICAgICBjbHV0dGVycyB0aGUgc3R5bGVz IHNpZGViYXIuICBUaGVzZSBjaGFuZ2VzIHJlbW92ZSB0aGUgZXh0cmEgbmV3bGluZXMuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9y LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9y LnByb3RvdHlwZS5fZm9ybWF0dGVkQ29udGVudCk6CisKIDIwMTUtMDktMTYgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXgg Y29tbW9uIHR5cG8gInN1cHJlc3MiID0+ICJzdXBwcmVzcyIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0 RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NT U3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKaW5kZXggZTU0NTNjM2JiOGU5NjEwZTM4NjA4 NzdhMGJlOWI1MGUyYzIxNzRkYi4uNzU0MGM2N2ZiNjZkMmJkNmZlMDZmNTMzNWZhNTQzM2RlOTEz ZDQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3Iu anMKQEAgLTcyNiw3ICs3MjYsOSBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRl eHRFZGl0b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgICAgICAv LyBBZGQgdGhlIHN1ZmZpeCB3aGl0ZXNwYWNlIHdlIHN0cmlwcGVkLgogICAgICAgICBjb250ZW50 ICs9IHRoaXMuX3N1ZmZpeFdoaXRlc3BhY2U7CiAKLSAgICAgICAgcmV0dXJuIGNvbnRlbnQ7Cisg ICAgICAgIC8vIFRoaXMgcmVndWxhciBleHByZXNzaW9uIHJlcGxhY2VtZW50IHJlbW92ZXMgZXh0 cmEgbmV3bGluZXMKKyAgICAgICAgLy8gaW4gYmV0d2VlbiBwcm9wZXJ0aWVzIHdoaWxlIHByZXNl cnZpbmcgbGVhZGluZyB3aGl0ZXNwYWNlCisgICAgICAgIHJldHVybiBjb250ZW50LnJlcGxhY2Uo L1xzKlxuXHMqXG4oXHMqKS9nLCAiXG4kMSIpOwogICAgIH0KIAogICAgIF9jb21taXRDaGFuZ2Vz KCkK