149175 2015-09-15 11:29:20 -0700 JS Function removed after parsing 2016-05-06 12:25:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED WORKSFORME InRadar P2 Normal --- 1 mail webkit-unassigned amichal fpizlo ggaren hartman.wiki mathias nvasilyev webkit-bug-importer oldest_to_newest 1126065 0 mail 2015-09-15 11:29:20 -0700 Steps to reproduce: Open http://rodneyrehm.de/t/css.escape (with cold cache / freshly started browser) and open DevTools and run `CSS.escape` to print the value. Expected behavior: The function's body is printed to the console Actual behavior: `undefined` is printed to the console Additional Notes: The issue cannot be reproduced reliably. Sometimes hitting Command+R will make CSS.escape actually hold the function, sometimes you need Command+Shift+R. Usually cleaning the cache and or restarting the browser before opening this page will make WebKit (or JavaScriptCore, or whatever) exhibit this behavior. Eventually CSS.escape will hold the function, but it may lose it again. It feels like some script optimization routine is (sometimes) killing the function declaration, because it is not used immediately (i.e. dead code removal), or some such. Live Testcase: http://rodneyrehm.de/t/css.escape Related issue on Github: https://github.com/mathiasbynens/CSS.escape/issues/2 1127597 1 mathias 2015-09-21 01:27:32 -0700 Confirmed in r189569. 1142751 2 nvasilyev 2015-11-17 19:22:52 -0800 *** This bug has been marked as a duplicate of bug 126337 *** 1145240 3 mathias 2015-12-01 09:12:34 -0800 (In reply to comment #2) > > *** This bug has been marked as a duplicate of bug 126337 *** Note that this is not really a duplicate of bug 126337. Fixing bug 126337 would work around the issue in this specific case of `CSS.escape` but the underlying JavaScriptCore bug would still be there. 1145514 4 nvasilyev 2015-12-01 20:04:47 -0800 Oh, you're right. Sorry about that. It isn't about WebKit missing CSS.escape. It is about a bizarre WebKit behavior with this particular CSS.escape shim. 1160970 5 hartman.wiki 2016-02-01 12:33:15 -0800 We encountered the same issue (with the same polyfill) in Wikipedia/MediaWiki. Issue was tracked: https://phabricator.wikimedia.org/T121991 1161101 6 webkit-bug-importer 2016-02-01 16:08:42 -0800 <rdar://problem/24448680> 1178056 7 amichal 2016-03-25 12:20:10 -0700 You can also reproduce it be delaying the lookup with a setTimeout. The code below alerts('window.CSS.escape missing in event') in Version 9.1 (10601.5.17.4) <html> <script src='css.escape.js'></script> <script type='text/javascript'> if (!window.CSS.escape) { alert('window.CSS.escape not loaded'); } console.log(!!window.CSS.escape); setTimeout(function() { console.log(!!window.CSS.escape); if (!window.CSS.escape) { alert('window.CSS.escape missing in event'); } },5000); </script> </html> 1190696 8 fpizlo 2016-05-06 10:57:34 -0700 I can't get this to reproduce in WebKit trunk right anymore. Please reopen if you can get it to fail in trunk, nightly, etc. 1190702 9 278255 fpizlo 2016-05-06 11:07:58 -0700 Created attachment 278255 patch that has the regression test 1190704 10 278255 mark.lam 2016-05-06 11:09:24 -0700 Comment on attachment 278255 patch that has the regression test rs=me if it bots don't complain. 1190717 11 hartman.wiki 2016-05-06 12:25:00 -0700 Confirmed. Still broken in Safari Version 9.1 (11601.5.17.1), but works in STP Version 9.1.1 (11601.6.17, 11602.1.29). 278255 2016-05-06 11:07:58 -0700 2016-05-06 11:09:24 -0700 patch that has the regression test blah.patch text/plain 5218 fpizlo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwMDUxMykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA1LTA2ICBGaWxpcCBQaXpsbyAgPGZw aXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgSlMgRnVuY3Rpb24gcmVtb3ZlZCBhZnRlciBwYXJz aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkx NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIFRoaXMgYnVnIGRvZXNuJ3QgaGFwcGVuIGFueW1vcmUsIGJ1dCB0aGUgdGVzdCBjYXNlIGlz IHN0aWxsIHVzZWZ1bC4gVGhpcyB0ZXN0IHdpbGwgZmFpbCAxLzUgb2YKKyAgICAgICAgdGhlIHRp bWUgaWYgd2UgcmVncmVzcy4KKworICAgICAgICAqIGpzL2RvbS9mdW5jdGlvbi1yZW1vdmVkLWFm dGVyLXBhcnNpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBqcy9kb20vZnVuY3Rp b24tcmVtb3ZlZC1hZnRlci1wYXJzaW5nLmh0bWw6IEFkZGVkLgorCiAyMDE2LTA1LTA2ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3MtZ3Jp ZF0gVW5wcmVmaXggQ1NTIEdyaWQgTGF5b3V0IHByb3BlcnRpZXMKSW5kZXg6IExheW91dFRlc3Rz L2pzL2RvbS9mdW5jdGlvbi1yZW1vdmVkLWFmdGVyLXBhcnNpbmctZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2pzL2RvbS9mdW5jdGlvbi1yZW1vdmVkLWFmdGVyLXBhcnNp bmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvZG9tL2Z1bmN0 aW9uLXJlbW92ZWQtYWZ0ZXItcGFyc2luZy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAg LTAsMCArMSwyIEBACit3aW5kb3cuQ1NTLmVzY2FwZSBzdGlsbCBoZXJlCisKSW5kZXg6IExheW91 dFRlc3RzL2pzL2RvbS9mdW5jdGlvbi1yZW1vdmVkLWFmdGVyLXBhcnNpbmcuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9kb20vZnVuY3Rpb24tcmVtb3ZlZC1hZnRlci1wYXJzaW5n Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9qcy9kb20vZnVuY3Rpb24tcmVtb3Zl ZC1hZnRlci1wYXJzaW5nLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMjMgQEAKKzxo dG1sPgorPCEtLQorTk9URTogVGhpcyBpbnRlbnRpb25hbGx5IGRvZXMgbm90IHVzZSBkZXNjcmlw dGlvbigpIGFuZCBkb2VzIG5vdCBpbmNsdWRlIGpzLXRlc3QtcG9zdCBiZWNhdXNlCitkb2luZyBl aXRoZXIgb2YgdGhvc2UgdGhpbmdzIG1hZGUgdGhlIGJ1ZyBnbyBhd2F5LgorLS0+CisgIDxzY3Jp cHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICA8c2Ny aXB0IHR5cGU9J3RleHQvamF2YXNjcmlwdCc+CisvKiEgaHR0cHM6Ly9tdGhzLmJlL2Nzc2VzY2Fw ZSB2MS4xLjAgYnkgQG1hdGhpYXMgfCBNSVQgbGljZW5zZSAqLworOyhmdW5jdGlvbihyb290KSB7 CisKKwlpZiAoIXJvb3QuQ1NTKSB7CisJCXJvb3QuQ1NTID0ge307CisJfQorCisJdmFyIENTUyA9 IHJvb3QuQ1NTOworCisJdmFyIEludmFsaWRDaGFyYWN0ZXJFcnJvciA9IGZ1bmN0aW9uKG1lc3Nh Z2UpIHsKKwkJdGhpcy5tZXNzYWdlID0gbWVzc2FnZTsKKwl9OworCUludmFsaWRDaGFyYWN0ZXJF cnJvci5wcm90b3R5cGUgPSBuZXcgRXJyb3I7CisJSW52YWxpZENoYXJhY3RlckVycm9yLnByb3Rv dHlwZS5uYW1lID0gJ0ludmFsaWRDaGFyYWN0ZXJFcnJvcic7CisKKwlpZiAoIUNTUy5lc2NhcGUp IHsKKwkJLy8gaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzc29tLyNzZXJpYWxpemUtYW4taWRl bnRpZmllcgorCQlDU1MuZXNjYXBlID0gZnVuY3Rpb24odmFsdWUpIHsKKwkJCXZhciBzdHJpbmcg PSBTdHJpbmcodmFsdWUpOworCQkJdmFyIGxlbmd0aCA9IHN0cmluZy5sZW5ndGg7CisJCQl2YXIg aW5kZXggPSAtMTsKKwkJCXZhciBjb2RlVW5pdDsKKwkJCXZhciByZXN1bHQgPSAnJzsKKwkJCXZh ciBmaXJzdENvZGVVbml0ID0gc3RyaW5nLmNoYXJDb2RlQXQoMCk7CisJCQl3aGlsZSAoKytpbmRl eCA8IGxlbmd0aCkgeworCQkJCWNvZGVVbml0ID0gc3RyaW5nLmNoYXJDb2RlQXQoaW5kZXgpOwor CQkJCS8vIE5vdGU6IHRoZXJlknMgbm8gbmVlZCB0byBzcGVjaWFsLWNhc2UgYXN0cmFsIHN5bWJv bHMsIHN1cnJvZ2F0ZQorCQkJCS8vIHBhaXJzLCBvciBsb25lIHN1cnJvZ2F0ZXMuCisKKwkJCQkv LyBJZiB0aGUgY2hhcmFjdGVyIGlzIE5VTEwgKFUrMDAwMCksIHRoZW4gdGhyb3cgYW4KKwkJCQkv LyBgSW52YWxpZENoYXJhY3RlckVycm9yYCBleGNlcHRpb24gYW5kIHRlcm1pbmF0ZSB0aGVzZSBz dGVwcy4KKwkJCQlpZiAoY29kZVVuaXQgPT0gMHgwMDAwKSB7CisJCQkJCXRocm93IG5ldyBJbnZh bGlkQ2hhcmFjdGVyRXJyb3IoCisJCQkJCQknSW52YWxpZCBjaGFyYWN0ZXI6IHRoZSBpbnB1dCBj b250YWlucyBVKzAwMDAuJworCQkJCQkpOworCQkJCX0KKworCQkJCWlmICgKKwkJCQkJLy8gSWYg dGhlIGNoYXJhY3RlciBpcyBpbiB0aGUgcmFuZ2UgW1wxLVwxRl0gKFUrMDAwMSB0byBVKzAwMUYp IG9yIGlzCisJCQkJCS8vIFUrMDA3RiwgW4VdCisJCQkJCShjb2RlVW5pdCA+PSAweDAwMDEgJiYg Y29kZVVuaXQgPD0gMHgwMDFGKSB8fCBjb2RlVW5pdCA9PSAweDAwN0YgfHwKKwkJCQkJLy8gSWYg dGhlIGNoYXJhY3RlciBpcyB0aGUgZmlyc3QgY2hhcmFjdGVyIGFuZCBpcyBpbiB0aGUgcmFuZ2Ug WzAtOV0KKwkJCQkJLy8gKFUrMDAzMCB0byBVKzAwMzkpLCBbhV0KKwkJCQkJKGluZGV4ID09IDAg JiYgY29kZVVuaXQgPj0gMHgwMDMwICYmIGNvZGVVbml0IDw9IDB4MDAzOSkgfHwKKwkJCQkJLy8g SWYgdGhlIGNoYXJhY3RlciBpcyB0aGUgc2Vjb25kIGNoYXJhY3RlciBhbmQgaXMgaW4gdGhlIHJh bmdlIFswLTldCisJCQkJCS8vIChVKzAwMzAgdG8gVSswMDM5KSBhbmQgdGhlIGZpcnN0IGNoYXJh Y3RlciBpcyBhIGAtYCAoVSswMDJEKSwgW4VdCisJCQkJCSgKKwkJCQkJCWluZGV4ID09IDEgJiYK KwkJCQkJCWNvZGVVbml0ID49IDB4MDAzMCAmJiBjb2RlVW5pdCA8PSAweDAwMzkgJiYKKwkJCQkJ CWZpcnN0Q29kZVVuaXQgPT0gMHgwMDJECisJCQkJCSkKKwkJCQkpIHsKKwkJCQkJLy8gaHR0cHM6 Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzc29tLyNlc2NhcGUtYS1jaGFyYWN0ZXItYXMtY29kZS1wb2lu dAorCQkJCQlyZXN1bHQgKz0gJ1xcJyArIGNvZGVVbml0LnRvU3RyaW5nKDE2KSArICcgJzsKKwkJ CQkJY29udGludWU7CisJCQkJfQorCisJCQkJaWYgKAorCQkJCQkvLyBJZiB0aGUgY2hhcmFjdGVy IGlzIHRoZSBmaXJzdCBjaGFyYWN0ZXIgYW5kIGlzIGEgYC1gIChVKzAwMkQpLCBhbmQKKwkJCQkJ Ly8gdGhlcmUgaXMgbm8gc2Vjb25kIGNoYXJhY3RlciwgW4VdCisJCQkJCWluZGV4ID09IDAgJiYK KwkJCQkJbGVuZ3RoID09IDEgJiYKKwkJCQkJY29kZVVuaXQgPT0gMHgwMDJECisJCQkJKSB7CisJ CQkJCXJlc3VsdCArPSAnXFwnICsgc3RyaW5nLmNoYXJBdChpbmRleCk7CisJCQkJCWNvbnRpbnVl OworCQkJCX0KKworCQkJCS8vIElmIHRoZSBjaGFyYWN0ZXIgaXMgbm90IGhhbmRsZWQgYnkgb25l IG9mIHRoZSBhYm92ZSBydWxlcyBhbmQgaXMKKwkJCQkvLyBncmVhdGVyIHRoYW4gb3IgZXF1YWwg dG8gVSswMDgwLCBpcyBgLWAgKFUrMDAyRCkgb3IgYF9gIChVKzAwNUYpLCBvcgorCQkJCS8vIGlz IGluIG9uZSBvZiB0aGUgcmFuZ2VzIFswLTldIChVKzAwMzAgdG8gVSswMDM5KSwgW0EtWl0gKFUr MDA0MSB0bworCQkJCS8vIFUrMDA1QSksIG9yIFthLXpdIChVKzAwNjEgdG8gVSswMDdBKSwgW4Vd CisJCQkJaWYgKAorCQkJCQljb2RlVW5pdCA+PSAweDAwODAgfHwKKwkJCQkJY29kZVVuaXQgPT0g MHgwMDJEIHx8CisJCQkJCWNvZGVVbml0ID09IDB4MDA1RiB8fAorCQkJCQljb2RlVW5pdCA+PSAw eDAwMzAgJiYgY29kZVVuaXQgPD0gMHgwMDM5IHx8CisJCQkJCWNvZGVVbml0ID49IDB4MDA0MSAm JiBjb2RlVW5pdCA8PSAweDAwNUEgfHwKKwkJCQkJY29kZVVuaXQgPj0gMHgwMDYxICYmIGNvZGVV bml0IDw9IDB4MDA3QQorCQkJCSkgeworCQkJCQkvLyB0aGUgY2hhcmFjdGVyIGl0c2VsZgorCQkJ CQlyZXN1bHQgKz0gc3RyaW5nLmNoYXJBdChpbmRleCk7CisJCQkJCWNvbnRpbnVlOworCQkJCX0K KworCQkJCS8vIE90aGVyd2lzZSwgdGhlIGVzY2FwZWQgY2hhcmFjdGVyLgorCQkJCS8vIGh0dHBz Oi8vZHJhZnRzLmNzc3dnLm9yZy9jc3NvbS8jZXNjYXBlLWEtY2hhcmFjdGVyCisJCQkJcmVzdWx0 ICs9ICdcXCcgKyBzdHJpbmcuY2hhckF0KGluZGV4KTsKKworCQkJfQorCQkJcmV0dXJuIHJlc3Vs dDsKKwkJfTsKKwl9CisKK30odHlwZW9mIGdsb2JhbCAhPSAndW5kZWZpbmVkJyA/IGdsb2JhbCA6 IHRoaXMpKTsKKworICA8L3NjcmlwdD4KKyAgPHNjcmlwdCB0eXBlPSd0ZXh0L2phdmFzY3JpcHQn PgorICAgIHRyeSB7CisgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQod2luZG93LmVuYWJsZVBp eGVsVGVzdGluZyk7CisgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9IGNh dGNoIChlKSB7IH0KKyAgICBpZiAoIXdpbmRvdy5DU1MuZXNjYXBlKSB7CisgICAgICBkZWJ1Zygn d2luZG93LkNTUy5lc2NhcGUgbm90IGxvYWRlZCcpOworICAgIH0KKyAgICBzZXRUaW1lb3V0KGZ1 bmN0aW9uKCkgeworICAgICAgaWYgKHdpbmRvdy5DU1MuZXNjYXBlKQorICAgICAgICBkZWJ1Zygi d2luZG93LkNTUy5lc2NhcGUgc3RpbGwgaGVyZSIpOworICAgICAgZWxzZQorICAgICAgICBkZWJ1 Zygnd2luZG93LkNTUy5lc2NhcGUgbWlzc2luZyBpbiBldmVudCcpOworICAgICAgdHJ5IHsKKyAg ICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICB9IGNhdGNoIChlKSB7IH0KKyAg ICB9LDUwKTsKKyAgPC9zY3JpcHQ+Cis8L2h0bWw+Cg==