149174 2015-09-15 11:28:38 -0700 [WebGL] Only require that the stencil value and write masks have as many bits set as the stencil buffer is deep 2015-09-15 18:55:05 -0700 1 1 1 Unclassified WebKit WebGL Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hur.ims hur.ims commit-queue dino oldest_to_newest 1126064 0 hur.ims 2015-09-15 11:28:38 -0700 Regarding the stencil mask value tests, fast/canvas/webgl/gl-get-calls.html seems obsolete compared to webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html. 1126071 1 261220 hur.ims 2015-09-15 11:35:09 -0700 Created attachment 261220 Patch 1126080 2 hur.ims 2015-09-15 11:53:28 -0700 Copied from the webgl/1.0.2/resources/webgl_test_files/conformance/state/gl-get-calls.html. https://github.com/KhronosGroup/WebGL/commit/b540926f97e5566d4d5fbdc3539ff19910734f7e It seems that there is a difference in the way that glGetIntegerV returns an unsigned int type value among OpenGL implementatios. Some return the whole bits of value(e.g., 0xffffffff -> 0xffffffff), whereas some(e.g., ANGLE) return a max-int-clamped value(e.g., 0xffffffff -> 0x7fffffff). It would be good to make this test independent on the OpenGL implementations. 1126239 3 261220 commit-queue 2015-09-15 18:55:01 -0700 Comment on attachment 261220 Patch Clearing flags on attachment: 261220 Committed r189838: <http://trac.webkit.org/changeset/189838> 1126240 4 commit-queue 2015-09-15 18:55:05 -0700 All reviewed patches have been landed. Closing bug. 261220 2015-09-15 11:35:09 -0700 2015-09-15 18:55:01 -0700 Patch bug-149174-20150916033457.patch text/plain 5603 hur.ims U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5ODEwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTRkNTVkMzUxYjA2ZmRlZmJiMjhk NGM3MGIxZTljMTBlNmE3Mjc2Mi4uNWIyMjhjNzE5ZDE5NWJhOTZkYjQyYzFlOGI3YWZiNTZkMTYy NWM5ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA5LTE1ICBKaW55b3VuZyBIdXIgIDxo dXIuaW1zQG5hdmVyY29ycC5jb20+CisKKyAgICAgICAgW1dlYkdMXSBPbmx5IHJlcXVpcmUgdGhh dCB0aGUgc3RlbmNpbCB2YWx1ZSBhbmQgd3JpdGUgbWFza3MgaGF2ZSBhcyBtYW55IGJpdHMgc2V0 IGFzIHRoZSBzdGVuY2lsIGJ1ZmZlciBpcyBkZWVwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkxNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb3BpZWQgdGhlIHN0ZW5jaWwgbWFzayByZWxhdGVkIHRl c3RzIGZyb20gdGhlIHdlYmdsLzEuMC4yL3Jlc291cmNlcy93ZWJnbF90ZXN0X2ZpbGVzL2NvbmZv cm1hbmNlL3N0YXRlL2dsLWdldC1jYWxscy5odG1sLgorCisgICAgICAgIEl0IHNlZW1zIHRoYXQg dGhlcmUgaXMgYSBkaWZmZXJlbmNlIGluIHRoZSB3YXkgdGhhdCBnbEdldEludGVnZXJWIHJldHVy bnMgYW4gdW5zaWduZWQgaW50IHR5cGUgdmFsdWUgYW1vbmcgCisgICAgICAgIE9wZW5HTCBpbXBs ZW1lbnRhdGlvcy4gU29tZSByZXR1cm4gdGhlIHdob2xlIGJpdHMgb2YgdmFsdWUoZS5nLiwgMHhm ZmZmZmZmZiAtPiAweGZmZmZmZmZmKSwgd2hlcmVhcyBzb21lKGUuZy4sIEFOR0xFKSAKKyAgICAg ICAgcmV0dXJuIGEgbWF4LWludC1jbGFtcGVkIHZhbHVlKGUuZy4sIDB4ZmZmZmZmZmYgLT4gMHg3 ZmZmZmZmZikuCisKKyAgICAgICAgSXQgd291bGQgYmUgZ29vZCB0byBtYWtlIHRoaXMgdGVzdCBp bmRlcGVuZGVudCBvbiB0aGUgT3BlbkdMIGltcGxlbWVudGF0aW9ucy4KKworICAgICAgICAqIGZh c3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFz dC9jYW52YXMvd2ViZ2wvZ2wtZ2V0LWNhbGxzLmh0bWw6CisKIDIwMTUtMDktMTUgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ds LWdldC1jYWxscy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9n bC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CmluZGV4IGFmMGEyYTNkNDI5ZGVhZmI1ZDg2NTJmOTQ2 MTlkYzUzZGVhY2ZlZjUuLjk5YjVhZmZlODA5ODI4YzU2MzA4ZGE1MTE5ZTliYTU0OTMzZGQ1ZmQg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy1l eHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZ2wtZ2V0LWNh bGxzLWV4cGVjdGVkLnR4dApAQCAtNTQsOCArNTQsOCBAQCBQQVNTIGNvbnRleHQuZ2V0UGFyYW1l dGVyKGNvbnRleHQuU1RFTkNJTF9CQUNLX0ZVTkMpIGlzIGNvbnRleHQuQUxXQVlTCiBQQVNTIGNv bnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9CQUNLX1BBU1NfREVQVEhfRkFJTCkg aXMgY29udGV4dC5LRUVQCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJ TF9CQUNLX1BBU1NfREVQVEhfUEFTUykgaXMgY29udGV4dC5LRUVQCiBQQVNTIGNvbnRleHQuZ2V0 UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9CQUNLX1JFRikgaXMgMAotUEFTUyBjb250ZXh0Lmdl dFBhcmFtZXRlcihjb250ZXh0LlNURU5DSUxfQkFDS19WQUxVRV9NQVNLKSBpcyAweEZGRkZGRkZG Ci1QQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9CQUNLX1dSSVRFTUFT SykgaXMgMHhGRkZGRkZGRgorUEFTUyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlNURU5D SUxfQkFDS19WQUxVRV9NQVNLKSAmIG1pbmltdW1SZXF1aXJlZFN0ZW5jaWxNYXNrIGlzIG1pbmlt dW1SZXF1aXJlZFN0ZW5jaWxNYXNrCitQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQu U1RFTkNJTF9CQUNLX1dSSVRFTUFTSykgJiBtaW5pbXVtUmVxdWlyZWRTdGVuY2lsTWFzayBpcyBt aW5pbXVtUmVxdWlyZWRTdGVuY2lsTWFzawogUEFTUyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250 ZXh0LlNURU5DSUxfQklUUykgPj0gMCBpcyB0cnVlCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVy KGNvbnRleHQuU1RFTkNJTF9DTEVBUl9WQUxVRSkgaXMgMAogUEFTUyBjb250ZXh0LmdldFBhcmFt ZXRlcihjb250ZXh0LlNURU5DSUxfRkFJTCkgaXMgY29udGV4dC5LRUVQCkBAIC02NCw4ICs2NCw4 IEBAIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5TVEVOQ0lMX1BBU1NfREVQVEhf RkFJTCkgaXMgY29udGV4dC5LRUVQCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQu U1RFTkNJTF9QQVNTX0RFUFRIX1BBU1MpIGlzIGNvbnRleHQuS0VFUAogUEFTUyBjb250ZXh0Lmdl dFBhcmFtZXRlcihjb250ZXh0LlNURU5DSUxfUkVGKSBpcyAwCiBQQVNTIGNvbnRleHQuZ2V0UGFy YW1ldGVyKGNvbnRleHQuU1RFTkNJTF9URVNUKSBpcyBmYWxzZQotUEFTUyBjb250ZXh0LmdldFBh cmFtZXRlcihjb250ZXh0LlNURU5DSUxfVkFMVUVfTUFTSykgaXMgMHhGRkZGRkZGRgotUEFTUyBj b250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlNURU5DSUxfV1JJVEVNQVNLKSBpcyAweEZGRkZG RkZGCitQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9WQUxVRV9NQVNL KSAmIG1pbmltdW1SZXF1aXJlZFN0ZW5jaWxNYXNrIGlzIG1pbmltdW1SZXF1aXJlZFN0ZW5jaWxN YXNrCitQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9XUklURU1BU0sp ICYgbWluaW11bVJlcXVpcmVkU3RlbmNpbE1hc2sgaXMgbWluaW11bVJlcXVpcmVkU3RlbmNpbE1h c2sKIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5URVhUVVJFX0JJTkRJTkdfMkQp IGlzIG51bGwKIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5URVhUVVJFX0JJTkRJ TkdfQ1VCRV9NQVApIGlzIG51bGwKIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5V TlBBQ0tfQUxJR05NRU5UKSBpcyA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy93ZWJnbC9nbC1nZXQtY2FsbHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmds L2dsLWdldC1jYWxscy5odG1sCmluZGV4IGZhYjkxMzc1ODA1NDU3MDJmODBkYTlhYTFkNmM4ODQ3 YWM5YmY5ZGMuLjU2OTM3ZDg0MjRjZTVhNThiNGRjNmFlYzZmY2E0ZDcxMjBkZDI0ODAgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy5odG1sCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy5odG1sCkBAIC0x Nyw2ICsxNyw3IEBAIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3QgZW5zdXJlcyBiYXNpYyBmdW5jdGlv bmFsaXR5IG9mIHRoZSB1bmRlcmx5aW5nIGdyYXBoaWNzIGxpCiBkZWJ1ZygiIik7CiBkZWJ1Zygi Q2FudmFzLmdldENvbnRleHQiKTsKIAordmFyIG1pbmltdW1SZXF1aXJlZFN0ZW5jaWxNYXNrID0g MDsKIHZhciBjb250ZXh0ID0gY3JlYXRlM0RDb250ZXh0KGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJjYW52YXMiKSk7CiBpZiAoIWNvbnRleHQpCiAgICAgdGVzdEZhaWxlZCgiY29udGV4dCBkb2Vz IG5vdCBleGlzdCIpOwpAQCAtODEsOCArODIsMTEgQEAgZWxzZSB7CiAgICAgc2hvdWxkQmUoJ2Nv bnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9CQUNLX1BBU1NfREVQVEhfUEFTUykn LCAnY29udGV4dC5LRUVQJyk7CiAgICAgc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNv bnRleHQuU1RFTkNJTF9CQUNLX1JFRiknLCAnMCcpOwogCi0gICAgc2hvdWxkQmUoJ2NvbnRleHQu Z2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9CQUNLX1ZBTFVFX01BU0spJywgJzB4RkZGRkZG RkYnKTsKLSAgICBzaG91bGRCZSgnY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5TVEVOQ0lM X0JBQ0tfV1JJVEVNQVNLKScsICcweEZGRkZGRkZGJyk7CisgICAgdmFyIHN0ZW5jaWxCaXRzID0g Y29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5TVEVOQ0lMX0JJVFMpOworICAgIG1pbmltdW1S ZXF1aXJlZFN0ZW5jaWxNYXNrID0gKDEgPDwgc3RlbmNpbEJpdHMpIC0gMTsKKworICAgIHNob3Vs ZEJlKCdjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlNURU5DSUxfQkFDS19WQUxVRV9NQVNL KSAmIG1pbmltdW1SZXF1aXJlZFN0ZW5jaWxNYXNrJywgJ21pbmltdW1SZXF1aXJlZFN0ZW5jaWxN YXNrJyk7CisgICAgc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJ TF9CQUNLX1dSSVRFTUFTSykgJiBtaW5pbXVtUmVxdWlyZWRTdGVuY2lsTWFzaycsICdtaW5pbXVt UmVxdWlyZWRTdGVuY2lsTWFzaycpOwogCiAgICAgLy8gSWYgRVhUX3BhY2tlZF9kZXB0aF9zdGVu Y2lsIGlzIHN1cHBvcnRlZCwgU1RFTkNJTF9CSVRTID4gMDsgb3RoZXJ3aXNlLCBTVEVOQ0lMX0JJ VFMgPT0gMC4KICAgICBzaG91bGRCZSgnY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5TVEVO Q0lMX0JJVFMpID49IDAnLCAndHJ1ZScpOwpAQCAtOTQsOCArOTgsOCBAQCBlbHNlIHsKICAgICBz aG91bGRCZSgnY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5TVEVOQ0lMX1JFRiknLCAnMCcp OwogICAgIHNob3VsZEJlKCdjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlNURU5DSUxfVEVT VCknLCAnZmFsc2UnKTsKIAotICAgIHNob3VsZEJlKCdjb250ZXh0LmdldFBhcmFtZXRlcihjb250 ZXh0LlNURU5DSUxfVkFMVUVfTUFTSyknLCAnMHhGRkZGRkZGRicpOwotICAgIHNob3VsZEJlKCdj b250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlNURU5DSUxfV1JJVEVNQVNLKScsICcweEZGRkZG RkZGJyk7CisgICAgc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJ TF9WQUxVRV9NQVNLKSAmIG1pbmltdW1SZXF1aXJlZFN0ZW5jaWxNYXNrJywgJ21pbmltdW1SZXF1 aXJlZFN0ZW5jaWxNYXNrJyk7CisgICAgc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNv bnRleHQuU1RFTkNJTF9XUklURU1BU0spICYgbWluaW11bVJlcXVpcmVkU3RlbmNpbE1hc2snLCAn bWluaW11bVJlcXVpcmVkU3RlbmNpbE1hc2snKTsKIAogICAgIHNob3VsZEJlKCdjb250ZXh0Lmdl dFBhcmFtZXRlcihjb250ZXh0LlRFWFRVUkVfQklORElOR18yRCknLCAnbnVsbCcpOwogICAgIHNo b3VsZEJlKCdjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlRFWFRVUkVfQklORElOR19DVUJF X01BUCknLCAnbnVsbCcpOwo=