149173 2015-09-15 11:27:40 -0700 Web Inspector: command-click in NewTabContentView should open new tab without switching to it 2022-03-01 02:45:27 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1126061 0 bburg 2015-09-15 11:27:40 -0700 This is how the home screen grids work in FF and Safari. 1126062 1 webkit-bug-importer 2015-09-15 11:28:04 -0700 <rdar://problem/22705409> 1126106 2 261227 bburg 2015-09-15 13:46:41 -0700 Created attachment 261227 Proposed fix 1126133 3 261227 joepeck 2015-09-15 14:31:58 -0700 Comment on attachment 261227 Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=261227&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:510 > +WebInspector.createNewTabWithType = function(tabType, options={}) In the one other place I think we have this right now, we have spaces. I still favor no spaces. Lets decide on IRC. > Source/WebInspectorUI/UserInterface/Base/Main.js:520 > + let insertionIndex = referencedView ? this.tabBar.tabBarItems.indexOf(referencedView.tabBarItem) : null; Nit: I think `undefined` may be better than `null`. Null makes me think an object should go here, but it should be a number (or a default value), which null is not typically associated with. > Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js:114 > + let tabItemElements = Array.from(this.element.querySelectorAll("." + WebInspector.NewTabContentView.TabItemStyleClassName)); Nit: This could be a private function, since it is done in multiple places and is easy to get wrong. 1126191 4 261227 bburg 2015-09-15 16:42:47 -0700 Comment on attachment 261227 Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=261227&action=review >> Source/WebInspectorUI/UserInterface/Base/Main.js:520 >> + let insertionIndex = referencedView ? this.tabBar.tabBarItems.indexOf(referencedView.tabBarItem) : null; > > Nit: I think `undefined` may be better than `null`. Null makes me think an object should go here, but it should be a number (or a default value), which null is not typically associated with. OK 1126195 5 bburg 2015-09-15 16:44:43 -0700 Committed r189828: <http://trac.webkit.org/changeset/189828> 261227 2015-09-15 13:46:41 -0700 2022-03-01 02:45:27 -0800 Proposed fix bug-149173-20150915134629.patch text/plain 5772 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5ODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 ZDE4MjA5M2U3OTMxOTIwNGM2MzQ3Y2Y2ZjllNzk1MGM0Y2M4YzVkLi5iNzgyMmE0MDI3MWZmZmE1 MmZkY2RhODRiYTQ4NjY0MWMwYzhlNzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMCBAQAorMjAxNS0wOS0xNSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBjb21tYW5kLWNsaWNrIGluIE5ld1RhYkNvbnRlbnRWaWV3 IHNob3VsZCBvcGVuIG5ldyB0YWIgd2l0aG91dCBzd2l0Y2hpbmcgdG8gaXQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTE3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGFsbG93IGEgdXNlciB0byBx dWlja2x5IHJlc3RvcmUgdGFicywgaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGNvbW1hbmQtY2xp Y2sKKyAgICAgICAgYWxsIHRoZSB0YWJzIHRoYXQgYXJlIGRlc2lyZWQgd2l0aG91dCBnb2luZyBi YWNrIHRocm91Z2ggdGhlIFsrXSB0YWIgYnV0dG9uLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY3JlYXRlTmV3VGFiV2l0aFR5 cGUpOiBSZW5hbWVkLgorCisgICAgICAgICAgICBVc2UgYW4gb3B0aW9ucyBvYmplY3QgYW5kIHNw bGl0IGNyZWF0aW5nIHRoZSB0YWIgZnJvbSBkZWxldGluZyB0aGUKKyAgICAgICAgICAgIHJlcGxh Y2VkIHRhYiBhbmQgc2hvd2luZyB0aGUgbmV3IHRhYi4gQWRkIGJldHRlciBlcnJvciBjaGVja2lu Zy4KKworICAgICAgICAoV2ViSW5zcGVjdG9yLmNyZWF0ZU5ld1RhYik6IERlbGV0ZWQuCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXdUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5OZXdUYWJDb250ZW50Vmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu TmV3VGFiQ29udGVudFZpZXcucHJvdG90eXBlLl9jcmVhdGVOZXdUYWJXaXRoVHlwZSk6IFJlbmFt ZWQuCisKKyAgICAgICAgICAgIElmIHRoZSBtZXRhIGtleSBpcyBwcmVzc2VkLCBkb24ndCBzd2l0 Y2ggdG8gdGhlIG5ldyB0YWIgb3IgcmVtb3ZlIHRoaXMgdmlldworICAgICAgICAgICAgdW5sZXNz IHRoZXJlIGFyZSBubyBtb3JlIHRhYnMgdGhhdCBjYW4gYmUgY3JlYXRlZCBiZXlvbmQgdGhlIGN1 cnJlbnQgb25lLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV3VGFiQ29udGVudFZpZXcucHJv dG90eXBlLl9hbGxvd2FibGVUYWJUeXBlcyk6IEFkZGVkLgorICAgICAgICAoV2ViSW5zcGVjdG9y Lk5ld1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fY3JlYXRlTmV3VGFiKTogRGVsZXRlZC4KKwog MjAxNS0wOS0xNSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IENsb3NpbmcgdGhlIGZpbmFsIGluc3BlY3RvciB0YWIgc2hvdWxk IGJlIGFsbG93ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jh c2UvTWFpbi5qcwppbmRleCBkYTRjMmQ1YzBlMjljYmM1ZDg0ZjNjNzJjODE2M2MzM2EzNDhmMjky Li45NDBhN2ExMzQyN2NiZmJiNWYwN2Q0MzhjMjg3Y2I4MmYzMDhiMmVkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC01MDcsMjAg KzUwNywyNCBAQCBXZWJJbnNwZWN0b3IuaXNOZXdUYWJXaXRoVHlwZUFsbG93ZWQgPSBmdW5jdGlv bih0YWJUeXBlKQogICAgIHJldHVybiB0cnVlOwogfTsKIAotV2ViSW5zcGVjdG9yLmNyZWF0ZU5l d1RhYiA9IGZ1bmN0aW9uKHRhYlR5cGUsIG5ld1RhYkNvbnRlbnRWaWV3VG9SZXBsYWNlKQorV2Vi SW5zcGVjdG9yLmNyZWF0ZU5ld1RhYldpdGhUeXBlID0gZnVuY3Rpb24odGFiVHlwZSwgb3B0aW9u cz17fSkKIHsKICAgICBjb25zb2xlLmFzc2VydCh0aGlzLmlzTmV3VGFiV2l0aFR5cGVBbGxvd2Vk KHRhYlR5cGUpKTsKIAotICAgIHZhciB0YWJDb250ZW50VmlldyA9IHRoaXMuX3RhYkNvbnRlbnRW aWV3Rm9yVHlwZSh0YWJUeXBlKTsKKyAgICBsZXQge3JlZmVyZW5jZWRWaWV3LCBzaG91bGRSZXBs YWNlVGFiLCBzaG91bGRTaG93TmV3VGFifSA9IG9wdGlvbnM7CisgICAgY29uc29sZS5hc3NlcnQo IXJlZmVyZW5jZWRWaWV3IHx8IHJlZmVyZW5jZWRWaWV3IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9y LlRhYkNvbnRlbnRWaWV3LCByZWZlcmVuY2VkVmlldyk7CisgICAgY29uc29sZS5hc3NlcnQoIXNo b3VsZFJlcGxhY2VUYWIgfHwgcmVmZXJlbmNlZFZpZXcsICJNdXN0IHByb3ZpZGUgYSByZWZlcmVu Y2UgdmlldyB0byByZXBsYWNlIGEgdGFiLiIpOwogCi0gICAgaWYgKG5ld1RhYkNvbnRlbnRWaWV3 VG9SZXBsYWNlKSB7Ci0gICAgICAgIHZhciBpbnNlcnRpb25JbmRleCA9IHRoaXMudGFiQmFyLnRh YkJhckl0ZW1zLmluZGV4T2YobmV3VGFiQ29udGVudFZpZXdUb1JlcGxhY2UudGFiQmFySXRlbSk7 Ci0gICAgICAgIHRoaXMudGFiQnJvd3Nlci5jbG9zZVRhYkZvckNvbnRlbnRWaWV3KG5ld1RhYkNv bnRlbnRWaWV3VG9SZXBsYWNlLCB0cnVlKTsKLSAgICAgICAgdGhpcy50YWJCcm93c2VyLnNob3dU YWJGb3JDb250ZW50Vmlldyh0YWJDb250ZW50VmlldywgdHJ1ZSwgaW5zZXJ0aW9uSW5kZXgpOwot ICAgICAgICByZXR1cm47Ci0gICAgfQorICAgIGxldCB0YWJDb250ZW50VmlldyA9IHRoaXMuX3Rh YkNvbnRlbnRWaWV3Rm9yVHlwZSh0YWJUeXBlKTsKKyAgICBjb25zdCBzdXBwcmVzc0FuaW1hdGlv bnMgPSB0cnVlOworICAgIGxldCBpbnNlcnRpb25JbmRleCA9IHJlZmVyZW5jZWRWaWV3ID8gdGhp cy50YWJCYXIudGFiQmFySXRlbXMuaW5kZXhPZihyZWZlcmVuY2VkVmlldy50YWJCYXJJdGVtKSA6 IG51bGw7CisgICAgdGhpcy50YWJCcm93c2VyLmFkZFRhYkZvckNvbnRlbnRWaWV3KHRhYkNvbnRl bnRWaWV3LCBzdXBwcmVzc0FuaW1hdGlvbnMsIGluc2VydGlvbkluZGV4KTsKIAotICAgIHRoaXMu dGFiQnJvd3Nlci5zaG93VGFiRm9yQ29udGVudFZpZXcodGFiQ29udGVudFZpZXcpOworICAgIGlm IChzaG91bGRSZXBsYWNlVGFiKQorICAgICAgICB0aGlzLnRhYkJyb3dzZXIuY2xvc2VUYWJGb3JD b250ZW50VmlldyhyZWZlcmVuY2VkVmlldywgc3VwcHJlc3NBbmltYXRpb25zKTsKKworICAgIGlm IChzaG91bGRTaG93TmV3VGFiKQorICAgICAgICB0aGlzLnRhYkJyb3dzZXIuc2hvd1RhYkZvckNv bnRlbnRWaWV3KHRhYkNvbnRlbnRWaWV3KTsKIH07CiAKIFdlYkluc3BlY3Rvci5hY3RpdmF0ZUV4 dHJhRG9tYWlucyA9IGZ1bmN0aW9uKGRvbWFpbnMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXdUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNvbnRlbnRWaWV3Lmpz CmluZGV4IGE4MGQ5NDY4ZWU2NDU5NjRmZjAyNDk3Y2Y2YjhlYTMzNTNiZGUxOTMuLmI4YjAwMjlj ZjYzMmMxYTg5NGZiZjllZWJjNjlmZDljZjEzNTIzNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNvbnRlbnRWaWV3LmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ld1RhYkNvbnRlbnRW aWV3LmpzCkBAIC01MCw3ICs1MCw3IEBAIFdlYkluc3BlY3Rvci5OZXdUYWJDb250ZW50VmlldyA9 IGNsYXNzIE5ld1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRhCiAKICAgICAg ICAgICAgIHZhciB0YWJJdGVtRWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OwogICAgICAgICAgICAgdGFiSXRlbUVsZW1lbnQuY2xhc3NMaXN0LmFkZChXZWJJbnNwZWN0b3Iu TmV3VGFiQ29udGVudFZpZXcuVGFiSXRlbVN0eWxlQ2xhc3NOYW1lKTsKLSAgICAgICAgICAgIHRh Ykl0ZW1FbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fY3JlYXRlTmV3VGFi LmJpbmQodGhpcywgaW5mby50eXBlKSk7CisgICAgICAgICAgICB0YWJJdGVtRWxlbWVudC5hZGRF dmVudExpc3RlbmVyKCJjbGljayIsIHRoaXMuX2NyZWF0ZU5ld1RhYldpdGhUeXBlLmJpbmQodGhp cywgaW5mby50eXBlKSk7CiAgICAgICAgICAgICB0YWJJdGVtRWxlbWVudFtXZWJJbnNwZWN0b3Iu TmV3VGFiQ29udGVudFZpZXcuVHlwZVN5bWJvbF0gPSBpbmZvLnR5cGU7CiAKICAgICAgICAgICAg IHZhciBib3hFbGVtZW50ID0gdGFiSXRlbUVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiZGl2IikpOwpAQCAtOTUsMTIgKzk1LDI1IEBAIFdlYkluc3BlY3Rvci5OZXdU YWJDb250ZW50VmlldyA9IGNsYXNzIE5ld1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVj dG9yLlRhCiAKICAgICAvLyBQcml2YXRlCiAKLSAgICBfY3JlYXRlTmV3VGFiKHRhYlR5cGUsIGV2 ZW50KQorICAgIF9jcmVhdGVOZXdUYWJXaXRoVHlwZSh0YWJUeXBlLCBldmVudCkKICAgICB7CiAg ICAgICAgIGlmICghV2ViSW5zcGVjdG9yLmlzTmV3VGFiV2l0aFR5cGVBbGxvd2VkKHRhYlR5cGUp KQogICAgICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIFdlYkluc3BlY3Rvci5jcmVhdGVOZXdU YWIodGFiVHlwZSwgdGhpcyk7CisgICAgICAgIGNvbnN0IGNhbkNyZWF0ZUFkZGl0aW9uYWxUYWJz ID0gdGhpcy5fYWxsb3dhYmxlVGFiVHlwZXMoKS5sZW5ndGggPiAxOworICAgICAgICBjb25zdCBv cHRpb25zID0geworICAgICAgICAgICAgcmVmZXJlbmNlZFZpZXc6IHRoaXMsCisgICAgICAgICAg ICBzaG91bGRSZXBsYWNlVGFiOiAhY2FuQ3JlYXRlQWRkaXRpb25hbFRhYnMgfHwgIVdlYkluc3Bl Y3Rvci5tb2RpZmllcktleXMubWV0YUtleSwKKyAgICAgICAgICAgIHNob3VsZFNob3dOZXdUYWI6 ICFXZWJJbnNwZWN0b3IubW9kaWZpZXJLZXlzLm1ldGFLZXkKKyAgICAgICAgfQorICAgICAgICBX ZWJJbnNwZWN0b3IuY3JlYXRlTmV3VGFiV2l0aFR5cGUodGFiVHlwZSwgb3B0aW9ucyk7CisgICAg fQorCisgICAgX2FsbG93YWJsZVRhYlR5cGVzKCkKKyAgICB7CisgICAgICAgIGxldCB0YWJJdGVt RWxlbWVudHMgPSBBcnJheS5mcm9tKHRoaXMuZWxlbWVudC5xdWVyeVNlbGVjdG9yQWxsKCIuIiAr IFdlYkluc3BlY3Rvci5OZXdUYWJDb250ZW50Vmlldy5UYWJJdGVtU3R5bGVDbGFzc05hbWUpKTsK KyAgICAgICAgbGV0IHRhYlR5cGVzID0gdGFiSXRlbUVsZW1lbnRzLm1hcCgodGFiSXRlbUVsZW1l bnQpID0+IHRhYkl0ZW1FbGVtZW50W1dlYkluc3BlY3Rvci5OZXdUYWJDb250ZW50Vmlldy5UeXBl U3ltYm9sXSk7CisgICAgICAgIHJldHVybiB0YWJUeXBlcy5maWx0ZXIoKHR5cGUpID0+IFdlYklu c3BlY3Rvci5pc05ld1RhYldpdGhUeXBlQWxsb3dlZCh0eXBlKSk7CiAgICAgfQogCiAgICAgX3Vw ZGF0ZVRhYkl0ZW1zKCkK