149172 2015-09-15 11:05:06 -0700 [GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only 2015-09-15 14:50:36 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez cgarcia commit-queue mcatanzaro mrobinson oldest_to_newest 1126048 0 clopez 2015-09-15 11:05:06 -0700 cairo-gl can be built with full OpenGL support or with OpenGLESv2 support. When cairo-gl is built with only OpenGLESv2 support, cairo-glx is not enabled. If then webkitgtk+ is built with GLX (full OpenGL) support and with it ACCELERATED_2D_CANVAS support the following build error would happen: Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:270:74: error: 'cairo_glx_device_create' was not declared in this scope make[2]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/platform/graphics/glx/GLContextGLX.cpp.o] Error 1 1126050 1 261217 clopez 2015-09-15 11:08:26 -0700 Created attachment 261217 Patch 1126141 2 261217 commit-queue 2015-09-15 14:50:32 -0700 Comment on attachment 261217 Patch Clearing flags on attachment: 261217 Committed r189826: <http://trac.webkit.org/changeset/189826> 1126142 3 commit-queue 2015-09-15 14:50:36 -0700 All reviewed patches have been landed. Closing bug. 261217 2015-09-15 11:08:26 -0700 2015-09-15 14:50:32 -0700 Patch bug-149172-20150915200814.patch text/plain 1528 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTg5ODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM0MTViMGY5MzMyNzE4 OTkzMzlhMWUxNTQyMGM2NDhjZjJkYzQ2OC4uZTExY2JmZjk0ODYzNDgxNTIzOTJlNDhhZTY5YWQy ZWYzMzA5YzdhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA5LTE1ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEtdIEJ1aWxkIGZhaWx1cmUgd2l0aCBBQ0NFTEVSQVRFRF8yRF9DQU5WQVMgd2hlbiBjYWlyby1n bCBoYXMgYnVpbHQgd2l0aCBPcGVuR0xFU3YyIHN1cHBvcnQgb25seS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTE3MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdM WC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHTENvbnRleHRHTFg6OmNhaXJvRGV2aWNlKToKKwog MjAxNS0wOS0xNSAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbQ1NTIEdyaWQgTGF5b3V0XSBVc2luZyB7cm93LCBjb2x1bW59LWF4aXMgdGVybXMg aW4gYWxpZ25tZW50IHJlbGF0ZWQgbG9naWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5jcHAKaW5kZXggZjA1YjZjZjgyMTM3OTZk MGI5NTlmZjdlMTM5NzU5NjBhMjczNGJlZi4uYTBhMGMxNjQ5MDdjMzFlNzg4OWJlMTEzODJlNGMz YjIxZWFkODQzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z2x4L0dMQ29udGV4dEdMWC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ2x4L0dMQ29udGV4dEdMWC5jcHAKQEAgLTIyNiw3ICsyMjYsNyBAQCBjYWlyb19kZXZpY2Vf dCogR0xDb250ZXh0R0xYOjpjYWlyb0RldmljZSgpCiAgICAgaWYgKG1fY2Fpcm9EZXZpY2UpCiAg ICAgICAgIHJldHVybiBtX2NhaXJvRGV2aWNlOwogCi0jaWYgRU5BQkxFKEFDQ0VMRVJBVEVEXzJE X0NBTlZBUykKKyNpZiBFTkFCTEUoQUNDRUxFUkFURURfMkRfQ0FOVkFTKSAmJiBDQUlST19IQVNf R0xYX0ZVTkNUSU9OUwogICAgIG1fY2Fpcm9EZXZpY2UgPSBjYWlyb19nbHhfZGV2aWNlX2NyZWF0 ZShkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KFBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlz cGxheSgpKS5uYXRpdmUoKSwgbV9jb250ZXh0LmdldCgpKTsKICNlbmRpZgogCg==